From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoobj@marvell.com>,
"Shetty, Praveen" <praveen.shetty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature
Date: Fri, 3 Apr 2020 05:52:09 +0000 [thread overview]
Message-ID: <VE1PR04MB66397FCC96D2C19FB4031C67E6C70@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MN2PR18MB28777B49E47E7167A59AFB6BDFC70@MN2PR18MB2877.namprd18.prod.outlook.com>
> > > diff --git a/examples/ipsec-secgw/ipsec.c
> > > b/examples/ipsec-secgw/ipsec.c index d40657102..76ee9dbcf 100644
> > > --- a/examples/ipsec-secgw/ipsec.c
> > > +++ b/examples/ipsec-secgw/ipsec.c
> > > @@ -418,6 +418,73 @@ create_inline_session(struct socket_ctx *skt_ctx,
> > > struct ipsec_sa *sa,
> > > return 0;
> > > }
> > >
> > > +int
> > > +create_ipsec_esp_flow(struct ipsec_sa *sa) {
> > > + int ret = 0;
> > > + struct rte_flow_error err;
> > > + if (sa->direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS)
> > > + return 0; /* No Flow director rules for Egress traffic */
> >
> > [Anoob] Any reason why this is not relevant for Egress.
> >
> > [Praveen] we don't see an use case for load distribution across ingress queues
> > for outbound IPsec traffic therefore we have limited this configuration to
> > inbound IPsec processing, as this is the only use case we can verify.
>
> [Anoob] Why do you say load distribution for ingress queues is not required but
> is required for egress? I would say the use case is the same in either direction.
>
> Said that, adding just egress should be fine. I leave this to Akhil's judgement.
>
I believe it does not matter for EGRESS in most hardwares,
INGRESS flows should have distribution. I think your comments are just reverse but
The code is inline with my understanding.
next prev parent reply other threads:[~2020-04-03 5:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 14:55 [dpdk-dev] [PATCH v1] " Praveen Shetty
2020-03-12 11:00 ` Anoob Joseph
[not found] ` <BN7PR11MB25310A9A6B9C3BE91A411AA29DFD0@BN7PR11MB2531.namprd11.prod.outlook.com>
[not found] ` <BN7PR11MB2531E92F9B078563A947615F9DFD0@BN7PR11MB2531.namprd11.prod.outlook.com>
[not found] ` <BN7PR11MB2531ABDDAE26D1FD3B216E259DFD0@BN7PR11MB2531.namprd11.prod.outlook.com>
2020-03-13 7:05 ` Shetty, Praveen
2020-03-13 10:51 ` Anoob Joseph
2020-03-13 12:21 ` Shetty, Praveen
2020-03-19 16:21 ` [dpdk-dev] [PATCH v2] " Praveen Shetty
2020-03-20 8:15 ` Anoob Joseph
2020-03-23 11:24 ` Shetty, Praveen
2020-03-31 13:02 ` [dpdk-dev] [PATCH v3] " Praveen Shetty
2020-04-01 13:19 ` Akhil Goyal
2020-04-01 13:26 ` Anoob Joseph
2020-04-01 13:53 ` Akhil Goyal
2020-04-02 11:15 ` Shetty, Praveen
2020-04-02 13:39 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-04-02 17:56 ` Shetty, Praveen
2020-04-03 5:14 ` Anoob Joseph
2020-04-03 5:52 ` Akhil Goyal [this message]
2020-04-03 10:21 ` Shetty, Praveen
2020-04-03 10:28 ` Anoob Joseph
2020-04-08 14:13 ` [dpdk-dev] [PATCH v4] " Praveen Shetty
2020-04-09 10:09 ` [dpdk-dev] [PATCH v5] " Praveen Shetty
2020-04-14 7:33 ` Shetty, Praveen
2020-04-15 18:59 ` Akhil Goyal
2020-04-16 11:49 ` Shetty, Praveen
2020-04-16 16:47 ` [dpdk-dev] [PATCH v6] " Praveen Shetty
2020-04-17 20:58 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB66397FCC96D2C19FB4031C67E6C70@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=bernard.iremonger@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=praveen.shetty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).