From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87BFAA0562; Fri, 3 Apr 2020 07:52:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90B321BFC5; Fri, 3 Apr 2020 07:52:12 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20061.outbound.protection.outlook.com [40.107.2.61]) by dpdk.org (Postfix) with ESMTP id 378C61BFC4 for ; Fri, 3 Apr 2020 07:52:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OgknrBlnhP95B2WKnM78fPi12dX8gKhFptW+watyqYAsrEru2PC6vywDrWScIJHQKbGiSOCwcKPdjglA6tLGliHe3SrEtsPWjDCsgSbY/1eqem1TSW82x9UtqGlPRRo1UUGZPlGZw2LwPQsasZjdGnFlVR2wsOn/WuASiy7aBUi04PEONNzp6PKiLMMh0FgDenzXHVtB0Yn8tW0dezIy0j9XKpXhWGUfQl1zxJzhmCpAUuWYlhsXOb0zFK4vn1bQGoCp8VyOE1L826ob3tu4UAL8Go+MYW41Q1Kor0D+JffoDaZXxDRgGAejpJwWfY76G1uJU0rMoH6RA1fiZ+fHIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lsZYF24AroR7FIrQczXP4LxQvKgTbMLTc1TFsaUoU0=; b=GpcbtLcauHh53unnZvEs//zb20xdtsgStdFbTth7GtdvuDrE8NT8pVKlm3dZf+g08Xgmd5h7BtjGFjm6kFMECZd++Vk8fq609Tt6W+XT9w3z+qmUhiHQKDLWVpL+Q68wPE4O/zOuuuqiwRpGwAiDxX7znZA3t4y5QGGUHRjnSoWVB61HdncTzwVeO4Sxl9QAisSOpZyKhD/2EQxS3vGDW+d8vnUAh0Zl6E80tUA9up729cvnBV++xfw0VENNC60Qi63Vg4aD0pjl974U7OXvw2S9JFkD601KDFcLNKzqOI82YPjydTIdDtQd5aYoZUavGgAqHrllY0MswhxxlaPO5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+lsZYF24AroR7FIrQczXP4LxQvKgTbMLTc1TFsaUoU0=; b=cJFkeWqPFGxWm1O5EHImFJ4D2kB5DBq2Aw0kOjKymSqz44ht+ccAmZi/qmjX8UGoyoABti9Nuxg2Yu9VJWK8WU6cEEnhtuU8mFyM7crOeNyu0mTWOh98WNwAYTlGMvRk+NrVEPyQtPQLjsB0ikHEmlMxCXKuoM2wllJ4zGE4Yt4= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (2603:10a6:803:129::11) by VE1PR04MB6527.eurprd04.prod.outlook.com (2603:10a6:803:11f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.15; Fri, 3 Apr 2020 05:52:09 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::8060:a35c:4858:c490]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::8060:a35c:4858:c490%7]) with mapi id 15.20.2878.018; Fri, 3 Apr 2020 05:52:09 +0000 From: Akhil Goyal To: Anoob Joseph , "Shetty, Praveen" , "dev@dpdk.org" , "Doherty, Declan" CC: "Iremonger, Bernard" , "Ananyev, Konstantin" Thread-Topic: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature Thread-Index: AQHWCPQY6g4i1sKgvEm4flJQiXV2gqhmHkUAgAC9MwCAAAlC0A== Date: Fri, 3 Apr 2020 05:52:09 +0000 Message-ID: References: <20200319162145.28906-1-praveen.shetty@intel.com> <20200331130211.24761-1-praveen.shetty@intel.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [45.118.166.64] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 665dca6f-e529-4879-cd96-08d7d7932629 x-ms-traffictypediagnostic: VE1PR04MB6527: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0362BF9FDB x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6639.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(346002)(376002)(136003)(39860400002)(366004)(6506007)(4326008)(71200400001)(186003)(5660300002)(8936002)(81156014)(2906002)(7696005)(81166006)(76116006)(66946007)(8676002)(478600001)(316002)(66446008)(86362001)(110136005)(33656002)(66556008)(52536014)(9686003)(26005)(64756008)(54906003)(44832011)(66476007)(55016002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LlvnMQ84mk4x2kxga0dbQvtN+KBHq0i6f3jhdTyMAPYjy6Qz3cSUJnHNsfHfbOQ5pZ/9nsEUOnBeTs7rrv4ggTPVdCagvXYD8hg0i8uv9ayn397RgnyE3cRfV4QTUcKBygmF+nz9hk883U2IyrveE4U3XJjsp7ekgfGruSbMCmpYHMqcNhB5ti/HkOrewDL/9SOHjWd5E9Ia61J6A45rGqNGSJkt2BtftvSyrzt+AEr8VS+JoPOm4OuzWDylvZmw8IpFS/fArKoyfgHNJeWOXIevBgCRVKLKftMMighoOYqxCb2yK/Yc8bsA6jI7sRoNNwuL9euSL+2gh5OezDQMIF6XFw8O3GX1WCRmKhAS/zuBzeeyZ0Tm3s+F80VNj3fx6JmbbrUt/Z0oKUyenJwkZt0AJi1XwIcXhls4Fp7rqozlTuOPDGzK6szIs2o5L4PE x-ms-exchange-antispam-messagedata: FWnLklPYo/lw2GkQuFDw73yQKTs5x5OY8STiUceZVX0SxNARxYn5k/xxbylHQgSMEdZ347rv8UoYgjacGazajR5qKW5dyV1dQvaSNYkJ7i6UbjjsjhScH6+5AeTwkOrI5EdN9tO0XPoTFMPWNo0BqA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 665dca6f-e529-4879-cd96-08d7d7932629 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2020 05:52:09.5163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 69MPX+3eR+Ok3pfyZpIVqFoJlSs2RuPAWo3votF2QTH4uD1F1F6qNrABkG8Ro0qs2E+lFPVOgUd+AyhFteNZcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6527 Subject: Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > diff --git a/examples/ipsec-secgw/ipsec.c > > > b/examples/ipsec-secgw/ipsec.c index d40657102..76ee9dbcf 100644 > > > --- a/examples/ipsec-secgw/ipsec.c > > > +++ b/examples/ipsec-secgw/ipsec.c > > > @@ -418,6 +418,73 @@ create_inline_session(struct socket_ctx *skt_ctx= , > > > struct ipsec_sa *sa, > > > return 0; > > > } > > > > > > +int > > > +create_ipsec_esp_flow(struct ipsec_sa *sa) { > > > + int ret =3D 0; > > > + struct rte_flow_error err; > > > + if (sa->direction =3D=3D RTE_SECURITY_IPSEC_SA_DIR_EGRESS) > > > + return 0; /* No Flow director rules for Egress traffic */ > > > > [Anoob] Any reason why this is not relevant for Egress. > > > > [Praveen] we don't see an use case for load distribution across ingress= queues > > for outbound IPsec traffic therefore we have limited this configuration= to > > inbound IPsec processing, as this is the only use case we can verify. >=20 > [Anoob] Why do you say load distribution for ingress queues is not requir= ed but > is required for egress? I would say the use case is the same in either di= rection. >=20 > Said that, adding just egress should be fine. I leave this to Akhil's jud= gement. >=20 I believe it does not matter for EGRESS in most hardwares, INGRESS flows should have distribution. I think your comments are just reve= rse but The code is inline with my understanding.