DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding
@ 2020-02-10  7:35 Thierry Herbelot
  2020-02-10  7:44 ` Anoob Joseph
  0 siblings, 1 reply; 3+ messages in thread
From: Thierry Herbelot @ 2020-02-10  7:35 UTC (permalink / raw)
  To: dev; +Cc: stable, Thomas Monjalon, Anoob Joseph

Like for OCTEON TX, the OCTEON TX2 crypto engines must
first be unbound from their kernel module, then rebound to
vfio-pci, before being used in DPDK.

As this capability is detected at runtime by dpdk-pmdinfo,
add the info in the PMD registering directives.

Then an external script can be used for bind and unbind.

Fixes: 2f8a1b963eb77 ("crypto/octeontx2: add PMD skeleton")
Cc: stable@dpdk.org
Cc: Anoob Joseph <anoobj@marvell.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 drivers/crypto/octeontx2/otx2_cryptodev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c
index 7fd216bb3901..7b8add1bfc6a 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
@@ -145,6 +145,7 @@ static struct cryptodev_driver otx2_cryptodev_drv;
 RTE_INIT(otx2_cpt_init_log);
 RTE_PMD_REGISTER_PCI(CRYPTODEV_NAME_OCTEONTX2_PMD, otx2_cryptodev_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_OCTEONTX2_PMD, pci_id_cpt_table);
+RTE_PMD_REGISTER_KMOD_DEP(CRYPTODEV_NAME_OCTEONTX2_PMD, "vfio-pci");
 RTE_PMD_REGISTER_CRYPTO_DRIVER(otx2_cryptodev_drv, otx2_cryptodev_pmd.driver,
 		otx2_cryptodev_driver_id);
 
-- 
2.25.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding
  2020-02-10  7:35 [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding Thierry Herbelot
@ 2020-02-10  7:44 ` Anoob Joseph
  2020-02-12 10:28   ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2020-02-10  7:44 UTC (permalink / raw)
  To: Thierry Herbelot, dev; +Cc: stable, Thomas Monjalon

> 
> Like for OCTEON TX, the OCTEON TX2 crypto engines must first be unbound
> from their kernel module, then rebound to vfio-pci, before being used in DPDK.
> 
> As this capability is detected at runtime by dpdk-pmdinfo, add the info in the
> PMD registering directives.
> 
> Then an external script can be used for bind and unbind.
> 
> Fixes: 2f8a1b963eb77 ("crypto/octeontx2: add PMD skeleton")
> Cc: stable@dpdk.org
> Cc: Anoob Joseph <anoobj@marvell.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding
  2020-02-10  7:44 ` Anoob Joseph
@ 2020-02-12 10:28   ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-02-12 10:28 UTC (permalink / raw)
  To: Anoob Joseph, Thierry Herbelot, dev; +Cc: stable, Thomas Monjalon

> >
> > Like for OCTEON TX, the OCTEON TX2 crypto engines must first be unbound
> > from their kernel module, then rebound to vfio-pci, before being used in DPDK.
> >
> > As this capability is detected at runtime by dpdk-pmdinfo, add the info in the
> > PMD registering directives.
> >
> > Then an external script can be used for bind and unbind.
> >
> > Fixes: 2f8a1b963eb77 ("crypto/octeontx2: add PMD skeleton")
> > Cc: stable@dpdk.org
> > Cc: Anoob Joseph <anoobj@marvell.com>
> >
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-12 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10  7:35 [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding Thierry Herbelot
2020-02-10  7:44 ` Anoob Joseph
2020-02-12 10:28   ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).