From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD133A0471 for ; Thu, 18 Jul 2019 17:21:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D22F28EE; Thu, 18 Jul 2019 17:21:16 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20087.outbound.protection.outlook.com [40.107.2.87]) by dpdk.org (Postfix) with ESMTP id A75A41C01 for ; Thu, 18 Jul 2019 17:21:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B12IjI4nzClP4Eg6xQS+BSlnvSCNHm+sBNB6E4pz3XNpkA50RHAtKVu8nlmVC5tpivEs5QMODHCs/DooJb2z+6YdvYhREeMGHxSB6gmfv1E6/c9ZttrCaQzDrX5s0q7eg9vYQiFUzl3qV5NbGXq6vFtg4U12slz6hNAbbKg7ulJOHo2gxXNlFI70pyHaKtjk1dYYWBERZ6G60+aBTFwn3Nms0v9Pq/zUcf0C3hQOhNZ9klvxbqp0da56nVkS8DPw93PxxRub7USvMWVeXy4r3pyQkgSfOln9SzSyr6wR9zGJhLylcenugGylgkPQfqqcrbXxn0DHIlNGT3KGpk18Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LY5Cail9hIOl7TSj2rbRQIG+M731ao8/ljscQn5oZ4M=; b=oeUbN6HM9qZH7aoq0qxHr3bng0xrI7OfW+p79UE7otOorBSFXVJhWhyDTkYJxeeF1V1YNaPdX+e9w4/jdjBCFIe3u9lZYn4v+0e7BrLJoqAaE1W2y5AQec2Rpco2razO8GQMPQIwIxvtOArIhfppXYWGA5o6UtlZ4YfMWoEypWkuj7/iwaTzpvM4hyT3KEtPpaDEXwIAUPGLQhyccCfwNAtUzWUtU/5kY1EvSfsO2I01sEUGzfA4vwyqVAHQoWT3lGa77neb3buh66UAa/qVhx2PIrJOJ8Cp47n3bpkiTREdcy4ncMlreNeDAXRG/nuMvwPBjZCvE25v48P2cLQgQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LY5Cail9hIOl7TSj2rbRQIG+M731ao8/ljscQn5oZ4M=; b=ZE3CcGmInXgmC2WMn3AK8DrKRwmzTUen835ZSVkMFDVSjUouEuikG8tYL33+cswVhKT2f2BX3IQ1MvkSk3OuSvaXea+vW6lpFeQNxZ23pDrNB9LBByBqEckSmFn47NiYAO3B3D4Gq0KAvYl9UTHVLQbARwZlwS4FT3FGDPRADSQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6382.eurprd04.prod.outlook.com (20.179.232.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Thu, 18 Jul 2019 15:21:13 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::d546:8474:f63a:5d22]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::d546:8474:f63a:5d22%6]) with mapi id 15.20.2073.012; Thu, 18 Jul 2019 15:21:13 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Iremonger, Bernard" , "Zhu, TaoX" , "Nicolau, Radu" CC: "dev@dpdk.org" , "Zhu, TaoX" Thread-Topic: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option Thread-Index: AQHVPUy0B0YMz6K6LU2tnqDaB6H1MabQNPMAgABJJOA= Date: Thu, 18 Jul 2019 15:21:13 +0000 Message-ID: References: <20190718142143.7148-1-taox.zhu@intel.com> <8CEF83825BEC744B83065625E567D7C260DD1866@IRSMSX108.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772580168A56F59@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A56F59@irsmsx105.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.0.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9e2d300b-af7d-4ff9-e947-08d70b939224 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6382; x-ms-traffictypediagnostic: VE1PR04MB6382: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01026E1310 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(39860400002)(376002)(396003)(346002)(199004)(189003)(13464003)(6436002)(478600001)(2906002)(6246003)(71190400001)(71200400001)(52536014)(66946007)(74316002)(25786009)(81166006)(81156014)(86362001)(66446008)(64756008)(66556008)(76116006)(66476007)(8936002)(14454004)(256004)(4326008)(3846002)(6116002)(26005)(54906003)(316002)(9686003)(99286004)(11346002)(446003)(33656002)(68736007)(53936002)(102836004)(110136005)(229853002)(186003)(486006)(6506007)(7696005)(5660300002)(7736002)(44832011)(66066001)(476003)(55016002)(53546011)(76176011)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6382; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lg10zAjKkHAjbt0Iyr6YlaCQpgnZb5/BNSBZn+lCsoVvhGw4mllXb5fsKLVfOX7lw0OLoJR9+2yMhb+/XILlLia43FnY3fL5xPHY+ciugRCdoOy7p64EbdwSohe5pVsvUJbNdR0LXyxgzN+vGTqqydw9UFQ0VuBLqVrwmHAZQ4Q7/kda7+KAt4CkqrYdJHn9UKh6Xfb0eK13k+5uEO26YQ3WhSD7kdt8jcKRjkr1vSN7GX28RV53p7Ad696SBHtIvxR2lZ7/3AXwDM6ennaZjP047V0CU6ZHhSjnUEmEyKaYlR6ft96mfSJ30jl+v5GWPgkfgmKQbELDwlw3RXesN49qmH4/v6OY+5UckO/z7VAwl7zfODd6ULO1htEceXtCJuVHS/exC54rF8FwrFw9rU8lGp7Ts4dS/SqHrbbajrc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e2d300b-af7d-4ff9-e947-08d70b939224 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2019 15:21:13.5185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6382 Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu parse option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 >=20 > Hi guys, >=20 > > > > Hi Tao > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of > > > taox.zhu@intel.com > > > Sent: Thursday, July 18, 2019 3:22 PM > > > To: Nicolau, Radu ; akhil.goyal@nxp.com > > > Cc: dev@dpdk.org; Zhu, TaoX > > > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add parameter --mtu > > > parse option > > > > > > From: Zhu Tao > > > > > > This patch add parameter --mtu parse key and enumeration value. > > > > > > Signed-off-by: Zhu Tao > > > --- > > > examples/ipsec-secgw/ipsec-secgw.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > > > secgw/ipsec-secgw.c > > > index b1ecbb975..05fffa967 100644 > > > --- a/examples/ipsec-secgw/ipsec-secgw.c > > > +++ b/examples/ipsec-secgw/ipsec-secgw.c > > > @@ -159,6 +159,7 @@ static const struct option lgopts[] =3D { > > > {CMD_LINE_OPT_RX_OFFLOAD, 1, 0, > > > CMD_LINE_OPT_RX_OFFLOAD_NUM}, > > > {CMD_LINE_OPT_TX_OFFLOAD, 1, 0, > > > CMD_LINE_OPT_TX_OFFLOAD_NUM}, > > > {CMD_LINE_OPT_REASSEMBLE, 1, 0, > > > CMD_LINE_OPT_REASSEMBLE_NUM}, > > > + {CMD_LINE_OPT_MTU, 1, 0, CMD_LINE_OPT_MTU_NUM}, > > > {NULL, 0, 0, 0} > > > }; > > > > > > -- > > > 2.17.1 >=20 > Thanks for fixing it for me, don't know where I lost that line. >=20 > > > > This patch looks like a fix, if so it should have a fixes line and Cc: > stable@dpdk.org if it is to be back ported. >=20 > I am agree with Bernard about fixes line, though no need to CC stable, > as this bug was introduced in 19.08 timeframe. >=20 > > > > Also > > ./devtools/check-git-log.sh -1 > > Wrong headline lowercase: > > examples/ipsec-secgw: add parameter --mtu parse option > > >=20 > Apart from the nits mentioned above: > Acked-by: Konstantin Ananyev > Tested-by: Konstantin Ananyev Changed the subject and added fixes line Applied to dpdk-next-crypto Thanks.