From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 0F12AA046B
	for <public@inbox.dpdk.org>; Tue, 25 Jun 2019 14:57:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C62831BA8F;
	Tue, 25 Jun 2019 14:57:07 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40084.outbound.protection.outlook.com [40.107.4.84])
 by dpdk.org (Postfix) with ESMTP id A54981BA85
 for <dev@dpdk.org>; Tue, 25 Jun 2019 14:57:05 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FWUaOs+89vz4sWir/WWCeNIg8rQ6OuwLrU+T1vZW3hs=;
 b=SWcOUDJDvXcD2zrEae8Z7grALeb9Yw+ItujBSkUCrPMNzvw38EsKHR1ipeZeY6bC1cyFVB/48SLWs8m++tkM/MyzFSlZcwAfZHpCmq5lZW4ltlBCWP5omI5sfA9udFJkv8Xc7/wR4JeEADWL3YH70yJl+K/jank8v6srJqXYaxY=
Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by
 VE1PR04MB6672.eurprd04.prod.outlook.com (20.179.235.145) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.2008.16; Tue, 25 Jun 2019 12:57:04 +0000
Received: from VE1PR04MB6639.eurprd04.prod.outlook.com
 ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com
 ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2008.014; Tue, 25 Jun 2019
 12:57:04 +0000
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Smoczynski, MarcinX" <marcinx.smoczynski@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Kovacevic, Marko"
 <marko.kovacevic@intel.com>, "orika@mellanox.com" <orika@mellanox.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>, "Nicolau, Radu" <radu.nicolau@intel.com>,
 "Kantecki, Tomasz" <tomasz.kantecki@intel.com>, "Iremonger, Bernard"
 <bernard.iremonger@intel.com>, "olivier.matz@6wind.com"
 <olivier.matz@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 1/3] net: new ipv6 header extension parsing function
Thread-Index: AQHVBYt/A1SfYuZY10OyhHyZoPRbVaakrYQAgABlzgCAAO7h0IAE90SAgAGl7TA=
Date: Tue, 25 Jun 2019 12:57:04 +0000
Message-ID: <VE1PR04MB66398F1C1B2C1EAE5A928BCAE6E30@VE1PR04MB6639.eurprd04.prod.outlook.com>
References: <20190508104717.13448-1-marcinx.smoczynski@intel.com>
 <VE1PR04MB6639DD8D7110A56C09ED2F2FE6E40@VE1PR04MB6639.eurprd04.prod.outlook.com>
 <2601191342CEEE43887BDE71AB97725801689E2C5B@IRSMSX104.ger.corp.intel.com>
 <VE1PR04MB663903D56058E5988074890FE6E70@VE1PR04MB6639.eurprd04.prod.outlook.com>
 <2F25558C1648FA498380EAC12A861262CE62EB@LCSMSX153.ger.corp.intel.com>
In-Reply-To: <2F25558C1648FA498380EAC12A861262CE62EB@LCSMSX153.ger.corp.intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=akhil.goyal@nxp.com; 
x-originating-ip: [92.120.1.65]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 33d4d76a-4103-4e15-09a9-08d6f96c9f4e
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);
 SRVR:VE1PR04MB6672; 
x-ms-traffictypediagnostic: VE1PR04MB6672:
x-ms-exchange-purlcount: 1
x-microsoft-antispam-prvs: <VE1PR04MB66729909862057C58C37EE27E6E30@VE1PR04MB6672.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0079056367
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(376002)(39860400002)(366004)(346002)(396003)(136003)(199004)(189003)(68736007)(33656002)(2501003)(73956011)(7416002)(66556008)(76116006)(66946007)(71190400001)(2906002)(66476007)(64756008)(71200400001)(52536014)(305945005)(99286004)(7736002)(7696005)(74316002)(66066001)(102836004)(8936002)(6506007)(26005)(81156014)(81166006)(8676002)(478600001)(5660300002)(86362001)(316002)(110136005)(966005)(186003)(66446008)(14454004)(55016002)(6246003)(6116002)(6306002)(11346002)(25786009)(6436002)(3846002)(4326008)(229853002)(256004)(53936002)(44832011)(9686003)(486006)(476003)(446003)(76176011)(921003)(1121003);
 DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6672;
 H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: wPpjnHn06/wwh7FY/N60OYafXe8PYYoXcHWrUEo6fSCe0OShl09d/2rym26UeN1coEzA5YwLaXLTHqiHIYsKvC3W0cWqrufQaKspjzyqisMrv54z1zIdFx65XelipIs0CIgap0fBLCnFPS4q30TOc+dYXizlayI+cxIogpvF3rcOXvxfGsRKrUFC6rZq66VZMK8Y3a+TgZNbSM3u521u4Gu4iM+jo6A9p2U5MV1dVoWtUPGdrDTciLAYQy2DGN3InrqyL6aJqIj057/VY2qbTQXwEhqthrdRRQ/hFyAkuzNelkPyHJpl3j4qy02KTmHYBzGbeciBH8bySNSGDgViK5e2T9SvWmVpyNC9lAJxt/AH49SRnPUlzXlsT0Q2dGbMwgyFR9hKYwpxiuY5hkkBaFyViv2vRiKRHJST+EO7w2I=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33d4d76a-4103-4e15-09a9-08d6f96c9f4e
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2019 12:57:04.2740 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6672
Subject: Re: [dpdk-dev] [PATCH 1/3] net: new ipv6 header extension parsing
	function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Marcin,

>=20
> Hi Akhil,
> I've double checked and there is no problem with linking application agai=
nst
> shared libraries, because inline functions are being inlined during compi=
lation
> and before linking is done. To be more specific: there is not such symbol=
 as
> rte_ipv6_get_next_ext in ipsec-secgw.o (which uses this function in
> prepare_one_packet function).
>=20
> There are a number of inline experimental functions defined today  and th=
ey are
> mostly (43 out of 59) not listed in maps, e.g. rte_ticketlock functions f=
amily
> defined here:
> lib/librte_eal/common/include/generic/rte_ticketlock.h
>=20
> Is there any particular reason we should put inlines in maps? Maps are us=
ed by
> linker to control versions of shared libraries and inlines are not proces=
sed by
> linker.
>=20
> I am aware this patchset causes build failures on BSDs - this is a projec=
t-wide
> issue which I have addressed here:
> http://patchwork.dpdk.org/patch/53406/
> I'll put a note in the next version of this patchset's cover that it depe=
nds on
> abovementioned patchset.
>=20
> Marcin

Thanks for correcting me.=20