From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61B4CA00E6 for ; Fri, 9 Aug 2019 12:21:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D57AE231E; Fri, 9 Aug 2019 12:21:34 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by dpdk.org (Postfix) with ESMTP id C4E962082; Fri, 9 Aug 2019 12:21:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJ5GxruMhYH47lTStlD6p+ixBkKELuOBQdJBHBM1rt8ST05r1w6EWYERQw5e1Ft6ABJ52EsDm9dBmiQZdrr7RPt5JSFFeq2PPv74HDuvQpIdJUMftYA5U1s5iClSl6GUoipzgHfxgv21aLDljdUddc5dfjV8OAzDScLh66j1t8Sly8jBe4sr07t6ulQQgxzo1xnAH5LrxS19o0pO/Yn21fV6dhHETALI4Cgd2sT8JaA8BgeJHlTWYaq2YCdsRll3BLzChO8v5/ue8AiWj+Nran+13RVuJw98HwU20rzPZOQP1nt0NVln8cfpo/RAXNgSB8LNTCYRYXKkPBqgTvDkKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwEsHOmRviochyjREofKTg08SYXafa06hedL+vFMTRA=; b=WVZ9bZpNmpxNsbmhdpd1sSVEFyoCMvdYt9KUUYhz/AzxYotN4x2i18Pp/ndCps2pqe1fhiWxmV0Yxm/AMpIhSCYADhUcxsNYsKKryGVZ/6FcNwjBNXUjxeE3/F+ggiao8mxWwg8ihwogKyOWOFFkJRYRt0BrnHfk/18oOL23fVAtG3yl89Fk9Q9UcTbaMY9IGLn9aRKvZ0huIUKP9S9Vk1XkGAod+cje2BNcdGAi6sRN6BDGkUrdLgJoOmCXUzQC/EdlVkSO7hN21O8Y8vopAEYQrPOouholz5GkhXOCktyPM6lt/VJ89VAZb0SvtYaRLHU1i93f+sHWwlhbwTEbIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwEsHOmRviochyjREofKTg08SYXafa06hedL+vFMTRA=; b=jHBB0xRhs5gYyyASaIVZTkj+sZogrOBdSPz602IqLq3O5KYAxoI69E8GJoNEIBPZE7KcaloaogjeaPkzwXihU/DBvkrDGh2cPElixSGz1JEwFSnsRJbvQk090uuMShGknLlhZbAN3gi3i4Sd3H3eBV15LGTPdo2krpuic5p4aQM= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6464.eurprd04.prod.outlook.com (20.179.233.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.20; Fri, 9 Aug 2019 10:21:32 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec%7]) with mapi id 15.20.2157.020; Fri, 9 Aug 2019 10:21:32 +0000 From: Akhil Goyal To: Thomas Monjalon CC: "stable@dpdk.org" , Bernard Iremonger , "dev@dpdk.org" , "konstantin.ananyev@intel.com" Thread-Topic: [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value Thread-Index: AQHVTRvgA5nvrYdIUEGA1JKX4Yiki6bvsG8AgAEpeACAAcNnkA== Date: Fri, 9 Aug 2019 10:21:32 +0000 Message-ID: References: <1565181012-19553-1-git-send-email-bernard.iremonger@intel.com> <4252912.OkXEp6FMEK@xps> In-Reply-To: <4252912.OkXEp6FMEK@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fec6de6-fe53-46b9-cf20-08d71cb359de x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6464; x-ms-traffictypediagnostic: VE1PR04MB6464: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01244308DF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(39860400002)(346002)(189003)(199004)(44832011)(486006)(476003)(66446008)(66946007)(64756008)(66476007)(66556008)(6916009)(446003)(11346002)(71190400001)(71200400001)(76116006)(8936002)(2906002)(102836004)(6436002)(25786009)(14454004)(256004)(4326008)(33656002)(8676002)(305945005)(4744005)(7736002)(26005)(9686003)(54906003)(81156014)(55016002)(316002)(5660300002)(74316002)(81166006)(3846002)(76176011)(53936002)(7696005)(6246003)(6116002)(229853002)(478600001)(99286004)(6506007)(52536014)(186003)(86362001)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6464; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZEBiRAIxy8A6Lu/tJG8/OJW60t6BBspn2o/IXMikwE4Bv2xxwl0jonGxiH92Wp7pSA28oK4CQSAS11gu1rBatlBYW5v6S8HEM6tAMKsmwhFexGmMX5/GaGuv3ttsHk3gPpqA3Z9GL/6Q4Ibe5vYCDPnWQli5uWiPENhRncggtuJgl8221iyFuG/drndM+Y4QeISyHNazBhL/+7cChqhdj4MXjSMul1T+L4hE3Q+U98/N1kCm67r+eo8AJ9kBMw5Yzmf7DdbmC1hTexX5cN2o3mRjVwxos1Y5X1r9+RIsxokUZWQOSOb0JbpMCVn0bkuArjqL3daDKV4KrtkSnAFliR6oHQ4lRvbIs84h793I+PudWDffwG9mEodrCeZnwMjH2u3GwIhn3WVK2uzpxjeds74rmg7pAiefyaS+a7WEWlc= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fec6de6-fe53-46b9-cf20-08d71cb359de X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2019 10:21:32.7163 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8zIE/zdZTyRLA+pgf6kSfCgwA9Hpsrx7kebxQv6qlrQasWB87S4eWarczLpoM56qg2GCBGPgzMbbI+pjzkxNPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6464 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ipsec-secgw: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 07/08/2019 15:39, Akhil Goyal: > > > > > > > > Check the return value of the rte_eth_dev_rss_hash_conf_get function. > > > > > > Coverity issue: 344970 > > > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inl= ine > crypto") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bernard Iremonger > > > --- > > Acked-by: Akhil Goyal > > > > Thomas, > > Could you please take this patch directly to master. >=20 > It doesn't look critical at all. > Why do you want this in DPDK 19.08 without enough time for proper validat= ion > testing? Yes this one is not a critical fix. We can defer it to next release.