From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6043DA2EDB for ; Tue, 1 Oct 2019 14:38:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FC814C74; Tue, 1 Oct 2019 14:38:16 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40061.outbound.protection.outlook.com [40.107.4.61]) by dpdk.org (Postfix) with ESMTP id 23B84397D for ; Tue, 1 Oct 2019 14:38:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XT11Wx5lQFhjNtj56DcwXy84XkeFbMsST42HVX14uynjK8aLKZYFBi7nlgjKPQOQwcItgTpl71UUwe5al3oc01u6zoE6rYwedmPRXwDI6fCxOeASyshnoMuSIqvdHBDODl3euHpkxZtUYAcn9NtRlZqNdDpsT1DmlF11dp+oF8u+JDiZnUbnJTmKJR4XM40L6bGi+gWK8Q2aohUFSf792Tk1ejuxKmTvpgluyowoKo8BDIB/D9z/p0iVPnbjEHDARtS9C+AmRY34QSpTR+BNvN0SHQ8MFUox9gP9F381ePV74YYSSlZX33heiuhwyMiE8NavvIU2BEgrLQ9QPI31lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dcL5ZJpeEUf5E8Ld8cLk2ZVro25/g023qS/pUwvnOsQ=; b=Zzl+v8rWPizbZeYV4Q2Ygh2KBP1N/f9yWmGHbeSvAt5pF8/RuyA3ipUFFd2MQShu7czKIowIT8b5zcb0ClSJRr2ndOqohPCqiBikilD+ksBbL5TsMa1O6VMgWTdbV0duGJ957BRgkW7T+7mmrOWQsvhfwIV6ALqwMbMib3cvemqKoWCXQL7RwEN7kmeLGnsiCw4/MFg8lxyZ2LTX3hLrbvkUoO1h4NXv07IxG6PCmgu5JJy/sXLwjjydY62X14DjBHK1XlZBmYujigaC+2q3q4VOJ0Z0yHuUuuXCBMxiH/Ddzi0mdxBYeBRE6lt1AhfzJB7uzVG/e1yDzKXgCElUyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dcL5ZJpeEUf5E8Ld8cLk2ZVro25/g023qS/pUwvnOsQ=; b=oxcBFYB0H/ftL2j3aQr8b/BmR6/pU8Hlz3XYM+h3lQngZnvhnOZQMnDtmRMBcB3Ao/pYR9xLBmQHd1eidBx664eko2sDM0ru00ewd9b6y/06GubnShPWMaBW9j8KHtFrLK8sQ7BnTUm8fxBcOb3HqiXjQR8N92QX7G0okO24Mg4= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6606.eurprd04.prod.outlook.com (20.179.235.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.15; Tue, 1 Oct 2019 12:38:13 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.022; Tue, 1 Oct 2019 12:38:13 +0000 From: Akhil Goyal To: Anoob Joseph , Pablo de Lara CC: Kanaka Durga Kotamarthy , Jerin Jacob , Narayana Prasad , Fiona Trahe , Shally Verma , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 2/8] crypto/octeontx: add RSA and modexp asym capabilities Thread-Index: AQHVZxKQEmb/u2Z88E6+kRnaLipSoKdF2xlQ Date: Tue, 1 Oct 2019 12:38:13 +0000 Message-ID: References: <1568035687-25492-1-git-send-email-anoobj@marvell.com> <1568035687-25492-3-git-send-email-anoobj@marvell.com> In-Reply-To: <1568035687-25492-3-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e8831c6-9be5-42a8-f2ba-08d7466c39d4 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6606: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 0177904E6B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(366004)(39860400002)(346002)(136003)(189003)(199004)(44832011)(102836004)(26005)(478600001)(7696005)(76176011)(8936002)(7736002)(71190400001)(6506007)(81166006)(229853002)(81156014)(6246003)(8676002)(14454004)(305945005)(486006)(64756008)(66446008)(66946007)(55016002)(11346002)(476003)(66066001)(66476007)(74316002)(76116006)(2906002)(25786009)(6436002)(66556008)(186003)(71200400001)(256004)(446003)(9686003)(33656002)(6116002)(3846002)(4326008)(86362001)(52536014)(54906003)(110136005)(99286004)(316002)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6606; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yAJd+gzmRZh6iBnrdogEfNlGiWPbmSEmeN4s+03/2BrdQnIuGlR1yzm+g+so9sUq2J+I5RHOr6TS5PH2g3ZbqUCYumMVYlAUuWZmFiJtLq+29LkUh94LHPZb0AZXrJ5BGumWo0PiNP+xicw0uBdNUSnDxCoX6FSUdLplDG8muCnen14w/mk7brn1CssKnVKw93w4Gib+EJwrheVIdYjJkM5J/L2pikrVp5jGkEQWO6+Ej++59RkCnahzVITUM8eVlZp5d42hGCVPLjJFSQ/xMbg9pvOnB9j5KZAkigN01kBOrwlQC9zF4NIkwxwHKIyFod8lXECLLCG/pYRDCd0mCinjyvMc34xTvrtDNNPuTBU3SY+MzUnOFKnE5QoMx5qeY9vsJmwj26+gNBOtR31Y/r2g7YIXlL93r+ffGsp5utk= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e8831c6-9be5-42a8-f2ba-08d7466c39d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2019 12:38:13.5244 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YIVx4OuTSFj4Uu8tpsyuHAsfssy+eGGlx9JPhmzClmXR7o7tjTs2E/35jv+cMeUFqAfxElnKBvfTbhnu/Dphzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6606 Subject: Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx: add RSA and modexp asym capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, > const struct rte_cryptodev_capabilities * > -otx_get_capabilities(void) > +otx_get_capabilities(uint64_t flags) > { > - return otx_capabilities; > + if (flags & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO) > + return otx_asym_capabilities; > + else > + return otx_sym_capabilities; > + > } I believe this will give Asym capabilities always. As the feature flag RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO will always be set, as the flags are set= in init. It will never go in else. > diff --git a/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > b/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > index fc62821..439b50e 100644 > --- a/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > +++ b/drivers/crypto/octeontx/otx_cryptodev_capabilities.h > @@ -8,10 +8,9 @@ > #include >=20 > /* > - * Get capabilities list for the device > - * > + * Get capabilities list for the device, based on device type > */ > const struct rte_cryptodev_capabilities * > -otx_get_capabilities(void); > +otx_get_capabilities(uint64_t flags); >=20 > #endif /* _OTX_CRYPTODEV_CAPABILITIES_H_ */ > diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c > b/drivers/crypto/octeontx/otx_cryptodev_ops.c > index 88efed3..b59a001 100644 > --- a/drivers/crypto/octeontx/otx_cryptodev_ops.c > +++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c > @@ -105,7 +105,7 @@ otx_cpt_dev_info_get(struct rte_cryptodev *dev, struc= t > rte_cryptodev_info *info) > if (info !=3D NULL) { > info->max_nb_queue_pairs =3D CPT_NUM_QS_PER_VF; > info->feature_flags =3D dev->feature_flags; > - info->capabilities =3D otx_get_capabilities(); > + info->capabilities =3D otx_get_capabilities(info->feature_flags); > info->sym.max_nb_sessions =3D 0; > info->driver_id =3D otx_cryptodev_driver_id; > info->min_mbuf_headroom_req =3D > OTX_CPT_MIN_HEADROOM_REQ; > @@ -635,7 +635,8 @@ otx_cpt_dev_create(struct rte_cryptodev *c_dev) > case OTX_CPT_VF_TYPE_AE: > /* Set asymmetric cpt feature flags */ > c_dev->feature_flags =3D > RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO | > - RTE_CRYPTODEV_FF_HW_ACCELERATED; > + RTE_CRYPTODEV_FF_HW_ACCELERATED | > + RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT; > break; > case OTX_CPT_VF_TYPE_SE: > /* Set symmetric cpt feature flags */ > -- > 2.7.4