From: Akhil Goyal <akhil.goyal@nxp.com>
To: Shally Verma <shallyv@marvell.com>,
Fiona Trahe <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] compressdev: clarify destination buffer size for corner case
Date: Mon, 29 Jul 2019 08:48:46 +0000 [thread overview]
Message-ID: <VE1PR04MB6639A0D9C05F0AAD98ABA978E6DD0@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <BN6PR1801MB20529F23D5C4F4EC7E0B55F2ADC30@BN6PR1801MB2052.namprd18.prod.outlook.com>
> >
> > ----------------------------------------------------------------------
> > Clarify the corner case with incompressible data whereby the output can
> > actually be greater than the uncompressed data.
> >
> > Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> > ---
> > lib/librte_compressdev/rte_comp.h | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/librte_compressdev/rte_comp.h
> > b/lib/librte_compressdev/rte_comp.h
> > index b7474c4..95306c5 100644
> > --- a/lib/librte_compressdev/rte_comp.h
> > +++ b/lib/librte_compressdev/rte_comp.h
> > @@ -323,6 +323,12 @@ struct rte_comp_op {
> > * If the output data is expected to be bigger than this a chain of
> > * mbufs can be passed to the PMD if the PMD's capabilities indicate
> > * it supports this.
> > + *
> > + * @note, if incompressible data is passed to an engine for
> > compression
> > + * using RTE_COMP_ALGO_DEFLATE, it's possible for the output data
> > + * to be larger than the uncompressed data, due to the inclusion
> > + * of the DEFLATE header blocks. The size of m_dst should
> > accommodate
> > + * this, else OUT_OF_SPACE errors can be expected in this case.
> > */
> >
> > struct {
> > --
> > 1.7.0.7
> Acked-by: Shally Verma <shallyv@marvell.com>
Applied to dpdk-next-crypto
Thanks.
prev parent reply other threads:[~2019-07-29 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 17:04 [dpdk-dev] " Fiona Trahe
2019-07-26 8:22 ` Dybkowski, AdamX
2019-07-26 12:46 ` Akhil Goyal
2019-07-27 4:21 ` [dpdk-dev] [EXT] " Shally Verma
2019-07-29 8:48 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6639A0D9C05F0AAD98ABA978E6DD0@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).