From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80EC2A328D for ; Tue, 22 Oct 2019 08:03:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C702D4C8B; Tue, 22 Oct 2019 08:03:25 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50072.outbound.protection.outlook.com [40.107.5.72]) by dpdk.org (Postfix) with ESMTP id 65D0C37AF; Tue, 22 Oct 2019 08:03:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzG6zE4zGui35XIv+oeBBtiy9JaJjpKQhub95GFxph8cijNd1lplM9y/UPr+zryV3AgiAxmuDkNALRRzD47UpS1x/IOQpnL2ATVu3pc4WJO+h0xrIr/0ud5EC6AUyLf3lBmN7n6X5A4rEkkuEFNB3CDeH4ykhOZKNq0TANcB+3SSkHep5yoLaCG/ljJmC0lJ4AK61WzJvVPFTEP8DYHdCzYIC9kNFrg6MHmgR3qGp6VHWbhDeIb0uGkU6PM14ndRYv7PS1eUxG1YC3X7N0xSc1sW5qBSy+IZW73PRZiuONV/UxShdLWABC4nvpfixyPQ15GuGpeAj1X0a/wglgtuOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UCU3p/ZaDiwgledXokhoqdyCI3M8oX+5F/Gm75E1GPE=; b=fyU1BDrmNq1uZPvh3fruBABbVsaaIM6SMIWe91jdx2k+44f612/y1tlm2Cxra/2gvZPqkgGdEqK9tG+cCrxFqLWMikRybNdDl03reCBC4x2LQGpqHNCHTRfOwQ2jFlhaWghtn2qnEZwUmJWh5jENkJf39vGa+yATXI1EOy23yac+L55mA5ub5I7sj4vddKeYqwc0H3adm85vZ8nTpPpPIC8DZHb14XF6BCt7p1peds/OPisNnH8QIz1u8dc1fiKY0Ys6Ik4FT+pHmznSNu8PTMu/VBKVyukDajYEXxNGRqN91+4cF9gkYTTTh+pIpkM5XVZTJlvhD8TLbsJkS+yphw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UCU3p/ZaDiwgledXokhoqdyCI3M8oX+5F/Gm75E1GPE=; b=CscRugR1vEztMRq4yjuPkxTbPFU+HKt8y5xq32iBMAqv4Mtzcifz9CJTh5wpNDhCS8zw8DC98peogmG1pGS5XQ+iAR91ACgjK3m0bW4z4XHfhKNGEnwcjHvQP+G35Kluw9Go5lKxQ+DzIgN6fmZc6XYYIJdV3Pyz4zXp2/Qw6dU= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6509.eurprd04.prod.outlook.com (20.179.235.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.24; Tue, 22 Oct 2019 06:03:22 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561%6]) with mapi id 15.20.2367.022; Tue, 22 Oct 2019 06:03:22 +0000 From: Akhil Goyal To: "Somalapuram, Amaranath" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used Thread-Index: AQHVgyZjqDIZFySiFUO55qa6IdDkV6dbiM7ggAqgo9CAAAxnwA== Date: Tue, 22 Oct 2019 06:03:22 +0000 Message-ID: References: <20191015070112.92937-1-asomalap@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 600708fc-b4c7-4ce9-b038-08d756b58b59 x-ms-traffictypediagnostic: VE1PR04MB6509: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:972; x-forefront-prvs: 01986AE76B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(199004)(189003)(13464003)(446003)(476003)(11346002)(486006)(71200400001)(71190400001)(186003)(3846002)(6116002)(110136005)(316002)(26005)(44832011)(33656002)(2906002)(2501003)(66066001)(5660300002)(52536014)(6306002)(55016002)(9686003)(6436002)(86362001)(4326008)(6246003)(66446008)(64756008)(66556008)(81156014)(81166006)(305945005)(74316002)(8676002)(7736002)(8936002)(66476007)(66946007)(76116006)(229853002)(53546011)(6506007)(25786009)(478600001)(102836004)(966005)(14454004)(14444005)(256004)(7696005)(99286004)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6509; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2gb2N7vy2IcmaxEicHpPBGDBQr85lwwTTrsqM0EpAafRmpAWdunNYUTau4n/acBiioiH8AFeBdtPJkn7WvlmfccPB5MrAQsltcvADw84Z4EpEQrAyz1Un4ywEy+4O71lvX0xhdqfJjGaJwh1JXpZA/z6dZigsSc2Zg+F7gPXc7Nb2bfDPGesfd9VEqrk7vKwhanCZE9tzNceRUHadSYPyznlO//MNyNkB30k+IMxKB46vBeKkGOOQyuKRTZQKi/gDFP2xoZIXveC/NB7Txpk4mRfsAfWLMwbOx2TAbJ+819GB/SHJrDC2t6htMgy75B/ETv1Sx+Nx3yGg6ng8Xx1vWHIES23X3YybzRxhz3/hNRqOmh7nE+Lx4gLJqC/tSROmuVToTdSdkBixh7K5naLo34Hk2eT0meyDiMARcpab07YcQ++tL0bvvukvvaWOfbGUH+GQHxCQBl/ZcRHfkvG//Iim5zzN3GON/PVnXszNmI= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 600708fc-b4c7-4ce9-b038-08d756b58b59 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2019 06:03:22.2704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IW1lpoaXIjoDXLE4pg2Lvlklo0jNgsuGrPOxZLlCuCkbUK2cnsnGNPOZ80EbJNhq9sV82xPM59LFDXQd2UKLAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6509 Subject: Re: [dpdk-dev] [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authentication is used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Please refer coding guidelines at https://doc.dpdk.org/guides/contributing/= patches.html Here is the example of a fix commit. In this "abcdefgh1234" is the commit = id which introduced this issue. You can check the commit id of the changed commit using git blame . doc: fix some parameter description Update the docs, fixing description of some parameter. Fixes: abcdefgh1234 ("doc: add some parameter") Cc: author@example.com Signed-off-by: Alex Smith >=20 > Hi Akhil, >=20 > Not sure about how to use fix line if I don't have bug number. >=20 > If I run ./devtools/check-git-log.sh it expect bug number. > Do you recommend to log a bug for my patches ?? >=20 > Please let me know. >=20 > Regards, > S.Amarnath >=20 > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, October 15, 2019 4:31 PM > To: Somalapuram, Amaranath ; > dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH v1 3/6] crypto/ccp: crash when using ccp cpu authenti= cation > is used >=20 > [CAUTION: External Email] >=20 > Title: crypto/ccp: fix CPU authentication crash > > > > From: Amaranath Somalapuram > > > > when ccp_auth_opt=3D1 is set and > > if authentication error occurred ccp driver crash. > > proble is enqueue count and dequeue count miss match if we continue. > Please rephrase this description. >=20 > Fixes line?? >=20 > > Cc: stable@dpdk.org > > > > Signed-off-by: Amaranath Somalapuram > > --- > > drivers/crypto/ccp/ccp_crypto.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/crypto/ccp/ccp_crypto.c > > b/drivers/crypto/ccp/ccp_crypto.c index 19ae9153d..1837c8543 100644 > > --- a/drivers/crypto/ccp/ccp_crypto.c > > +++ b/drivers/crypto/ccp/ccp_crypto.c > > @@ -2738,7 +2738,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, > > session, auth_ct= x); > > if (op[i]->status !=3D > > RTE_CRYPTO_OP_STATUS_SUCCESS) > > - continue; > > + > > CCP_LOG_ERR("RTE_CRYPTO_OP_STATUS_AUTH_FAILED"); > > } else > > result =3D ccp_crypto_auth(op[i], cmd_q, > > b_info); > > > > -- > > 2.17.1