From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AC13A052F; Fri, 31 Jan 2020 15:26:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 343811C0CA; Fri, 31 Jan 2020 15:26:19 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50063.outbound.protection.outlook.com [40.107.5.63]) by dpdk.org (Postfix) with ESMTP id B5A951C0C2 for ; Fri, 31 Jan 2020 15:26:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3ToY1O0S2rQhvJayL5l7xkTO3tNdPjcZBpUat7yycgg8G3lqE4z3mTpzKYhijqAyHrRvirNm1fWHUtLtRNI/WZcTO8xceC0IyxOVsfUOYThcMoooddgqqIPHnDFrOFnfWKm3BN+qs5ZNXh3L3muM/3ePsySvHRRB0F+BUHOaWNDP2CPv9oZtIlECrnu4/ER7JcuU+LTw/vYdv5vmW1BiwdddXYlen/RvD528t/tJyajkcLv9TNAn/yEtpr5zNZjBaG2wNNb8pdMgZToByQZJR+1QiTPyxOmDDpXqg2UZTAqAQi2Pr4vUjbEABJVp6Bi+6/vBqXo5kD26vj2GI4RWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zKtPlFIdtcTHjU+9aDNV3iFUy2DIIaYpMhjI4gmKY3c=; b=IM66fD7mNhEjpQFq5p6Cdf1jnxuBt18WObakfew41vzbUQDwhyf89GszUIbnfN69uwIjQK/Bo2lEGXGlNQ23XQnJlK6rr1wCQZWO1K7Dz4ndYvMIboQX2kOihQQBC2x4nb/CeoZQajY6h2KbvqdnrUedf88+RoJQ3gnAtRUvA74ufgDmeCNYwOpV1QWcId1CQ9Rssi6UUHzHMlnlJT2SlBTxN9O16n7SKlq6hZmLL5lydvFCStfdjQSEqosQP4APTrZ2D5ly2fGpGk8kBZOFBlAAeyJSQuihDcMHcLaq1eWKvJGVOx9PJgh9wDd+9dTUTlmj5zbOO4cS91msnSEUgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zKtPlFIdtcTHjU+9aDNV3iFUy2DIIaYpMhjI4gmKY3c=; b=ms6R56C9MCsoZKHKg/oA853c3Lnc+bFj88Z9Bk/O4q1d2lQXc9j0ayvTiabrNqn57xMMd3W2ChBI75erya8AuCM9FMpSbe0LI+cx+4ffrRf/Dbc2kaQ2t3UVFdx3wKFRmWZedSAXDAgWVTc4ij7QRJR4yhU/33PP+BBdnnS5VwI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6654.eurprd04.prod.outlook.com (10.255.118.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Fri, 31 Jan 2020 14:26:16 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2665.027; Fri, 31 Jan 2020 14:26:16 +0000 From: Akhil Goyal To: Marcin Smoczynski , "konstantin.ananyev@intel.com" , "roy.fan.zhang@intel.com" , "declan.doherty@intel.com" , "radu.nicolau@intel.com" , "pablo.de.lara.guarch@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 4/8] security: add cpu crypto action type Thread-Index: AQHV1eZnKJuNj8bF4U+7pEmVvjUMgqgE1FOQ Date: Fri, 31 Jan 2020 14:26:16 +0000 Message-ID: References: <20200128031642.15256-1-marcinx.smoczynski@intel.com> <20200128142220.16644-1-marcinx.smoczynski@intel.com> <20200128142220.16644-5-marcinx.smoczynski@intel.com> In-Reply-To: <20200128142220.16644-5-marcinx.smoczynski@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b5c3b2cc-4164-420d-3dd1-08d7a6598880 x-ms-traffictypediagnostic: VE1PR04MB6654: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 029976C540 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(376002)(346002)(366004)(136003)(199004)(189003)(15650500001)(110136005)(71200400001)(81166006)(81156014)(8936002)(5660300002)(33656002)(55016002)(8676002)(478600001)(9686003)(64756008)(4326008)(66476007)(66946007)(76116006)(66556008)(66446008)(52536014)(44832011)(316002)(2906002)(26005)(7696005)(186003)(6506007)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6654; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0Y+HuqT/k4mvZIWLVlTc1X1pgEr0+pE3YI1f73i2NCVisbyCbXF3NtkBLUA51HF6gXk26lDkuffJu1UcuSgQrJ0La+uxKJbSa5i8bjvCs8Xl5ZHuCWFXFumCLs7WzRsxumpKpGsHOalqayn0/4UcycJ+jIzBmljAxOfBHM2JnFcaqoZHvfw+4gl/MBeAGqoJEF3RPuavWa/hWSrhdFKIGhvPvjkdwGsruI86fV9dUtqf7ikgqMthmVBWCu3xlUSvOErr/20O9R1nlff+LGHz7ws5K0VqYTTOI4Biffert0BmTdjTDFylaLAgOPYdQpE4Bad7GEOgLy2JXy+AueOUYoXAmuHi55fizLnbxItKeov3fQ4Ywib3ouo6KlP3Q/tzJ1dQFtZAGRvT+QJuEqh/KyAAxEPeGpQRjddCPxM/gd224EfPGf7/QJGqmutqdGoY x-ms-exchange-antispam-messagedata: ojnDRO9NAk8h/LSEnK+2gY0qlqf9jlpRN4wlaF6VxUkvmAoPFHcB/uS1mWltCvK8qnevk13L1lOUdwoPU5wH2NYRp3eLzHi27b5A2JL92QgQ3bZq/VuIHwbzCUzw8aBQ32sJ7DnRSeHBl6MlHVdNdw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5c3b2cc-4164-420d-3dd1-08d7a6598880 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2020 14:26:16.7211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mm/idGThShSqW2oakpJ6FWLJ597OfOxqnjx4tiOas0SOpcYFgdsuhzLuDuZfgsPYRwKsAquawGAnfq9gybk+MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6654 Subject: Re: [dpdk-dev] [PATCH v5 4/8] security: add cpu crypto action type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Marcin/Konstantin, > Introduce CPU crypto action type allowing to differentiate between > regular async 'none security' and synchronous, CPU crypto accelerated > sessions. >=20 > Signed-off-by: Marcin Smoczynski > Acked-by: Konstantin Ananyev > Acked-by: Fan Zhang > --- > lib/librte_security/rte_security.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte= _security.h > index 546779df2..c8b2dd5ed 100644 > --- a/lib/librte_security/rte_security.h > +++ b/lib/librte_security/rte_security.h > @@ -1,6 +1,6 @@ > /* SPDX-License-Identifier: BSD-3-Clause > * Copyright 2017,2019 NXP > - * Copyright(c) 2017 Intel Corporation. > + * Copyright(c) 2017-2020 Intel Corporation. > */ >=20 > #ifndef _RTE_SECURITY_H_ > @@ -307,10 +307,14 @@ enum rte_security_session_action_type { > /**< All security protocol processing is performed inline during > * transmission > */ > - RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL > + RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, > /**< All security protocol processing including crypto is performed > * on a lookaside accelerator > */ > + RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO > + /**< Crypto processing for security protocol is processed by CPU > + * synchronously > + */ I am not able to see the need for this enum. It is used by the app and ipsec library to identify the cpu-crypto codepath= . I don't see any security action been performed for this action_type. This enum is just like NONE which is not used beyond the application/lib. I think this needs to be documented properly in the description of the enum= . It should be something like Similar to ACTION_TYPE_NONE, but the crypto processing is done on CPU Synchronously. Also add documentation of this in the rte_security.rst in this patch only. There should not be any separate patch for documentation. Regards, Akhil