From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD63DA0524; Fri, 31 Jan 2020 13:53:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 62ACD1C0C3; Fri, 31 Jan 2020 13:53:09 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by dpdk.org (Postfix) with ESMTP id E1E081C0C2 for ; Fri, 31 Jan 2020 13:53:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cNKcf3EVFf1Ox48PS4q9WVfM+kEm/XSauAUZoNx5ND1sfUly2Vp9dZFp1E57WteVspyaSZzZ2UEaYqCDJHy8fjzJwEe6LUr7gBeTjd//wMrlXXmGKp5e9T7vdBWXuVlaXwVS/JbkBY0hK3jclqpTl1EZKwkT3JEqfuvZTR3RG65wDeY/NJv/PoGysis9tAgud3Terfsl0BW4HTm4pQA3k/zngtkavrA6Kfh9UW0TWtV8TrrQ0h4aIKQC7ySRogz5DuM36Ebx8cxRIEi15ucAooEOq791IM+AI1sqlRTWIJxTUPyUsw9cIr8OfOnCwCCqryBCpenAo5jqF/j859oruA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rFE/NnvEwd2rcG6gsGH7CYWb0XCriB7n7bkH5wq1ahs=; b=NOu5mzi3Qm5jJFLjw32b3xbuU8PU+RC36JXLDlmjJEEzoiCglORJ7+FkUYITq4QvsAf+LCUyym28WNQcrW7YDQ6mZuIMBDeMRac302XJhCy+kMPQH57efofgfaAKHyuVriFNvU3OYuzhJnFRCRGr3nJWDwGkl7NYy3LWF0xuiuSQTIDJtQSsXpDxxc/hg23Bl2RQdbPYuUmRWPs9/WAw5Z+K/EMrRM/QI4FSplX0SSZ/J6qAHWd8RZd9lUMt8Ro0ja9HUxr51kwUlq5oLLR8SNgzv6sLxV2VZIdUvApQ3uqAFamyKqDoDCcZYpxa1khdX21ZHiqmqz3GvNBGILPb2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rFE/NnvEwd2rcG6gsGH7CYWb0XCriB7n7bkH5wq1ahs=; b=NBa9rauORKPKTgDSiUf8LDGGFwOXC6i1qfyyB7DUlKXfwYh2eWnixmxtCkdLPssnOKQhDpJU2Xgg+ay6UQOhs4hsr0akt/h+XjmT87oBLUMjNvSEe4yX2MpkAYAF+AYfgoTebuYKMT9YyWS87xeyGhhTrP9ZhruXTb3thach0hI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6382.eurprd04.prod.outlook.com (20.179.234.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Fri, 31 Jan 2020 12:53:06 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::25b0:b1ac:aed0:63e1%7]) with mapi id 15.20.2665.027; Fri, 31 Jan 2020 12:53:06 +0000 From: Akhil Goyal To: Anoob Joseph , Vladimir Medvedkin CC: "konstantin.ananyev@intel.com" , "dev@dpdk.org" Thread-Topic: [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw Thread-Index: AQHV1q1F4w2RqjI6IE6VioTYQWMILKgEvOsA Date: Fri, 31 Jan 2020 12:53:06 +0000 Message-ID: References: <1579012036-326214-1-git-send-email-vladimir.medvedkin@intel.com> <1580306768-110555-1-git-send-email-vladimir.medvedkin@intel.com> In-Reply-To: <1580306768-110555-1-git-send-email-vladimir.medvedkin@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dedec8ab-bffc-42ee-2282-08d7a64c8493 x-ms-traffictypediagnostic: VE1PR04MB6382: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:561; x-forefront-prvs: 029976C540 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(346002)(136003)(396003)(366004)(199004)(189003)(316002)(44832011)(26005)(8936002)(186003)(4326008)(478600001)(86362001)(71200400001)(33656002)(9686003)(7696005)(55016002)(110136005)(66946007)(52536014)(5660300002)(66476007)(66556008)(64756008)(66446008)(81156014)(81166006)(6506007)(2906002)(8676002)(76116006)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6382; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V+++OMjTTyiKP7rxMxgWNGsAew6q3U5GVKzMHOTWJp2xZVior8IINo+PKFH5zbwydJKgCRRyOJ1bxYw2W0zwg5FbxKCMMJSNjGmCVkYZPPNaC9V874+Zy5IL+MkIMnm2SOkVnAi1a5+YnonuelqOlboZMkZKpQu+TCbuRl+FPue6Qkfja+BDFFNlyunOy3lVbm9G9tGqhq81IAjV8/gjVG3CSgBkbnz7BBgmOMtVQvBbY/In/r/uMiUOMQwCTYahXbT4OFh57xb94bAl9x32CI55SIjBx7MhirvjNxMUnieOx/565WAd0HLbuo0wfbFhxaSngkR7ejcUxD65K+YyiGHVX8xMLeggYyegFCPOAiIrWz7tDUAzSe6hCU5WOAybN5lcivPJasXHdOB4fNWy0gC7mQqOvs3G0AKR94gELAHEcz96eaVBLmHbRWRKiq3g x-ms-exchange-antispam-messagedata: AzUL2IGU/PNfQ8DTfm0DR80oaWmJ9uqIPsY1DJI+U329G7yFI8FQmGLr7Nn7Dngp5rQh5ZgckCKE/hV9STd7uugMw6YyHU2nAJ6kR696FRl9iwrlGM/7TnI3hhMieWm1Jv7+6UzSHeOJ3gu10Kys0A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dedec8ab-bffc-42ee-2282-08d7a64c8493 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2020 12:53:06.7105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qzXO/+mqKMfgp86cppvqC/Yk36evBwzvaxKkpsGcyqNrY9IyFGjdSRzhXnSoH6H6W+Zn+NWEO6KkMa1/nu7urA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6382 Subject: Re: [dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > This series integrates SA database (SAD) capabilities from ipsec library. > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > Also patch series removes hardcoded limitation for maximum number of SA's > and SP's. > According to our measurements, after this series of patches, > ipsec-secgw performance drops by about 0-2%. >=20 > v5: > - introduce SAD cache to solve performance degradation > - ipsec_sad_add() returns an error if the key is present >=20 > v4: > - put tunnel SA's into SAD with SPI_ONLY type for performance reason >=20 > v3: > - parse SA and SP into sorted array instead of linked list >=20 > v2: > - get rid of maximum sp limitation >=20 > Vladimir Medvedkin (6): > ipsec: move ipsec sad name length into .h > examples/ipsec-secgw: implement inbound SAD > examples/ipsec-secgw: integrate inbound SAD > examples/ipsec-secgw: get rid of maximum sa limitation > examples/ipsec-secgw: get rid of maximum sp limitation > examples/ipsec-secgw: add SAD cache >=20 > examples/ipsec-secgw/Makefile | 1 + > examples/ipsec-secgw/ipsec-secgw.c | 34 +++++- > examples/ipsec-secgw/ipsec.h | 12 +- > examples/ipsec-secgw/meson.build | 2 +- > examples/ipsec-secgw/parser.c | 4 + > examples/ipsec-secgw/parser.h | 9 ++ > examples/ipsec-secgw/sa.c | 238 +++++++++++++++++++++----------= ------ > examples/ipsec-secgw/sad.c | 149 +++++++++++++++++++++++ > examples/ipsec-secgw/sad.h | 168 ++++++++++++++++++++++++++ > examples/ipsec-secgw/sp4.c | 114 +++++++++++++----- > examples/ipsec-secgw/sp6.c | 112 ++++++++++++----- > lib/librte_ipsec/ipsec_sad.c | 20 ++-- > lib/librte_ipsec/rte_ipsec_sad.h | 2 + > 13 files changed, 686 insertions(+), 179 deletions(-) > create mode 100644 examples/ipsec-secgw/sad.c > create mode 100644 examples/ipsec-secgw/sad.h >=20 Series Acked-by: Akhil Goyal Hi Anoob, Do you have any comments on this set. I do not see degradation on this patc= hset now. Regards, Akhil