DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"gavin.hu@arm.com" <gavin.hu@arm.com>,
	"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
	"juraj.linkes@pantheon.tech" <juraj.linkes@pantheon.tech>,
	"nd@arm.com" <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] test: fix ipsec unit test segfault
Date: Wed, 25 Mar 2020 19:03:57 +0000	[thread overview]
Message-ID: <VE1PR04MB6639ADD7D49B5088E7C6526CE6CE0@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB25586F457083B226D2C33C589AF00@SN6PR11MB2558.namprd11.prod.outlook.com>

> >
> > Segfault was observed when running ipsec unit test:
> >
> >  + TestCase [10] : test_ipsec_replay_inb_repeat_null_null_wrapper
> >                    succeeded
> >  + TestCase [11] : test_ipsec_replay_inb_inside_burst_null_null_wrapper
> >                    succeeded
> >  + TestCase [12] : test_ipsec_crypto_inb_burst_2sa_null_null_wrapper
> >                    succeeded
> >  + TestCase [13] : test_ipsec_crypto_inb_burst_2sa_4grp_null_null_wrapper
> >                    succeeded
> > Segmentation fault
> >
> > Data corruption happens due to incorrect destroy of session. Security
> > session needs process different from crypto session.
> >
> > Destroy corresponding sessions according to different security actions.
> >
> > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> 
> Good catch, thanks for the fix.
> As a nit caption should probably be: "test/ipsec: fix ..."

Fixed
Applied to dpdk-next-crypto

Thanks.
> 
> Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> > 2.17.1


      reply	other threads:[~2020-03-25 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  8:05 Ruifeng Wang
2020-03-23 12:21 ` Ananyev, Konstantin
2020-03-25 19:03   ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB6639ADD7D49B5088E7C6526CE6CE0@VE1PR04MB6639.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=ruifeng.wang@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).