From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 236FAA046B for ; Tue, 25 Jun 2019 14:51:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5A4021BA8F; Tue, 25 Jun 2019 14:51:37 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by dpdk.org (Postfix) with ESMTP id 4D7611B9DA for ; Tue, 25 Jun 2019 14:51:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=upgCYJz+V9nKu01UiYlxFMFZI+dFRQRNGeG7wab22hw=; b=TCMXvGVXMWsN/S8XrMratk2jjwj+Mg8qTwHqW9l48AU0+ccHq+pX9kC2KSW5ySAAvfWPVMImGniLDRZpfdJKTcC09xYu/q2BMFXurTjoDUhHP40gFpnVte0oNZnjpEFqk/TPX+kAUHE7ptCFLIgiCaq46xdqafnvzc4RD+zj9kI= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6495.eurprd04.prod.outlook.com (20.179.233.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Tue, 25 Jun 2019 12:51:34 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2008.014; Tue, 25 Jun 2019 12:51:34 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [PATCH v2] ipsec: support multi-segment packets Thread-Index: AQHVF0PVLktohJiGH02v2s0RI4OY+6akmsaggAAfwQCAB8AOgA== Date: Tue, 25 Jun 2019 12:51:33 +0000 Message-ID: References: <20190527182328.12143-1-konstantin.ananyev@intel.com> <20190531000006.13918-1-konstantin.ananyev@intel.com> <2601191342CEEE43887BDE71AB97725801689E2B8D@IRSMSX104.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801689E2B8D@IRSMSX104.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 12e53faf-7821-4404-e916-08d6f96bda77 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6495; x-ms-traffictypediagnostic: VE1PR04MB6495: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0079056367 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(396003)(376002)(346002)(39860400002)(189003)(199004)(26005)(81156014)(486006)(476003)(44832011)(76116006)(86362001)(8936002)(73956011)(9686003)(66066001)(68736007)(256004)(966005)(3846002)(110136005)(6116002)(14444005)(45080400002)(81166006)(52536014)(66446008)(64756008)(66556008)(6506007)(55016002)(102836004)(25786009)(8676002)(71190400001)(5660300002)(305945005)(66476007)(186003)(7736002)(66946007)(71200400001)(229853002)(33656002)(2501003)(7696005)(2906002)(316002)(6306002)(53936002)(6436002)(14454004)(6246003)(74316002)(11346002)(99286004)(446003)(478600001)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6495; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: qpogy7pfia8KnPn05yqJf1pxaeTSS7whQ9QyCwnolrPqsCNmEbFHX5tTChaIyC+ae/NRBiz0ZuowvkLCQYUIPMYf91KW2ENBAUC0Y2sxgO4jfejq1DT2f0bd2/F8QSFUpetVZ/ww1zXzYNxRAIktHvtzEwjcJLm4P9QgMR3RNp2qGp8Xwj1XYuWPZLZS6kAwEWMNub+6a46qTfWZMqmiKMLQSIAkOLc3a98G7J12SZjC43smKI7gYClX+18mJZsZwTBbwl8iP207/Lx0ky+K3HOryriupAqYU2ooLOrxTf8Be63tO8mt2ghmYKOdYpAxlAt8u9iuSUhsOzXKO/codWqon2IqoT6MjmX94gXJMa/C67E1Nptml8c5ELHwSd0oII3ZxbtmowR7JjuIPg7PFZPStHIOyOLgXRIixR0yjF0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12e53faf-7821-4404-e916-08d6f96bda77 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2019 12:51:33.9893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6495 Subject: Re: [dpdk-dev] [PATCH v2] ipsec: support multi-segment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > > Hi Konstantin, > > > > > > > > Add support for packets that consist of multiple segments. > > > Take into account that trailer bytes (padding, ESP tail, ICV) > > > can spawn across multiple segments. > > > > > > Signed-off-by: Konstantin Ananyev > > > --- > > > > Which all action types does this patch work well with? > > Will it work for lookaside none and inline crypto case both? >=20 > Yes, in theory it should work with any device that supports > in-place SGL. > On practice, right now I am not aware about inline-crypto devices > that can support such feature. > So far, tested with lookaside-none device. >=20 > > For the other 2, ipsec lib is not used. >=20 > In fact, ipsec lib can be used by all 4 cases I believe. > Though as I udenstand for lookaside-proto and inline-proto > nothing need to be added/changed inside the lib > (as HW supposed to deal with it transparently). >=20 > > > > Also how can the SG support be tested? >=20 > Here is a separate patch series that adds fragmentation/reassembly > support into ipsec-secgw and updates test-scripts with new test-cases: > https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatche= s.d > pdk.org%2Fcover%2F54491%2F&data=3D02%7C01%7Cakhil.goyal%40nxp.co > m%7Cf96f8b751ed04b046a6508d6f58bacc1%7C686ea1d3bc2b4c6fa92cd99c5c > 301635%7C0%7C0%7C636966377578333871&sdata=3DHnVDoMHuh255qzx5 > OWBsupGrqNS4m9eZyNeZ%2FxpBWHE%3D&reserved=3D0 >=20 > > > > > > > > v1 -> v2: > > > merge with latest mainline > > > fix build problem for RTE_BUILD_SHARED_LIB=3Dy > > > update programmer's guide > > > > > > doc/guides/prog_guide/ipsec_lib.rst | 1 - > > > lib/librte_ipsec/Makefile | 3 +- > > > lib/librte_ipsec/esp_inb.c | 148 +++++++++++++++++++++-----= -- > > > lib/librte_ipsec/misc.h | 61 ++++++++++++ > > > 4 files changed, 175 insertions(+), 38 deletions(-) > > > > > > diff --git a/doc/guides/prog_guide/ipsec_lib.rst > > > b/doc/guides/prog_guide/ipsec_lib.rst > > > index 6fc08886f..63b75b652 100644 > > > --- a/doc/guides/prog_guide/ipsec_lib.rst > > > +++ b/doc/guides/prog_guide/ipsec_lib.rst > > > @@ -162,7 +162,6 @@ Limitations > > > The following features are not properly supported in the current ver= sion: > > > > > > * ESP transport mode for IPv6 packets with extension headers. > > > -* Multi-segment packets. > > > * Updates of the fields in inner IP header for tunnel mode > > > (as described in RFC 4301, section 5.1.2). > > > * Hard/soft limit for SA lifetime (time interval/byte count). > > > diff --git a/lib/librte_ipsec/Makefile b/lib/librte_ipsec/Makefile > > > index e80926baa..22f29d98a 100644 > > > --- a/lib/librte_ipsec/Makefile > > > +++ b/lib/librte_ipsec/Makefile > > > @@ -9,7 +9,8 @@ LIB =3D librte_ipsec.a > > > CFLAGS +=3D -O3 > > > CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) > > > CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > > -LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_net -lrte_cryptodev -lrte_sec= urity > > > +LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_mbuf -lrte_net > > > +LDLIBS +=3D -lrte_cryptodev -lrte_security > > > > > > > I believe this build dependency should also be updated in meson.build f= ile as > well. >=20 > I found that unnecessary, meson seems to be able to figure out implicit > dependencies itself. > Though if you strongly insist, I can add them. > Konstantin Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.