From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoobj@marvell.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Sunila Sahu <ssahu@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
Narayana Prasad <pathreya@marvell.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
Shally Verma <shallyv@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 5/6] app/test: register octeontx2 PMD to asym testsuite
Date: Tue, 1 Oct 2019 14:13:58 +0000 [thread overview]
Message-ID: <VE1PR04MB6639B211CCFA8CAB8A854023E69D0@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1568042799-25982-6-git-send-email-anoobj@marvell.com>
>
> From: Sunila Sahu <ssahu@marvell.com>
>
> This patch updates asymmetric crypto unit-test application to
> validate asymmetric crypto operation supported by octeontx2 PMD.
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Signed-off-by: Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>
> Signed-off-by: Sunila Sahu <ssahu@marvell.com>
> ---
> app/test/test_cryptodev_asym.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
> index 241c384..edbd34e 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
> @@ -1851,6 +1851,21 @@ test_cryptodev_octeontx_asym(void)
> return unit_test_suite_runner(&cryptodev_octeontx_asym_testsuite);
> }
>
> +static int
> +test_cryptodev_octeontx2_asym(void)
> +{
> + gbl_driver_id = rte_cryptodev_driver_id_get(
> + RTE_STR(CRYPTODEV_NAME_OCTEONTX2_PMD));
> + if (gbl_driver_id == -1) {
> + RTE_LOG(ERR, USER1, "OCTEONTX2 PMD must be loaded.
> Check if "
> +
> "CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_CRYPTO is "
> + "enabled in config file to run this "
> + "testsuite.\n");
> + return TEST_FAILED;
> + }
> + return unit_test_suite_runner(&cryptodev_octeontx_asym_testsuite);
> +}
> +
> REGISTER_TEST_COMMAND(cryptodev_openssl_asym_autotest,
> test_cryptodev_openssl_asym);
>
> @@ -1858,3 +1873,6 @@
> REGISTER_TEST_COMMAND(cryptodev_qat_asym_autotest,
> test_cryptodev_qat_asym);
>
> REGISTER_TEST_COMMAND(cryptodev_octeontx_asym_autotest,
> test_cryptodev_octeontx_asym);
It looks a typo but it is intentional. Better to add a comment here and in the description
That you are reusing the octeontx test suite.
> +
> +REGISTER_TEST_COMMAND(cryptodev_octeontx2_asym_autotest,
> + test_cryptodev_octeontx2_asym);
> --
> 2.7.4
next prev parent reply other threads:[~2019-10-01 14:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:26 [dpdk-dev] [PATCH 0/6] add asymmetric support in crypto_octeontx2 PMD Anoob Joseph
2019-09-09 15:26 ` [dpdk-dev] [PATCH 1/6] crypto/octeontx2: add RSA and modexp asym capabilities Anoob Joseph
2019-09-09 15:26 ` [dpdk-dev] [PATCH 2/6] crypto/octeontx2: allocate memory for asymmetric operation Anoob Joseph
2019-09-09 15:26 ` [dpdk-dev] [PATCH 3/6] crypto/octeontx2: add asymmetric session operations Anoob Joseph
2019-09-09 15:26 ` [dpdk-dev] [PATCH 4/6] crypto/octeontx2: add asymmetric in enqueue/dequeue ops Anoob Joseph
2019-10-01 14:11 ` Akhil Goyal
2019-10-02 10:55 ` Anoob Joseph
2019-09-09 15:26 ` [dpdk-dev] [PATCH 5/6] app/test: register octeontx2 PMD to asym testsuite Anoob Joseph
2019-10-01 14:13 ` Akhil Goyal [this message]
2019-10-02 10:52 ` Anoob Joseph
2019-09-09 15:26 ` [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support Anoob Joseph
2019-09-10 4:13 ` Jerin Jacob Kollanukkaran
2019-09-10 6:12 ` Anoob Joseph
2019-09-10 6:30 ` Thomas Monjalon
2019-09-10 11:33 ` Anoob Joseph
2019-09-10 11:39 ` Akhil Goyal
2019-09-10 12:23 ` Anoob Joseph
2019-09-10 11:41 ` Thomas Monjalon
2019-09-09 16:25 ` [dpdk-dev] [PATCH 0/6] add asymmetric support in crypto_octeontx2 PMD Shally Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6639B211CCFA8CAB8A854023E69D0@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jerinj@marvell.com \
--cc=kkotamarthy@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).