From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 096CEA0352; Tue, 5 Nov 2019 09:01:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72B8534F3; Tue, 5 Nov 2019 09:01:50 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150070.outbound.protection.outlook.com [40.107.15.70]) by dpdk.org (Postfix) with ESMTP id F41422C15; Tue, 5 Nov 2019 09:01:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZM/HHsRRyRiOSYGXatJs2pU5SWMhR0dz5hVtR/IEM4vJtFfzywdRiYGGNNUn79N4kBxhYynEFPe2uNnaDZo4O/jFWuzB/gUvlRWTsQRjvhTdVTsQZ4jRDP+FR43gbeIm7AQ/QW3vw1yVU+bMR+iqsVH27oCWl90dqcqWUjJkFqlv0EegH8hoNWfWRign5ZZrTuzrnIN7v21j52YRUKY9hTZIPxreV5gbmm5AmW+aPochkW/QDVubzHlkh2RlnUS12aMUR8lBHgB+ibzD12pqpHv1CiEM7xylRje9zMNGd3NiWuP7OrZDt/at5/uryimSu4CVWzRUREBu5jChW70GAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YfGfz/0f6pbyMVpTN+Irg/KNqmYd2FeqL34ZT5g0c+M=; b=PcKgSeUqoEpk7D/v4u569yADUkmEtT0zKuvFKOKU+/Kz4v+ykitDraVxGd9bPzIPm02h3nozlKN9X23w1T8IyOtTnit/DKVlaC9KpgFfZWcNsy+Pq2wPXjZ7J0hq3p3AJaHvYCa5kRW5/ZJ6XI6sJ6l2rkq0dVK7xv4zLanEY/3/QHKtmhGrgZRtYH17KXjAd+mfV0Lr+4FVsS7/fZaAvWUfKAikHJXguT3Qxr+AO1FvSnUeStFfOlvsGLefvU/49UYb1rMXxA79wFoTz3wmzG/F3DOLdNwh2P3IM1ic7i/p3DLf+5d3o8d4t6bX1dsO3Emw93cubYnVCeZb/elT2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YfGfz/0f6pbyMVpTN+Irg/KNqmYd2FeqL34ZT5g0c+M=; b=CKhDdDEcMCu2Sd5dpYYUwYdoBqAhNqvZ0SAIwek51cWvl8lf609zW0iTkGxH0kwBW4PxxfNAVJJiOV1JJyDhWiGeq9bwgKmWU6S5WJW6Xb3O1TUtd+h+X7etDQDnLnpqWKKKyd3ecUpFLUSAWATim/6VfJ6NYAvrIgZK5vxDcPU= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6429.eurprd04.prod.outlook.com (20.179.232.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Tue, 5 Nov 2019 08:01:46 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561%6]) with mapi id 15.20.2408.024; Tue, 5 Nov 2019 08:01:46 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Iremonger, Bernard" , Thomas Monjalon CC: "dev@dpdk.org" , "anoobj@marvell.com" , "jerinj@marvell.com" , dpdk-techboard Thread-Topic: [PATCH v2 0/3] examples/ipsec-secgw: set default Thread-Index: AQHVeGtwa0h85gmQX0WS5PacJv4Ia6dVb/tggAAu0ACABbdw0IAAJRuAgABm+ICAFzYJAIADXz8QgATffwCAARYYsA== Date: Tue, 5 Nov 2019 08:01:46 +0000 Message-ID: References: <1567069173-10505-1-git-send-email-bernard.iremonger@intel.com> <1569943080-20228-1-git-send-email-bernard.iremonger@intel.com> <5630388.AILYuOXkcA@xps> <8CEF83825BEC744B83065625E567D7C260E0E213@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260E14C88@IRSMSX108.ger.corp.intel.com> <2601191342CEEE43887BDE71AB97725801A8C7F304@IRSMSX104.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801A8C7F304@IRSMSX104.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c5c2110b-89b6-4e80-9826-08d761c66771 x-ms-traffictypediagnostic: VE1PR04MB6429: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0212BDE3BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(39860400002)(346002)(376002)(396003)(53754006)(199004)(189003)(66476007)(316002)(66556008)(478600001)(7696005)(64756008)(66446008)(14454004)(76176011)(86362001)(8676002)(76116006)(5660300002)(4326008)(110136005)(2906002)(99286004)(25786009)(81166006)(6506007)(8936002)(81156014)(26005)(71200400001)(71190400001)(6246003)(55016002)(6116002)(66946007)(52536014)(11346002)(3846002)(54906003)(102836004)(446003)(476003)(229853002)(44832011)(6436002)(14444005)(33656002)(186003)(305945005)(7736002)(66066001)(74316002)(486006)(9686003)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6429; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LkgQvlgzpYI6aQc+6GxZku7MVt9fszBq0gPaSsubrbcWOcaa7Kv62+nweTGAtROkbDYANDpviYL94LeZwaRA3NHZ0+owHz1Z3n6cSHXWvZ8aNT2ls5XDWGgUSz8Dn59g9ZiWJ2Lc9HiWUM4+iP6V6+HbtMDNzB/UOZd5T1hJpRF2iVjEOmgBzPjonFnYD66h1swAUAu722VVZuTyMUILGWO+s5yDkC73AHPV6HM5sm4r9eW2qFVconNTvNtPtMTMQ1WIeYwmrXwojYevlt6rlcDdaTztGh1IcfuMhQp4NGky2dTr/vm76RsGlW1muPsAAcf7Ku3v0ONxvOz2GDGl5BnT+cM1JkTZO8kvU0MqQ9G35zQ5axkkHHWHQyM22MaU7ahrm0oNIWLtjZ3B7gmbylTuxb+a92yhNBm8xjebfyIKOc4qlZ0Zaejv6O2lpleg x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c2110b-89b6-4e80-9826-08d761c66771 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 08:01:46.1981 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sYmkWA204LOQnSH5mhTrkyknKLOsY94xhT+JTg4AejWeVlI/9dgiFkE29SMHKyPtODllG3XfaRPH+nD3GsNWyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6429 Subject: Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, >=20 > Hi Akhil, >=20 > > > > > > > > > > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > > > > > Hi All, > > > > > > > > > > > > > > > > This patchset would need ack from more vendors as it will i= mpact > > > > > > > > user > > > > > > > experience > > > > > > > > on a key example application which is normally demonstrated= to > > > > > > customers. > > > > > > > > > > > > > > > > IPSec library is still evolving and there are new functiona= lity > > > > > > > > added every > > > > > > > release. > > > > > > > > Atleast from NXP side we are not OK with this change. > > > > > > > > > > > > > > What can be changed in the library to make it acceptable as a > > > > > > > default in this example? > > > > > > > > > > > > > > > > > > > We are observing performance issues with ipsec library. So woul= d > > > > > > request other Vendors to confirm if they are OK with the perfor= mance > > > > numbers. > > > > > > > > > > Could you give some details on the performance issues you are see= ing. > > > > > > > > > > > > > We were observing about 4-5% drop when using the ipsec-lib instead = of > the > > > > Legacy code path. We would again measure it on RC1. That is why I s= ay, I > will > > > > Hold this patch till RC2, unless some other vendor also confirms th= at. > > > > > > Is there any update on performance measurements on 19.11-rc1 ? > > > > > The performance impact of this patch is huge ~10% w.r.t. 19.11-rc1 base= on > NXP hardware. > > > > We cannot merge this. Anoob also reported performance issues on Marvell > hardware. >=20 > Sure, 10% is a lot, so more than understandable. > Though, I think we do need to decide our future goals for it. > I see two main options here: > 1. Make lib code-path on par with legacy one in terms of performance, > deprecate and then remove legacy code-path. > Till that happen (deprecation/removal) to minimize code divergence, > forbid to add new features to legacy code path only. > New features should be added to both paths, or library code path. > Obviously that one looks like a preferred option to me, > but it requires some effort from all interested parties (Intel, NXP, Marv= ell, ...). > If everyone is ok with it, then I think it would be good to have some dra= ft > timeline here. > If you guys are not interested in this effort, then the only other approa= ch I can > think about: > 2. split ipsec-secgw app into 2 (one using librte_ipsec, second using raw= devices > (legacy one)). > We probably can still try to keep some code shared by 2 apps: > (configuration/initialization/session management (SAD, SPD)), > but actual packet processing path will be different. > I really don't like that option, but I think we need to come-up with clea= r decision, > one way or another. >=20 IMO, Option 1 is the only way forward. From NXP side, we can start our work= on this post 19.11 release and should target in 20.02 release. Regards, Akhil =20