From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoobj@marvell.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Narayana Prasad <pathreya@marvell.com>,
Ankur Dwivedi <adwivedi@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/octeontx: fix global variable multiple definitions
Date: Wed, 9 Oct 2019 09:49:57 +0000 [thread overview]
Message-ID: <VE1PR04MB6639C21832539224C06455B7E6950@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1570182275-361-1-git-send-email-anoobj@marvell.com>
>
> 'cpt_logtype' & 'otx_cryptodev_driver_id' global variables are defined
> in a header file which was causing multiple definitions of the
> variables. Fixed it by moving the required vars to the .c file and
> introducing a new macro so the CPT_LOG macros in common/cpt would use
> the associated PMD log var.
>
> Issue has been detected by '-fno-common' gcc flag.
>
> Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Applied to dpdk-next-crypto
Thanks.
prev parent reply other threads:[~2019-10-09 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 9:44 Anoob Joseph
2019-10-09 9:49 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB6639C21832539224C06455B7E6950@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=adwivedi@marvell.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).