From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 277EAA3160 for ; Wed, 9 Oct 2019 11:50:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 159EF1E544; Wed, 9 Oct 2019 11:50:01 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60043.outbound.protection.outlook.com [40.107.6.43]) by dpdk.org (Postfix) with ESMTP id 17D6F1E53D; Wed, 9 Oct 2019 11:50:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPPmq9ZrpVpqd2m/BWmOkJ9GaRw9dZ98Ux9P6vx6Z0prUo+cA5gM0vOpe3wsyp3Ws8Gcrp4+IugYDZ407qtpDY70ZIq0Kl925HyadKoGcXtV9fcGR12wofTtTE19/sEJnakTGemsAXgxC7qOZxTQoybWSHzOw1EhT79rYBPyOWT57aL/2Y4bisjuGXDSepVlUsL6TM4RXZ39jTzqi21DJO7ryEdQngmglIm729yy4b0iBFrd3XEUMseID2a34jej3WB+mu/bkLHMQgd3fdVKAjxW30yir33O6kP8ZrtH8oNHCWG222WajrVWwT8c/U2XaAiq6zSbKSjf0wRJHS9asw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/B2maiBdnQ07xYMXHVaotC7/JQ7CqqtdwS8e7qQr2Y=; b=Vfx5/NfJ3EWNhLj8fZDR2lEcwNIDlrLssn2eFUyy5Dx/ACwdIOH1bFe7lBU7pzi4vGfYBv5T0GOud/zxUQ/dsupMpWA4EaKdY/rTOYXqeTnQFTC0963NR9DmvhnPqunKxfvfXeB8FLKgOUiWr28vzPTiZc5qeSHALKO6XizbP9XMzS4NRR97+tHgjQ5g8IpL6WKpwRo09CohXsC5NsQXTRR64WW604NNY/MM/bPvAhdi2PdoS6NNGPAwhEGqROpaSg9bt9inrHHOVu2d/7WEZbATaN5Jy3h8LQC+s6gLnSChvpIL5f2uShJqev+QqKvm9vivwOYpJEoPOeykO2WFAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/B2maiBdnQ07xYMXHVaotC7/JQ7CqqtdwS8e7qQr2Y=; b=bgOKG5UELEc6XjR73hP0334Vdfwzl5alC25RR2PMyYIxlrxxnlVQmVOUoiBziSK9el8IFkhEb/dO1ddEX19hGlwxrSCuNfKHEi/XZYlwONuzUYvHIEuznWrOsq6s2/QSGRZinzqmDdV02qEQ1mEq2Wva9JyRr1dQCdlrcbdUrAY= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6384.eurprd04.prod.outlook.com (20.179.235.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Wed, 9 Oct 2019 09:49:58 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2327.026; Wed, 9 Oct 2019 09:49:58 +0000 From: Akhil Goyal To: Anoob Joseph , Pablo de Lara CC: Jerin Jacob , Narayana Prasad , Ankur Dwivedi , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] crypto/octeontx: fix global variable multiple definitions Thread-Index: AQHVephhGN/J3s2AEUG3uhuW9ctIBKdSGILg Date: Wed, 9 Oct 2019 09:49:57 +0000 Message-ID: References: <1570182275-361-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1570182275-361-1-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcd29534-c1be-461e-3d73-08d74c9e0ba5 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6384: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 018577E36E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(189003)(199004)(486006)(5660300002)(6246003)(76176011)(4744005)(11346002)(25786009)(54906003)(102836004)(316002)(4326008)(110136005)(7696005)(7736002)(446003)(55016002)(33656002)(9686003)(74316002)(26005)(71200400001)(256004)(186003)(71190400001)(44832011)(6506007)(52536014)(305945005)(99286004)(81166006)(81156014)(229853002)(2906002)(86362001)(8676002)(6436002)(76116006)(14454004)(66066001)(3846002)(66946007)(6116002)(478600001)(64756008)(66446008)(8936002)(476003)(66476007)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6384; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1tIMVCInogdlO8Wx+seT/whnUyUwEi9fw3ADVp3td9n34MQzZzjqvBi6FWc7R5xmT7PyWssUWTP+iT9KvtAQI13drCtGUmfjd7fWGwh+kiVP/zuZ6Olw73RhZn1fiIM5dP3P/rz4qI/t3btBPN+vcsBLw8fsFNxBelalUQ2KP7M4Axd9acLQJLBRTVV+YNs+X6bwcZPzn9wNt23RztuiSZ9mFqHEDfm7WFSu7bGQEIpHTAq1uUo+R2nGQjrNgJIrG8/jmDLcogwnL6VFWhesLO3gSL8AwJp3iggzbogZvCBDOOYnWWyAo8sXtWDpgNCtFbiWYZzkXAjqpho2a7bMIpT6qI4x1ShsNYW9j+cpShLqQN9cNRY5WIpG1uI+gvzTomq7CbpY0lGVlsfD/EGPR6FhWgjwxoT5tRfv1Pr/+Ys= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcd29534-c1be-461e-3d73-08d74c9e0ba5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2019 09:49:57.8557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kOORwMKVsQ9JfJwL2OgO+cya0jRVJS3gZs+1mfRO6EpugE/5ZRUUG/UGRpRb4T/s9I4nletVRgEbKYSnx0ZGqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384 Subject: Re: [dpdk-dev] [PATCH] crypto/octeontx: fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 'cpt_logtype' & 'otx_cryptodev_driver_id' global variables are defined > in a header file which was causing multiple definitions of the > variables. Fixed it by moving the required vars to the .c file and > introducing a new macro so the CPT_LOG macros in common/cpt would use > the associated PMD log var. >=20 > Issue has been detected by '-fno-common' gcc flag. >=20 > Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") > Cc: stable@dpdk.org >=20 > Signed-off-by: Anoob Joseph > Reported-by: Ferruh Yigit > --- Applied to dpdk-next-crypto Thanks.