From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAC65A046B for ; Fri, 26 Jul 2019 16:00:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F06B1C42C; Fri, 26 Jul 2019 16:00:11 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10065.outbound.protection.outlook.com [40.107.1.65]) by dpdk.org (Postfix) with ESMTP id E581A1C422 for ; Fri, 26 Jul 2019 16:00:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/9HDTvmcbGHe+aJ62PYEZPVD2LzzPSQRQ3YfdG6gitRvIVt702aBH45SGOuPYGJtnwc4G1eO3BXRnDPQYrmVCOSuZqQy3l5CKkG7IANgU2AlVtDqhIPcG7EKwTWy5z9LqNrRw8ZksXEA7blDf8CmdC1dt317XKdRNx+yQ3y8V+qnl3xBZ9+7j8gMjocrJZxdBCz55/UC9jVx/sfB4HKKA8pDXshBP+iY5QNoOLHR0ttig7m0bwJ2dEbL4tZNTw6BI/40HpzLCgzZhy0w2NdRFIlWceVruo7SsTRnHyXFVvNtbKfhLJSsO+FgDYxnx38B4vri964ubHv4mz/ksD+PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y3mslsoUmjzXDP1yYKsEJnFZ8tESxgi2rk+Al0cjLLg=; b=W2B02//wZ5sTdHvk7Ahco80R8urrVqv2WjDCp7glFudQ957pV8l3JzUOokcwewpc5b8HOLFLsAz+C12wStq66cI1O82lQveECQyHCFUdx/2/iflgyVXFfm4RLt4o51WY5cdJ49rY6cn3M8UOYBT5o3e8wGqPjvF0qAqM5rm1Z/KqNjVm29e4/UB7H4jbAIKNIGhx3Cf4zH4gR7SveFfaoq6j4Tqm5Az1+q1HwRkb0gWFU/6mTlC1ZEbaIaJSx2Mvr2ijDkqKyo4FlmQuQfcSD1ciNj1ziZw5HRprxG/Wb0JJLN5ki8gu9mbdzdcpge3LbvqNuOadeR63J3pjLt3xlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=nxp.com;dmarc=pass action=none header.from=nxp.com;dkim=pass header.d=nxp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y3mslsoUmjzXDP1yYKsEJnFZ8tESxgi2rk+Al0cjLLg=; b=FixktBktvejEsE2WqJEk8P3hPWfk4ENV+WEaMd7pwptBa8tckskLznV/NZXh8ZtF1q1psNYwlo1O14GlO9pn7spYdpE32eTo5ctvvh/duKEpgGiRXIRzmiX7s5GpkvmEPRY9iLts+JnlrgKfn18qdJXlMA4+ThblfcaYKn0PNUQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6525.eurprd04.prod.outlook.com (20.179.233.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Fri, 26 Jul 2019 14:00:08 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::964:4ddc:346b:e2ec%7]) with mapi id 15.20.2115.005; Fri, 26 Jul 2019 14:00:08 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "Dybkowski, AdamX" , "dev@dpdk.org" Thread-Topic: [PATCH] app/compress-perf: prevent output buffer overflow Thread-Index: AQHVQT5BtgKITZ9ypEuIQDHyw+xqoabc4EYAgAASAQA= Date: Fri, 26 Jul 2019 14:00:08 +0000 Message-ID: References: <20190723095328.23236-1-adamx.dybkowski@intel.com> <348A99DA5F5B7549AA880327E580B435897D1C1A@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435897D1C1A@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.0.6] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e49e1440-3c80-4459-78bb-08d711d191a9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6525; x-ms-traffictypediagnostic: VE1PR04MB6525: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01106E96F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(199004)(189003)(6506007)(9686003)(26005)(55016002)(316002)(81156014)(2501003)(8936002)(81166006)(53936002)(68736007)(74316002)(305945005)(66556008)(64756008)(256004)(14444005)(102836004)(7736002)(3846002)(52536014)(6116002)(229853002)(66476007)(11346002)(66446008)(76116006)(8676002)(186003)(5660300002)(4744005)(66946007)(478600001)(486006)(446003)(86362001)(110136005)(33656002)(7696005)(25786009)(76176011)(6436002)(44832011)(2906002)(66066001)(6246003)(14454004)(99286004)(71200400001)(71190400001)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6525; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dbdHlihX6nnAkxRfCHl0p0sjII0UpRUlL5QnDG9bROc9D4uGIKU8tEcddKESLzU8PCN/vmySncCCbpMU6t8WayP+rztSl6lI1F3LLrYIJT8gEoQhmAzmiyt7Fbbf42PM3I+xUH0n1GwGsKci3NNdHexn4LjtwPjmcORHf8S50RW5MYFaWz4JnX2DAet3jBOsfvAuBfdubH4iQDRbuGr7BTJ7xY0GHJfvTaP6mRn+Iri3F5GUiqMyFK4nhqlPpt1ALMVSvOAQpjfLOi1W926Zw33Iqs0uo0M1ezW+lY1T7MeY9Xr91kzktd24aR3RFS5pMv1PX1HNckmJvKhMfdGdobQu72wlUSJDfH0A/TrkZbiU0KmLVpWKauvJFf1SiBh6dnCjvbGy1nwbavHmwHA2IXDuy4xrAT5BudQ2OlvVI3M= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e49e1440-3c80-4459-78bb-08d711d191a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 14:00:08.4655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6525 Subject: Re: [dpdk-dev] [PATCH] app/compress-perf: prevent output buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > This patch fixes the issue of memory overwrite after the end of > > the output buffer by calculating its size as the number of all > > segments multipled by the output segment size. > > Additionally buffer overflow errors returned by PMD driver are > > detected and shown, ending the test. > > > > Also the output buffer size multiplier was increased from 105% > > to 110% to allow running the tests on noncompressible files that > > expand to over 107% of original size during the compression. > > > > The changes were made in the verification part of the flow and > > they don't affect the benchmark results. > > > > Fixes: 424dd6c8c1 ("app/compress-perf: add weak functions for multicore > test") > > > > Signed-off-by: Adam Dybkowski > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.