DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Marcin Smoczynski <marcinx.smoczynski@intel.com>,
	"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"fiona.trahe@intel.com" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix gcm iv length
Date: Tue, 5 Nov 2019 23:00:50 +0000	[thread overview]
Message-ID: <VE1PR04MB6639DDB9AE0FE84FC1BCFFFDE67E0@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191031140445.4564-1-marcinx.smoczynski@intel.com>



> 
> The example IPsec application does not work properly when using
> AES-GCM with crypto_openssl.
> 
> ESP with AES-GCM uses standard 96bit long algorithm IV ([1]) which
> later concatenated with be32(1) forms a J0 block. GCM specification
> ([2], chapter 7.1) states that when length of IV is different than
> 96b, in order to format a J0 block, GHASH function must be used.
> 
> According to specification ([2], chapter 5.1.1) GCM implementations
> should support standard 96bit IVs, other lengths are optional. Every
> DPDK cryptodev supports 96bit IV and few of them supports 128bit
> IV as well (openssl, mrvl, ccp). When passing iv::length=16 to a
> cryptodev which does support standard IVs only (e.g. qat) it
> implicitly uses starting 96 bits. On the other hand, openssl follows
> specification and uses GHASH to compute J0 for that case which results
> in different than expected J0 values used for encryption/decryption.
> 
> Fix an inability to use AES-GCM with crypto_openssl by changing IV
> length to the standard value of 12.
> 
> [1] RFC4106, section "4. Nonce format" and "3.1. Initialization Vector"
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftools.ietf
> .org%2Fhtml%2Frfc4106&amp;data=02%7C01%7Cakhil.goyal%40nxp.com%7Cd
> 24096cff31845d1619e08d75e0babaa%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C637081276526121698&amp;sdata=DInvN3miogcG9WqkuRlUQ%
> 2BzuqMRs2P63CJA%2BojPx6vU%3D&amp;reserved=0
> [2] NIST SP800-38D
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcsrc.nist.
> gov%2Fpublications%2Fdetail%2Fsp%2F800-
> 38d%2Ffinal&amp;data=02%7C01%7Cakhil.goyal%40nxp.com%7Cd24096cff318
> 45d1619e08d75e0babaa%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C637081276526121698&amp;sdata=EU6tJ9qvzpzh1b8j%2BsPjc18E3CUrXkSZ7c
> O6xvOmv1U%3D&amp;reserved=0
> 
> Fixes: 0fbd75a99f ("cryptodev: move IV parameters to session")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto

Thanks.


      reply	other threads:[~2019-11-05 23:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 14:04 Marcin Smoczynski
2019-11-05 23:00 ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB6639DDB9AE0FE84FC1BCFFFDE67E0@VE1PR04MB6639.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=marcinx.smoczynski@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).