From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F404A328D for ; Tue, 22 Oct 2019 14:08:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BA0B1BEC3; Tue, 22 Oct 2019 14:08:27 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70077.outbound.protection.outlook.com [40.107.7.77]) by dpdk.org (Postfix) with ESMTP id 4CE3F1BEB3 for ; Tue, 22 Oct 2019 14:08:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y3zot9x41Zi2pzfmBfRk8EhuD6wzRVV77OHvSGTtt3tPvY+KVWoAVQogaerW1bhbbZMz8b0ki4iCiRpA36sYXeufz0DtuBSc+scWl3p9HA2PoWL5sm59Mr5gUs7VKaOCw1JYtuvxUm1t5o8O9/C6b8TotFuUy2+DV+7WJexgBj0Mrr/SQZ8sv8WXqFco5sg3cHue1mnJ8CHlFlZqopt3LVGiHSlQMxPG9F202FH+poeOXYvjiEeLmClL7qF33DILhEvKdvk9gGS4a43r1DGAT25zW5y31QHRxh1jUhVP7iby5OFaG6ejxzIYsYusMbn9FF0Q9XV7Y7eKeNPVBa0M3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dh8D94+huVmZjSiOv8xtM3bAqJch9FezCfytlaeKe8c=; b=Y72S2uBx0+4tZbkWlTCkYYjpiTjpURpS0U4YSjG1BcwvDW0o3/mO9yOCcVCgV9rkpfMROdsw5BLAA5d9Ee6u+Y0RIqXnF1PIPmUyCtLtSxhUCzh2uMs77iFW8tMUkVuZtIVkjO4AJ32WaILmbeM4xU3Y0NSsBUHAsCpaEGCg4IbGJxkC8ZFRn4mLrVHaxvEbzKCl435uq0ymeQCy6wd2gMuzyjWQ77n6UQZTCMNOl9XzXrYb0Z4kr+Upj5J1iNXqQnKdlldpU41WGQhtWTXO2RfkUSV5dFhZWatpMEltsjAsb8widIZe1JyRWYKw1I603LZyB3oP8hs43H4sjcP7Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dh8D94+huVmZjSiOv8xtM3bAqJch9FezCfytlaeKe8c=; b=W1tYMolNEWLMGWXDRrz2xl+fZ/SM9y/C4/duS2fvPBWKQDmYlcLNagC2y2a5K5UJjBYiEZu5MkB46G6K4qdUfaDD7geRIM0XOXu0RvFYsB/cDCGLWwb3oEVzksWGKwQUAc6rHhRJja/zf4qX0B+TU0Oh8UKG6dNfKT95A3yamo8= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6608.eurprd04.prod.outlook.com (20.179.235.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2367.20; Tue, 22 Oct 2019 12:08:24 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561%6]) with mapi id 15.20.2367.022; Tue, 22 Oct 2019 12:08:23 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "dev@dpdk.org" CC: "Kusztal, ArkadiuszX" , "Dybkowski, AdamX" Thread-Topic: [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases Thread-Index: AQHViMy2P6rriDFipkOHIvzS90RmUadmiuywgAAEJwCAAAGpgA== Date: Tue, 22 Oct 2019 12:08:21 +0000 Message-ID: References: <1571744076-7623-1-git-send-email-fiona.trahe@intel.com> <348A99DA5F5B7549AA880327E580B435A217B6E0@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435A217B6E0@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b30f175c-c6e4-4a76-aaf1-08d756e889b6 x-ms-traffictypediagnostic: VE1PR04MB6608: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01986AE76B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(18543002)(199004)(189003)(6506007)(229853002)(71200400001)(99286004)(8936002)(81166006)(81156014)(71190400001)(14444005)(256004)(14454004)(102836004)(478600001)(55016002)(9686003)(486006)(8676002)(2501003)(33656002)(52536014)(26005)(3846002)(476003)(66066001)(4326008)(54906003)(110136005)(86362001)(5660300002)(76176011)(64756008)(186003)(305945005)(6246003)(44832011)(6116002)(25786009)(66946007)(446003)(7736002)(6436002)(76116006)(66476007)(66556008)(7696005)(66446008)(316002)(2906002)(11346002)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6608; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EDomALsiOMkJ7opvZySl8AkjzevIeR3k0mv2hDPTFb3iGRL7X/0QNDzwU2AcNVSQqHKvSRLKbiv/gB4NTAwbq6ErX1f69s6M9pIXvd6crX3ji7s7LqU0YjBrv8GRM9Nnc4LYpRtHIh8wn6WpLjLUqEJbcQdo7caA4b/WSt9oDd2oXPOtUZX1AxKeSEXeWsCd7RXiw6YGNdi8qMGIak0drqPJuZ9+cIp/CeI+7gobaMx7WHykYDUtkDQxakPTeh4A4or2sSLU040W+CwA1Gva6S2pYDtBqCflXpatN+j8gWgCxzyZlM4E5HfjZ6e88M95qpESbpwjMuh2TE+55NfM4IfXBtw6kw2btwt3MzUpLFoD1I4if2HvV3e74yQOSu/b56+T91IDFxu9WPbWBIRH7k8S1a6Ke+Pdpnt6sSUqu5/g5h0ti6ca/0laywSA5U7V x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b30f175c-c6e4-4a76-aaf1-08d756e889b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2019 12:08:23.6827 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: amrV7sk7njGjmE9eHeAZNazsxHjwB/X8bEDnTocdYDfwfAXJrRsqK2iD3pRez17sVtkm7aEuwwrfOrkafONFAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6608 Subject: Re: [dpdk-dev] [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, >=20 > > > > Hi Fiona, > > > > > > > > Clarify constraints on fields specified in bits for wireless > > > algorithms in digest-encrypted case. > > > > > > Signed-off-by: Fiona Trahe > > > --- > > > lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++++ > > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > > b/lib/librte_cryptodev/rte_crypto_sym.h > > > index bc8da24..0204d37 100644 > > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > > @@ -703,6 +703,13 @@ struct rte_crypto_sym_op { > > > * auth.data.length and is typically > > > * equal to auth.data.offset + > > > * auth.data.length + digest_length. > > > + * - for wireless algorithms, i.e. > > > + * SNOW 3G, KASUMI and ZUC, as the > > > + * cipher.data.length, > > > + * cipher.data.offset, > > > + * auth.data.length and > > > + * auth.data.offset are in bits, they > > > + * must be 8-bit multiples. > > > > What is the meaning of 'they' here? > > cipher.data.length, cipher.data.offset, auth.data.length and auth.data.= offset > are in bits > > and may or may not be multiple of 8bits. This is documented in their co= mments. > > > [Fiona] This added note is an extra bullet under the explanation for Dige= st- > encrypted cases. > In these cases only those fields listed MUST be 8-bit multiples. > Can you suggest a change that would make that clearer? @@ -590,7 +590,9 @@ struct rte_crypto_sym_op { * For SNOW 3G @ RTE_CRYPTO_CIPHER= _SNOW3G_UEA2, * KASUMI @ RTE_CRYPTO_CIPHER_KASU= MI_F8 * and ZUC @ RTE_CRYPTO_CIPHER_ZUC= _EEA3, - * this field should be in bits. + * this field should be in bits an= d must be + * 8-bit multiples in cases of enc= rypted + * digest. */ Same change may be done in other 3 fields. >=20 >=20 > > > > > * > > > * Note, that for security reasons, it > > > * is PMDs' responsibility to not > > > -- > > > 1.7.0.7