From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99E5AA00E6 for ; Fri, 12 Jul 2019 08:31:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 532B8322C; Fri, 12 Jul 2019 08:31:07 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10041.outbound.protection.outlook.com [40.107.1.41]) by dpdk.org (Postfix) with ESMTP id 8F4142F42 for ; Fri, 12 Jul 2019 08:31:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93Y3sRmjuwrlh9dmam/Dv/7CBzTJhI2W2vQ8tL61VzQ=; b=RGjm1tBiMWttFtcEhs2Rgtu9l0ST+CKOfAcq29ULwreT50SSUCMPwDWgWGJQE4o6rDoyt34bDH34rYAGFlNTkBlkQDPYaXZ4fzCzHMeh0+fNnyoJoONH9rBRzzAH/5dq19RjlSBSN1CbZ8dahM7ubdt1LDnKV3n0SAdthwFriH4= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6477.eurprd04.prod.outlook.com (20.179.233.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Fri, 12 Jul 2019 06:31:03 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2052.019; Fri, 12 Jul 2019 06:31:03 +0000 From: Akhil Goyal To: Thomas Monjalon , Liron Himi , Fan Zhang CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam Thread-Index: AQHVMzTmuqaz8H3LFEiX8ZaVHS6sdaa8BNyggAKh5oCAAeH8AIAAUskAgAW0qOA= Date: Fri, 12 Jul 2019 06:31:03 +0000 Message-ID: References: <20190705132349.7245-1-roy.fan.zhang@intel.com> <4113530.0QG5j2eBUe@xps> <18406135.oEg8MpVtrz@xps> In-Reply-To: <18406135.oEg8MpVtrz@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9a411c3-ffff-4283-147d-08d706928377 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6477; x-ms-traffictypediagnostic: VE1PR04MB6477: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 00963989E5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(199004)(189003)(66446008)(64756008)(478600001)(6246003)(71190400001)(76176011)(5660300002)(6506007)(4744005)(7696005)(71200400001)(110136005)(102836004)(9686003)(229853002)(74316002)(55016002)(7736002)(68736007)(305945005)(486006)(33656002)(6116002)(3846002)(316002)(66946007)(186003)(4326008)(76116006)(66556008)(66476007)(6436002)(8676002)(14454004)(66066001)(446003)(11346002)(81156014)(256004)(86362001)(2906002)(52536014)(99286004)(8936002)(44832011)(26005)(81166006)(25786009)(476003)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6477; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 1Vsm2Jjne+sW9iinDAh407YcScV5wB0MZVGAdpKukA1/u8ZpaPkQYDkA8E0VnPmtpYaaVRqfJawRKa5aPZFJzvYrMMPE2Kw9TQzYLqJQeyV0lmA3pIzot1XVscEUUrLbLqYQoVLPHqOZ0Ax47/bXA6c0s6mKa5B54NfW6EMmAfKe+AEXyuKVwO67/WpbSSVR5McAkgVsLt1JBFcQMOQeppLQNzyNaVJ9JC2xCg8R64I4diqlggW/fJ3iNZoKX+l3xRRL2tRO5goaK2bymlPJ4qnFpUNitU1F3NgKzC0lHtV0kY3s5V6sEUtBPtzirB9TNDCG1iWaQaf3lA/wgpa47KncPcQBBTwZ7+YqSxdG9LE/VeRWsJVpZ/0SlXUYfPxnfPN+TcJoB0IliQFsFbVLCFrD8fQrGozRVjr5LlPTrEo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9a411c3-ffff-4283-147d-08d706928377 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2019 06:31:03.6345 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6477 Subject: Re: [dpdk-dev] [PATCH] crypto/mvsam: fix missed code change for mvsam X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, >=20 > 08/07/2019 12:26, Thomas Monjalon: > > 07/07/2019 07:41, Liron Himi: > > > From: Akhil Goyal > > > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform = key > > > > data type change for mvsam driver. > > > > > > > > Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant") > > > > > > > > Signed-off-by: Fan Zhang > > > > --- > > > Based on Fan's comments > > > > > > acked-by: Liron Himi > > > > So we are OK to merge this patch with > > "cryptodev: make xform key pointer constant" > > in next-crypto tree? >=20 > There is still a compilation error: >=20 > drivers/crypto/mvsam/rte_mrvl_pmd.c:267:41: error: > incompatible type for argument 2 of 'memcpy' > memcpy(cipher_key, cipher_xform->cipher.key, > ~~~~~~~~~~~~~~~~~~~~^~~~ >=20 > Seen when compiling arm64-thunderx-linux-gcc >=20 Could you send a proper fix to this issue. Thanks, Akhil