From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B14FA2EFC for ; Tue, 15 Oct 2019 15:42:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B86931EBD5; Tue, 15 Oct 2019 15:42:03 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130045.outbound.protection.outlook.com [40.107.13.45]) by dpdk.org (Postfix) with ESMTP id AEE3B1EBCD for ; Tue, 15 Oct 2019 15:42:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJE3G1RnzE8oYsdBo3lkywyp/CoAMzumcrrj1hlNeooLXei+O/bYLr9gPG2KfSn32srQtoClzwJ81AaWipzl6bjHPLStYcID8d43nre/aAYAMs9K98gWp93n6Cd0E0MY1sT/AfjAJmAWNgyYHUWEx0RxvmX7o/hza0JPIMado9O17XBiQqo5gKEEpqoHH80ZDn17f+1pBgBh7AjPKokpiTCgfrbwteZxLHm9Q8xK9M3SSuVbrKMIsdK0zbjChYfr4tHP6LD8TX8UfOTBCPl3HpN5uMY/lEh2PRzP3v/1/Vv7PMR4HM60hl3PMy0XHIYKWSGFCFvTXLALqhEVARPY/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOn1BNMEHLEKBRrrWoWqwwdMvXu8hUk7m5QSGY7PG9k=; b=VyO7EaFV6DdHK3kgEjjlC4KctySIOIW8ifhj43qgNUBdilTqYEametamOhrsV/V/gfYQV//km24+LbLkkz87MXqiEmmhbuciUsSGfG6/CWHD/dPOrvEAUGnj5VON2Jh+Ce0NLduiteIGfNZZrx1HdtOlGxJtBMX1ExBv0xoEMxOdOqpYstqg+VB1axGBo4whXaYvFNGOCfNIlAGHqTc7/E+qnzPhM2r0rUj6TU8FdjhvY+dl497ifXmXLJbyVgPTW4TklIreyGZPg82r9OrbxEAMRkD1pq9qypyoUCYRNIPvE0BiWHrgJTCMD70vB8uOGyOS6EUFrJgtT+ZHFZpnZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOn1BNMEHLEKBRrrWoWqwwdMvXu8hUk7m5QSGY7PG9k=; b=pPHxuOCJDNXvo1gbVQGzS+eLvQIpIkXsZXb5pDndUHlhV0XnNKFxWA9yGmAErcVTUSrnXJsi4CUkur6hk0xPZR06bW2MT4BU/7zmL985MilJ+oiY2foqswj2qhoWyEBJlQ/oXBrqZfPlXxQIh1A2ir4sSFK01N9ez7vfAlzvyPQ= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6480.eurprd04.prod.outlook.com (20.179.233.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Tue, 15 Oct 2019 13:42:01 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2347.023; Tue, 15 Oct 2019 13:42:01 +0000 From: Akhil Goyal To: "fiona.trahe@intel.com" CC: "arkadiuszx.kusztal@intel.com" , Damian Nowak , "dev@dpdk.org" Thread-Topic: [PATCH] crypto/qat: fix null auth issues when using vfio_pci Thread-Index: AQHVTpUViaLhXmdIHEO155J/e3Jf46dcH1DA Date: Tue, 15 Oct 2019 13:42:01 +0000 Message-ID: References: <20190809092901.17788-1-damianx.nowak@intel.com> In-Reply-To: <20190809092901.17788-1-damianx.nowak@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1ec275f-b3db-4b98-a41b-08d751757554 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6480: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 01917B1794 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(189003)(199004)(13464003)(478600001)(2501003)(71190400001)(71200400001)(2351001)(14454004)(2906002)(66066001)(33656002)(6116002)(8936002)(3846002)(25786009)(7736002)(229853002)(44832011)(486006)(66476007)(66556008)(64756008)(66446008)(11346002)(446003)(476003)(54906003)(9686003)(55016002)(6916009)(6246003)(86362001)(5640700003)(6436002)(76176011)(99286004)(7696005)(66946007)(316002)(81156014)(81166006)(8676002)(256004)(14444005)(305945005)(186003)(26005)(52536014)(74316002)(5660300002)(53546011)(76116006)(4326008)(6506007)(102836004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6480; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QW94hFCv9YPPXpH+pAFsif2/yl4WtR+sNTxU17ATlYFu4oZESZWFzzwkM/V6HKcPQ4dYRljd1C3PWahp1YKl2+orkg2Yb3/0ZataM9WeVhOaxpPagFyO3KK5t7qqa48t7rXrqXBciC8bnDOq/o4h8/jcP+fV+75K71UPrFae3Q+vB2trJMdsDEVnt4Nex4P+l3MRGf8MgCazFINs/URfAq4h5ygmuT1O1//kcBx1Oic6I5t5p/YFepgxVhw3tgyPKNeuHwDcumroevl42hvjGjlbpcOTtmFTWRZ0jfZgKqyPrhV7cbQUZB0c3Sv80GOu3vsZLJ6OKYYpY6DXffKvwaWbNOmYQ8GSkGzgNOJpxHY3uqKRI/gEZ82BVc/sm3pgmk7/DXrHJQMkVBE3SosAaw1ad1Q3PFYUKuUGBTqcmdc= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1ec275f-b3db-4b98-a41b-08d751757554 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2019 13:42:01.6340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X2AW+HuP9NSvVM6cB/YuweAQgm7zFwZomhKtYNMbpu3AIy0sSQr4O5I4xW7iz258IMsT+B3DH4cZpqRoy+BdEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480 Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fiona, Could you please Ack the following change. Thanks, Akhil > -----Original Message----- > From: Damian Nowak > Sent: Friday, August 9, 2019 2:59 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; fiona.trahe@intel.com; > arkadiuszx.kusztal@intel.com; Damian Nowak > Subject: [PATCH] crypto/qat: fix null auth issues when using vfio_pci >=20 > When running auth NULL cases while using > vfio_pci, DMAR read/write faults appear. It > happens even if digest_length is set to 0. > This is caused by auth_res_addr initialized > as 0x0. >=20 > Fixes: 4e0955bddb08 > Cc: Fiona Trahe >=20 > Signed-off-by: Damian Nowak > --- > drivers/crypto/qat/qat_sym.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c > index 46ef27a..6aa514c 100644 > --- a/drivers/crypto/qat/qat_sym.c > +++ b/drivers/crypto/qat/qat_sym.c > @@ -307,9 +307,8 @@ qat_sym_build_request(void *in_op, uint8_t *out_msg, > } > min_ofs =3D auth_ofs; >=20 > - if (likely(ctx->qat_hash_alg !=3D > ICP_QAT_HW_AUTH_ALGO_NULL)) > - auth_param->auth_res_addr =3D > - op->sym->auth.digest.phys_addr; > + auth_param->auth_res_addr =3D > + op->sym->auth.digest.phys_addr; >=20 > } >=20 > -- > 2.7.4