From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 366DBA04B4; Fri, 8 Nov 2019 14:16:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF76B1C1A4; Fri, 8 Nov 2019 14:16:28 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150071.outbound.protection.outlook.com [40.107.15.71]) by dpdk.org (Postfix) with ESMTP id 46C811C0B7; Fri, 8 Nov 2019 14:16:27 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZYlcIgZ5inF8sfboR+g36OpGFjXZ6uxjRRf9qukb/vGewRCZlnd9XYahH2npOZnrnX5BjXxk4ZEsQHuN8vp97hSFBMl85j4f1qi1RLFVtGBP/GSAoTcdFfugBYGggB6VcRp67wWdQZEn3rC63aZ8mK8G2+R5JH21/KVv1xCOMzpYjMHQgAX5EPCsmHVajC/2kzxJDVPY5sRyi5tu9F1ct4tHcahRv97l77RdoPqOxzEoEiINBFyBT5K57Hi+klcpO2Bh2JxyarxylrfIrF7Ywp/xdTsbh6Imv0SR5gzqELnLKk/yUyzjIIPje3nf8ziEK0P/DKnNscgOGpLvU6GlSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Rs4rNM1OZtGcXhVm5YEL0w0OCdDJby4ZSQNeei8f+k=; b=PDOrI7VzwewTm6KCd0lzJTDws/sVtR5tSxCGbTj0G+vlC4MS8nXrl/6MDDnHVZNmgR/VTfRxMwG6Z1udiGrpl5eF+QkAT9BS/oPkoHT7e0JryyhorxjamYwDUrVc1g39usze1PL2YvXeRQ+zxolagUXhHKDN3LYkwTYRMvQ+SjaJMYoGQxWX3jJqRbMX58G2HQkcV2zHsFOMbHSBvrYJIVjIK6BUi7AJL+yC88k18UmZL+t5Z0UUM3osE3UxVAe/4gIZIoiaEdCUSFFQzzfxEdSlK6zUyGGmGtLxoNK8RUsCW0osTbnCMeBxAaggU1vW3mg3cdVOjFRtvPkksXHO8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Rs4rNM1OZtGcXhVm5YEL0w0OCdDJby4ZSQNeei8f+k=; b=PaHYNmgbPf0mVJqV4ZwNlxP/JT8ndTPKodejS8mjnj+CQPS3C72PXXRoGqxwgjdrjqAHl/Hv00+nI22Jsx+Gjt7XTZ4SLC45gwb708zJkmtsiqKJJ46WpBhGdkIG/X/iItUzk6l9iu7ea3X47Y5VwTS7OD9PC+jL0akqwU+a5us= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6669.eurprd04.prod.outlook.com (20.179.235.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22; Fri, 8 Nov 2019 13:16:25 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561%6]) with mapi id 15.20.2430.023; Fri, 8 Nov 2019 13:16:25 +0000 From: Akhil Goyal To: "Somalapuram, Amaranath" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v1 1/6] doc: documentation update Thread-Index: AQHVgyY+Nj8nmG7x9kWDozgGW1U0oadbhTcwgB8Ki2CABtYocA== Date: Fri, 8 Nov 2019 13:16:25 +0000 Message-ID: References: <20191015070018.92514-1-asomalap@amd.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0613f3a7-f083-4899-f357-08d7644ddb66 x-ms-traffictypediagnostic: VE1PR04MB6669: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0215D7173F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(199004)(189003)(3846002)(186003)(8936002)(6436002)(81156014)(55016002)(33656002)(6506007)(229853002)(6116002)(2501003)(9686003)(7736002)(305945005)(99286004)(81166006)(11346002)(476003)(74316002)(66066001)(26005)(8676002)(446003)(76176011)(14444005)(2906002)(14454004)(7696005)(44832011)(102836004)(486006)(71200400001)(71190400001)(6246003)(66446008)(64756008)(66556008)(66476007)(25786009)(86362001)(5660300002)(316002)(110136005)(15650500001)(4326008)(478600001)(256004)(52536014)(66946007)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6669; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BN6VHgM2vSRIRHgvKsaai1jIOUA0USuSG9DD/4gHEEh86esinIFjibthbU5U4ujvISQH5JhJJQtSas/DyEci9KJ0/13UAZuoZ7MBCtiebvDQ+o/oBVLHPyjzCgBupsi/7RxNVvcnX2Wn8gg9mQMqxQ9LRb+oBCFhUozRxDjsgkpam+JyVMaEd2QIbBTLuFtL+nWtaRFhrTTB3nx0lh4103pdADogGrv5V8Rb+b8TDgVMvOMcbRtb+k5fhVXTa5Kj6aBQbzdvgBeprMBVS7MOSYjFhi3t21PoNtWierxt4Hs12pH97Cl8TiCAtkf5xfC5e8MhfqkmGyJfZJ22BQEWZ9I2Ny4YSwpXucMXN08SC35lMVZmtwqV0wvhyriHo11eqO18oKOihzEpQpB61tR+96mdNdEoXZBxgLhVhPmmvusvMqCzLiDSo6tL/SQhcPXV x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0613f3a7-f083-4899-f357-08d7644ddb66 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 13:16:25.0672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9Dw1FS4RJmqMmwu7WxTc1E7Rs22Mh1iBndmOU4INZSapJIyU8g75ewnkbKiQojCJ+SpWm0YsVTJFSyyiU1v1NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6669 Subject: Re: [dpdk-dev] [PATCH v1 1/6] doc: documentation update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Akhil, > If I use fix as a tag. I get the below message. > Is this messages is ok or do we need to have bug numbers for this? >=20 > ./devtools/check-git-log.sh > Missing 'Fixes' tag: > doc: fix app usage in CCP guide >=20 > Regards, > S.Amarnath >=20 Yes, it should have a fixes tag=20 For this patch it would be=20 Fixes: 4433ced9aa4b ("doc: add AMD CCP guide") And patch title would be "doc: fix app usage in CCP guide". You should find the commit ID of the original patch which introduced this i= ssue. You can use git blame. Please make similar changes in all the patches. Regards, Akhil >=20 > Title should be "doc: fix app usage in CCP guide" >=20 > > > > From: Amaranath Somalapuram > > > > Update the docs, fixing description of some parameter. > > Changing AES_CBC to aes-cbc, SHA1_HMAC to sha1-hmac. > Patch description should be something like: > Command line arguments for running l2fwd-crypto was updated but the AMD > CCP PMD still uses old arguments. > This patch updates the command line arguments of l2fwd-crypto while runni= ng > with crypto-ccp >=20 >=20 > Please add a fixes line here specifying the commit Id and patch title Of= the patch > which originally introduced this issue. >=20 > > Cc: stable@dpdk.org > > > > Signed-off-by: Amaranath Somalapuram > > --- > > doc/guides/cryptodevs/ccp.rst | 32 ++++++++++++++++---------------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/doc/guides/cryptodevs/ccp.rst > > b/doc/guides/cryptodevs/ccp.rst index 034d20367..a43fe92de 100644 > > --- a/doc/guides/cryptodevs/ccp.rst > > +++ b/doc/guides/cryptodevs/ccp.rst > > @@ -109,14 +109,14 @@ To validate ccp pmd, l2fwd-crypto example can be > > used with following command: > > > > .. code-block:: console > > > > - sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp" -- -p 0x1 > > - --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo AES_CBC > > - --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f > > - --iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff > > - --auth_op GENERATE --auth_algo SHA1_HMAC > > - --auth_key > > 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > - > > > > :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:1 > > 1:11:11 > > - :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > + sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp" -- -p = 0x1 > > + --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo aes-cbc > > + --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f > > + --cipher_iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff > > + --auth_op GENERATE --auth_algo sha1-hmac > > + --auth_key > > 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > + > > + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:1 > > + 1:1 > > 1:11 > > + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > > > The CCP PMD also supports computing authentication over CPU with > > cipher offloaded to CCP. > > To enable this feature, pass an additional argument as ccp_auth_opt=3D= 1 > > to -- vdev parameters as @@ -124,14 +124,14 @@ following: > > > > .. code-block:: console > > > > - sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev "crypto_ccp,ccp_auth_o= pt=3D1" > > -- -p 0x1 > > - --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo AES_CBC > > - --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f > > - --iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff > > - --auth_op GENERATE --auth_algo SHA1_HMAC > > - --auth_key > > 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > - > > > > :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:1 > > 1:11:11 > > - :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > + sudo ./build/l2fwd-crypto -l 1 -n 4 --vdev > > + "crypto_ccp,ccp_auth_opt=3D1" -- - > > p 0x1 > > + --chain CIPHER_HASH --cipher_op ENCRYPT --cipher_algo aes-cbc > > + --cipher_key 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f > > + --cipher_iv 00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:ff > > + --auth_op GENERATE --auth_algo sha1-hmac > > + --auth_key > > 11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > + > > + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:1 > > + 1:1 > > 1:11 > > + :11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11:11 > > > > Limitations > > ----------- > > -- > > 2.17.1