From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF634A3295 for ; Wed, 23 Oct 2019 16:59:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF9411C29D; Wed, 23 Oct 2019 16:59:39 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30057.outbound.protection.outlook.com [40.107.3.57]) by dpdk.org (Postfix) with ESMTP id 331451C227 for ; Wed, 23 Oct 2019 16:59:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQnH2I4bUY7sNsFqSywUwB9R0yDQ3y5lw59rXdu1F62HYCW3acJL6qs30CtIbk3KgpDwNCaCbAs0AmFvQwevzwJAg6VdWBZUhsuqWRGg9H+CEx8xayjCDXDkIGFsJ9X5Pow54aGU+3WsdgrGDwBuO+k9GNRTiPdS3ReqInemCjwr9C+T21JtZKbek/yIvvre/UnqCHjIEXXAH8KeoS4OBaBpNKynW8yKzZb9cwvMajQ/aUuCSTa+xriAVDOafKfieoPWqTUzYUOWgLtZ7Sq02orO4jQ/VG64duC986H1c/Kuj3yIGY+MoHiXDkQSW4MAp4ygPoxrX1xM9v5Z9lKAvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ke6s08NNdNJm7OG5qAZ4u4KXkGv/mInbH+JDkoE0yUk=; b=FkBIqkn8wEiIyy5c6xvXwm2i9KHCWu9+AGb6/hmmFMviHfEgpqecoj/IaEoqj5j2eGNvBWJBn937AgeJtnIX6s4qGJOts8gzpR8v/AjKiTzPI/fQdN50dn13HRWQXl7FLxqaAPK3sxZboQOTLoyLNDg0bjdzKGejjSq/XJcx5Ewy66D4fs4L5anJR8GAaWChUKUj5vh6OiKkX3GnPEeqhx3evEhIRkYROvRI3Q1JsDpSN4lXtlPVH53QnnnS4Bw8hODc+IdQCsYdv1EIEQ1ya1cTiiHltFcnyHhIOqx7E+T3sRzmf2bjdUt27N3c+19OTkhhWl9XTpx9wl1CipUwaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ke6s08NNdNJm7OG5qAZ4u4KXkGv/mInbH+JDkoE0yUk=; b=EFWxCfdccmVbOuWp/NUoaGJ6ZYCpx4+XOPgnCzfoHWHQHti/OeQNZ3OLS7UX7zGJMLs/+hdLCm8UiiSW9pNq3SaveyAIBbovC24Q8vtwNv4FfMHQ/xOY2dZ7JDmTb4gypj23EiSRoU4ba5TZpDFWyMzddiYjmb8u+VTsH9TooY0= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6717.eurprd04.prod.outlook.com (10.255.118.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Wed, 23 Oct 2019 14:59:38 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::9dc:aa5c:2bb8:b561%6]) with mapi id 15.20.2367.022; Wed, 23 Oct 2019 14:59:38 +0000 From: Akhil Goyal To: "Trahe, Fiona" , "dev@dpdk.org" CC: "Kusztal, ArkadiuszX" , "Dybkowski, AdamX" Thread-Topic: [PATCH v2] cryptodev: clarify wireless inputs in digest-encrypted cases Thread-Index: AQHViNt3bOA7mWxlDU2PckpTRDqXCKdmpaPwgAAXvQCAAZWoUA== Date: Wed, 23 Oct 2019 14:59:38 +0000 Message-ID: References: <1571744076-7623-1-git-send-email-fiona.trahe@intel.com> <1571750416-11742-1-git-send-email-fiona.trahe@intel.com> <348A99DA5F5B7549AA880327E580B435A217BA58@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435A217BA58@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: af82515e-657a-4f8f-cdc3-08d757c9a035 x-ms-traffictypediagnostic: VE1PR04MB6717: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(376002)(136003)(366004)(346002)(189003)(199004)(18543002)(55016002)(54906003)(71200400001)(9686003)(6506007)(186003)(102836004)(99286004)(81156014)(33656002)(6116002)(316002)(3846002)(229853002)(76176011)(5660300002)(26005)(110136005)(7696005)(71190400001)(6436002)(25786009)(86362001)(2906002)(8676002)(66476007)(8936002)(478600001)(66446008)(66946007)(305945005)(6246003)(64756008)(66066001)(7736002)(256004)(66556008)(81166006)(44832011)(11346002)(14454004)(476003)(74316002)(76116006)(446003)(486006)(2501003)(4326008)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6717; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /95pdgIq/4oSMlqXuH4q9MzMG10eIBTGv7lpVctFXZe6AAJhpLPKUusbGfRdwjE2oZawS8D7hy7v0iShQdKY4zxmgPpAU/FYU1o+8VnfLgzcZrbpUyOMaBZtBZW7zmJXbVwrwOmOL13zdxQ/HdOQ1YhIc33/NlM/ixyaqkksrfE1C79N0ErZlbm/HWmTsCwEo9rJzyShP7+PryyyGTnz1XzglELJJJtuXa6sjg2Yf9i3pclp2jCjKcq+mdvajAzoLXML3lGYiJjCSuRRuqunCsGsXFngOtn0FODaAgjcQ+J9tyaxN2hbpG6DzqvI8c5nyDsC1RWUyyii9Zk2zVcuNJA8eT6Erpt+xI2Rx6VqtqeD1RojLFMwR0RWuwijBlO/IwWAHswXm19BbF72SdJt41hWWbVk1yd1fQZc0FtqDpjqgDgJ1Q1PuyePJnNuHWan x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: af82515e-657a-4f8f-cdc3-08d757c9a035 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2019 14:59:38.2948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ELJyuVo9pF0v1JzgjEvYBXEwmD1Kzj0KRVZgLDFyI4kUuXgyi5jhJ2obYucth3JgNcHZY4jy1+ESnrfLsZ0JNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6717 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: clarify wireless inputs in digest-encrypted cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > Clarify constraints on fields specified in bits for wireless > > > algorithms in digest-encrypted case. > > > > > > v2 changes: > > > - added note on each of the affected parameter fields > > > > > > Signed-off-by: Fiona Trahe > > > --- > > > lib/librte_cryptodev/rte_crypto_sym.h | 23 +++++++++++++++++++---- > > > 1 files changed, 19 insertions(+), 4 deletions(-) > > > > > //snip// > > > > > @@ -703,6 +711,13 @@ struct rte_crypto_sym_op { > > > * auth.data.length and is typically > > > * equal to auth.data.offset + > > > * auth.data.length + digest_length. > > > + * - for wireless algorithms, i.e. > > > + * SNOW 3G, KASUMI and ZUC, as the > > > + * cipher.data.length, > > > + * cipher.data.offset, > > > + * auth.data.length and > > > + * auth.data.offset are in bits, they > > > + * must be 8-bit multiples. > > > > Why do you need this change? This is redundant information. > [Fiona] I think it's useful that it's under the digest-encrypted case not= es. > So ok as is and is good to have info in both places people may look. > However if we want to avoid duplication, then I'd prefer to keep here and= add a > note > under the specific params to direct to check here. Like: > = * and ZUC @ > RTE_CRYPTO_CIPHER_ZUC_EEA3, > - * this field should be in bits. > + * this field should be in bits. See also > + * notes about digest-encrypted case. > */ OK Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.