From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46E59A0568; Mon, 2 Mar 2020 09:57:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C5531BFF3; Mon, 2 Mar 2020 09:57:45 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2079.outbound.protection.outlook.com [40.107.21.79]) by dpdk.org (Postfix) with ESMTP id 0738223D for ; Mon, 2 Mar 2020 09:57:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGUnsEEAMjyBOsK9oGqi1WpCXJDOnqWbS/42MktADxFrF59TGmGvS1YjApZQadB4otvGY4pPIiIYUhDSxJ6vWAXVmuVlKOWtkU2vCb+nR9NNtIyV+tipSMFPeJuIEovJ1CVV7addJUWKgdUy2ugpSIfQ8VOX8n68sKYHhtEuKerVNyICa0j1jF8l3q5O+Y6sPq+nJ4rikojk/Y27+1x8iRNKblcA3/bHDwVKgUgt0Ni1buXcWPcVyYya0ofIhHEwEBSnFgkPPM8XgKnNnOJiqVi94cd8YkFyi2vktMprkdh7Qxy+4wKhh6FWE3q5Uno92Uco2AmroikjvkiQNH9lgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TS39kF3Q44lXowVflxPPNEXMNU2UjiYyxt7q314SAN4=; b=NI9jxXACMMAXa/moK7P7pWLvX1e9e2eKQOaapLqVyWZCz3kFI03bYKuTxcbiIfFKA59T6g0q6anapuHkwGxdDISy2xll1s/85nePHU0R/2jn7jajqAvyLCmFPh9AHC4YovOKpa8DEOvGOvaRmVFJV4KdNIBu5lgo/BwyXxZz15VMSZZVSy9/DrqbC4m49zBU3wpaKnL+gMlSgosRhUchK/L+9z4USe1Ely8duPCd70K+gY2VxsFnxRAU7CzEnJz5VLGEdqiIe6UcTUEqtuqd/ZGuK4kx0uZc6byZkQrysLU3ys/7N71mumE/drmEbk9E4ZWZLZsiIPfrpfRYtrjRow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TS39kF3Q44lXowVflxPPNEXMNU2UjiYyxt7q314SAN4=; b=Wqs/foalyg6VWsB8mJlSne2fW6AioSTuDB84wdIFTwPL2K9F7IjHW2EJhWt8h/aj5TjUntK23azY6qNpEtW1nj8EyugJz1sbHI9MtCVvjvrLnRbGBiViWDo4YMDGg2ykmhXfQRA4LkZRQh4Aza8iR3Ih/x3qP1tRvTm1T+K1CLA= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6384.eurprd04.prod.outlook.com (20.179.235.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 08:57:42 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7d99:ec14:5e42:dc18]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::7d99:ec14:5e42:dc18%3]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 08:57:42 +0000 From: Akhil Goyal To: Anoob Joseph , Konstantin Ananyev CC: Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Ankur Dwivedi , Archana Muniganti , Tejasree Kondoj , Vamsi Krishna Attunuru , "dev@dpdk.org" , Radu Nicolau , Thomas Monjalon , Lukas Bartosik Thread-Topic: [PATCH v5 00/15] add eventmode to ipsec-secgw Thread-Index: AQHV7YmZRr96nxpcH0Kc8ByDqKef8ag1AzoAgAAC0nA= Date: Mon, 2 Mar 2020 08:57:42 +0000 Message-ID: References: <1582185727-6749-1-git-send-email-lbartosik@marvell.com> <1582820317-7333-1-git-send-email-lbartosik@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.69] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bfceb618-7dbd-453d-ab2d-08d7be87c49d x-ms-traffictypediagnostic: VE1PR04MB6384: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-forefront-prvs: 033054F29A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(189003)(199004)(30864003)(478600001)(316002)(8936002)(8676002)(81166006)(81156014)(44832011)(86362001)(2906002)(186003)(9686003)(26005)(7416002)(33656002)(54906003)(55016002)(110136005)(66946007)(66556008)(64756008)(66446008)(5660300002)(4326008)(53546011)(52536014)(71200400001)(6506007)(7696005)(76116006)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6384; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yxqfIhpQVP8YiWQlNzZF6sud5QbEGd4ynFZnZ15+sH5ryc7QJSr9y1ISqAIMVcLoBsuDvmiQpejcT+9Txv3yqkeA47uqiFIAIRx+2jGYGwKotXkbo3SMeoAzgT0V+BkwAyNZ3kwWXAfdTXEFfwASJtiAnWT/jkjLPJm3CkPyuXX1WKM6HsdiGSfsLc+0+NvQGL1BymifEAayEYi5H4GhsP56jEOM+BGtKACVKYfC657vAIZkKJoxWyo+kr0Qs8v/gGmMi5GlU/JXu/lr3E+o+u9DjoySQTIhJr1b3rTQ6ck6GlldduBB4rug5enHHiSS3ABKvJLXjg2EiIkQ+sliJv6Jg7iJG5hx1DALXJkrwRpMK9XxQRaWwblM/ADJGrj48eYABGXQByJXQ8bYzlT3GD7uqslhx7/lv5F1a9Zx62ptbdbIg3Mpt+F+YIHeW81T x-ms-exchange-antispam-messagedata: rQjRnQdjfuwhUGbiSA9Gzl8xO/McQs8zrXDonPanyMfZNbTgamdyjVMHSm70DWkiTw/9u8T15/wxu5/zUKnrbeZTFoTJTmCfyi+9Lp3PA/0ZDmCiUwCZT/NJYEAJB/N6OhSJYf4GPJrCCQDCrlV+XA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfceb618-7dbd-453d-ab2d-08d7be87c49d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2020 08:57:42.2105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qb4dR/y+I3OyWL+MDl9k9asQS0Lhq6ee5/oHb+f73Zzs1Ya9c72oOyCSlkYN+Rkm5Jo8DrsTvV1HStxwc2rGsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6384 Subject: Re: [dpdk-dev] [PATCH v5 00/15] add eventmode to ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, I will merge this series in this week. Regards, Akhil > -----Original Message----- > From: Anoob Joseph > Sent: Monday, March 2, 2020 2:17 PM > To: Akhil Goyal ; Konstantin Ananyev > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Ankur Dwivedi ; > Archana Muniganti ; Tejasree Kondoj > ; Vamsi Krishna Attunuru ; > dev@dpdk.org; Radu Nicolau ; Thomas Monjalon > ; Lukas Bartosik > Subject: RE: [PATCH v5 00/15] add eventmode to ipsec-secgw >=20 > Hi Akhil, Konstantin, >=20 > Are there any more comments? Or can we have the patches merged? >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Lukasz Bartosik > > Sent: Thursday, February 27, 2020 9:48 PM > > To: Akhil Goyal ; Radu Nicolau > > ; Thomas Monjalon > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raj= u > > Athreya ; Ankur Dwivedi ; > > Anoob Joseph ; Archana Muniganti > > ; Tejasree Kondoj ; Vamsi > > Krishna Attunuru ; Konstantin Ananyev > > ; dev@dpdk.org > > Subject: [PATCH v5 00/15] add eventmode to ipsec-secgw > > > > This series introduces event-mode additions to ipsec-secgw. > > > > With this series, ipsec-secgw would be able to run in eventmode. The wo= rker > > thread (executing loop) would be receiving events and would be submitti= ng it > > back to the eventdev after the processing. This way, multicore scaling = and h/w > > assisted scheduling is achieved by making use of the eventdev capabilit= ies. > > > > Since the underlying event device would be having varying capabilities,= the > > worker thread could be drafted differently to maximize performance. > > This series introduces usage of multiple worker threads, among which th= e one > to > > be used will be determined by the operating conditions and the underlyi= ng > > device capabilities. > > > > For example, if an event device - eth device pair has Tx internal port,= then > > application can do tx_adapter_enqueue() instead of regular event_enqueu= e(). > So > > a thread making an assumption that the device pair has internal port wi= ll not > be > > the right solution for another pair. The infrastructure added with thes= e patches > > aims to help application to have multiple worker threads, there by extr= acting > > maximum performance from every device without affecting existing paths/= use > > cases. > > > > The eventmode configuration is predefined. All packets reaching one eth= port > > will hit one event queue. All event queues will be mapped to all event = ports. So > > all cores will be able to receive traffic from all ports. > > When schedule_type is set as RTE_SCHED_TYPE_ORDERED/ATOMIC, event > > device will ensure the ordering. Ordering would be lost when tried in P= ARALLEL. > > > > Following command line options are introduced, > > > > --transfer-mode: to choose between poll mode & event mode > > --event-schedule-type: to specify the scheduling type > > (RTE_SCHED_TYPE_ORDERED/ > > RTE_SCHED_TYPE_ATOMIC/ > > RTE_SCHED_TYPE_PARALLEL) > > > > Additionally the event mode introduces two modes of processing packets: > > > > Driver-mode: This mode will have bare minimum changes in the applicatio= n > > to support ipsec. There woudn't be any lookup etc done in > > the application. And for inline-protocol use case, the > > thread would resemble l2fwd as the ipsec processing would = be > > done entirely in the h/w. This mode can be used to benchma= rk > > the raw performance of the h/w. All the application side > > steps (like lookup) can be redone based on the requirement > > of the end user. Hence the need for a mode which would > > report the raw performance. > > > > App-mode: This mode will have all the features currently implemented wi= th > > ipsec-secgw (non librte_ipsec mode). All the lookups etc > > would follow the existing methods and would report numbers > > that can be compared against regular ipsec-secgw benchmark > > numbers. > > > > The driver mode is selected with existing --single-sa option (used also= by poll > > mode). When --single-sa option is used in conjution with event mode the= n > index > > passed to --single-sa is ignored. > > > > Example commands to execute ipsec-secgw in various modes on OCTEON TX2 > > platform, > > > > #Inbound and outbound app mode > > ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=3D128 -w > > 0002:03:00.0,ipsec_in_max_spi=3D128 -w 0002:0e:00.0 -w 0002:10:00.1 --l= og- > > level=3D8 -c 0x1 -- -P -p 0x3 -u 0x1 -f aes-gcm.cfg --transfer-mode eve= nt --event- > > schedule-type parallel > > > > #Inbound and outbound driver mode > > ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=3D128 -w > > 0002:03:00.0,ipsec_in_max_spi=3D128 -w 0002:0e:00.0 -w 0002:10:00.1 --l= og- > > level=3D8 -c 0x1 -- -P -p 0x3 -u 0x1 -f aes-gcm.cfg --transfer-mode eve= nt --event- > > schedule-type parallel --single-sa 0 > > > > This series adds non burst tx internal port workers only. It provides > infrastructure > > for non internal port workers, however does not define any. Also, only = inline > > ipsec protocol mode is supported by the worker threads added. > > > > Following are planned features, > > 1. Add burst mode workers. > > 2. Add non internal port workers. > > 3. Verify support for Rx core (the support is added but lack of h/w to = verify). > > 4. Add lookaside protocol support. > > > > Following are features that Marvell won't be attempting. > > 1. Inline crypto support. > > 2. Lookaside crypto support. > > > > For the features that Marvell won't be attempting, new workers can be > > introduced by the respective stake holders. > > > > This series is tested on Marvell OCTEON TX2. > > This series is targeted for 20.05 release. > > > > Changes in v5: > > * Rename function check_params() to check_poll_mode_params() and > > check_eh_conf() to check_event_mode_params() in order to make it clea= r > > what is their purpose. > > * Forbid usage of --config option in event mode. > > * Replace magic numbers on return with enum values in > > process_ipsec_ev_inbound() > > and process_ipsec_ev_outbound() functions. > > * Add session_priv_pool for both inbound and outbound configuration in > > ipsec_wrkr_non_burst_int_port_app_mode worker. > > * Add check of event type in ipsec_wrkr_non_burst_int_port_app_mode > worker. > > * Update description of --config option in both ipsec-secgw help and > > documentation. > > > > Changes in v4: > > * Update ipsec-secgw documentation to describe the new options as well = as > > event mode support. > > * In event mode reserve number of crypto queues equal to number of eth > ports > > in order to meet inline protocol offload requirements. > > * Add calculate_nb_mbufs() function to calculate number of mbufs in a p= ool > > and include fragments table size into the calculation. > > * Move structures ipsec_xf and ipsec_sad to ipsec.h and remove static > keyword > > from sa_out, nb_sa_out, sa_in and nb_sa_in in sa.c. > > * Update process_ipsec_ev_inbound(), process_ipsec_ev_outbound(), > > check_sp() > > and prepare_out_sessions_tbl() functions as a result of changes intro= duced > > by SAD feature. > > * Remove setting sa->cdev_id_qp to 0 in create_inline_session as sa_ctx > > is created with rte_zmalloc. > > * Minor cleanup enhancements: > > - In eh_set_default_conf_eventdev() function in event_helper.c put defi= nition > > of int local vars in one line, remove invalid comment, put > > "eventdev_config->ev_queue_mode =3D RTE_EVENT_QUEUE_CFG_ALL_TYPES" > > in one line > > instead of two. > > - Remove extern "C" from event_helper.h. > > - Put local vars in reverse xmas tree order in eh_dev_has_rx_internal_p= ort() > and > > eh_dev_has_tx_internal_port() functions in event_helper.c. > > - Put #include in alphabetical order in ipsec-secgw.c. > > - Move "extern volatile bool force_quit" and "#include " to = ipsec- > > secgw.h, > > remove #include . > > - Remove not needed includes in ipsec_worker.c. > > - Remove expired todo from ipsec_worker.h. > > > > Changes in v3: > > * Move eh_conf_init() and eh_conf_uninit() functions to event_helper.c > > including minor rework. > > * Rename --schedule-type option to --event-schedule-type. > > * Replace macro UNPROTECTED_PORT with static inline function > > is_unprotected_port(). > > * Move definitions of global variables used by multiple modules > > to .c files and add externs in .h headers. > > * Add eh_check_conf() which validates ipsec-secgw configuration > > for event mode. > > * Add dynamic calculation of number of buffers in a pool based > > on number of cores, ports and crypto queues. > > * Fix segmentation fault in event mode driver worker which happens > > when there are no inline outbound sessions configured. > > * Remove change related to updating number of crypto queues > > in cryptodevs_init(). The update of crypto queues will be handled > > in a separate patch. > > * Fix compilation error on 32-bit platforms by using userdata instead > > of udata64 from rte_mbuf. > > > > Changes in v2: > > * Remove --process-dir option. Instead use existing unprotected port ma= sk > > option (-u) to decide wheter port handles inbound or outbound traffic= . > > * Remove --process-mode option. Instead use existing --single-sa option > > to select between app and driver modes. > > * Add handling of PKT_RX_SEC_OFFLOAD_FAIL result in app worker thread. > > * Fix passing of req_rx_offload flags to create_default_ipsec_flow(). > > * Move destruction of flows to a location where eth ports are stopped > > and closed. > > * Print error and exit when event mode --schedule-type option is used > > in poll mode. > > * Reduce number of goto statements replacing them with loop constructs. > > * Remove sec_session_fixed table and replace it with locally build > > table in driver worker thread. Table is indexed by port identifier > > and holds first inline session pointer found for a given port. > > * Print error and exit when sessions other than inline are configured > > in event mode. > > * When number of event queues is less than number of eth ports then > > map all eth ports to one event queue. > > * Cleanup and minor improvements in code as suggested by Konstantin > > > > Ankur Dwivedi (1): > > examples/ipsec-secgw: add default rte flow for inline Rx > > > > Anoob Joseph (5): > > examples/ipsec-secgw: add framework for eventmode helper > > examples/ipsec-secgw: add eventdev port-lcore link > > examples/ipsec-secgw: add Rx adapter support > > examples/ipsec-secgw: add Tx adapter support > > examples/ipsec-secgw: add routines to display config > > > > Lukasz Bartosik (9): > > examples/ipsec-secgw: add routines to launch workers > > examples/ipsec-secgw: add support for internal ports > > examples/ipsec-secgw: add event helper config init/uninit > > examples/ipsec-secgw: add eventmode to ipsec-secgw > > examples/ipsec-secgw: add driver mode worker > > examples/ipsec-secgw: add app mode worker > > examples/ipsec-secgw: make number of buffers dynamic > > doc: add event mode support to ipsec-secgw > > examples/ipsec-secgw: reserve crypto queues in event mode > > > > doc/guides/sample_app_ug/ipsec_secgw.rst | 135 ++- > > examples/ipsec-secgw/Makefile | 2 + > > examples/ipsec-secgw/event_helper.c | 1812 > > ++++++++++++++++++++++++++++++ > > examples/ipsec-secgw/event_helper.h | 327 ++++++ > > examples/ipsec-secgw/ipsec-secgw.c | 506 +++++++-- > > examples/ipsec-secgw/ipsec-secgw.h | 88 ++ > > examples/ipsec-secgw/ipsec.c | 5 +- > > examples/ipsec-secgw/ipsec.h | 53 +- > > examples/ipsec-secgw/ipsec_worker.c | 649 +++++++++++ > > examples/ipsec-secgw/ipsec_worker.h | 41 + > > examples/ipsec-secgw/meson.build | 6 +- > > examples/ipsec-secgw/sa.c | 21 +- > > examples/ipsec-secgw/sad.h | 5 - > > 13 files changed, 3516 insertions(+), 134 deletions(-) create mode 10= 0644 > > examples/ipsec-secgw/event_helper.c > > create mode 100644 examples/ipsec-secgw/event_helper.h > > create mode 100644 examples/ipsec-secgw/ipsec-secgw.h > > create mode 100644 examples/ipsec-secgw/ipsec_worker.c > > create mode 100644 examples/ipsec-secgw/ipsec_worker.h > > > > -- > > 2.7.4