From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D139AA2F67 for ; Fri, 4 Oct 2019 14:00:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7FD01C217; Fri, 4 Oct 2019 14:00:17 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50058.outbound.protection.outlook.com [40.107.5.58]) by dpdk.org (Postfix) with ESMTP id DB2721C216 for ; Fri, 4 Oct 2019 14:00:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQfTBc6B5X+/QcFiQGbjgro9r+UVuvF0DCC0GMGhPACe0u9O8tBH+AWIECk2TVoCCJmpVS9hcBJOYnZcnIC4BBO1VbM69YHudUQstK018WZZa5bPe9SU2PLBbnl1Erxi/NNKQs9jTKNscl2A/iozrqrQ39HsLC87ZKBUUfpHdgkH+3kFqHweEGCW0gmaRaFZ8+n1gHQwnEpKxpAKs66FVSXuASffB1t6PRz5NfJFJuA8LCmi/LofxzwWVGYKEc6GW/vjguq6RaKul+hrXXGGkpbLktvD4RHvmxpntwSGT9c6P8GLZz/gpwl4dboTlP/xosknGZ5f+0L23wiSEU3f2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+xzyteGE6bMhpokbKkBrjXdPu9OI9qw4A/dnwWgLzw=; b=lqweXAibAzWT9MKkYtMFCXmH91xfub07gvXo/2mU+4+ySVf7EcGB7QKpQF96wtAmHt9zK41vreDjj+J8cXeE4IUSpZCgZggqzpq63LCz2GAxfqXluO9jCFFMr3oKfqlRo/Fibc3dJWkA216QgMSS70o9i1uzqbfo8QdCJj6E902m6rw8AdzPBdtmHqaJFXrkeSbUoY4YcG4DI9QN2lbMhfkGcDC2Mgi/mhYu5PKnEBm3hU4LOmko26mKc4foz0TiybxoCSpK3NkcMRgPfVHm5PSTjl0TZ6s14ZRWCvxW/27k7zE58B/0mKIty7h8+yFTkxS3rBRiuH+c3XhXlR9n0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+xzyteGE6bMhpokbKkBrjXdPu9OI9qw4A/dnwWgLzw=; b=VGsLLB1gS6RjqBPNxeW38+4MOl64bN8eUjA8J5VuFW5SFrh4fyVNReKsFCgCqUgtH9WiMXE69EgidFI0uyjZdR9DyotbuH83ezIwrUt4nRr/9QeUqIWlA8D8CtqhpDBfNOWCOlGEJ8Vp5P98/msSPS62llyyfYq7tGq2QAgkJEk= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (10.255.118.11) by VE1PR04MB6464.eurprd04.prod.outlook.com (20.179.233.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Fri, 4 Oct 2019 12:00:15 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::c045:5df2:ba1f:c3ee%5]) with mapi id 15.20.2305.023; Fri, 4 Oct 2019 12:00:15 +0000 From: Akhil Goyal To: "jianjay.zhou@huawei.com" CC: "dev@dpdk.org" , Xiao Wang Thread-Topic: [dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA affinity Thread-Index: AQHVYyaI7ro6Bdw8bkuuWiRyRtelkadKkAHg Date: Fri, 4 Oct 2019 12:00:14 +0000 Message-ID: References: <20190904132151.58885-1-xiao.w.wang@intel.com> In-Reply-To: <20190904132151.58885-1-xiao.w.wang@intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a8825119-3fdc-415c-3c66-08d748c26ae9 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: VE1PR04MB6464: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 018093A9B5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(199004)(189003)(9686003)(6246003)(5640700003)(6116002)(55016002)(4744005)(3846002)(81166006)(5660300002)(76176011)(81156014)(25786009)(7736002)(6436002)(478600001)(305945005)(54906003)(52536014)(8936002)(86362001)(6916009)(2906002)(4326008)(74316002)(316002)(66476007)(66556008)(64756008)(2351001)(186003)(71190400001)(66446008)(446003)(11346002)(44832011)(71200400001)(476003)(26005)(486006)(33656002)(229853002)(14444005)(99286004)(6506007)(66066001)(7696005)(256004)(14454004)(66946007)(2501003)(102836004)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6464; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zFaaP+wUk4f5bSGpWvPHfjpr+ySf01Qj09Or7sJVVwbicBpTxH9qwatsuc4tca6j0+rcyx5TTaAOcgbHqfmW3e6MearXniKcMrfoXDQVYOTMbjIxmCZjOBWipCaWDzacNTBSaxWmsT5mPpfeT7GG1WvMezShERpZeO27Au9vE/Igap/mEmnbq8nxCRhVWuYAfAkGsJVy9J2rHj+wY5/IzctwsWnGnHMat8cGvPhxLzoe6tV9JPaNyggAfFDr4M+T2CIDh+G8UNg7ybqzTaiL5rNmbWo9dwH411OytZad+qF0hkCgXnhCyf8r1LOO56oRK5xH7L8toPGauO6ikTFPbm+x9Uum992sOlQLEG3LOCRmuCL9weRWF5lbZ1pPqfgpXR99bkVQ83m/n8nRdDoUwCIC96Xx6F8JkzjykOQR+bU= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8825119-3fdc-415c-3c66-08d748c26ae9 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2019 12:00:14.8631 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rHlPmztSd8O4CVE2/Igg/UWOwDYqCxPJOE23JEa/7fNfWKq44scZn0k1Ip3hOt2HN5sz8HUKYOk1PyW1jqnSTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6464 Subject: Re: [dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA affinity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jay, Could you please review this change. Thanks, Akhil >=20 > It's better to allocate device private data on the same NUMA node with > device, rather than with the main thread. This helps avoid cross-NUMA > access for worker thread. >=20 > Signed-off-by: Xiao Wang > --- > drivers/crypto/virtio/virtio_cryptodev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/virtio/virtio_cryptodev.c > b/drivers/crypto/virtio/virtio_cryptodev.c > index f16bdfe57..4af479f54 100644 > --- a/drivers/crypto/virtio/virtio_cryptodev.c > +++ b/drivers/crypto/virtio/virtio_cryptodev.c > @@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe( > { > struct rte_cryptodev_pmd_init_params init_params =3D { > .name =3D "", > - .socket_id =3D rte_socket_id(), > + .socket_id =3D pci_dev->device.numa_node, > .private_data_size =3D sizeof(struct virtio_crypto_hw) > }; > char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > -- > 2.15.1