From: Phil Yang <Phil.Yang@arm.com>
To: Harman Kalra <hkalra@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status
Date: Thu, 9 Jul 2020 05:17:51 +0000 [thread overview]
Message-ID: <VE1PR08MB4640110A42E9474815B3FE1EE9640@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200708114114.GA49487@outlook.office365.com>
> -----Original Message-----
> From: Harman Kalra <hkalra@marvell.com>
> Sent: Wednesday, July 8, 2020 7:41 PM
> To: Phil Yang <Phil.Yang@arm.com>
> Cc: dev@dpdk.org; drc@linux.vnet.ibm.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status
>
> On Thu, Jun 11, 2020 at 06:24:25PM +0800, Phil Yang wrote:
> > The event status is defined as a volatile variable and shared
> > between threads. Use c11 atomics with explicit ordering instead
> > of rte_atomic ops which enforce unnecessary barriers on aarch64.
> >
> > Signed-off-by: Phil Yang <phil.yang@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
>
> Patches looks fine to me with commit message changes suggested
> by Honnappa, i.e. using C11 atomic built-ins.
> Since first patch of the series will not be backported, so I
> think both patches can be combined into one.
OK. Thanks.
I will update in the next version.
Thanks,
Phil
>
> Reviewed-by: Harman Kalra <hkalra@marvell.com>
>
<snip>
next prev parent reply other threads:[~2020-07-09 5:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:24 [dpdk-dev] [PATCH 1/2] eal: remove redundant code Phil Yang
2020-06-11 10:24 ` [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status Phil Yang
2020-07-08 5:24 ` Honnappa Nagarahalli
2020-07-08 11:41 ` Harman Kalra
2020-07-09 5:17 ` Phil Yang [this message]
2020-07-08 12:29 ` David Marchand
2020-07-08 13:43 ` Aaron Conole
2020-07-08 13:59 ` David Marchand
2020-07-08 20:48 ` Aaron Conole
2020-07-08 15:04 ` Kinsella, Ray
2020-07-09 5:21 ` Phil Yang
2020-07-08 5:14 ` [dpdk-dev] [PATCH 1/2] eal: remove redundant code Honnappa Nagarahalli
2020-07-08 5:20 ` Phil Yang
2020-07-09 6:46 ` [dpdk-dev] [PATCH v2] eal: use c11 atomic built-ins for interrupt status Phil Yang
2020-07-09 8:02 ` Stefan Puiu
2020-07-09 8:07 ` Phil Yang
2020-07-09 8:34 ` [dpdk-dev] [PATCH v3] " Phil Yang
2020-07-09 10:30 ` David Marchand
2020-07-10 7:18 ` Dodji Seketeli
2020-07-10 6:32 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB4640110A42E9474815B3FE1EE9640@VE1PR08MB4640.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=hkalra@marvell.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).