From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CF65A0526; Thu, 9 Jul 2020 07:18:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 507851DA6E; Thu, 9 Jul 2020 07:18:01 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by dpdk.org (Postfix) with ESMTP id 6DE8B1D57F for ; Thu, 9 Jul 2020 07:18:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNd2EFGcnrmnpwFSCsop9Y4LH9Eo87l+RoZBF1EZUmM=; b=Zbh/i77UKb4kWI0Zl4LCpLQav6k2RGmSTD0MKs7V0uTYItIcZi/vCxPZx5Uo/N7TPFgUgXi2jogdCjt0upuGwJsyESjvjBT+YLq1lhLVfRh62RT0b32+e4QTDi+6uTsl1HLQlgNpfQeT6txyUq1eT6XgIVYLx9N6jpoBEGHv4qw= Received: from AM5PR0601CA0074.eurprd06.prod.outlook.com (2603:10a6:206::39) by AM0PR08MB5201.eurprd08.prod.outlook.com (2603:10a6:208:15b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 9 Jul 2020 05:17:59 +0000 Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::e2) by AM5PR0601CA0074.outlook.office365.com (2603:10a6:206::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22 via Frontend Transport; Thu, 9 Jul 2020 05:17:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Thu, 9 Jul 2020 05:17:58 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Thu, 09 Jul 2020 05:17:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8e98f1ee0d20.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D1E53400-BD9E-4B92-A076-B42D2DEBE9D5.1; Thu, 09 Jul 2020 05:17:53 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8e98f1ee0d20.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 09 Jul 2020 05:17:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EUDNJVSrTW0HFxFfsRWifmecFhDSdzdHdrSjzAm9gB9GnGxnX1/rMHjIxScgbFk7jT8ltPPUGjkJQsQwXNkngDl5oNAgXHYVWG3x4KVd7S+w4NZuJOdbyi6SEnShwLPNIdVzMaSR5mEktyu7AsaDF+uMhvaLO3YzegnlqSd/9wlpF9v7DyqEV/jUy2ltcVAeKL4rkCjkYw0+l8lHO2MmyABCGJgVSucrv+IAuiOjfcq5nANMM0IQJwylCz/kcBPkLaevYKAMDnR7oY1q0Q4Ahu5WTUwKaHbFylEQPut0148zMX16o0AwQp2Ehtt03Y2SB5RtTY0vqZuO54UQoMXNhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNd2EFGcnrmnpwFSCsop9Y4LH9Eo87l+RoZBF1EZUmM=; b=BYmHOSeaTqotjjOUafbBkwwIdOCnWFG3MldBe7oMclhltFWvl3JTkSn3k3mXLj6PPu3h/LJx1tkV8aVqeialuM3gjyF9RPVgY4zYBUxNm8ErRst0j6P6SvIUCLOTFlgH1/mo02nVuvIxqPM1jTV4rbUHGAofLTel8tJ+UHBsDtWzCAd7KSN0DPem36QbIrNDuj53SYk/VUs0R63amqo42uYS/MxmRNWfhoJmBSzu3mn3EzNnelfWahyby1ty+N8HnKcFOhlwzjjxcpk3x+7J/mdD2nw5XRdTOGw5OrgdOs19NY9UvZdFfRAvMEoQUCqmLwo0TDPgHgzSO0TU9znn+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNd2EFGcnrmnpwFSCsop9Y4LH9Eo87l+RoZBF1EZUmM=; b=Zbh/i77UKb4kWI0Zl4LCpLQav6k2RGmSTD0MKs7V0uTYItIcZi/vCxPZx5Uo/N7TPFgUgXi2jogdCjt0upuGwJsyESjvjBT+YLq1lhLVfRh62RT0b32+e4QTDi+6uTsl1HLQlgNpfQeT6txyUq1eT6XgIVYLx9N6jpoBEGHv4qw= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR08MB5312.eurprd08.prod.outlook.com (2603:10a6:803:139::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Thu, 9 Jul 2020 05:17:51 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3174.022; Thu, 9 Jul 2020 05:17:51 +0000 From: Phil Yang To: Harman Kalra CC: "dev@dpdk.org" , "drc@linux.vnet.ibm.com" , Honnappa Nagarahalli , Ruifeng Wang , nd Thread-Topic: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status Thread-Index: AQHWP9qd78/A526DFEidLJrRDdk/nKj9uasAgAEmj6A= Date: Thu, 9 Jul 2020 05:17:51 +0000 Message-ID: References: <1591871065-12461-1-git-send-email-phil.yang@arm.com> <1591871065-12461-2-git-send-email-phil.yang@arm.com> <20200708114114.GA49487@outlook.office365.com> In-Reply-To: <20200708114114.GA49487@outlook.office365.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a1762caa-0422-4f5a-8633-571a3885d12c.0 x-checkrecipientchecked: true Authentication-Results-Original: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 24be7a5b-795d-47cf-9db5-08d823c771f8 x-ms-traffictypediagnostic: VI1PR08MB5312:|AM0PR08MB5201: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2043;OLM:2043; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8v4N6ZMlNq+ivwuqLQS37c6hQPdCmoyaPRmvt4waV13WGV9cXH1grfDJZ2Db3j9Vg4dAWi5kjs5GBI+/1j79PfvGDJ+NG+EyPG5PkTykZkqmh8t+VW+K3b1IzfsjfwHV1AG/P6+xPp9zQx/bMRkV+Dx/tfrWQi9h6VTAx+PjEhF6Dn0O5/YvRn8cmxULXulWp9z/7lOawjo6M42yP01eYVJGLtcYZQE2zcrDV8c2geMVganIKemfRTdWN/y/I7qapAB5nMcrgoC7tyQpa6c2r6Mjn4OHuqmonFyJTtxpWMhVEV5+/AwqVeTOXHH2BxJRJZKEQzStQRCA7972Gb8e+g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(396003)(366004)(376002)(66946007)(8676002)(83380400001)(55016002)(9686003)(8936002)(4744005)(64756008)(66446008)(52536014)(66476007)(66556008)(5660300002)(186003)(316002)(26005)(2906002)(54906003)(6506007)(53546011)(6916009)(71200400001)(33656002)(76116006)(478600001)(7696005)(86362001)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: hqegOvwQahfyWowTjHy/MT19kUKrfEa0zscBlRdkPIYglt1JZW60W1kHhui0xk6wm+w6tIn/p/EPir3mTCXO6IX9OZOBwAlu04N98yExDKCJExaYUoAyC+WTGwn8FRGerut0dApBDn+y437gQ33iecrYG5S0+9IQHtoTbpCPB6Jt4Tn8bD/AFrSh94I2/a9IBtZ7cnb8FK6jMppyEX9bpSfmWAqi6/Tk9LXnM+4+tlqwdtEqMfp/cKq1GyQLZciCYpTUJVy8Q6glWGwa+gS0gXZQ9dv06dg30eVLTyVMnSoRzHTWc3uVqBS/T8WOPVteTVxjFSAFERu13eUdT5J+YyNaWYPKbzlZh/5oPgVy78AVUoG3UcLp/h9to0ShQUnQ36OSTusTiP6krrDsmnJ24X6EBZyTV3mj2O3PPwnfbKYhEsDorclpqGEMblvhzYR/VRZZw33JovO9KztiFp++5OWQnCaMvfNcI178EU3HiZw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5312 Original-Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966005)(7696005)(33656002)(82740400003)(36906005)(4326008)(336012)(5660300002)(186003)(83380400001)(52536014)(9686003)(26005)(55016002)(53546011)(478600001)(2906002)(70586007)(6506007)(70206006)(6862004)(82310400002)(54906003)(47076004)(316002)(356005)(8676002)(86362001)(8936002)(81166007); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 18ef5b86-b76f-4ede-0560-08d823c76d4e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IAVQuD6VRLWToPUKwCRMUeF7A6gd8Pw58cnTgC0yM3OMOk00By57VTC5K9D7+qQC0UsN4n3OrhIqWS8b2mp2YzhiGfGyeJ7pJCGqk5U6Gd7RTVn3DOmB5Pe9wZTqV5f9OQt1lazPB2zg+7JCa6QpXtWL3fYpiu8lP2qEPk8zNoE0cD/6ROKqZBMsp8PX6kbA+UCbqqsGi8+uyyshpjutSC66Sw+pHCpGcxlHjBckHYL6+z3DSwAtIjYXiddnU1fU558eg5jcma3/0xCIyWJuc8ecJd4OHFmXs48mITq70c7vyHUWU1wQU5d3YOs3Dd2d9MliwoFlqb/PEn3m1Bz4Pdywyw5X9V83L6sY6QuoykL7u7tXsHXDZmsixM19g0WZe7BO0YcbKUYfUkHFf2lsaA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2020 05:17:58.9918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24be7a5b-795d-47cf-9db5-08d823c771f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5201 Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Harman Kalra > Sent: Wednesday, July 8, 2020 7:41 PM > To: Phil Yang > Cc: dev@dpdk.org; drc@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > Subject: Re: [dpdk-dev] [PATCH 2/2] eal: use c11 atomics for interrupt st= atus >=20 > On Thu, Jun 11, 2020 at 06:24:25PM +0800, Phil Yang wrote: > > The event status is defined as a volatile variable and shared > > between threads. Use c11 atomics with explicit ordering instead > > of rte_atomic ops which enforce unnecessary barriers on aarch64. > > > > Signed-off-by: Phil Yang > > Reviewed-by: Ruifeng Wang > > --- >=20 > Patches looks fine to me with commit message changes suggested > by Honnappa, i.e. using C11 atomic built-ins. > Since first patch of the series will not be backported, so I > think both patches can be combined into one. OK. Thanks.=20 I will update in the next version. Thanks, Phil >=20 > Reviewed-by: Harman Kalra >=20