From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67961A0546; Thu, 16 Jul 2020 18:38:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0E6D1BED2; Thu, 16 Jul 2020 18:38:12 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by dpdk.org (Postfix) with ESMTP id C57371BEBF for ; Thu, 16 Jul 2020 18:38:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYMdvlyrOQCmoLDsJJoF3oDSQXsAn3VAnhlZVA9Bsko=; b=UmSHGwTKqFebXN2vS1tWHOa4biVqo5cL+GlGPyRLumEsquyyz5biVaPJmVvtFUQI7sM6NQE2MLIM1k/z7HxAxWTG+moi6rxpd6/dad2UZcqiKh5rf39Tli14s6Hh0w9EqsMiUhuQTkQo1hzi6igx3V34AQDOxbi0HcJHN2VLdvM= Received: from AM6P192CA0006.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::19) by AM5PR0801MB2017.eurprd08.prod.outlook.com (2603:10a6:203:42::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18; Thu, 16 Jul 2020 16:38:09 +0000 Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::36) by AM6P192CA0006.outlook.office365.com (2603:10a6:209:83::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Thu, 16 Jul 2020 16:38:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Thu, 16 Jul 2020 16:38:09 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Thu, 16 Jul 2020 16:38:08 +0000 X-CR-MTA-TID: 64aa7808 Received: from 38c432acf438.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 15250158-AE08-4202-8A1F-349AD92C20B4.1; Thu, 16 Jul 2020 16:38:03 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 38c432acf438.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 Jul 2020 16:38:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTWGbg5IRhZSzEDPDNHb7c0hQkM2u9tX0e++rkANcTpuiG9LXb8gub80LNhuKWObo4pgaKKx8gegmaDgVtZNA1/HMJfqtNhl6YsQhcFQM8XtoAQQJZF/s8hOzvwUR/zp0pGI7NYgOPkV1rc1FL0Iytb97ZKIaKy7p5KAJTpnAAhcZ+xXFkl+AP14p+1SIHEsTM3k1MXtuJ9+XfBUaEYVGx/1mX4Ltwmgc5+MLxfhx6b0miXwXtVRI85al9SjKByoP+EWeTSNRvr+A+LbtU6tHVLFFnnunSPFVQONvbJefKy3RWUwsuwqOVAYc+0WezCgMoM4+SuIOh+UlpHyCAFikA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYMdvlyrOQCmoLDsJJoF3oDSQXsAn3VAnhlZVA9Bsko=; b=NHgJkcAxQXvUv45jNM9jJ9iKhkEvAEmKmLtfLHRE+rVAkZpV5Lr1wyAHZtQSQs9qx+67RZtH9mUmYIbBPl0O4l0FSD+cn038U4KFkzeaJnUlQ/8nHy/RzbIQ7JvUQDLZrvTorp9PzsMOSQ2vlty+isQtLghUpe3aOU6V/YkLZoczdZFjGX96lBTpOnhanb2d1iAGWOJTmnlewcrmasa28gq4S5qHT0gVjF1P5bwLRmW/Ulh+wEy34aKArgtH8EtLPpAAkawYwGuKY/mD4fWDY3wnzp58MZlYR8glJwhc+IvfwbAkVZeYNl5IlqNheYfTre0jexvqqwMqoRHl4xgFZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYMdvlyrOQCmoLDsJJoF3oDSQXsAn3VAnhlZVA9Bsko=; b=UmSHGwTKqFebXN2vS1tWHOa4biVqo5cL+GlGPyRLumEsquyyz5biVaPJmVvtFUQI7sM6NQE2MLIM1k/z7HxAxWTG+moi6rxpd6/dad2UZcqiKh5rf39Tli14s6Hh0w9EqsMiUhuQTkQo1hzi6igx3V34AQDOxbi0HcJHN2VLdvM= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VI1PR08MB2782.eurprd08.prod.outlook.com (2603:10a6:802:1c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Thu, 16 Jul 2020 16:37:59 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 16:37:59 +0000 From: Phil Yang To: "thomas@monjalon.net" , Honnappa Nagarahalli CC: "dev@dpdk.org" , "Mcnamara, John" , David Christensen , dev , "jerinj@marvell.com" , "Ananyev, Konstantin" , Ola Liljedahl , Bruce Richardson , Ruifeng Wang , nd , David Marchand , nd Thread-Topic: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches Thread-Index: AQHWW17JhtEN78yYH0WNHExzcO0TKKkKEpgAgABCV2A= Date: Thu, 16 Jul 2020 16:37:59 +0000 Message-ID: References: <1594621423-14796-1-git-send-email-phil.yang@arm.com> <1594875225-5850-3-git-send-email-phil.yang@arm.com> <3325015.uBoaBXitGU@thomas> In-Reply-To: <3325015.uBoaBXitGU@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: c18db9cc-5ff3-47b8-9a54-06c307090879.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [180.162.1.103] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f32b6a2f-807e-4e0c-036f-08d829a69f8b x-ms-traffictypediagnostic: VI1PR08MB2782:|AM5PR0801MB2017: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RmN2L7+Wu7cWGGfUuXgioMuDzW6Zh87Tw6Ie/yt9fxQWRMwtfa/aznsHnsJ5LvPiCTDrZedO1+dZI2/m0D3xZ6mofW0GOOXvcckI4ZW0AJUm81WrCZmEhXruByWX/kvsO1LMuaXjFqMrRmv0bpynaO1Fks9XSfHZ6v4vStMm1tX0Q6yKgWdY5eemxKKIr2+LyH7hS3SvZo7uy0UtASXXTqzS18FJXXPoeFnJBPanY2fIzCNC2SS5vHavg20R5UoyNzx02Mgu6Li7+NpfkMcSk2NsZmUgw7mOHqARbA2HfbJQFUC41LrTs3Kvz3lB0VuO X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(7696005)(2906002)(26005)(76116006)(316002)(6506007)(53546011)(8936002)(54906003)(110136005)(186003)(71200400001)(9686003)(4326008)(33656002)(8676002)(52536014)(83380400001)(64756008)(478600001)(6636002)(5660300002)(55016002)(66476007)(66556008)(66446008)(66946007)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: JfdI8eAptmYJwZodWWw0D9Utc6enJNYruLEP9TpC4ssWR8R0VGZbMl029oS+IMzmUwbogfTieJJBJi8VLl/IQ18Peg94I/wVUItvh7OVKtqF7je7r3hgKif+80sjRraH6Gkx6zC194ayi29JBIrwcMHZtG9wenuT68Ur/WxuwNcLTXBE2IX/Kq8+OIv3JHC5dlmcG5E6JMzgCMxdA/ZjjmVbw0YFXWhrCizbGUbExLT1g2izQlfUWmxA4vQky3vEzWxPLjAQvVj5YRcTrO50IG0LOInr/8vjR5lk7L1bXseMxydWmerdz2AtWJatkqTH+kHGvxHevIWjXxsP8+5Mjllj3vPS7Iva+jpRzhaP/2uvzVxOuiXUruG8zVQ40s1gMlx3j/S/23oYKpxB0FYeJbGvOEu/OXkeOK4HPSaWueovmPm9DVOWVnaxkYDQRaPVfTcyPGWzPtJMhZu/oB587Jvl3HcwmpFchnPzxae5bB0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2782 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(136003)(376002)(39860400002)(396003)(46966005)(33656002)(8936002)(82740400003)(5660300002)(8676002)(356005)(81166007)(83380400001)(82310400002)(86362001)(47076004)(52536014)(53546011)(2906002)(70586007)(54906003)(6636002)(4326008)(478600001)(110136005)(55016002)(336012)(9686003)(26005)(36906005)(6506007)(70206006)(7696005)(316002)(186003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: dbfbdb01-cce0-4d04-6647-08d829a699a4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pBUcgkI01SWGrdgbzcfgbbcyOBdBskST0dyCg/jFwFJSsPGFsKejY1nRPDt5SqaRJgmSG049fwN8dKkeqg4F5ahYBHJ+Gd7HOWKf8znQdnjwMmkqiJtFSQKmct7mhtBZ7giAerQItAi2x39J9IoZsSsf7obeWfDHHsmAa+BCMcDcODK82TCcai08EIDwhPQLBIYNejsBG5wv3bYIoz6Ry7yt2BiyFiOnnphvScB8KeWWAd+9rcvbBg0nVzz/1oysiIK37njk7/ddi9GZglS4pYfKOstSpNu4KrBfxooyk8CJ2xSkPP8jOkAFJW+XJb/SDAHh06FztiNK51Xrs0yhiV6Os2/HKe8ozz3vKggNnhr374lNuV70j6rC1YcTy7aiWShAyxJq7DIa6swMYrPesQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2020 16:38:09.0273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f32b6a2f-807e-4e0c-036f-08d829a69f8b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2017 Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, Thomas Monjalon writes: > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomi= c > APIs in future patches >=20 > 16/07/2020 12:48, David Marchand: > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > > check_forbidden_additions() { # > > > res=3D0 > > > + c11_atomics_dir=3D"lib/librte_distributor lib/librte_hash lib= /librte_kni > > > + lib/librte_lpm lib/librte_rcu lib/librte_rin= g > > > + lib/librte_stack lib/librte_vhost > > > + drivers/event/octeontx drivers/event/octeont= x2 > > > + drivers/event/opdl drivers/net/bnx2x drivers= /net/hinic > > > + drivers/net/hns3 drivers/net/memif drivers/n= et/thunderx > > > + drivers/net/virtio examples/l2fwd-event" > > > > I prefer a form like: > > > > + c11_atomics_dir=3D"" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/octeontx" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/octeontx2" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/event/opdl" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/bnx2x" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/hinic" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/hns3" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/memif" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/thunderx" > > + c11_atomics_dir=3D"$c11_atomics_dir drivers/net/virtio" > > + c11_atomics_dir=3D"$c11_atomics_dir examples/l2fwd-event" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_distributor" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_hash" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_kni" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_lpm" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_rcu" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_ring" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_stack" > > + c11_atomics_dir=3D"$c11_atomics_dir lib/librte_vhost" > > > > Easier to read and update. >=20 > Why do we need this list at all? > Are we allowed to add new code with old atomics > in other directories? > How bad it is to have a warning on non-converted libs? >From my perspective, the pros of this list are : 1. Avoid introducing false warnings in non-converted modules. Otherwise, th= e maintainers have to wonder if that module is converted or not. 2. Keep non-converted modules compatible. C11 atomic builtins cannot be use= d directly for rte_atomicXX_t variables. The cons are : 1. The list needs updating every time we convert a module. 2. The script is not elegant as before. Thanks, Phil =20