From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54D3EA04B8; Tue, 12 Nov 2019 07:41:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CEE02AB; Tue, 12 Nov 2019 07:41:05 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40050.outbound.protection.outlook.com [40.107.4.50]) by dpdk.org (Postfix) with ESMTP id D9224237; Tue, 12 Nov 2019 07:41:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Jv9e5TQWSzFyke/6eCg8DOXgNEuFa3mrcHh1RllsA8=; b=EJqDQWTPRR5NicyXy0+wzCfYpr1xMPby+hmJaADRvxJ5NwANEIs/Dbxw+LPNEJLC6VrfEZFfQm852V7HO/gT3rcHYF3JvFW8bDZ9lV3KJ8ob3gQ7HpvLam6ZoWZXRtdf1cC+w1+nZxesuGgaC30wRL6qlLTOfiez4LKjZMagjnI= Received: from VI1PR0802CA0031.eurprd08.prod.outlook.com (2603:10a6:800:a9::17) by HE1PR0802MB2444.eurprd08.prod.outlook.com (2603:10a6:3:df::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Tue, 12 Nov 2019 06:41:01 +0000 Received: from AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by VI1PR0802CA0031.outlook.office365.com (2603:10a6:800:a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22 via Frontend Transport; Tue, 12 Nov 2019 06:41:01 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT008.mail.protection.outlook.com (10.152.16.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.21 via Frontend Transport; Tue, 12 Nov 2019 06:41:01 +0000 Received: ("Tessian outbound 3fba803f6da3:v33"); Tue, 12 Nov 2019 06:41:00 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9092ec3bcf96.2 (cr-mta-lb-1.cr-mta-net [104.47.9.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF4BFFDA-3BAF-4ABA-89BF-18E2B7E0A251.1; Tue, 12 Nov 2019 06:40:54 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2056.outbound.protection.outlook.com [104.47.9.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9092ec3bcf96.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Tue, 12 Nov 2019 06:40:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzBwL/51pveWp0lviNaTKH/j5lz8rrWb6uUTT51RJeGj7KVVo+hFWeAlhH2wxEmGWjfPGj31uN0MFWM5VhVMuABf+dGoB/sYDR6c/DovKTaE8SdzjHTlqNZtcdKs1b5LZgswaSTxYv7oppspiRnPoao1c30M2phNnE88r2VV197AbX6tdOnpcEDtLzXIYdPqcA0MiOoGOE2eLB5WwxE/juxxjbmBEHUI4C0cExtpZ5HQTTTMakUjHz4ydoUsZtsk1tq9X2QGadhdxRyI3at5+tYKLDzzXnb3PkgrOw0NUh3soJ+8BadmEQ8NGMZRAjonOZAjW8rl4cJ+WF17ncq63A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Jv9e5TQWSzFyke/6eCg8DOXgNEuFa3mrcHh1RllsA8=; b=ECY8Xa/hcGwdh/t2GCOI36b6wukzZ8CyQiHgoBipmnN3laq0spnKNSJ0t/RFFd+QAgU6POS131PYmw80p9v5xpv2e4gbsO9/T9b2euXCGjNGSp30iEPzz4lx6oy7zi4oGu9e+C1qL/l/UgD4Kbm0mDtAYDrAz4WcbAd2iSlqkgJQVHcREurlpp2V7Me5Q41bs8GI9O4pj555gXqPdXZn7Vqk7bX6QaaDuvpfpW5R22ZGOfN4xnntHuK5sw+izMVXchjRX5ryNeytL5RB8X+P1Jo0b747Q1G3unU0rlXPivFLGRysa9njhquGmS/+g8aj9nF2/Ye5IEPF7RTdC+ZLtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Jv9e5TQWSzFyke/6eCg8DOXgNEuFa3mrcHh1RllsA8=; b=EJqDQWTPRR5NicyXy0+wzCfYpr1xMPby+hmJaADRvxJ5NwANEIs/Dbxw+LPNEJLC6VrfEZFfQm852V7HO/gT3rcHYF3JvFW8bDZ9lV3KJ8ob3gQ7HpvLam6ZoWZXRtdf1cC+w1+nZxesuGgaC30wRL6qlLTOfiez4LKjZMagjnI= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4655.eurprd08.prod.outlook.com (10.255.27.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22; Tue, 12 Nov 2019 06:40:53 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::3d2a:e5be:952e:541a]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::3d2a:e5be:952e:541a%6]) with mapi id 15.20.2430.027; Tue, 12 Nov 2019 06:40:53 +0000 From: "Phil Yang (Arm Technology China)" To: "thomas@monjalon.net" CC: Bruce Richardson , "dev@dpdk.org" , "david.marchand@redhat.com" , "jerinj@marvell.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , "Joyce Kong (Arm Technology China)" , nd , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture Thread-Index: AQHVmH1n1zu49GwJzkuulAXqP/uuj6eG2hnQgAAyrgCAAAQxQA== Date: Tue, 12 Nov 2019 06:40:52 +0000 Message-ID: References: <1573468461-25972-1-git-send-email-phil.yang@arm.com> <20191111104712.GB1444@bricha3-MOBL.ger.corp.intel.com> <3677391.EzyCDiKdWj@xps> In-Reply-To: <3677391.EzyCDiKdWj@xps> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: db40a125-a0b7-4b62-8866-c36b63837748.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dd505812-a37b-4d30-1b8b-08d7673b4862 X-MS-TrafficTypeDiagnostic: VE1PR08MB4655:|VE1PR08MB4655:|HE1PR0802MB2444: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1303;OLM:1303; x-forefront-prvs: 021975AE46 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(13464003)(199004)(189003)(966005)(14454004)(76176011)(7696005)(305945005)(5640700003)(478600001)(6436002)(74316002)(7736002)(54906003)(316002)(2501003)(2351001)(81166006)(6246003)(81156014)(66446008)(64756008)(66556008)(66946007)(76116006)(66476007)(2906002)(3846002)(1730700003)(6116002)(8676002)(11346002)(446003)(86362001)(52536014)(229853002)(8936002)(66066001)(99286004)(486006)(53546011)(6506007)(5660300002)(25786009)(55236004)(6306002)(476003)(4326008)(26005)(102836004)(256004)(9686003)(6916009)(71200400001)(14444005)(186003)(55016002)(71190400001)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4655; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PCu7mwhkGosELXtwxrOCYd+E9uL8c2srXgPvI8mx/kO1HJXTQX07LpCXY5rGrFKWvoYfcldXKruAtye1+L1lGIi+K/uijF6NkDb4ApHxgbvxUYlUaejgU95xrSl13DtvrC/gme73CN7wxkGi0gX4/88XqraFGlfh6osxDuKSQxK+AFj6uDOKjoisd3iuRxNjsaC66GX7brhsjOFF64lEWql1DgFo5Vuv3Pyi44FWIFYQH1Qo3lBQaMHkQwgQInHejOYDXvkvuOT0EA+lOH5CIgHyCGZ0c7NkN5Kqp4w+CBVHK+QqDGtBI2iU9ZAf5YxeFELXZUQsfn320bRAHOpAyIfTHqzsuOOa4J0PNcOe5vqhnkqMWTvcyeYH0aEfr0790xxdJF0l4+40XfjUqimvfTLZiM1ci7a1cR9QGSqhDgR1E70cMapBk6u0eW9wHMlrJPTgAodVYnW6PiZcZ5Pf/jxNsx4weiUrRASeO5UQA/o= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4655 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(376002)(136003)(39860400002)(1110001)(339900001)(199004)(189003)(13464003)(54906003)(4326008)(81166006)(316002)(46406003)(81156014)(70206006)(6862004)(70586007)(2501003)(1730700003)(14444005)(305945005)(6306002)(55016002)(9686003)(966005)(7736002)(86362001)(14454004)(6246003)(36906005)(8676002)(76176011)(47776003)(478600001)(76130400001)(97756001)(33656002)(26826003)(66066001)(53546011)(102836004)(7696005)(6506007)(5640700003)(356004)(50466002)(99286004)(186003)(22756006)(52536014)(126002)(74316002)(8746002)(2906002)(8936002)(229853002)(2351001)(26005)(23726003)(450100002)(3846002)(6116002)(336012)(446003)(105606002)(476003)(486006)(5660300002)(11346002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2444; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 8bf3c52f-dd8c-42cd-7e0c-08d7673b4393 NoDisclaimer: True X-Forefront-PRVS: 021975AE46 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yQxuY99naQzW1Fb0qpwXlH72F9DMacjx5Vxo7VvUHxdVNiQGx8TF75YLTW27mfwe5kg/s872V+pleKlsc5m4APcNg1JbMmIxBkJV2jxFOVhePJlBSTzpgTmHQbFnsPXD4c7lWvrR2gY1P2PNxw4kNM1S4ksAwYAmt4CUwehd8cGRIQxeOdp7JaiduEQNVqoQeGrr0cDIxSdhUr0fvvTkTv0FTM9jMF+51DbXQ/9kItsftnVhvqDBAkGsTJweaygFpOLgASIrSl/7T5tFcDC0fukbVTEh4by+Nx3uUIA5STRDD8B/Vqwu4cAdj5HcdZwGMkqFc6c/jQ3VSJbZI8TgbcciQ0+u4R8F+3Xu4Bd69j2c6ifRs0KQpk0TjdNiql4XDPqKkLmnUNxE0Rgnsnk+GQUlpg1xNX0YYO/6FFaO+21oOr0YmNrlXJHvSrArd4o/emL0/+oDE/86OWF9m7xo/FSe3m17hARP+qp9jm7sinQ= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2019 06:41:01.0304 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dd505812-a37b-4d30-1b8b-08d7673b4862 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2444 Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, November 12, 2019 2:03 PM > To: Phil Yang (Arm Technology China) > Cc: Bruce Richardson ; dev@dpdk.org; > david.marchand@redhat.com; jerinj@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; Joyce Kong (Arm Technology China) > ; nd ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on arm= hf > architercture >=20 > 12/11/2019 06:25, Phil Yang (Arm Technology China): > > From: Bruce Richardson > > > On Mon, Nov 11, 2019 at 06:34:20PM +0800, Phil Yang wrote: > > > > The older version (e.g. version 7.4.0 ) of GNU C compiler for the a= rmhf > > > > architecture doesn't support the flag '-Wno-address-of-packed- > member', > > > > so remove this flag for aarch32. > > > > > > > > Fixes: a385972c3675 ("mk: disable warning for packed member pointer= ") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Phil Yang > > > > Reviewed-by: Gavin Hu > > > > Tested-by: Joyce Kong > > > > > > > > --- > > > > mk/toolchain/gcc/rte.vars.mk | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/mk/toolchain/gcc/rte.vars.mk > b/mk/toolchain/gcc/rte.vars.mk > > > > index 9fc7041..ec0cbbf 100644 > > > > --- a/mk/toolchain/gcc/rte.vars.mk > > > > +++ b/mk/toolchain/gcc/rte.vars.mk > > > > @@ -100,7 +100,9 @@ WERROR_FLAGS +=3D -Wno-format-truncation > > > > endif > > > > > > > > # disable packed member unalign warnings > > > > +ifneq ($(CONFIG_RTE_ARCH_ARM), y) > > > > WERROR_FLAGS +=3D -Wno-address-of-packed-member > > > > +endif > > > > > > > You don't need to do this, as gcc will not complain about this unknow= n > flag > > > unless you have other issues in your code.[1] I think it's better to = keep > the > > > code clean in this case, otherwise we'll have the code littered with > > > conditionals for various flags. > > > > > > /Bruce > > > > > > [1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html > > > "When an unrecognized warning option is requested (e.g., > > > -Wunknown-warning), GCC emits a diagnostic stating that the option is > not > > > recognized. However, if the -Wno- form is used, the behavior is sligh= tly > > > different: no diagnostic is produced for -Wno-unknown-warning unless > other > > > diagnostics are being produced. This allows the use of new -Wno- opti= ons > > > with old compilers, but if something goes wrong, the compiler warns t= hat > an > > > unrecognized option is present." > > > > Thanks, Bruce. > > > > There are thousands of warnings with alignment when compiling for > ARMv7 (ARMv7 supports unaligned memory access). > > Without this new flag, the build system works fine for ARMv7. So I add= this > conditional for ARMv7 only. > > I agree with you we should clean up the code, but it needs a lot of eff= ort to > achieve that. > > This patch is going to make the ARMv7 target build successfully during = this > period. >=20 > I would go the opposite direction. > I think we should remove all warnings disablement like "-Wno-something", > and clean the code. Thanks, Thomas. I think it is a compiler issue rather than a code defect in this case, as I= t cannot recognize the '-Waddress-of-packed-member' flag.=20 "arm-linux-gnueabihf-gcc: error: unrecognized command line option '-Waddres= s-of-packed-member'" >=20 > If you want to allow building ARMv7, you can just allow warnings as not > errors. > So we will still see something is wrong but it won't prevent from buildin= g. Yes. We did this already, all the alignment issues are emitted as warnings = on ARMv7.=20 Please see these two commits: 79fa5c2a9992 ("mk: ignore alignment errors for ARMv7") 6433c19105e8 ("mk: generalize strict alignment warning handling") >=20 >=20