From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15B43A2F6B for ; Wed, 9 Oct 2019 04:11:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 824521BEA3; Wed, 9 Oct 2019 04:11:02 +0200 (CEST) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-eopbgr120040.outbound.protection.outlook.com [40.107.12.40]) by dpdk.org (Postfix) with ESMTP id BFADE2BAC for ; Wed, 9 Oct 2019 04:11:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=feSDacrMaYbTHLGmydM6HXU8XMWzPKyG1hfnTvX+byQ=; b=pUrONSnJIaRP7GavE1C1rRL142pAvD0joS6VKsJl11SU41QS7psoZg7KrVjqCYBONVVzpoN+qCqRnhCmn550WJLAIzxc9zlWOH1JvmIolzU9yJDwT1OEVuZ0UCf/BBke5imuFm7BnDr72jI0L0NZa9xybeChghdGrNb80yfLxhQ= Received: from DB6PR0802CA0039.eurprd08.prod.outlook.com (2603:10a6:4:a3::25) by PR2PR08MB4668.eurprd08.prod.outlook.com (2603:10a6:101:1e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Wed, 9 Oct 2019 02:10:59 +0000 Received: from DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::206) by DB6PR0802CA0039.outlook.office365.com (2603:10a6:4:a3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Wed, 9 Oct 2019 02:10:59 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT009.mail.protection.outlook.com (10.152.20.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Wed, 9 Oct 2019 02:10:57 +0000 Received: ("Tessian outbound 0939a6bab6b1:v33"); Wed, 09 Oct 2019 02:10:57 +0000 X-CR-MTA-TID: 64aa7808 Received: from b0318c4cfc3b.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.2.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 333D384E-321B-4F34-BE9D-A7F9A791D5C9.1; Wed, 09 Oct 2019 02:10:52 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0318c4cfc3b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Oct 2019 02:10:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XkMJfuVyYesECxTn4olUU2Q4kEp/3hQfBqZKytGTfnCWQ3wyUXB0SPYsacIj/ZFYQMuchyW9exwtyPeg+PWekEsEU+JgNbwYx8A+GHto85URO/8iKCU8Mio8276ZOZjoJhwNcjXRhwAuOABYlPvQaD4QisnDsoZ550tfqomiZLOXrx2n779WZS7j+MZNij9sURwIB1WJBFCx4iAQE0JkPDP6fR88j/hPz4VnO0NI2pxbaajVVOgaFk9gOC7SIpzadnSmBeQlk+L8bwmFh3wvGfvmcLMJvvt4wVE1Wi0yW5navTXYgPDVeb3MAk6/BQBKXKuZd5KiyzLcuNFTbvoODw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=feSDacrMaYbTHLGmydM6HXU8XMWzPKyG1hfnTvX+byQ=; b=baY0BJbxW8LVfQyUbDjnUHJ2BY8YCOMisbQObQNBaAz1OaGfTkJIQ4U+aLevEBqpCF6dG7rfHTb5o99rVVHML53N1rXS73kgo2IbLx4hx5TqkDr9UaHKkx/u3MgMnNkCOnHZPrinmDNy/iym0n+43uhULANH+OTbeEj50zHdu5Gq2D7EkfHKmTHTERDIFNi1q5xDlwYmQcvkR/pvK4PkrbCBkJt/Bsmq0birm1C7uOL7HKMmw9uKWlqD7mwk4m++NnIX4rzEW+89oDy/cEPh0bm3J86ccrwZqdPWBL1g75NYRJaNiv0gGqGFCSiWSJS8+Gh9kczHySL3esvSUWO8Rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=feSDacrMaYbTHLGmydM6HXU8XMWzPKyG1hfnTvX+byQ=; b=pUrONSnJIaRP7GavE1C1rRL142pAvD0joS6VKsJl11SU41QS7psoZg7KrVjqCYBONVVzpoN+qCqRnhCmn550WJLAIzxc9zlWOH1JvmIolzU9yJDwT1OEVuZ0UCf/BBke5imuFm7BnDr72jI0L0NZa9xybeChghdGrNb80yfLxhQ= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB5118.eurprd08.prod.outlook.com (20.179.30.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 9 Oct 2019 02:10:49 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::e57f:3c29:b610:cc3d]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::e57f:3c29:b610:cc3d%6]) with mapi id 15.20.2347.016; Wed, 9 Oct 2019 02:10:49 +0000 From: "Phil Yang (Arm Technology China)" To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , Honnappa Nagarahalli , "Damjan Marion (damarion)" , nd , "Gavin Hu (Arm Technology China)" , "ferruh.yigit@intel.com" , nd Thread-Topic: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier Thread-Index: AQHVfchE+HbsDxm8VkuTzUuCmLTDh6dRkKtA Date: Wed, 9 Oct 2019 02:10:49 +0000 Message-ID: References: <1566817214-26599-1-git-send-email-phil.yang@arm.com> <643c7eb281aa4b1e832f9d7f34af741f@XCH-ALN-004.cisco.com> In-Reply-To: <643c7eb281aa4b1e832f9d7f34af741f@XCH-ALN-004.cisco.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a94faca0-783b-454f-b6e5-fd429680cec8.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 87ceaeba-a2aa-4f18-cd5b-08d74c5dec4a X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VE1PR08MB5118:|VE1PR08MB5118:|PR2PR08MB4668: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 018577E36E X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(376002)(136003)(39860400002)(346002)(189003)(199004)(13464003)(66946007)(102836004)(26005)(64756008)(186003)(76176011)(76116006)(66446008)(53546011)(6506007)(66476007)(66556008)(55236004)(33656002)(25786009)(71190400001)(486006)(66066001)(446003)(11346002)(71200400001)(476003)(86362001)(74316002)(7696005)(2906002)(99286004)(3846002)(6116002)(55016002)(110136005)(14444005)(256004)(305945005)(2501003)(7736002)(54906003)(316002)(6246003)(81156014)(229853002)(52536014)(8936002)(8676002)(14454004)(478600001)(9686003)(81166006)(6436002)(4326008)(5660300002)(414714003)(473944003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5118; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xxRAIqH4PP6hULOHmSmyb7cFuEKe6aNmQEbmfRn3HIAraNszPAuiARI997t1/LsjW+QR6ocjI9F/H/Fwg+Zwhr8DdzAqInQVuVtL1AmT+jqLgNyufebmlyopFA8SnUPRyJaet7M9La7mOMh4RMW1T38wLgKvd07nkQIMRxykWWpBeJWJ6xrom458nV28aROk/l/47ciB7gnElbuHerXhWRmT452qHOm5xRnbZgSDxqqkHGMYQSVllWwucvgbK+r6/0utT1bQEDW66w1x3BdHq+6dF8K1v8BXVSKNjiak2hCyEhZ3BUwNB8Ftc6nv01mS3NpfQwH5JM8NDyXmm6MJ58afwHm//j9mU05pEBDX8mi5JStJNVMIOLiakbR0mjTZR5mRuzsnrc7HmP+9LUy2Bo3ImPk5fRzf4K3daAsNURY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5118 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(396003)(39860400002)(136003)(13464003)(199004)(189003)(81156014)(81166006)(8676002)(9686003)(52536014)(229853002)(55016002)(8936002)(8746002)(6246003)(5660300002)(25786009)(33656002)(486006)(46406003)(22756006)(2501003)(102836004)(4326008)(63350400001)(110136005)(54906003)(50466002)(26826003)(126002)(26005)(11346002)(446003)(476003)(14444005)(76176011)(6506007)(53546011)(66066001)(305945005)(99286004)(70586007)(86362001)(14454004)(74316002)(3846002)(7736002)(356004)(7696005)(97756001)(186003)(47776003)(70206006)(76130400001)(336012)(316002)(2906002)(23726003)(478600001)(6116002)(414714003)(473944003); DIR:OUT; SFP:1101; SCL:1; SRVR:PR2PR08MB4668; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 15a62dc1-8ec2-4065-3d06-08d74c5de74a NoDisclaimer: True X-Forefront-PRVS: 018577E36E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K9F1QSjlvBCdDUVjRCuWQHrM+lcdLmaXQL7ePaeTG1bhbKICJkWNc52KxMc/80ojUXL1/PcN/RMhhKJjy6p/bL9BkndjpQRif5axbuifyaFS007SSK+4oSjcuG8Jn7M6WLD5pku2kduZjBRHuTcDh5vO56/j6xKSw+sgUKBt8J09uNmksRCO30Yr4+DlSZU1DwgqOFwG9f+6UQBYhL8ZakXtbQ/8ZUvBqpQLM4R4QHIDCpEMawjjUM+YsXz7fkX5IlzhDmZH2hJdQiTwu3n92gt8m/wXPS2d0graoMoyOwEWZUojM4Ta5TGRGjZTISuTjQzYGpEqT4n2vWWBAx2MA2dejWIoMdUYSQLKjtN5N8pd5H9YLY2SvEWlWPyquv4jkg4xqhzYx0Nio7T85n015MdeoY6eshHIaKhAgyH+cPc= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2019 02:10:57.5718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87ceaeba-a2aa-4f18-cd5b-08d74c5dec4a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4668 Subject: Re: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > > Sent: Tuesday, October 8, 2019 7:05 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: thomas@monjalon.net; jerinj@marvell.com; Honnappa Nagarahalli > ; Damjan Marion (damarion) > ; nd ; Gavin Hu (Arm Technology > China) ; nd > Subject: RE: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way > barrier >=20 > > > -----Original Message----- > > > From: dev On Behalf Of Phil Yang > > > Sent: Monday, August 26, 2019 7:00 PM > > > To: jgrajcia@cisco.com; dev@dpdk.org > > > Cc: thomas@monjalon.net; jerinj@marvell.com; Honnappa Nagarahalli > > > ; damarion@cisco.com; nd > > > > > Subject: [dpdk-dev] [PATCH v1] net/memif: optimized with one-way > > > barrier > > > > > > Using 'rte_mb' to synchronize the shared ring head/tail between > > > producer and consumer will stall the pipeline and damage performance > > > on the weak memory model platforms, such like aarch64. Meanwhile > > > update the shared ring head and tail are observable and ordered > between > > CPUs on IA. > > > > > > Optimized this full barrier with the one-way barrier can improve the > > > throughput. On aarch64 n1sdp server this patch make testpmd > throughput > > > boost 2.1%. On Intel E5-2640, testpmd got 3.98% performance gain. > > > > > > Signed-off-by: Phil Yang > > > Reviewed-by: Gavin Hu >=20 > The patch is looking good, but 'MEMIF_VERSION_MAJOR' in memif.h needs > to > be set to 3 as ring pointers are no longer volatile. Updated in v2.=20 Thanks for your comments. Thanks, Phil