From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB7ECA00E6 for ; Thu, 8 Aug 2019 05:44:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D63DE2082; Thu, 8 Aug 2019 05:44:56 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130040.outbound.protection.outlook.com [40.107.13.40]) by dpdk.org (Postfix) with ESMTP id 08E61F04 for ; Thu, 8 Aug 2019 05:44:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8hFMpngpicbszVDPmBEg/hSlCNa2Y7BelVheERUSJDI=; b=pO8jEouIs7a2VWlnzaIqmaxfz9Wnk95XOYasy9cTAt/rV8kZs5W0W4f/PPPVvPhSNk08iQAYBhhqu4OqgQuvKTQZh4nGs47j9GLspx7V3l1FQ+qiAQxfnxrU8zEoxwMZqz++gxFp+FiwzCg65K7KNoNU4VYmOXYwb/8T+5WSP+0= Received: from AM4PR08CA0065.eurprd08.prod.outlook.com (2603:10a6:205:2::36) by VE1PR08MB4958.eurprd08.prod.outlook.com (2603:10a6:803:110::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.16; Thu, 8 Aug 2019 03:44:53 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::202) by AM4PR08CA0065.outlook.office365.com (2603:10a6:205:2::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2157.16 via Frontend Transport; Thu, 8 Aug 2019 03:44:52 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Thu, 8 Aug 2019 03:44:51 +0000 Received: ("Tessian outbound 1e6e633a5b56:v26"); Thu, 08 Aug 2019 03:44:49 +0000 X-CR-MTA-TID: 64aa7808 Received: from 17695dd48e17.2 (cr-mta-lb-1.cr-mta-net [104.47.5.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 54F71A7C-8284-4F45-9D45-A9007BD649A7.1; Thu, 08 Aug 2019 03:44:44 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2055.outbound.protection.outlook.com [104.47.5.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17695dd48e17.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Aug 2019 03:44:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUFPI4BwU+P0BP0Nxw3Zb/f2mQwC05rh1mY6uNBcHnh8zeoSda60cyCwLwTMiULVXAoVsWB97VcwVV41Jr/ENnDVP7go12CZiORP9HzkCl65fggbkwW2Fxnn+WtJdRobMbh3kVi5Pmqezc87uiWA6gWJdVZOsx9VgLRYVGRrbFgjpJHQxu9GrsCsf8KhBhXSMllMk/yJWxJpJX69f1uvM+fdXOKpSTse828UYxTEwg2kffXEija9Ohd9ss2ScbVIE0/U6rgLDMJqTWsZoZ370FtnhZEgzTyjpmFtpZp5NjRg0qhJziZxlu6Nhnneq78abHK52aw0C1D6o0vRZt55QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8hFMpngpicbszVDPmBEg/hSlCNa2Y7BelVheERUSJDI=; b=KzeeMwVeCmTG1DtpmOWtFiHToPcBzwJPxy4bhIsZX1e5Fv60+I6wPvCnve7lopI/Fm1+6S5kuy0dOPZruBqp1+I7Am0zbjPTW7gdtJceYBsoU+RZihE/ixi9QCDSMydF+EjSTDhd2sfO+im//pj8N/fTuq2uPWYZJz2/Fw0URzSJhAb2uzfj2Sf4RHTHTNGqdB9e/Db7tA/f9YpwrtRlYKoVXUJOJg64QNVjd6v+ZUDCHUy+SeYQgvhljdt2J01n1A4SQdWRZLdg3c2KfzB6XejcAuIF3sGo95HI/zYGKcnxijpTQfWeBV2Tc9+nw3z2VXrHqTK+ucqa98PWGV4azQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8hFMpngpicbszVDPmBEg/hSlCNa2Y7BelVheERUSJDI=; b=pO8jEouIs7a2VWlnzaIqmaxfz9Wnk95XOYasy9cTAt/rV8kZs5W0W4f/PPPVvPhSNk08iQAYBhhqu4OqgQuvKTQZh4nGs47j9GLspx7V3l1FQ+qiAQxfnxrU8zEoxwMZqz++gxFp+FiwzCg65K7KNoNU4VYmOXYwb/8T+5WSP+0= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB5181.eurprd08.prod.outlook.com (20.179.31.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Thu, 8 Aug 2019 03:44:41 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::e5ba:d190:d546:6ee3]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::e5ba:d190:d546:6ee3%4]) with mapi id 15.20.2157.015; Thu, 8 Aug 2019 03:44:41 +0000 From: "Phil Yang (Arm Technology China)" To: Aaron Conole , "dev@dpdk.org" CC: "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH] test/mcslock: wait for lcore completion Thread-Index: AQHVTTCeECSjEgAYNUGOVN0PDbx87Kbwmywg Date: Thu, 8 Aug 2019 03:44:41 +0000 Message-ID: References: <20190807145844.23670-1-aconole@redhat.com> In-Reply-To: <20190807145844.23670-1-aconole@redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 439fcd5b-2968-4653-8323-0056cdbed650.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 848eaa04-4205-4f1e-0205-08d71bb2c4b4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5181; X-MS-TrafficTypeDiagnostic: VE1PR08MB5181:|VE1PR08MB4958: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:4502;OLM:4502; x-forefront-prvs: 012349AD1C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(396003)(366004)(376002)(346002)(51914003)(199004)(189003)(13464003)(6116002)(3846002)(74316002)(102836004)(25786009)(66066001)(2906002)(14454004)(186003)(55236004)(26005)(316002)(7736002)(53546011)(110136005)(305945005)(4326008)(81156014)(81166006)(54906003)(8936002)(8676002)(6506007)(256004)(14444005)(76176011)(478600001)(486006)(5660300002)(53936002)(86362001)(99286004)(6246003)(2501003)(476003)(52536014)(33656002)(55016002)(446003)(11346002)(71200400001)(9686003)(7696005)(71190400001)(66946007)(66476007)(66556008)(76116006)(6436002)(66446008)(64756008)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5181; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: ezwS5hnkEzHlchUnXJXa6ThKFATzedNUipXXoxJXC+WRj7k8MUBfgxWd548ZdRsNxQjHm3XPuCxGtklbjlNAMRfdeSz5PuKFQJWTZJHY2oTbM1OAftujxClskwZoWWhSfFivSL7MCYtRmbN29nkJs/R/8e8r0Cj21dWhyV3/nD21K5lJDnmetLeNRJ0shggkaJ1G8M6ZGFF+Z68PhATmNANYxMzsfGfITI4L+cw3SOv3gUwhQ9Lw+MU7HcQZyScPkPgRAy85WNhCmvahPHxLXKc+eMlWMO7tqqqNjIYdW/KyKeyIQGaphFTJuWMWG6vr9WnycALk0JuhlXhgb4ynr9gLITaiokZ7fQFcx5LJ7MqSEaObdcnoq3RKU1vqJ9ID/jk9+GiuX8b+rRTD8t+xZsQ7lhOkW9Zi1mjfg5QAd1I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5181 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(396003)(2980300002)(51914003)(13464003)(199004)(189003)(63370400001)(486006)(25786009)(63350400001)(33656002)(86362001)(126002)(476003)(99286004)(14454004)(97756001)(22756006)(26005)(14444005)(478600001)(7696005)(54906003)(55016002)(70206006)(70586007)(5660300002)(2501003)(110136005)(76176011)(26826003)(81156014)(316002)(3846002)(8936002)(8746002)(36906005)(6116002)(9686003)(52536014)(7736002)(76130400001)(305945005)(66066001)(229853002)(81166006)(47776003)(23726003)(2906002)(74316002)(446003)(336012)(186003)(6246003)(356004)(6506007)(102836004)(53546011)(11346002)(50466002)(46406003)(8676002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4958; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 83723c5f-faa6-46dd-719b-08d71bb2bebd X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:VE1PR08MB4958; NoDisclaimer: True X-Forefront-PRVS: 012349AD1C X-Microsoft-Antispam-Message-Info: u9TzuBMZ8x+1JZkh1GtoUrhXkfgz+pRbU39u2mAvCGKvrjciYZGszm4Lx2/FWv88pS7u0rab2sz4r3yvOJmB326uNMGZfc8A0mDp/ccXfubq+9g7EXGoQQE+BFvKskXhcb4GN2535yftJtnNJTemdwmGXQnjAGIaukGyVWAHOu1z86+TPkj4uCD/EQ6anO4OrvJzo9M5ZG+7+tiLidgJb4afmFHRo6W/TsmF+UTdJOictqP0Su/5goPJvnWb+vSkDGN3nQUvGktn5JUgE9tu75A1ulZROnYA7rMZSkHW3psXup013JwmRsOsXA/S/oEQVMqg0lkVLJZttstbRwEk8wq85CkqvBWOTzAfMa193AcF0WtohT8ybh32kQ42W+GVU/tH4py8CmZCuglmgECAhEPTzMXc1Pd0Btbqe4MuxGc= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2019 03:44:51.3153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 848eaa04-4205-4f1e-0205-08d71bb2c4b4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4958 Subject: Re: [dpdk-dev] [PATCH] test/mcslock: wait for lcore completion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Aaron Conole > Sent: Wednesday, August 7, 2019 10:59 PM > To: dev@dpdk.org > Cc: Phil Yang (Arm Technology China) ; Gavin Hu (Arm > Technology China) ; Honnappa Nagarahalli > > Subject: [PATCH] test/mcslock: wait for lcore completion >=20 > It's possible that the mcsunlock occurs before the test_mcslock_try has > a chance to execute, which will result in the trylock being successful, > making the test case fail. Fix this by waiting until all lcores have > completed their test before unlocking the master lock. >=20 > Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") > Cc: Phil Yang > Cc: Gavin Hu > Cc: Honnappa Nagarahalli > Signed-off-by: Aaron Conole > --- > app/test/test_mcslock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test/test_mcslock.c b/app/test/test_mcslock.c > index ed384b81d..e9359df2e 100644 > --- a/app/test/test_mcslock.c > +++ b/app/test/test_mcslock.c > @@ -225,8 +225,8 @@ test_mcslock(void) > RTE_LCORE_FOREACH_SLAVE(i) { > rte_eal_remote_launch(test_mcslock_try, NULL, i); > } > - rte_mcslock_unlock(&p_ml_try, &ml_try_me); > rte_eal_mp_wait_lcore(); > + rte_mcslock_unlock(&p_ml_try, &ml_try_me); >=20 > /* Test is_locked API */ > if (rte_mcslock_is_locked(p_ml)) { > -- > 2.21.0 Thanks for the patch. Acked-by: Phil Yang