From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDFBEA00C5; Fri, 8 May 2020 04:48:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFCA91DBE7; Fri, 8 May 2020 04:48:56 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10042.outbound.protection.outlook.com [40.107.1.42]) by dpdk.org (Postfix) with ESMTP id CADC41DA02; Fri, 8 May 2020 04:48:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bXCDhsmQll2hbae8/D/sWdKIsEIcIu/bqlOKcPu5mNE=; b=lHh82An8mOeZ1i2snjjSxZM35mvRkfe46zGnWI5OU+dEnaB6iKHajEMGjejpRHDmqcalSRyFRlp9r4+hvDrOc3co2+dq92Hn7DwJJx4SFwAi8f9m5b94whMP9ucxzuoTfLaHRgDdIH5fmz2YqRRk0Dk/ETfOoFF9FhOkxkSrLe8= Received: from AM6PR05CA0025.eurprd05.prod.outlook.com (2603:10a6:20b:2e::38) by AM6PR08MB4119.eurprd08.prod.outlook.com (2603:10a6:20b:ad::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Fri, 8 May 2020 02:48:53 +0000 Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2e:cafe::7e) by AM6PR05CA0025.outlook.office365.com (2603:10a6:20b:2e::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Fri, 8 May 2020 02:48:53 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Fri, 8 May 2020 02:48:52 +0000 Received: ("Tessian outbound fb9de21a7e90:v54"); Fri, 08 May 2020 02:48:52 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0de1dadc7037.4 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6796B728-E8B7-4908-BC28-3F06E6B65167.1; Fri, 08 May 2020 02:48:47 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0de1dadc7037.4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 May 2020 02:48:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdNDVZv9aUUaeCTjN6Y4N2qw7PqqKIRzqZaMpVAij8xSc/MHrTT6657XdGtqMIVRgJds45bAZFYz5voaKGet+/C+aZ+NDtSl2seA+4NmhgoxX1VgO+ICpvTfYTAk46xQIFxlLuiGAqqAYwdR20W64HlrpfZJ/arjt9Xu70CppNwvf0W1+w2FFFlfsNgn0HhsQHpo0tskR6OWQhamb11g6M9ecWUyMycn40909VGlAw02Hfx3HxUp+e76DeAMjphSSqbv8E8UQ48UdCwpRh1nGNSt5CtQzy7iMcD5+yyn8jMAWMYsZKcw07i2xlxruWj8Loefxt/znpBPZvAzTrWF0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bXCDhsmQll2hbae8/D/sWdKIsEIcIu/bqlOKcPu5mNE=; b=JIfpQkDIO0BHzhjihy8iiZnAzs4TM72jKrv7OHwbSuX6S4/MFmjI4xIrv+hOmbGdRSU0AvDMYy+2KkA7QM8UlSsBHJu7W4rnleKPvEAWuc9/24JgjiDJqbnqWRQyEqMmEjFF3R6frs6P2cWkQryt+QU3y4T0PdaEBBvye/hgJmnZGVsFiFLDNqZizSVge+DPgdI28FDY2wGgM682KulysRBVPUWdlJqSiV6nz/nUGh2mOJ7I3ykKmwPOVrCVSMap2owCNSW2xQA5EqF/zKJHPhlKYjt/cMMurtwrB9MRRkzJyfwr7tidS7yPP48Me/2+QupaRoeopxXB66T1f9y6wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bXCDhsmQll2hbae8/D/sWdKIsEIcIu/bqlOKcPu5mNE=; b=lHh82An8mOeZ1i2snjjSxZM35mvRkfe46zGnWI5OU+dEnaB6iKHajEMGjejpRHDmqcalSRyFRlp9r4+hvDrOc3co2+dq92Hn7DwJJx4SFwAi8f9m5b94whMP9ucxzuoTfLaHRgDdIH5fmz2YqRRk0Dk/ETfOoFF9FhOkxkSrLe8= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VE1PR08MB5054.eurprd08.prod.outlook.com (2603:10a6:803:10d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Fri, 8 May 2020 02:48:44 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::785b:54ca:be80:7b66]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::785b:54ca:be80:7b66%2]) with mapi id 15.20.2979.028; Fri, 8 May 2020 02:48:44 +0000 From: Phil Yang To: Phil Yang , "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "wenzhuo.lu@intel.com" , Ye Xiaolong CC: "qi.z.zhang@intel.com" , Lijian Zhang , Gavin Hu , Honnappa Nagarahalli , nd , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports Thread-Index: AQHV/di4+EOeTBKKukKjM+pL3geqT6idyf1w Date: Fri, 8 May 2020 02:48:44 +0000 Message-ID: References: <1584600111-17412-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1584600111-17412-1-git-send-email-phil.yang@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5d97e06c-6fd4-46bb-b999-b2ad15ca160b.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1cb830f4-768c-4a16-a9ae-08d7f2fa57de x-ms-traffictypediagnostic: VE1PR08MB5054:|VE1PR08MB5054:|AM6PR08MB4119: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4502;OLM:4502; x-forefront-prvs: 039735BC4E X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ATQa0d7EU8hpqo43tu4CThzgse8umru+iMXdp9aRD+7fk6X45kxWHrdq4C1LrVxlhObCwGzbhlk3jgL7sHRzU0JQZn1a04Q8BuPjtQbPXBEdZ9V2Tgg2arBzbPI/Y83wbMaAGTG8KrvVc3pi6G2g96buS3M5jJi5FVwHGualiEpXegvK+PyCnC2A+wMzJpccwM7hj4Ic7sflBsn9J67h2ZL5NDNWLM3n+174qKYG8W48wij6bgyKFxlXD6/w9Quh9Bj9zdCTkU/CLCAvbcx3otn2L7bDUpSvI3pUzXy2CINpAAsgifNHizGcOJmDuUSJGHAFII0O74E2vbByx4QKIIT0onKBsnlk7u/Hz1zwf2SVsZzNLs/IyWvW0VPjlSiBmC0CM3qtqKGZ0g+g7bSq+nOiXYawQXQROKSEhMFOM8zeE6dMYAvoGMVr9l6tv0gUS01PIBxKBUze08oFTXOiTA0fRPqLH81aSCuGh32yBmh+aoCBpC75obtI1WV88EX+6ilX0/aZszYIyw7tTQWr1g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(366004)(376002)(396003)(39860400002)(136003)(33430700001)(76116006)(66556008)(55236004)(2906002)(66476007)(71200400001)(86362001)(5660300002)(33440700001)(478600001)(66946007)(54906003)(66446008)(110136005)(316002)(83300400001)(83290400001)(83320400001)(83280400001)(83310400001)(64756008)(8936002)(186003)(7696005)(52536014)(26005)(33656002)(6506007)(4326008)(55016002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: /nlCSU7+8Cu3nKttG9S0kPA5LYAKcbP+v8d15xqNZpT4avxWiRkUolqNbdyHg8UYVzT4YvB44426s1tcqdeAaRYauvUlp2OMFwjQNHpkAHszRulez9yyJmLOQq8kOryFVOTL48X/yUtwTgDft6xrQE/1Kp2Afhm1mld1Y9xcQ5y3AmqAw4sv4zEKJ6M8ufdF85GM0Yk1zdV1zqe1nPklmXmVtkdUMnovYEBdIsBCAW++b0HgGAtQ1Fix06cWiByayYqqf70iCqN7uNvnT0MSgZiGHw9/7lUGVxC931fjstE/+142iQTuH83I6RRmAhrecD8lnJFLIktYkuTGSwksjzHsSM/8fJwr8CGJesHZImeJqjKzYeIwOSEo9FnRBOCHrnWxReSLwkmXEjZfURXMqDGcr1QtLQOja7c/RZCqpZwg2MeZimuvpG+GRqfhLIH1n85g/e1LPe0UZjiSSuM385WXlOcEfFKTiwMUhWLe9iE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5054 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(46966005)(33430700001)(55016002)(9686003)(33440700001)(81166007)(82740400003)(356005)(47076004)(82310400002)(5660300002)(8936002)(70206006)(70586007)(186003)(2906002)(26005)(36906005)(316002)(52536014)(86362001)(7696005)(4326008)(336012)(54906003)(110136005)(478600001)(33656002)(450100002)(6506007); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 91f261cf-2ccc-42c1-2756-08d7f2fa52d8 X-Forefront-PRVS: 039735BC4E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oc3XnAxSQx0ZU9eRoFyyQy/1m/xqFqkdFVeX56LhtN2v+xLCXapfoWhwXPP+58xNZXPaqkVY965Sg5ngdVkMnQGVEcO7x+S9xW92R9m4uMfMBESrGZZJzI7Rc8dsFHkFYttXkGLvVGG7qg2QQeEi1CqMwPYA/N4ZBw8al0QAE8Qv4qo2Kw8Zs1RrpBl3gV+5xHMgcEzvHllxci1bdbc3XuT2Dj10Z0ztAzu+ugSG1rzzh3fC4t6PcpO5VkkU4Ps6lhgXcmCRYka2rd+DpJVdL2bYfqn4/Txnb6AEnOrQTVTDSIbQyCWTvhrpBfjOEmRpurSgLZtn58ONCC3iqS+Vs67S6gySvvWvCR3eWgj9QioirgILamSlpDobadmjfNQN5CIrszvjZ8jhbPbOn9X9YWfhZGrgb4oRF2zzGKUwdHMN0WoDqhqzAu1n5i5C1agfdvYwsoOHJOI6fL6NCEoM+QGuLe15dwn8IDzsP0ZBUkKXpKsxky+CeVW65JHsLrxQ42I9Szf9QkQJpp0nyb4z+LU54J0v4zed+51tiH/FloU7PZvdZy0W/etBvFQmLGM4WkVR8tjMjHKfUd6aOB1L4g== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2020 02:48:52.4341 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1cb830f4-768c-4a16-a9ae-08d7f2fa57de X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4119 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fib= er > ports >=20 > With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it > is possible when a port is started to experience a timing issue > which prevents the link from ever being fully set up. >=20 > In ixgbe_dev_link_update_share(), if the media type is fiber and the > link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback > to ixgbe_dev_setup_link_thread_handler() is scheduled which should > try to set up the link and clear the flag afterwards. >=20 > If the device is started before the flag is cleared, the scheduled > callback is cancelled. This causes the flag to remain set and > subsequent calls to ixgbe_dev_link_update_share() return > without trying to retrieve the link state because the flag is set. >=20 > In ixgbe_dev_cancel_link_thread(), after cancelling the callback, > unset the flag on the device to avoid this condition. >=20 > Fixes: 819d0d1d57f1 ("net/ixgbe: fix blocking system events") > Cc: stable@dpdk.org >=20 > Bugzilla ID: 388 >=20 > Signed-off-by: Phil Yang > Signed-off-by: Lijian Zhang > Reviewed-by: Gavin Hu > --- Ping. Thanks, Phil