From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69158A0597; Wed, 8 Apr 2020 12:14:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F8C91C02A; Wed, 8 Apr 2020 12:14:57 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by dpdk.org (Postfix) with ESMTP id 552461BFC4; Wed, 8 Apr 2020 12:14:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zlNnC6a/9nqUZSeuBy08sYu+PyBPx7Vt25n5aXjEtk=; b=yXRPrCduKp1uYi1g4SlzhB/rGalmNHkHMxD/QH89OMNaVmKNRRzCTYTZ7ZEtcn1pEnpV0TKJXySxK6IjwLf7RQ9QgnvxRlHbjDS7dMYGSIxaDZyjpw0cKGAgG+s4Re879fBeDcKlrPTa8VKWs0cYxNORWQyi2mG4OV3I5SJC/NI= Received: from AM5PR0402CA0007.eurprd04.prod.outlook.com (2603:10a6:203:90::17) by DB7PR08MB2953.eurprd08.prod.outlook.com (2603:10a6:5:1b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Wed, 8 Apr 2020 10:14:55 +0000 Received: from AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::9) by AM5PR0402CA0007.outlook.office365.com (2603:10a6:203:90::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Wed, 8 Apr 2020 10:14:55 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT045.mail.protection.outlook.com (10.152.17.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Wed, 8 Apr 2020 10:14:54 +0000 Received: ("Tessian outbound e2c88df8bbbe:v50"); Wed, 08 Apr 2020 10:14:54 +0000 X-CR-MTA-TID: 64aa7808 Received: from e6f0ce9cd55a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1E2453F3-915A-4560-B4EA-11A19D9ADE73.1; Wed, 08 Apr 2020 10:14:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e6f0ce9cd55a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Apr 2020 10:14:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYNDn2CgAItMSU7H/tPGwnUm0k4JWUG8bU15uSe+se/IwJgVcwk4sSzf2r5EdrabWf2BHbWVh9TLTIEwz49t6gamCsxE1nfLTI1EAncdlaneFrzO5u47dNW8k/0XHKyZsgcMpyfPUOwGfXimY69UqRhkgXKEX9AGpy+ocxlS9PVPMRzBmYCC2/v44hl5v8hUKGmkB7SqZshGlXcJY1P4E99HXTH+qUJdUWY0gE/KOH80Y+kKfbhNZXoVRnwS4ZE9EIKVocISvSE1pGgGD5OF4SHmJRmHOm4xrYAfGX3PKb3vAdD6ywoUt62KRMll4c4hPsK4xRjU6d9iS+yWSFvKPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zlNnC6a/9nqUZSeuBy08sYu+PyBPx7Vt25n5aXjEtk=; b=QPRtoaOxUfZfQ8HOH8KI1R/t7h4VTNP749rpeh6vqa7eBcLnk+ur+cF24P1qiLk247jaF1YBc095OaVJ6ARRBUT+zuzd3RrA0H+vg+QdMmMW77ZNUpRp5jOaYLmk9BPu+BsW3bQIhpsfLscy+CVJQVOrWc4Ru9CwVn9kGTm8p0RYD6PsxCbjAvVRgIBNKfBI0UY6LmPjuCEg7vdOqCEFF/dpWj5F4XBLzWwwqyBon9Jr/vka2jlOtRJO1bh3KVUHw3SZfg1CS9ZCc31dFc54tG8KLzqrDQf38irwefoAjVA/frOus5XP/EBS758jADetz8Gxnl6xf2xKRAQJ35JwYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3zlNnC6a/9nqUZSeuBy08sYu+PyBPx7Vt25n5aXjEtk=; b=yXRPrCduKp1uYi1g4SlzhB/rGalmNHkHMxD/QH89OMNaVmKNRRzCTYTZ7ZEtcn1pEnpV0TKJXySxK6IjwLf7RQ9QgnvxRlHbjDS7dMYGSIxaDZyjpw0cKGAgG+s4Re879fBeDcKlrPTa8VKWs0cYxNORWQyi2mG4OV3I5SJC/NI= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4687.eurprd08.prod.outlook.com (10.255.113.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Wed, 8 Apr 2020 10:14:47 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::7df3:e3c8:54f7:57c2]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::7df3:e3c8:54f7:57c2%6]) with mapi id 15.20.2878.021; Wed, 8 Apr 2020 10:14:47 +0000 From: Phil Yang To: "Van Haaren, Harry" , "thomas@monjalon.net" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , Gavin Hu , Ruifeng Wang , Joyce Kong , nd , "stable@dpdk.org" , nd Thread-Topic: [PATCH v3 07/12] service: remove rte prefix from static functions Thread-Index: AQHWCa8i/SAa9HDi+U+lvhwYc+fWhahvBQ/Q Date: Wed, 8 Apr 2020 10:14:47 +0000 Message-ID: References: <1583999071-22872-1-git-send-email-phil.yang@arm.com> <1584407863-774-1-git-send-email-phil.yang@arm.com> <1584407863-774-8-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 297d64c1-48f2-424d-a814-0908c32a2aa3.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [58.39.116.39] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: fcfe7a0b-abce-4f3a-8f6f-08d7dba5aeff x-ms-traffictypediagnostic: VE1PR08MB4687:|VE1PR08MB4687:|DB7PR08MB2953: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 0367A50BB1 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(55016002)(478600001)(66556008)(66476007)(4326008)(71200400001)(26005)(110136005)(54906003)(316002)(5660300002)(9686003)(2906002)(66946007)(81166007)(64756008)(86362001)(66446008)(52536014)(76116006)(186003)(7416002)(8936002)(6506007)(53546011)(8676002)(7696005)(33656002)(81156014); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: q9ftWX681swsbvqKqBuxLX+gAfJC8ASyXNJCFVUNordel9iOBxbRJr5mrQT6URvS883qSfJco6E3hIA7+dS3A+saGwYQejH9SNDlgegJ1Dh9AxLmh8y3IVADhkZj6P/Ez7wMYtwjgcjTNJnEvvE6ek2+eVTJ5bf/aMRzkfev21HOTGLMuYRW+atGOGzzflyUrarO0jTFfg40UOAy6mhb53cUuXKpJ/3epk0t9VjEBjcISnu3g9hbOl/41bKNtrZ/WN6u0he/VgBtvuXmxcThqQ8q07cBrkiTKSkrYVarXLjivLl+GObzo7gS1rF4DYANAmHCTpAdLU2QhcbhXW03CqDt3OpUCnfOkI52AVHuH4HsBcdPMbX5iOZ6LuYkLeVoH3hBKXgCb6QRRkyIEFRsa/Qbu6I0wqqXO3Up64tBu/fQ/XY7ypECYVoRnQ6ewRIw x-ms-exchange-antispam-messagedata: DznXRX0dQ6bLcmP86zXQ21xShYwFJM1IbAUk6mGz+7NM2m6OF2gugce0y95oPSRNyiChyHhmdwxD/l1/zWHARJ4uXUsx8EssxcqY5J6s5E49ZMiJIevpD8+wo4mRUrOwimSD2T00Riwmyp9Hbh0rQg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4687 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(346002)(396003)(39860400002)(136003)(46966005)(47076004)(7696005)(336012)(26005)(186003)(70206006)(55016002)(52536014)(82740400003)(81166007)(9686003)(5660300002)(8936002)(8676002)(26826003)(356004)(6506007)(53546011)(2906002)(86362001)(450100002)(81156014)(478600001)(33656002)(70586007)(316002)(4326008)(36906005)(54906003)(110136005); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 071994fb-1011-4ab6-a653-08d7dba5aacc X-Forefront-PRVS: 0367A50BB1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J4DEcHnw6mxGLLWluD02SI8OFM9l2MQypoX0t4iozBHwijWpnBgNwTnBbH8j8LxeVulfblHWsjIG776DY9KsDc6Tois/+hxZZRTAduLROe8ru70KdUz7QpKy2ARwLqYMH2Xp7BbeYE3ZWgVRm92DxrwDG3n56EnmKxxRdd5dKoAVlQakkPH/jBoyIt6pDT8VBPwnb1Bg2NmbbKortI2+OR7C5KF/Mlk875/0PnpfyyRzlwuiP8gOYO/lie84s9ZUUzsAIPvAPFbYWe+51AXWpl+QH1nl2A2VIyytXzm9VY9W3bBW43rCe6iMeG+9yzY0z3gIoTRQ0Js+x1EVwwb5BFNTFUSeHCb9eGPpalW3UZcS9gFeYhh+8uUNAjASqwgBuIYnrFN64+w3GOCzahwuNTt8yx/aAxDK1J7Y4SwMCHxt7DbC4oK2KnWO72Ul/Ix3fzWDJMNhpPTgxRx1rNclRL7WaGEN4ftMkWkg/uUY8SWwnZcESt3g9kcvS9y/JW06OWn5e1mXyoZmOJgD3VtvOA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2020 10:14:54.7514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcfe7a0b-abce-4f3a-8f6f-08d7dba5aeff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2953 Subject: Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Van Haaren, Harry > Sent: Friday, April 3, 2020 7:58 PM > To: Phil Yang ; thomas@monjalon.net; Ananyev, > Konstantin ; > stephen@networkplumber.org; maxime.coquelin@redhat.com; > dev@dpdk.org > Cc: david.marchand@redhat.com; jerinj@marvell.com; > hemant.agrawal@nxp.com; Honnappa Nagarahalli > ; Gavin Hu ; > Ruifeng Wang ; Joyce Kong > ; nd ; stable@dpdk.org > Subject: RE: [PATCH v3 07/12] service: remove rte prefix from static func= tions >=20 > > From: Phil Yang > > Sent: Tuesday, March 17, 2020 1:18 AM > > To: thomas@monjalon.net; Van Haaren, Harry > ; > > Ananyev, Konstantin ; > > stephen@networkplumber.org; maxime.coquelin@redhat.com; > dev@dpdk.org > > Cc: david.marchand@redhat.com; jerinj@marvell.com; > hemant.agrawal@nxp.com; > > Honnappa.Nagarahalli@arm.com; gavin.hu@arm.com; > ruifeng.wang@arm.com; > > joyce.kong@arm.com; nd@arm.com; stable@dpdk.org > > Subject: [PATCH v3 07/12] service: remove rte prefix from static functi= ons > > > > Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses= ") > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Cc: stable@dpdk.org > > > > Signed-off-by: Phil Yang > > Reviewed-by: Honnappa Nagarahalli >=20 >=20 > This patchset needs a rebase since the EAL file movement got merged, > however I'll review here so we can include some Acks etc and make > progress. >=20 > Is this really a "Fix"? The internal function names were not exported > in the .map file, so are not part of public ABI. This is an internal > naming improvement (thanks for doing cleanup), but I don't think the > Fixes: tags make sense? >=20 > Also I'm not sure if we want to port this patch back to stable? Changing > (internal) function names seems like unnecessary churn, and hence risk to= a > stable release, without any benefit? OK. I will remove these tags in the next version and split the service core pat= ches from the original series into a series by itself. Thanks, Phil >=20 > --- >=20 >