From: Phil Yang <Phil.Yang@arm.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter
Date: Thu, 2 Jul 2020 03:28:29 +0000 [thread overview]
Message-ID: <VE1PR08MB4640A2E4C9BEEDC7DDE54A8CE96D0@VE1PR08MB4640.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1NxFPCy5URcn8AzVbdQ1+fCE_TayDyGA+bnG_5KP+=tMA@mail.gmail.com>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, July 1, 2020 7:22 PM
> To: Phil Yang <Phil.Yang@arm.com>
> Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; dev@dpdk.org; drc@linux.vnet.ibm.com;
> Ruifeng Wang <Ruifeng.Wang@arm.com>; Dharmik Thakkar
> <Dharmik.Thakkar@arm.com>; nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list
> counter
>
> On Mon, Jun 22, 2020 at 3:18 PM Phil Yang <Phil.Yang@arm.com> wrote:
> >
> > > -----Original Message-----
> > > From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> > > Sent: Friday, June 19, 2020 2:26 AM
> > > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; Phil Yang
> > > <Phil.Yang@arm.com>; dev@dpdk.org
> > > Cc: drc@linux.vnet.ibm.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> > > Dharmik Thakkar <Dharmik.Thakkar@arm.com>; nd <nd@arm.com>;
> > > stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>;
> > > nd <nd@arm.com>
> > > Subject: RE: [PATCH 1/3] eventdev: fix race condition on timer list counter
> > >
>
> > > Since this commit will be back ported, we should prefer to use rte_atomic
> > > APIs for this commit. Otherwise, we will have a mix of rte_atomic and C11
> > > APIs.
> > > My suggestion is to fix this bug using rte_atomic so that backported code
> will
> > > have only rte_atomic APIs. Add another commit (if required) in this series
> to
> > > make the bug fix use C11 APIs (this commit will not be backported).
> >
> > Agree.
> > I will change this patch to the rte_atomic version in the next version.
>
> Hi Phil,
>
> Could you send the next version? I would like to take this series for
> RC1(next-eventdev tree)
Thanks, Jerin.
I will upstream the new patch series soon.
>
>
> >
> > Thanks,
> > Phil
> >
next prev parent reply other threads:[~2020-07-02 3:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 11:19 Phil Yang
2020-06-12 11:19 ` [dpdk-dev] [PATCH 2/3] eventdev: use c11 atomics for lcore timer armed flag Phil Yang
2020-06-23 21:01 ` Carrillo, Erik G
2020-06-28 16:12 ` Phil Yang
2020-06-23 21:20 ` Stephen Hemminger
2020-06-23 21:31 ` Carrillo, Erik G
2020-06-28 16:32 ` Phil Yang
2020-06-12 11:19 ` [dpdk-dev] [PATCH 3/3] eventdev: relax smp barriers with c11 atomics Phil Yang
2020-06-22 10:12 ` Phil Yang
2020-06-23 19:38 ` Carrillo, Erik G
2020-06-28 17:33 ` Phil Yang
2020-06-29 18:07 ` Carrillo, Erik G
2020-06-18 15:17 ` [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter Carrillo, Erik G
2020-06-18 18:25 ` Honnappa Nagarahalli
2020-06-22 9:48 ` Phil Yang
2020-07-01 11:22 ` Jerin Jacob
2020-07-02 3:28 ` Phil Yang [this message]
2020-07-02 3:26 ` Phil Yang
2020-07-02 3:56 ` Honnappa Nagarahalli
2020-07-02 21:15 ` Carrillo, Erik G
2020-07-02 21:30 ` Honnappa Nagarahalli
2020-06-22 9:09 ` Phil Yang
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 1/4] " Phil Yang
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 2/4] eventdev: use c11 atomics for lcore timer armed flag Phil Yang
2020-07-02 20:21 ` Carrillo, Erik G
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 3/4] eventdev: remove redundant code Phil Yang
2020-07-03 3:35 ` Dharmik Thakkar
2020-07-02 5:26 ` [dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11 atomics Phil Yang
2020-07-02 20:30 ` Carrillo, Erik G
2020-07-03 10:50 ` Jerin Jacob
2020-07-06 10:04 ` Thomas Monjalon
2020-07-06 15:32 ` Phil Yang
2020-07-06 15:40 ` Thomas Monjalon
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 1/4] eventdev: fix race condition on timer list counter Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 2/4] eventdev: use C11 atomics for lcore timer armed flag Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 3/4] eventdev: remove redundant code Phil Yang
2020-07-07 11:13 ` [dpdk-dev] [PATCH v3 4/4] eventdev: relax smp barriers with C11 atomics Phil Yang
2020-07-07 14:29 ` Jerin Jacob
2020-07-07 15:56 ` Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 2/4] eventdev: use C11 atomics for lcore timer armed flag Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 3/4] eventdev: remove redundant code Phil Yang
2020-07-07 15:54 ` [dpdk-dev] [PATCH v4 4/4] eventdev: relax smp barriers with C11 atomics Phil Yang
2020-07-08 13:30 ` [dpdk-dev] [PATCH v4 1/4] eventdev: fix race condition on timer list counter Jerin Jacob
2020-07-08 15:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB4640A2E4C9BEEDC7DDE54A8CE96D0@VE1PR08MB4640.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=erik.g.carrillo@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).