From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9F28CA046B for ; Mon, 24 Jun 2019 17:35:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC8C02C57; Mon, 24 Jun 2019 17:35:07 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id 9F1372C19 for ; Mon, 24 Jun 2019 17:35:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=48LiUUUmpWSe0QFpfN7z/+Np8M4GVgRHuDbuy3PQvXo=; b=P5PhzmAGQg4PHMUfnu73l6CXlZ93Kt1MazypNofOoCLnQpApVT0DvwcTezJq8a/bE8ith6GFQdsEhDSIVocKk1yQfEdcUETnh554yXqkdUlOYnkQpUE8g30bzYqldNwcJuuQN+2NMILsthLVkGkNuQRf144R1b4W9oujPEwubk4= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4750.eurprd08.prod.outlook.com (10.255.112.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Mon, 24 Jun 2019 15:35:04 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::d411:12c1:65b9:874f]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::d411:12c1:65b9:874f%3]) with mapi id 15.20.2008.014; Mon, 24 Jun 2019 15:35:03 +0000 From: "Phil Yang (Arm Technology China)" To: "Eads, Gage" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [PATCH v2 1/3] eal/arm64: add 128-bit atomic compare exchange Thread-Index: AQHVKpuVRXXouUkiFE66uAB6ltkNsqaq7gpA Date: Mon, 24 Jun 2019 15:35:03 +0000 Message-ID: References: <1561257671-10316-1-git-send-email-phil.yang@arm.com> <1561259746-12611-1-git-send-email-phil.yang@arm.com> <9184057F7FC11744A2107296B6B8EB1E68D00D96@FMSMSX108.amr.corp.intel.com> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E68D00D96@FMSMSX108.amr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9eeb55c6-7e4d-4ed5-8da7-6dc69fdb2b10.1 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a776b750-c28b-4462-7545-08d6f8b9872c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4750; x-ms-traffictypediagnostic: VE1PR08MB4750: x-ms-exchange-purlcount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 007814487B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(346002)(136003)(396003)(13464003)(199004)(189003)(186003)(14454004)(53546011)(66476007)(55236004)(305945005)(229853002)(5660300002)(6116002)(33656002)(76176011)(11346002)(7696005)(3846002)(8676002)(52536014)(54906003)(66066001)(2501003)(110136005)(316002)(66946007)(81166006)(446003)(14444005)(71200400001)(68736007)(71190400001)(53936002)(76116006)(73956011)(476003)(66446008)(8936002)(6436002)(486006)(7736002)(81156014)(102836004)(6506007)(25786009)(6306002)(4326008)(6246003)(26005)(99286004)(74316002)(72206003)(9686003)(55016002)(66556008)(256004)(86362001)(478600001)(2906002)(64756008); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4750; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZtPo93d0PQ9Sptnf/4wZZQ/z+7ETHqLQ9nPdHs3xJ+K8UpByd2kGkmv4OLl7bTiybbQP8yb1lMtIB3jpxo3GATCJWfFrvQkCDOcWEzkwC9JCsnb2XS8K6lu2Mw7lQ4x5guXvjQbKLLaxCotOXhshTh+/46HIM/A0sgj29CaxJ1VJYGiLlJLqE0kGV1qPydYit8jch1NJMyEktF6bpE8MWFSl+MJj1nwpap+r0gpu83TOFJqexwz3yruayrKyHSObzZsv7PGq/6TeMET1ggiSeB7N+W8pT2hQgSZ94kyu4FOsET3I3YCWPbsfUSbP8ySwYIYX2R0EtRUVXtHjAUH9XhG+lRtoKtMYT2mP52vyrNS9AIbE0LKWYvJIb6G7NSpweSeJyOGzpJalvIFvHR8drMVZdzncC3S2h9WFiFrS1+o= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: a776b750-c28b-4462-7545-08d6f8b9872c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2019 15:35:03.8440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Phil.Yang@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4750 Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: add 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Eads, Gage > Sent: Monday, June 24, 2019 10:46 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: thomas@monjalon.net; jerinj@marvell.com; hemant.agrawal@nxp.com; > Honnappa Nagarahalli ; Gavin Hu (Arm > Technology China) ; nd > Subject: RE: [PATCH v2 1/3] eal/arm64: add 128-bit atomic compare exchang= e >=20 > Hi Phil, >=20 > > diff --git a/lib/librte_eal/common/include/generic/rte_atomic.h > > b/lib/librte_eal/common/include/generic/rte_atomic.h > > index 9958543..7dd1aa4 100644 > > --- a/lib/librte_eal/common/include/generic/rte_atomic.h > > +++ b/lib/librte_eal/common/include/generic/rte_atomic.h > > @@ -1081,6 +1081,18 @@ static inline void > > rte_atomic64_clear(rte_atomic64_t *v) > > > > /*------------------------ 128 bit atomic operations > > -------------------------*/ > > > > +/** > > + * 128-bit integer structure. > > + */ > > +RTE_STD_C11 > > +typedef struct { > > + RTE_STD_C11 > > + union { > > + uint64_t val[2]; > > + __extension__ __int128 int128; > > + }; > > +} __rte_aligned(16) rte_int128_t; > > + > > #ifdef __DOXYGEN__ > > >=20 Hi Gage, > This change breaks 32-bit x86 builds*. A couple ways to resolve this are = 1) > with RTE_ARCH_* ifdefs, or 2) keep duplicate definitions of the struct in= the > aarch64 and x86 header files. OK. Let's follow the first approach. I will update it in the new version. T= hanks! >=20 > Thanks, > Gage >=20 > *http://mails.dpdk.org/archives/test-report/2019-June/086586.html Thanks, Phil