From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 458B2A00C5; Fri, 8 May 2020 12:31:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24DDD1DB2F; Fri, 8 May 2020 12:31:30 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80078.outbound.protection.outlook.com [40.107.8.78]) by dpdk.org (Postfix) with ESMTP id 7971F1DB2E; Fri, 8 May 2020 12:31:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXjed3yAXggH+IC/JwyDtd/nVFHp95Qkj7TY6Lpbtzc=; b=XMXfJtZgUbVjZI4IKgHnAzfqkzM4Tde4sTlYZ1sDCKqhxY/9NRl/kxGcPyv4gglrWxyTCWDXuQya5fg1Z0U3Qoblx5Ip1PHnOuXZ/SZKTqKYfmzv2fiFRk15hTitrrq9kJnneSuwbbROcaIO1tWULduuzZ/t7zhe3RkPY/qApq4= Received: from DB6PR07CA0011.eurprd07.prod.outlook.com (2603:10a6:6:2d::21) by DB7PR08MB3769.eurprd08.prod.outlook.com (2603:10a6:10:7b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Fri, 8 May 2020 10:31:26 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::5f) by DB6PR07CA0011.outlook.office365.com (2603:10a6:6:2d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.11 via Frontend Transport; Fri, 8 May 2020 10:31:26 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Fri, 8 May 2020 10:31:26 +0000 Received: ("Tessian outbound ff098c684b24:v54"); Fri, 08 May 2020 10:31:26 +0000 X-CR-MTA-TID: 64aa7808 Received: from e157a5643155.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75621F5B-4BCC-4F4F-9A9C-14B0D51C8B31.1; Fri, 08 May 2020 10:31:21 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e157a5643155.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 May 2020 10:31:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ha1p6Qk8Z28PWntkr5sa5ZMuApO+wH7eyfZmZ092Ch1eFGColmJrWl+fNQRnFYRtsSLvy3fqykEqNDgr/ymmxA4bzsoAJMwC85RAQT8ljKErXOAJQWMygUsJZ3RmeGKy7wITvHZdK2tw5rKaqKH9bs3CekmVMKBh9zrSb94/r/sXJH4qgn4hVGZBLjScEoBpffBGHQ+evzj995BBc1Ax/KeHzFzxg7xySVoC14UmJooXsmJpWrhp1vGnHM0IzkcGuXj3KQ4CZAduzh0lXNyNu5FFeaKe/li8ogVx32XOkBK1JgRy64wu6vvSY/mN1nTFNPryxTZtWNZU+dyIymT/PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXjed3yAXggH+IC/JwyDtd/nVFHp95Qkj7TY6Lpbtzc=; b=AMJhrYYufzs9+Cb2pNpsryTPJis6AULgO+eD+MfcizDpeFjf9sRwWbaiAiDhEn/4RPjAc4yK5vqdDc+LQ+YXH4NJFFWEvQZVbEHFzkjlVVSZv0HlUnWsvxxphPnuFNCoNzR/MEFl49jeDeeAt8FCN16LrRJCp99HwnyYLt0QxFlA12nA0FuwsIavNJSyXMYP4teGgNTjPWbVynnEBXSlT0JlkTeCoVQMLtmYKJ5nz3e9LQ/uwHeFDykcjtCTTD7Imi2qywcC8gHDKv4fQr21JxbKi+yMW55EIw49dr29woGSVhBZcvhQ4/DW6nreNVYHQbu6qpy1TDMg/DWvrJJ3/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXjed3yAXggH+IC/JwyDtd/nVFHp95Qkj7TY6Lpbtzc=; b=XMXfJtZgUbVjZI4IKgHnAzfqkzM4Tde4sTlYZ1sDCKqhxY/9NRl/kxGcPyv4gglrWxyTCWDXuQya5fg1Z0U3Qoblx5Ip1PHnOuXZ/SZKTqKYfmzv2fiFRk15hTitrrq9kJnneSuwbbROcaIO1tWULduuzZ/t7zhe3RkPY/qApq4= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VE1PR08MB4669.eurprd08.prod.outlook.com (2603:10a6:802:a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Fri, 8 May 2020 10:31:18 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::785b:54ca:be80:7b66]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::785b:54ca:be80:7b66%2]) with mapi id 15.20.2979.028; Fri, 8 May 2020 10:31:18 +0000 From: Phil Yang To: Ye Xiaolong CC: "dev@dpdk.org" , "konstantin.ananyev@intel.com" , "wenzhuo.lu@intel.com" , "qi.z.zhang@intel.com" , Lijian Zhang , Gavin Hu , Honnappa Nagarahalli , nd , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports Thread-Index: AQHV/di4+EOeTBKKukKjM+pL3geqT6idyf1wgABhwICAAB/P8A== Date: Fri, 8 May 2020 10:31:18 +0000 Message-ID: References: <1584600111-17412-1-git-send-email-phil.yang@arm.com> <20200508083607.GE75514@intel.com> In-Reply-To: <20200508083607.GE75514@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: a92cf3d2-bb3a-492a-bbdf-11b69e6c6522.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 72b3e3bf-1d9f-465b-0a1f-08d7f33af6a3 x-ms-traffictypediagnostic: VE1PR08MB4669:|VE1PR08MB4669:|DB7PR08MB3769: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 039735BC4E X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bHJ6Vc9wRhS2OdSVyTcEb2AOdFJPxWyigJUVpM2oumZ5KXgBEXaaSZ6404SL1j6XQ4+90ZCXAVEyCkaoU0lrP6mZeDgfUVLRAH+s12b2SLmlND6MMUctNOvtKI71LcS16v85JIy2xe8dvIodVFfWcc+fhaTgezx5xv3/sxGlk5ZX1kXFkrj4zxe3JgmX1o/LX8JWs4z/8FWXF7x7AjXIDbMzhaL2jnvPa43Y67Sfk3hOZPIcfx98LYDNPiqNW2VveXDeQg7slt1UwZgATrvcR4ZrxIxqVLQI7GyUabWu9UpKCohCycQqNCOo9JdUU8KnoY5vOBd0KcOOS5v4cljYLtl7gX7dC8DFsU4OvgJQD/gHerWyClG0OprXwrwqOIYaHI1rBQvTOzNTQqk+XOmP6tjwteg5Jd2/1WhNNyehMSz1VjbZJTSNHwQwE0DX3MiausdkA/JVcTRHPDSF7E76dWaCpl+QPc7gmNIhsLbNnzjKza77A4yQeyZ2h+49me6QXQAhTMZXvAxBQL6PiXU3qw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(136003)(39860400002)(366004)(396003)(33430700001)(86362001)(9686003)(7696005)(55236004)(66476007)(478600001)(5660300002)(66556008)(64756008)(66946007)(83300400001)(316002)(83290400001)(2906002)(83280400001)(83310400001)(83320400001)(52536014)(76116006)(4326008)(6506007)(33656002)(33440700001)(53546011)(26005)(186003)(54906003)(71200400001)(66446008)(8936002)(6916009)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HVS2zkaTS0nlsfRjV2zcwLyJJpuGtgtM4Y9HXh+PDkHfr4Ob+f34f6vhgtMasgKAedFtSaqR0ziNUNL1uv1Grq8KOp6Er2qZB/5o4/RIavBVSlsHt96xdw1oFBFCZ0kxsmzoIm06cKghgYh+6fgW+5zSLakDK0YjltJP+ZPzSaDTfTDGZgSzV0H7zb4pdUwRqmLE+Ehf3kINqy2ZHKJBh5qboCpG/jdAq3cXLFLESCZV16NNDKZTJLkxD3gPQ0EMM0mrNq2wuYt3Uygv5FCHOrlDi3Hah02HPOuE0A6hmrbO/D7Lo9EOxjs8qX41Y9xLRBlyftY1lt7phD7MTz8FfSUDVBkREtv93dnV+z5a2cFiAxXmk5iMBzQ4lVlxDtakXdfY33jwKXs1yuq2ahtxm/y9FtvZTRVPkchhHOKZA+RJh5QEf3HxbO70ScmdPYLyZbUvX7//MvQnnLcXxbM1RWkBlb5raWkrd1GZQh4bJuQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4669 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(346002)(39860400002)(376002)(46966005)(33430700001)(6862004)(54906003)(33656002)(478600001)(52536014)(47076004)(70206006)(70586007)(55016002)(336012)(86362001)(2906002)(9686003)(8936002)(450100002)(4326008)(356005)(316002)(81166007)(26005)(186003)(33440700001)(5660300002)(7696005)(82740400003)(6506007)(82310400002)(53546011); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 865b79a4-8fc0-49d5-c4c4-08d7f33af1f9 X-Forefront-PRVS: 039735BC4E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WZ9zqoU7fcp4IjxJwwPbrVDb/BeiTyiKC+XnsFh3hGrHZ+l7aKclzv6Uz3llkVTakAyHFk7PV2auczV5+CRDpuWlrcVrM8v5wScDW3mjeMKitIRvtIslng0O55ovOgFo5r1Df44KxueVqW2msxU8pbg4aVr1fAur+9x7RaWHm10MelWOtL6UoAeYnnUIGztINK/T/reNtIoe8QayjxBv5PWn+X9I9ObUDTXDQNCyGS/vD/a7iNbRBZV0AzE+T+xkd1gbWJo0zLfadfNPASkBb0ghN5P2CAjQAxVAwdqh1TsPJM4oQ479epKht8uEFVSIl6suYg1Zk9vWftNOESIvqIQSiPxjJtZuAklZyBe5XIti3rnXQxEVKiPUIhvXoxWm2KeWxM9zN0UHuevIszmnLwLxT+l1+lMMT4bUFfmaHo4Df3Pz0tjUi3TVPP3t8kmgXKQl0TPujNCzfbI8JNLRKAIOtvGalQ4YxkBYM0JXRIuQwrl9vamkHX2vs2MX4nb4JRn4uEEnekL0DFjrYwKQg1EOMqNOq5tVthCEf1anDKxfGzTy/jeiw8edebXahCAgzR7P+Sl4Md3XKl7IUfApZQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2020 10:31:26.7508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72b3e3bf-1d9f-465b-0a1f-08d7f33af6a3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3769 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye Xiaolong > Sent: Friday, May 8, 2020 4:36 PM > To: Phil Yang > Cc: dev@dpdk.org; konstantin.ananyev@intel.com; wenzhuo.lu@intel.com; > qi.z.zhang@intel.com; Lijian Zhang ; Gavin Hu > ; Honnappa Nagarahalli > ; nd ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on= fiber > ports >=20 > On 05/08, Phil Yang wrote: > >> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on = fiber > >> ports > >> > >> With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it > >> is possible when a port is started to experience a timing issue > >> which prevents the link from ever being fully set up. > >> > >> In ixgbe_dev_link_update_share(), if the media type is fiber and the > >> link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback > >> to ixgbe_dev_setup_link_thread_handler() is scheduled which should > >> try to set up the link and clear the flag afterwards. > >> > >> If the device is started before the flag is cleared, the scheduled > >> callback is cancelled. This causes the flag to remain set and > >> subsequent calls to ixgbe_dev_link_update_share() return > >> without trying to retrieve the link state because the flag is set. > >> > >> In ixgbe_dev_cancel_link_thread(), after cancelling the callback, > >> unset the flag on the device to avoid this condition. > >> > >> Fixes: 819d0d1d57f1 ("net/ixgbe: fix blocking system events") > >> Cc: stable@dpdk.org > >> > >> Bugzilla ID: 388 > >> > >> Signed-off-by: Phil Yang > >> Signed-off-by: Lijian Zhang > >> Reviewed-by: Gavin Hu > >> --- > > > >Ping. >=20 > This fix makes sense to me, thanks for the work. > And it seems can't be applied to latest dpdk-next-net-intel cleanly, coul= d you > do a rebase? >=20 Thank you Xiaolong. I updated in V2, please review it. Thanks, Phil