From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 48471A00C4;
Fri, 24 Apr 2020 08:08:42 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 07C851C1C7;
Fri, 24 Apr 2020 08:08:41 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
(mail-eopbgr70074.outbound.protection.outlook.com [40.107.7.74])
by dpdk.org (Postfix) with ESMTP id 3632A1C1C0
for <dev@dpdk.org>; Fri, 24 Apr 2020 08:08:40 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=fyNgIaTi1NP0OtzrvW+KH0JHVfbohPDygrKmfe2Jz6M=;
b=w0ssLbBVi7hPFKo4laqi5OZEKgHxDR3nuBKcqyHTU1tqrKSVXrEp02jNs5qEr3j4+nUZAqHduhCt8GyH4qtEEL303yr1VyuRwyGL5VyqwUVRgX4mRIiao5NENNOf9rS0ERGE/jsDqBxj9rKkzU9j/RIoAPOS7866APdJCgrkhCQ=
Received: from DB6PR07CA0075.eurprd07.prod.outlook.com (2603:10a6:6:2b::13) by
AM5PR0801MB1681.eurprd08.prod.outlook.com (2603:10a6:203:3b::19) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Fri, 24 Apr
2020 06:08:38 +0000
Received: from DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com
(2603:10a6:6:2b:cafe::c6) by DB6PR07CA0075.outlook.office365.com
(2603:10a6:6:2b::13) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.9 via Frontend
Transport; Fri, 24 Apr 2020 06:08:38 +0000
Authentication-Results: spf=pass (sender IP is 63.35.35.123)
smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none
header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
63.35.35.123 as permitted sender) receiver=protection.outlook.com;
client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
DB5EUR03FT022.mail.protection.outlook.com (10.152.20.171) with
Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.2937.19 via Frontend Transport; Fri, 24 Apr 2020 06:08:38 +0000
Received: ("Tessian outbound 76e9a4cf1540:v53");
Fri, 24 Apr 2020 06:08:38 +0000
X-CR-MTA-TID: 64aa7808
Received: from 90403fd79eaa.1
by 64aa7808-outbound-1.mta.getcheckrecipient.com id
73ECB1C5-D0D8-4C5C-AF43-55AA96AA5BD8.1;
Fri, 24 Apr 2020 06:08:33 +0000
Received: from EUR05-AM6-obe.outbound.protection.outlook.com
by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 90403fd79eaa.1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
Fri, 24 Apr 2020 06:08:33 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Olzo+d5rA647GKXxLvC2DUmdHYefMQLT84pr2B40V8zDzmNDWE1q+/nzqwpBeGEMR0AehDrNi3JnLlqaccFyqCQ8moP/3tfGQxvzzhEX07qgaWy9ai4pldfh2soi5+D/E3SlWjjcLdJxHdaOovH2skEQ+5u9emqq9NunAg4zpkNJmtziL/2E+HZ7TLZllUOrptw2zlsD+paGwMf6uKirDV2cDEJvm/uFzDJzfAjFn1tboYuX194axSgzgRbdVlJs+8BEHMkN/suJYwfeW8qd3gw21V3w5Jo3HZWtDB0JKr+1V3oRp8YPbT6+Rv3c87b+8oKPU8diPB9QZyUagbhVqg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=fyNgIaTi1NP0OtzrvW+KH0JHVfbohPDygrKmfe2Jz6M=;
b=l0wuIvd54OUoDGOREcEvAyvPju5VnGCrvKSwiYXgqu3d1BgrsiUwKh7SxGcj2PD0n8yrZIMhHb33VXc4rMNAJFbAKbHhSgq9VolnC/wcRxCjXgLOQi4lWhfm1//V3Mo94HuiJpxDbgjreXXmd+aIIhG95gy422ZV8vQCr3OgoBsNALmRB1aa3V0Y4uZwkMMoCP1vL/dWWxuCx/KpaOsPcaFwIxHMuSaFQ3nY+HHAWp7ZWSRbaPa0d/FiWnJ3iVGJuJVjgS/6EPRszAtS1ByD54x5ftmXO1+jDEXZHfTGnNw3L97fH7Uk+P6jvWKPKWxg0nZcNQpSkVc31dFGSPnKtQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=fyNgIaTi1NP0OtzrvW+KH0JHVfbohPDygrKmfe2Jz6M=;
b=w0ssLbBVi7hPFKo4laqi5OZEKgHxDR3nuBKcqyHTU1tqrKSVXrEp02jNs5qEr3j4+nUZAqHduhCt8GyH4qtEEL303yr1VyuRwyGL5VyqwUVRgX4mRIiao5NENNOf9rS0ERGE/jsDqBxj9rKkzU9j/RIoAPOS7866APdJCgrkhCQ=
Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11)
by VE1PR08MB4877.eurprd08.prod.outlook.com (2603:10a6:802:a4::18)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Fri, 24 Apr
2020 06:08:30 +0000
Received: from VE1PR08MB4640.eurprd08.prod.outlook.com
([fe80::785b:54ca:be80:7b66]) by VE1PR08MB4640.eurprd08.prod.outlook.com
([fe80::785b:54ca:be80:7b66%2]) with mapi id 15.20.2921.030; Fri, 24 Apr 2020
06:08:29 +0000
From: Phil Yang <Phil.Yang@arm.com>
To: Phil Yang <Phil.Yang@arm.com>, "thomas@monjalon.net"
<thomas@monjalon.net>, "harry.van.haaren@intel.com"
<harry.van.haaren@intel.com>, "konstantin.ananyev@intel.com"
<konstantin.ananyev@intel.com>, "stephen@networkplumber.org"
<stephen@networkplumber.org>, "maxime.coquelin@redhat.com"
<maxime.coquelin@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"jerinj@marvell.com" <jerinj@marvell.com>, "hemant.agrawal@nxp.com"
<hemant.agrawal@nxp.com>, Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com>, Gavin Hu <Gavin.Hu@arm.com>, Ruifeng Wang
<Ruifeng.Wang@arm.com>, Joyce Kong <Joyce.Kong@arm.com>, nd <nd@arm.com>, nd
<nd@arm.com>
Thread-Topic: [dpdk-dev] [PATCH v3 03/12] eal/build: add libatomic dependency
for 32-bit clang
Thread-Index: AQHV+/oH9TFm6o5wAk6gmXadtFxtAaiIBPGQ
Date: Fri, 24 Apr 2020 06:08:29 +0000
Message-ID: <VE1PR08MB4640B533DCC9E31A8F107D3AE9D00@VE1PR08MB4640.eurprd08.prod.outlook.com>
References: <1583999071-22872-1-git-send-email-phil.yang@arm.com>
<1584407863-774-1-git-send-email-phil.yang@arm.com>
<1584407863-774-4-git-send-email-phil.yang@arm.com>
In-Reply-To: <1584407863-774-4-git-send-email-phil.yang@arm.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: f59f0827-57f3-41e0-91c8-9b39501b32d1.0
x-checkrecipientchecked: true
Authentication-Results-Original: spf=none (sender IP is )
smtp.mailfrom=Phil.Yang@arm.com;
x-originating-ip: [113.29.88.7]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 4919c1ce-f764-4fde-1cac-08d7e815ee66
x-ms-traffictypediagnostic: VE1PR08MB4877:|VE1PR08MB4877:|AM5PR0801MB1681:
x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM5PR0801MB16819A79ACBDE62FDDF3F008E9D00@AM5PR0801MB1681.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:913;OLM:913;
x-forefront-prvs: 03838E948C
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com;
PTR:; CAT:NONE; SFTY:;
SFS:(4636009)(346002)(366004)(136003)(376002)(396003)(39860400002)(8936002)(4326008)(7696005)(9686003)(110136005)(54906003)(55236004)(71200400001)(55016002)(81156014)(26005)(316002)(186003)(53546011)(33656002)(966005)(6506007)(2906002)(86362001)(478600001)(66476007)(64756008)(66946007)(76116006)(66446008)(66556008)(5660300002)(52536014);
DIR:OUT; SFP:1101;
received-spf: None (protection.outlook.com: arm.com does not designate
permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: L9nl4hU32CljG0yWKpbFuHJ4BihplRXKOUAFEc1mrykc6eNjLMbJm2kxvKtepYTulItv8RmFa7XZIYLKuFmHn+/qwADkPvE/Ne9pqxUlkbQ1ZJYESnFs8JRYo7uag8v4O1iCQzhMeoLicPz7bLjpTNfykT5uA6x/I49+KnHCyy7qmfIITQZqy8REM6ugV8IvIohEDSjpgtfj+xhzXv8UXl/98mDu7de+gQPw9s/Pjyd0WPHTHciAELuWbnskQowclUZE6VEoarA8rpcaCgJgP+5xMs+OX4H7n5Wvqqp3Y2rRgYJ5x/xcwtutwwEGyMLPnX8grWoPx0t8SBmyxlEmzEItYlQgfHAuQNZk0AVFlLjUIC4yGAx36wblAEg5YkBFMstB68RzGvXZQCxUdh1dExZ3wXZteVTQvA+bQbPJOk4e+7JeMauM1y2OCtnKYTrWGItEIwkcbRejoMVna1fyp9eyzteJUYJ3P2EN/0CONOCzbLhqu5Q0+5e5/5ioA6Sjem62gwhUtYfRrV+LofixVA==
x-ms-exchange-antispam-messagedata: C1tokiX35FA/WTmpAPiIbYQ3cw7ttj0pfmUp00GXX7hoY7RJwvJISuFPCoBQy5r9PBvancJQh9orBphmKjopx4q4ntK8m6hCvWoGZuJ0ezlu+9K9fqcp3WJ7cB3VILGwQGgYne62yuYw+7t60jzFmQ==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4877
Original-Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Phil.Yang@arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;
SFS:(4636009)(396003)(39860400002)(346002)(376002)(136003)(46966005)(55016002)(26005)(8936002)(478600001)(81156014)(966005)(5660300002)(7696005)(4326008)(110136005)(316002)(53546011)(6506007)(54906003)(9686003)(82310400002)(33656002)(356005)(86362001)(2906002)(47076004)(186003)(336012)(82740400003)(70586007)(81166007)(52536014)(70206006);
DIR:OUT; SFP:1101;
X-MS-Office365-Filtering-Correlation-Id-Prvs: cdd2532a-d866-4bac-a985-08d7e815e91e
X-Forefront-PRVS: 03838E948C
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ewF2yVN6lB4LxiOqynT8tgHuQVf4u5OlTOy9HTbxXWy7+EZ+WT/6oou8hiRenE+7AUda9WGF3Kr4ky25caPTE6fQCE5DhjvZyvQrcQbtKXnPdRR4ERpSfWqpleayUPrnx3KzYseNjOEcilkg/5lDN3ZNhUPx8ClpX5kzkTuVjmTZ3yAiovaeJJS/j2Z6W0i9XWBCz+tzmVL4++WmwQSDdaPpBuZH2jQVhWHDhiUEskSBwYR/Ht/EUa1T1F7E2C4/bcLxt09It5qg0KARvd4DVNdOjfWYe67l+QkW7jS/9fYfAJRLk3gj+lA86d5q9ibAH8jXLGuT0MhTtQ+e2t+sv33VcQIDlzpDpbcjv23q05THpCDLgMcD4B8LUyamGcklEvkSTK8W2W5v3ws1cjevWr6PEyi5oM/CC6FVoq9GxowNXA74Emj+v7OgVbKNiqilbgE45RY38z7fQWHY7P/VvDNdeTrTRb2LSxLVd/LwHnokgDxigZqpsSxf595CuxU6mG1/3cGS0CbEe8LlHrTBjMzgFRnE7Esci6n22JOnKhbu3hKAByHpsLenF0FIZi/qbPaVjXq8zs1T35ejwHTKC3lU9tR75uPBPpXKZnhAK/Q=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2020 06:08:38.7741 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4919c1ce-f764-4fde-1cac-08d7e815ee66
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1681
Subject: Re: [dpdk-dev] [PATCH v3 03/12] eal/build: add libatomic dependency
for 32-bit clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Phil Yang
> Sent: Tuesday, March 17, 2020 9:18 AM
> To: thomas@monjalon.net; harry.van.haaren@intel.com;
> konstantin.ananyev@intel.com; stephen@networkplumber.org;
> maxime.coquelin@redhat.com; dev@dpdk.org
> Cc: david.marchand@redhat.com; jerinj@marvell.com;
> hemant.agrawal@nxp.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Gavin Hu <Gavin.Hu@arm.com>;
> Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>; nd <nd@arm.com>
> Subject: [dpdk-dev] [PATCH v3 03/12] eal/build: add libatomic dependency
> for 32-bit clang
>=20
> When compiling with clang on 32-bit platforms, we are missing copies
> of 64-bit atomic functions. We can solve this by linking against
> libatomic for the drivers and libs which need those atomic ops.
>=20
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> lib/librte_eal/meson.build | 6 ++++++
> 1 file changed, 6 insertions(+)
>=20
> diff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build
> index 4be5118..3b10eae 100644
> --- a/lib/librte_eal/meson.build
> +++ b/lib/librte_eal/meson.build
> @@ -20,6 +20,12 @@ endif
> if cc.has_function('getentropy', prefix : '#include <unistd.h>')
> cflags +=3D '-DRTE_LIBEAL_USE_GETENTROPY'
> endif
> +
> +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops
> +if cc.get_id() =3D=3D 'clang' and dpdk_conf.get('RTE_ARCH_64') =3D=3D fa=
lse
> + ext_deps +=3D cc.find_library('atomic')
> +endif
> +
This should be unneeded since:
https://git.dpdk.org/dpdk/commit/?id=3Dda4eae278b56e698c64d0c39939a7a55c5b6=
abdd
Thanks,
Phil Yang
> sources =3D common_sources + env_sources
> objs =3D common_objs + env_objs
> headers =3D common_headers + env_headers
> --
> 2.7.4