From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 037AEA0597; Wed, 8 Apr 2020 12:49:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F7D81C1AE; Wed, 8 Apr 2020 12:49:26 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2046.outbound.protection.outlook.com [40.107.20.46]) by dpdk.org (Postfix) with ESMTP id CEA6B1C1AA; Wed, 8 Apr 2020 12:49:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfJoQqhG87LEgelsOAQPJYI5JI5Mc2DafN38+qyFXtE=; b=NY/O31/0KYOiCtmgMqWxgb3o406qVCg6PEoK/6gmyDegfpc3v0w4YGrI0tATldm7Pt7NtG0D2RYURrz7C2AzFaQ6iVfI78uWmGpo770WxPhKK+pD1FjlZRCch3JECowpi3buMzyemkQPaHZ5FWEY8l7WWV/FmNgfXSZZucErZEI= Received: from AM6P192CA0044.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::21) by VI1PR08MB3456.eurprd08.prod.outlook.com (2603:10a6:803:7e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Wed, 8 Apr 2020 10:49:22 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:82:cafe::97) by AM6P192CA0044.outlook.office365.com (2603:10a6:209:82::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Wed, 8 Apr 2020 10:49:22 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Wed, 8 Apr 2020 10:49:22 +0000 Received: ("Tessian outbound af37c2b81632:v50"); Wed, 08 Apr 2020 10:49:21 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9dc30c9270d8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AABC4DFA-A877-46D7-8E1D-56F1D8F09934.1; Wed, 08 Apr 2020 10:49:16 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9dc30c9270d8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Apr 2020 10:49:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PC0UmcoVH/Od+uFvX7mwTEgh4j/g8aprZkYMhNchurw4hTLLLKs+qM5UA3NRX/nRaoewiuq4Ad0VDxVFkp8dZuveiQiNbfNJxM6A1dWXQC9SevX73kWPQct80Qu1EJpbOvPdTHOrIRMrOhFANI3KklA0RvCYHSX1N3vTux5GwHkmWtC5/WD66HpdDhQmcRw1WMaQKRi2HRfycYrFKD4w6io57pUsqLuKfMjCBhRC4xCtqq56EGOFMCL8ljwvWFEi6BIYxLh2JzsyC+OLQcp4HpqeaCb+xbhet1A1bnqmDvkCRupAOnwJ+cGj6V5EEXFOTJ22mklc7drE4EGaIKDVDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfJoQqhG87LEgelsOAQPJYI5JI5Mc2DafN38+qyFXtE=; b=h/nd5gJytsMcA9EPBLAvOUYEsqGlpQOCkdQ6/zohMYXk+l4UNMQ4RZphz7O8IHhxEAB2Ji2ijq7N2T693aAYCXVQk8OtMehMzWn2E08clxMjeFSvsYGxKc4lufeAbI69ts91kSfs64BFh6HuQst4GTefoIXUyZl1uTClqWLAg9OSpVxpLRi/9FsnkpQozbA/GTH6Y3PNDdrhc1DqjeQjJvioEq64wFNBDi2qpTSx0Bc/f36w4wL9B940KhYOfDVMj/SnxTbrRVUpWwZA8YvIT1Eo/gYq0r1ZDnm9OwiV6i64I3FxMMsKMXMdE1Meq/UElb2nLBmuvxaTcpDixTxmpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfJoQqhG87LEgelsOAQPJYI5JI5Mc2DafN38+qyFXtE=; b=NY/O31/0KYOiCtmgMqWxgb3o406qVCg6PEoK/6gmyDegfpc3v0w4YGrI0tATldm7Pt7NtG0D2RYURrz7C2AzFaQ6iVfI78uWmGpo770WxPhKK+pD1FjlZRCch3JECowpi3buMzyemkQPaHZ5FWEY8l7WWV/FmNgfXSZZucErZEI= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4686.eurprd08.prod.outlook.com (10.255.115.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Wed, 8 Apr 2020 10:49:14 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::7df3:e3c8:54f7:57c2]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::7df3:e3c8:54f7:57c2%6]) with mapi id 15.20.2878.021; Wed, 8 Apr 2020 10:49:14 +0000 From: Phil Yang To: "Van Haaren, Harry" , "thomas@monjalon.net" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , Gavin Hu , Ruifeng Wang , Joyce Kong , nd , "stable@dpdk.org" , nd , nd Thread-Topic: [PATCH v3 07/12] service: remove rte prefix from static functions Thread-Index: AQHWCa8i/SAa9HDi+U+lvhwYc+fWhahvBQ/QgAAKvQCAAAL9MA== Date: Wed, 8 Apr 2020 10:49:14 +0000 Message-ID: References: <1583999071-22872-1-git-send-email-phil.yang@arm.com> <1584407863-774-1-git-send-email-phil.yang@arm.com> <1584407863-774-8-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: e34e3d36-f040-40eb-83a0-da9a8da902df.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [58.39.116.39] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6b6e730f-7930-45cb-87a3-08d7dbaa7f37 x-ms-traffictypediagnostic: VE1PR08MB4686:|VE1PR08MB4686:|VI1PR08MB3456: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; x-forefront-prvs: 0367A50BB1 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(136003)(376002)(39860400002)(396003)(346002)(4326008)(7696005)(6506007)(33656002)(53546011)(71200400001)(54906003)(110136005)(86362001)(2906002)(52536014)(478600001)(7416002)(76116006)(5660300002)(64756008)(66446008)(66946007)(66476007)(66556008)(81156014)(8936002)(316002)(9686003)(81166007)(55016002)(8676002)(186003)(26005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YjTfUVXwZat8UNxyf7S5XXlR7rUwIugcmchgrxgRwkpqDcrayVgRfBXuTzdvKA3V6qk9Mnzc9F0uczlVZC/vcyq0X4oah78aIC84eYz1QlmWKg68AfQwzPsG2trse/cUt7OULSYDwqwByjXDpahYpnPfavC48V3creZ0QDe9oRprV5B5k5QI5OemfdIYKAMYpBQIhit0DogkWr0yBmWGznAo36Zf55DKQDDzWNnSUbiHFEwCx6B2KTiqdIbA9rb0abNXRWbbpwMpi3GqWlOowWesM3RKGKSeKkOl3Rsx1W9RcjRKHshWEaR55sOaBMpuW8ylzjA4rcUGAQD41rHSwIot2/rxRB5i0LGqkBZZtnxDMbX/PeK37AMoojYcD1l9upnjIk4PZN26C9OX7F9OJLknZ4oFjhlIAWSjsCOO6hXXubrvEoUuKZPb4nrEUnfT x-ms-exchange-antispam-messagedata: vG/WsEbGDaPlJxzCmUaPPet2M7nafJSqtgb5ozutom54EfD/hCEvwfxLfyy2qwf5P0Hun688ld/xoyCO8RUqAkNQ/lCC3ackphR8a9YLP6aBEgznB1gm9XpZdTokkORCphjGN4dHieHxtTJZ5p+BgA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4686 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(376002)(39860400002)(396003)(346002)(46966005)(86362001)(36906005)(450100002)(47076004)(9686003)(55016002)(336012)(7696005)(186003)(82740400003)(2906002)(26005)(5660300002)(52536014)(6506007)(26826003)(8676002)(478600001)(53546011)(8936002)(81156014)(70206006)(110136005)(316002)(81166007)(54906003)(4326008)(33656002)(356004)(70586007); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ac7e522-c4a1-482d-44f6-08d7dbaa7aaf X-Forefront-PRVS: 0367A50BB1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SjiLvPDAoTJmLVqO8AHnEBtWNJ3dQ2PqTM8esibzCtxaPb9Tuk4VdJ9IcbMAarTsuWGV47QHqM2g5XcWnJ52DN2HSnXHO2FH4kHv1rO6Oj3ZM89clLN3Xl6rHh11dNocmeOnPerA9gXdDs4fFd4fAwsnefDKIcL1FhpkE0BDrC6x6MZWw16aQTjC0yWDDrYFG+T/LuhVimaFqTS32JfdITZ1MfulXuPSlLWs+NGdBYX9Q1EAxfJfCGnyeuKhByLKuq4pBk72DTv5q0M8isPwZ/pYrkmtN1EbRkA3CZXI91hmDlI1jPBNToT0CEZUNIefeYo7gXwCf73eccZdRqoovPpQQa1pMVQqZwT4qnxu8ZjsSE6hqL6lj1Tn2hYUxDCxtBnb9gNcn6gpgEeJ8e+5JVPTzREB66jy63YudneDo54bpD5deCBBqWxAADxZlOlj4DmF1xRZJBv4AV7CvQucWDYaokCIzOydcGAIr3j2YakhhfLFhcyKlHGvnbAZzc2IpV/89ZMYBzBcYnaRtuU9eQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2020 10:49:22.0452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6b6e730f-7930-45cb-87a3-08d7dbaa7f37 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3456 Subject: Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Van Haaren, Harry > Sent: Wednesday, April 8, 2020 6:37 PM > To: Phil Yang ; thomas@monjalon.net; Ananyev, > Konstantin ; > stephen@networkplumber.org; maxime.coquelin@redhat.com; > dev@dpdk.org > Cc: david.marchand@redhat.com; jerinj@marvell.com; > hemant.agrawal@nxp.com; Honnappa Nagarahalli > ; Gavin Hu ; > Ruifeng Wang ; Joyce Kong > ; nd ; stable@dpdk.org; nd > > Subject: RE: [PATCH v3 07/12] service: remove rte prefix from static func= tions >=20 > > -----Original Message----- > > From: Phil Yang > > Sent: Wednesday, April 8, 2020 11:15 AM > > To: Van Haaren, Harry ; > thomas@monjalon.net; > > Ananyev, Konstantin ; > > stephen@networkplumber.org; maxime.coquelin@redhat.com; > dev@dpdk.org > > Cc: david.marchand@redhat.com; jerinj@marvell.com; > hemant.agrawal@nxp.com; > > Honnappa Nagarahalli ; Gavin Hu > > ; Ruifeng Wang ; Joyce > Kong > > ; nd ; stable@dpdk.org; nd > > > Subject: RE: [PATCH v3 07/12] service: remove rte prefix from static > functions > > > > Is this really a "Fix"? The internal function names were not exported > > > in the .map file, so are not part of public ABI. This is an internal > > > naming improvement (thanks for doing cleanup), but I don't think the > > > Fixes: tags make sense? > > > > > > Also I'm not sure if we want to port this patch back to stable? Chang= ing > > > (internal) function names seems like unnecessary churn, and hence ris= k > to a > > > stable release, without any benefit? > > OK. > > I will remove these tags in the next version and split the service core > > patches from the original series into a series by itself. >=20 > Cool - good idea to split. >=20 > Perhaps we should focus on getting bugfixes in for the existing code, bef= ore > doing cleanup? It would make backports easier if churn is minimal. >=20 > Suggesting patches order (first to last) > 1. bugfixes/things to backport > 2. cleanups > 3. C11 atomic optimizations That is a good idea. I will follow this order. >=20 >=20 > > Thanks, > > Phil >=20 > Thanks, and I'll get to reading/reviewing your and Honnappa's feedback la= ter > today. >=20 > -H