From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4E29A046B for ; Mon, 22 Jul 2019 18:24:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A57701BF0F; Mon, 22 Jul 2019 18:24:00 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00056.outbound.protection.outlook.com [40.107.0.56]) by dpdk.org (Postfix) with ESMTP id C4DA41BF07 for ; Mon, 22 Jul 2019 18:23:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aIJsP2QoUqDYTrnmhUT8dlMUrVlAi/QPahDQLQJOEYGN9aiVjHMqIpBLnSjW+IrhseLtvo6PurG8L8PRy7OC6a6AEoaG/nIRIfiN2p0sEhzqqj5Ci/iPyAdyiIaeH7ZtW9YOt8ES2ZikDu1rFJtdvoqbR8WRuBjt45Rk+ECBjBWzbqzdXWo0KV3YZiIt8fWh6waoitTPs5shMyGEX8LxAv6FR2bt7i6uOQm5qH6iwBEwMzpJouN8odJ2TPGo/uIpYmO/Jb/5UZr5cCimAde7aQQQU7vjDkzETMQzdce6PGPzvyKBJgidq+zVnNSeLeY5qR2/efWyJHK4k6L1zO22nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93PwZy4iQ6zT0+R8lsqCsPh+AcudGnIv99nV6Suq9es=; b=WVXG65gWVMLkEZNtkCYNYrO9oryeTA9t59D7cdktmTqwaoNf34VzZq2Con1RhEZ+DFTyAjGSB1BAb/FI5uFq1jNTRsPqsEbgXlhv2k0GtxAm2UB8apKFUjI1ETqvBc5Lm6xl6rPD3DWwdEqT1P5MDjzGsIVoCIo7nHZLoOoO/VQUD5EwhIMelthbN/JSgdP4Z8SkoTdO1q3zjBAcgYQGftFsOrtKV+yoRZcrKJuX9W6fnTJxx+qxDrq5/cK+zxFspG3r9B1nY8swRfP+sk4aZiV9EiM/gEe6UMyLZOhB7rdjNlqEb/h58FRYwqomvYZ6HZDOChLgHifiacfJ6aMHew== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93PwZy4iQ6zT0+R8lsqCsPh+AcudGnIv99nV6Suq9es=; b=Adu2c/W21Ns37n+/EW7NkrjB0t8+nmFNxLPZyKAmdUiWVm/FF/to1zfhFe4UogK2GSg6HuPVWgcbQMvv4VRnWG8vfkXI31EH0s/IQKVeU7xXVhxzQq3QOhiZjDIa6xBqTusroFpKg/Dj8Fv74kFLcxV2FwZvhvghMr9YxFqb0LI= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (10.255.27.75) by VE1PR08MB4973.eurprd08.prod.outlook.com (10.255.158.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.14; Mon, 22 Jul 2019 16:23:57 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::f4e4:378b:49d3:d876]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::f4e4:378b:49d3:d876%5]) with mapi id 15.20.2094.013; Mon, 22 Jul 2019 16:23:57 +0000 From: "Phil Yang (Arm Technology China)" To: "jerinj@marvell.com" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "gage.eads@intel.com" , "hemant.agrawal@nxp.com" , Honnappa Nagarahalli , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare exchange Thread-Index: AQHVQJiRscoQvAgJG0CyuAb6aLunTKbW0lmw Date: Mon, 22 Jul 2019 16:23:57 +0000 Message-ID: References: <1561257671-10316-1-git-send-email-phil.yang@arm.com> <1563800774-2710-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: cc766c8f-4e58-437b-8743-66a7b70b1501.0 x-checkrecipientchecked: true authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5aa5ae25-336e-457c-5d17-08d70ec0ff12 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4973; x-ms-traffictypediagnostic: VE1PR08MB4973: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-microsoft-antispam-prvs: nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 01068D0A20 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(39860400002)(396003)(136003)(376002)(366004)(13464003)(199004)(189003)(8676002)(316002)(3846002)(55016002)(9686003)(54906003)(110136005)(86362001)(6116002)(6436002)(6246003)(71190400001)(71200400001)(68736007)(2906002)(53936002)(66446008)(64756008)(66556008)(66476007)(66946007)(25786009)(5660300002)(256004)(99286004)(305945005)(476003)(76176011)(7696005)(14454004)(478600001)(186003)(486006)(11346002)(4326008)(446003)(66066001)(55236004)(52536014)(6506007)(53546011)(76116006)(102836004)(2501003)(7736002)(33656002)(229853002)(8936002)(81156014)(26005)(81166006)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4973; H:VE1PR08MB4640.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gPnd/FlkD4+9sLK84eN5dB53325OIdvldgMrXDu2HgwxOD2W3BEaPzfMpLalFaESCJp2eh26rVOZasW2bIgmdZYffVpKAywOcb/S9kbUzGm4jX6j/BQSB+BylE04XUlfij6XSjVN61nUu/oHTYP37mSEXqmmK157/uvEXif9C8ogaFF4PVZia/EyBkfm6CGyRnCmi+uzQ9QBC4NBFC4HMVzl1dDO6b4c+kBZSEp/fTMXBwU6wcvG0SdNG1/MyWmSjTUvIdaJkIZ4LjGO1Id3+AFBFmtaRKeMq6mLXrE340CSr7ssRZzereyl7w6AymzmfxP8qs1s/4gEJ0re8I25GFqTAFHiLRM2jk5D1QERPHdEISKqTwchi9Tf1le6+Dp7ov1Hw19gpBgjpKXRPCiFQTjVwbk4GQUEl2z1rzDMDWU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa5ae25-336e-457c-5d17-08d70ec0ff12 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 16:23:57.0418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Phil.Yang@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4973 Subject: Re: [dpdk-dev] [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Monday, July 22, 2019 10:20 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: thomas@monjalon.net; gage.eads@intel.com; > hemant.agrawal@nxp.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > Subject: RE: [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare > exchange >=20 > It looks good. Some minor comments. Thanks. Updated in the new version. >=20 > > -----Original Message----- > > From: Phil Yang > > Sent: Monday, July 22, 2019 6:36 PM > > To: dev@dpdk.org > > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran > ; > > gage.eads@intel.com; hemant.agrawal@nxp.com; > > Honnappa.Nagarahalli@arm.com; gavin.hu@arm.com; nd@arm.com > > Subject: [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare > > exchange > > ---------------------------------------------------------------------- > > Add 128-bit atomic compare exchange on aarch64. > > > > Suggested-by: Jerin Jacob > > Signed-off-by: Phil Yang > > Tested-by: Honnappa Nagarahalli > > Reviewed-by: Honnappa Nagarahalli > > > > diff --git a/config/common_base b/config/common_base index > > 8ef75c2..16dea5a 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -1067,3 +1067,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=3Dy # Compile > the > > eventdev application # CONFIG_RTE_APP_EVENTDEV=3Dy > > + > > +# > > +# Compile ARM LSE ATOMIC instructions > > +# > > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dn >=20 >=20 > Move this config after "Compile Environment Abstraction Layer" section. > Now it is at end of file. Better to group the configs. >=20 >=20 > > diff --git a/config/defconfig_arm64-octeontx2-linuxapp-gcc > > b/config/defconfig_arm64-octeontx2-linuxapp-gcc > > index f20da24..a6508e8 100644 > > --- a/config/defconfig_arm64-octeontx2-linuxapp-gcc > > +++ b/config/defconfig_arm64-octeontx2-linuxapp-gcc > > @@ -19,3 +19,6 @@ CONFIG_RTE_EAL_IGB_UIO=3Dn > > > > # Max supported NIX LFs > > CONFIG_RTE_MAX_VFIO_GROUPS=3D128 > > + > > +# arm64 LSE ATOMIC support > > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dy >=20 > Move this config after CONFIG_RTE_MAX_LCORE=3D24 >=20 >=20 > > diff --git a/config/defconfig_arm64-thunderx2-linuxapp-gcc > > b/config/defconfig_arm64-thunderx2-linuxapp-gcc > > index cc5c64b..17b6dec 100644 > > --- a/config/defconfig_arm64-thunderx2-linuxapp-gcc > > +++ b/config/defconfig_arm64-thunderx2-linuxapp-gcc > > @@ -6,6 +6,7 @@ > > > > CONFIG_RTE_MACHINE=3D"thunderx2" > > > > +CONFIG_RTE_ARM_FEATURE_ATOMICS=3Dy > > CONFIG_RTE_CACHE_LINE_SIZE=3D64 > > CONFIG_RTE_MAX_NUMA_NODES=3D2 > > CONFIG_RTE_MAX_LCORE=3D256 >=20 > Move the new config here