From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BC612A0528;
Fri, 17 Jul 2020 11:41:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 63F701BF9D;
Fri, 17 Jul 2020 11:41:24 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
(mail-eopbgr40085.outbound.protection.outlook.com [40.107.4.85])
by dpdk.org (Postfix) with ESMTP id 41B6F1BF93
for <dev@dpdk.org>; Fri, 17 Jul 2020 11:41:23 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=OfD2sXno7OxvF39y5I6hm7DdhDhiCYMeW+rFML4iA60=;
b=eaPmQnGN/5kXo0Qm2y6TpfyEYflgE8B1VD0MheK+yFIuY2x3QhfCDvBCYqWOAJzsgKPiu99qduB0M7YLHfcPm8zxJY5pbXZj9xR9QJO7W04U1JxLSb9ljshg//Oi30ev1WHUOchhapZm21Nb5LlOnvvrRrzOTFRXiHg+OBXW1Y4=
Received: from DB6PR1001CA0040.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::26)
by AM0PR08MB3059.eurprd08.prod.outlook.com (2603:10a6:208:5c::20)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Fri, 17 Jul
2020 09:41:20 +0000
Received: from DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
(2603:10a6:4:55:cafe::bb) by DB6PR1001CA0040.outlook.office365.com
(2603:10a6:4:55::26) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend
Transport; Fri, 17 Jul 2020 09:41:20 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123)
smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified)
header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none
header.from=arm.com;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
63.35.35.123 as permitted sender) receiver=protection.outlook.com;
client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by
DB5EUR03FT059.mail.protection.outlook.com (10.152.21.175) with
Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 09:41:20 +0000
Received: ("Tessian outbound c4059ed8d7bf:v62");
Fri, 17 Jul 2020 09:41:20 +0000
X-CR-MTA-TID: 64aa7808
Received: from 088169137196.2
by 64aa7808-outbound-1.mta.getcheckrecipient.com id
A3FE89A0-2D8E-4BA7-AF32-BACD88750F54.1;
Fri, 17 Jul 2020 09:41:15 +0000
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 088169137196.2
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384);
Fri, 17 Jul 2020 09:41:15 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=FeOhY8h5MedZKqr02fcU58GN1FuM53ORtraRD7fEGmV2KILf59sM8cGgh2rlFZDfLhzCBnKkJK6vVJ494CFdMRAcK8hUxuBZ4K6Ki2ByuWMTfvPd5Ln3Jrzu8URKgsOo/VHHUuaB8KhPIGqdKK7VrV3XNsP8tOprWeI0M9lS6VtjF307hCNj7r/E39of1fibCfpZk1RbGc4UEYPyWbjhngbx7t0ABkIWle/wNTzjr96FW5rPd0jJNji7II28aqkjIChJLyTLhPp32BJfmED6Xz0s1MEB7Ap2HQ+w8kYg7trGOAcArbI9kvEK2VHdE16QieU2atgOkYCXoCYNT1BzSg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=OfD2sXno7OxvF39y5I6hm7DdhDhiCYMeW+rFML4iA60=;
b=d/fKNDfS3gTrQOHvC/ywvAwDtnjmS+8YxElvpu+I3IXcvh7GevpxbtQywQ8c1W5ea0itakk/5jSZO8K1+wFD1aUyI2nJ7kxacQyOlVaYntHHJFvHN1YYoAbNu5jumsB3OdEe9Ee4f9SXwZMinzMoRarpa0HzR961z4PEq0BH4zqWkBI6+U06PJpurjUjY2I7fv8k/PPvbJoVNmYOhrzSeZzTaXDsFdY56A09Dti3L3LSiKIlAVwHLCkSTAwRcSkEdtpV5iEZ/fORt39H/uPCvlz83xv9/fjJdFs5xa1B+K8hRx5Wpo0lJ6/Ti145f6J6zU9lqPNmamR/tcDsH3LLmQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass
header.d=arm.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
s=selector2-armh-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=OfD2sXno7OxvF39y5I6hm7DdhDhiCYMeW+rFML4iA60=;
b=eaPmQnGN/5kXo0Qm2y6TpfyEYflgE8B1VD0MheK+yFIuY2x3QhfCDvBCYqWOAJzsgKPiu99qduB0M7YLHfcPm8zxJY5pbXZj9xR9QJO7W04U1JxLSb9ljshg//Oi30ev1WHUOchhapZm21Nb5LlOnvvrRrzOTFRXiHg+OBXW1Y4=
Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11)
by VE1PR08MB5086.eurprd08.prod.outlook.com (2603:10a6:803:107::29)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.23; Fri, 17 Jul
2020 09:41:13 +0000
Received: from VE1PR08MB4640.eurprd08.prod.outlook.com
([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com
([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020
09:41:13 +0000
From: Phil Yang <Phil.Yang@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>
CC: "john.mcnamara@intel.com" <john.mcnamara@intel.com>, Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com>, "drc@linux.vnet.ibm.com"
<drc@linux.vnet.ibm.com>, "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>, "jerinj@marvell.com"
<jerinj@marvell.com>, "konstantin.ananyev@intel.com"
<konstantin.ananyev@intel.com>, Ola Liljedahl <Ola.Liljedahl@arm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>, Ruifeng Wang
<Ruifeng.Wang@arm.com>, nd <nd@arm.com>, nd <nd@arm.com>
Thread-Topic: [PATCH v9 2/3] devtools: prevent use of rte atomic APIs in
future patches
Thread-Index: AQHWXBVpZaC4bBsMCEimJaafiAPncKkLff6Q
Date: Fri, 17 Jul 2020 09:41:13 +0000
Message-ID: <VE1PR08MB4640CF83A5CFBAE1FA9FA611E97C0@VE1PR08MB4640.eurprd08.prod.outlook.com>
References: <1594875225-5850-1-git-send-email-phil.yang@arm.com>
<1594962519-20619-1-git-send-email-phil.yang@arm.com>
<1594962519-20619-3-git-send-email-phil.yang@arm.com>
<6407830.sh6FQpANWY@thomas>
In-Reply-To: <6407830.sh6FQpANWY@thomas>
Accept-Language: zh-CN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ts-tracking-id: f7b4bab8-419a-4d62-baaf-874b0af2505a.0
x-checkrecipientchecked: true
Authentication-Results-Original: monjalon.net; dkim=none (message not signed)
header.d=none; monjalon.net;
dmarc=none action=none header.from=arm.com;
x-originating-ip: [203.126.0.111]
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 25e847bb-ecd6-4cf3-31e7-08d82a358fd6
x-ms-traffictypediagnostic: VE1PR08MB5086:|AM0PR08MB3059:
x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM0PR08MB305934A2C3BA0BBFBBC505A1E97C0@AM0PR08MB3059.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: true
x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: G7hiK5yvbrNWa2bAUfhgf0N/JFaD0WD659RaSd1OuXo2oh4c0+TkRaLE2D3ZnUdqZ9FXEF/cMQUEuG22wJH645IfV2quSEwTraeJRlC+8ppgscQw2RiWw/a71g9Nm2TmTawTcy8y7eWcMaKRODBsjrfzVkJGTbuq8e57gXCbtuTJarw+EAnoLbr0V3bO5c+hQ+Zy8no4qhg1eudJV5oe+EeK5HhplR1R1qKvceQLHtcaxjJsYrlSlOwDIZJDoCZDhGTyzB1Povqgs1UApfB5VTSN7juYBSueBBJAuRWMeUkbVZpowGm9ga+cnvZdF65X4gVLrysm9Llum+Ng3p6JYd+9LpJx7H7XFRKaWj/NVtkYAnRUPXWy2kJd0h41zpHUYFInysQcy0Wae0pmVJ2SzLqe/aI/igaAAhr1P29KdzDEbRRb2G6d39N+tbPLSmtpE9G7EPv797PhyLZnegJRAw==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en;
SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com;
PTR:; CAT:NONE; SFTY:;
SFS:(4636009)(376002)(136003)(346002)(39860400002)(366004)(396003)(6506007)(71200400001)(33656002)(7696005)(55016002)(52536014)(26005)(966005)(9686003)(186003)(8676002)(5660300002)(8936002)(478600001)(76116006)(66946007)(66476007)(66556008)(64756008)(66446008)(83380400001)(2906002)(316002)(54906003)(4326008)(6916009)(86362001)(21314003);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: vTdY5+YyA2nLxxxxRopnJvM558Q6KNLTCnR8MgFBoAKgeEt5UDtPnpBS51j6qsyVy/75uUwFJ4tcPwBjUZZUhq7hVfHdg3x1HaAQJBeABdmJ+NkbLDj1wVVhOit1BURLF59DRWQdCkYi4EWkBN+GOHQ1BqAVC+ZJU/TD3YRJb2VgFOQ1LlJXZuxu3vE+/x4UkRQP/frIkHJFqHOvyL8ZGXSATNauI/cfBP2ygeF50VD1QUzanT5FS8Fwm/XXI2uyyaNlMMkXTFcH30RlR4DFUUKUJ94l5ClKkh5SjmTQz86XQ1B6cWaJaDIxJa1oTym/x6nRCfx4FMWRdoMq3IRJQ3O8n2tAs/jYJKDyXH0gL6h3q9Txy4g4CNqeV3vUa2KH0sqys5zf6RePq/6WoFdhWIjhQ/9LEeAlRgCi9WHtlgm22dVXACw/O3qEZ2ga7R3Kgr5BXFaWbH8UmEw+JV0hquablQlX8689g0EORwvkF9YzvCAMl6oR2yFKFIahA3ZD
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5086
Original-Authentication-Results: monjalon.net; dkim=none (message not signed)
header.d=none; monjalon.net;
dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:;
IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com;
PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:;
SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966005)(83380400001)(6862004)(26005)(356005)(70206006)(8676002)(82740400003)(186003)(82310400002)(4326008)(33656002)(81166007)(478600001)(47076004)(70586007)(316002)(6506007)(86362001)(2906002)(7696005)(54906003)(9686003)(966005)(8936002)(5660300002)(55016002)(336012)(52536014)(21314003);
DIR:OUT; SFP:1101;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 3ec76069-91b0-412b-1a2b-08d82a358b5e
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: iT5qTOa9fg1nL7L+ClIb+gTdPfXeZ5/BppYVv8u7aDDDM0UiK7B6xpM9/h70tGrikYF2z2qSyYJxtTGfnw6dDyXoDi9LbdHMAV7qN/sTjp/AMjRcg+VqCyG7bIgkTc2oJOOUpI+l9mWSeS8qIa7n4g++SNakHpucBhqhyQsfVvxesMKNspMhGxDpubFE/h51eCWns89NrC+NyhRUDSGsPg1WJEstMZhPuwVGuSAsAtIVQuqu/PD5LySXxj07HZ+qpGv3eXv7rNVm+4oNu2F4Vr8yfSvwaFQ+xV0oCorZOAp3zdcwEIl10Ia6Sge7DAbNu5vlYoOKKGuQRTQ/mbW52eQ7LuQSZ7hwUEShgy2iaUpVRHO3HufalPhAAKpa44WLLpyA0o7sHw3l1pe8dRxCITukng2+/xDu91a+A02Q/yVrbFx5A7/j80d//q3tcAOMbfu8UAYjGHqwg19HfNuXpntTuR4pcmRK7MtDgKrrTr6QfAJjxGA0SjUw3OlsYlT1
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 09:41:20.6498 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 25e847bb-ecd6-4cf3-31e7-08d82a358fd6
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123];
Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT059.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3059
Subject: Re: [dpdk-dev] [PATCH v9 2/3] devtools: prevent use of rte atomic
APIs in future patches
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Thomas Monjalon <thomas@monjalon.net> wrties:
> > In order to deprecate the rte_atomic and rte_smp barrier APIs, prevent
> > the patches from using these APIs and __sync builtins in new code.
> >
> > On x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) is quite
> expensive
> > for SMP case. Flag the new code which use __atomic_thread_fence API.
>=20
> When receiving such message error, I would look at the explanations
> in the git history. Unfortunately this commit log does not reference
> the documentation. Please add a link and give the 4 direct replacements
> in this commit log.
I will update it in v10. Thanks.
How about putting it like this? (Truncated the long link to pass the long l=
ine check)
"
In order to deprecate the rte_atomic and rte_smp barrier APIs[1], prevent
the patches from using these APIs and __sync builtins in new code. Please
use __atomic builtins instead of __sync builtins, rte_atomicNN_xxx and
rte_smp_[r/w]mb APIs.
On x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) is quite expensive for
SMP case. Flag the new code which use __atomic_thread_fence API. Please
use rte_thread_fence API instead of __atomic_thread_fence.
[1] Refer to the locks-and-atomic-operations section in
https://doc.dpdk.org/guides/prog_guide/writing_efficient_code.html.
"