From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E04CA0540; Mon, 13 Jul 2020 05:02:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAF3F1C1B9; Mon, 13 Jul 2020 05:02:38 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00057.outbound.protection.outlook.com [40.107.0.57]) by dpdk.org (Postfix) with ESMTP id 2BE4E1C1B7 for ; Mon, 13 Jul 2020 05:02:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jprhhqq9meqk4jaQyFLspwnFl8H1/+fzAgJCk0vvHMs=; b=rxEZr8dgjXWSAJ6Iosl6on5Q7zuZPRHbPhVNPYyngdH5qqxJdQblYw2CbXdRHE97RpEZQKu2fTYcLiMNfalchH+KT2mksFx7H2DsCUvu1PKzERqQ1Xdp404DR3MoHoe0NFBf+Us5BKpbyI0GOBZGQ9k0tcj6Uu9hqkaHT8vRtbU= Received: from DB6PR0601CA0011.eurprd06.prod.outlook.com (2603:10a6:4:7b::21) by DB7PR08MB4586.eurprd08.prod.outlook.com (2603:10a6:10:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Mon, 13 Jul 2020 03:02:35 +0000 Received: from DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b:cafe::b0) by DB6PR0601CA0011.outlook.office365.com (2603:10a6:4:7b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20 via Frontend Transport; Mon, 13 Jul 2020 03:02:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT008.mail.protection.outlook.com (10.152.20.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Mon, 13 Jul 2020 03:02:35 +0000 Received: ("Tessian outbound 7de93d801f24:v62"); Mon, 13 Jul 2020 03:02:35 +0000 X-CR-MTA-TID: 64aa7808 Received: from baf7672546de.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C30B787C-8D2A-4F0E-8BB5-1CD97DD319D0.1; Mon, 13 Jul 2020 03:02:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id baf7672546de.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 13 Jul 2020 03:02:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIfDNFtIS3EGV0zLNdQImCDDhwkp2mMNRAamzB+W27NXr8ArcruMBiKN+vslvvX36bK69mZjl+Qmvn12aFAvX3Zuk4IqPivrtnLwV8HrMPgG6t57cDWiYG3gJFlsXlwjJ1OmY1G9jjNyMfSmcQroRrSgmcfmz+e/BTTTkslbvp4rNYZdFdctnKfvOr1HV3+2LNXsuF5ROy+AOHSjYrLvYBtTGFjJn1fl0oMomJw9UT9IcYypwI64TLeS6lBoEOs8Rm2+zq4k5+3mjU1dgwUskYtQBVtnlO2x63sbFGPU7jns4qKz5VzC5DvRiWR0yEFzqxOgsduGxrunNKXVGy6+vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jprhhqq9meqk4jaQyFLspwnFl8H1/+fzAgJCk0vvHMs=; b=Kpq/E5sHC+z3SKxCH9wdDW9LeRlH7MBLbAPPP06rpa6LeeFKRLh4If1A9mSPySGXrab6OmXzdSxnggqfsqzuRQ2SJ9r6BKMUns6i7kszunykbYHKKh4SpfBpkGmBmEk4tq/fmoIC5G+lYLHDRIZIOGzS+E2Oa0+5gpFOwvl/UR87obf4ha4knGfsUGRAqVmpJ9XSEkXkUcM2ciT29RvRqNZUNyTIpxaO6oOUMojBLfGBUx5zugpD2YwGrLflxsGWhoaGfxS9ukV57IOmS1exhgrh9W3O48sChgyCgxpPhvCEWEqEHu/mkDKDKNcxfCpfE2uSjwxmKp55nX1o0vpNMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jprhhqq9meqk4jaQyFLspwnFl8H1/+fzAgJCk0vvHMs=; b=rxEZr8dgjXWSAJ6Iosl6on5Q7zuZPRHbPhVNPYyngdH5qqxJdQblYw2CbXdRHE97RpEZQKu2fTYcLiMNfalchH+KT2mksFx7H2DsCUvu1PKzERqQ1Xdp404DR3MoHoe0NFBf+Us5BKpbyI0GOBZGQ9k0tcj6Uu9hqkaHT8vRtbU= Received: from VE1PR08MB4640.eurprd08.prod.outlook.com (2603:10a6:802:b2::11) by VE1PR08MB5088.eurprd08.prod.outlook.com (2603:10a6:803:110::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.22; Mon, 13 Jul 2020 03:02:27 +0000 Received: from VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863]) by VE1PR08MB4640.eurprd08.prod.outlook.com ([fe80::c2e:9ccb:a690:6863%6]) with mapi id 15.20.3174.025; Mon, 13 Jul 2020 03:02:27 +0000 From: Phil Yang To: "matan@mellanox.com" , "shahafs@mellanox.com" , "viacheslavo@mellanox.com" CC: Honnappa Nagarahalli , "drc@linux.vnet.ibm.com" , nd , Phil Yang , "dev@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt Thread-Index: AQHWSThFaNly+vF+uUWgch7NBAwMH6kE8E8w Date: Mon, 13 Jul 2020 03:02:27 +0000 Message-ID: References: <20200410164127.54229-7-gavin.hu@arm.com> <1592900807-13289-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1592900807-13289-1-git-send-email-phil.yang@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 926e907d-831e-4961-b30a-81b7374dad20.0 x-checkrecipientchecked: true Authentication-Results-Original: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b773d033-c019-47a8-72cb-08d826d931c5 x-ms-traffictypediagnostic: VE1PR08MB5088:|DB7PR08MB4586: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1+4G4CA3n2yoi0P/8KXE7L79gB0nlXifnAFO9VgdigQB29sGRNe2e4jEzIHghQ5Jk1G1MHgYM/rQ0TZYUj511INFgK2vsMrkds02xugTwl/m73K3mNZ4XsLUagy+X465xRxtvSNkbdF3rcsg119l+rvLLm3QZLF8WYbnBB62taXMoHbu/qnsIqU03f1dg45Bs2BjEHFfnzgsVZyc6EYNrQwujPp3u/oLiSCwkL0OzVHjcVYZyF8ZlcIotFqPz4lgCNtKpiTCUynxSxsyKwFpcpAeOi4eaRdTYpmQb9RFRrN8QZFV6XmG6UeHeXCWRwH2WX6j0cGwNjNG3xtWeEG9+Q3+B460mCPCBluxi+r716RlKrZKwRg+JwviaJU3Waoq6rDSyBSk5TTBfzN9ydysww== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB4640.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(8936002)(5660300002)(33656002)(7696005)(54906003)(966005)(4326008)(86362001)(498600001)(83380400001)(2906002)(26005)(6506007)(55016002)(52536014)(64756008)(66946007)(66446008)(66556008)(110136005)(66476007)(186003)(53546011)(9686003)(76116006)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: V1NSQISLkBi8Zb+ZO8Q+cPAtsTLR9kuqubquPX/GGdygjVlPaYu3alicxIbegfwjzFJpZd08aMfeFVt41wYjacuenxGYnOhH8ac/KUZtC6NO8dRgo113ozEukJ4VcQIogwIwDklw8udy4V5ciDmYm5LvE2FonK8tFmPvxPtfB5PaiSXSENgCrV8nF9LkL45FgKDrDRo9YmXl9I6ngweAbdJpKtuQztZ98tS6j8F9tSetyl3IW4+r01jKLId8EW4xTEBRVkBPESKZ5raohBst20++vJcp29TXYkp9P/oOd28THA8+K4roJOAeM2YKJUwM97XylwspJ6AtqfNpaWEMIVqRMWVX66YpJ9hRjR95/QNMhUS/epkCftHGvQmrTJSJdw0MktatvsNRttEkTd8Hicce+djDVnvZ2ZFPe9Qlp6WMqKszeF10SUukqVAKcUWbqCH45u+5f0piHZxKQtUt2+2Aqr0MejhKk8/gM0SVajE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5088 Original-Authentication-Results: mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(39850400004)(376002)(346002)(46966005)(47076004)(2906002)(966005)(81166007)(186003)(4326008)(5660300002)(7696005)(83380400001)(478600001)(82740400003)(26005)(356005)(70206006)(52536014)(53546011)(8936002)(86362001)(6506007)(336012)(9686003)(110136005)(316002)(70586007)(55016002)(33656002)(54906003)(82310400002); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: f6f47bf1-5eb2-4daa-8fb1-08d826d92cc8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jDMi16naH+bfrhakjL5zTo7dcZnUKhdIIDZngx+VV5yenuC59mDjnhfqLvW7yztIQ8OhxxjtaqhW+1d7GCHZqtdn5IFIhGm5OylHWdqOGJ9uJh95FQDzDx6wnLdO1dPmQUa4i4ILIcwBL3MmYDiSWhMu58k+bIybfCJPBh2WXHW/fwu2yuDQA/cQMYncsVmRXhYpgef9L48F/agOPtAqh9LPuqExMxhTTa3WYJ1CZRKkm69uQXqWAMrCqTVGJzNSOK99437HtHP+85ZQkFl06x3vQ3JSaFF5UekuN+DXBhJjCwIVVSUauP/3IWSVDy1ZpzLMwfws04vGQesAoDc3ReXvkeDbs1bRHMlpixWrxKJIfBu/rBAMGYfoGQnkKr4mMwaKke2G2VwTdUuIdlGz8nDWyCSRmKmfY+dyKjNDK8HU9WWnoewGmxzI794a3nG87zCNUrzuoB0mVgWv65WE3BJ6cL7CvjeI9Xfs8BTeJpI= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2020 03:02:35.7647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b773d033-c019-47a8-72cb-08d826d931c5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4586 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, We are also doing C11 atomics converting for other components. Your insight would be much appreciated. Thanks, Phil Yang > -----Original Message----- > From: dev On Behalf Of Phil Yang > Sent: Tuesday, June 23, 2020 4:27 PM > To: dev@dpdk.org > Cc: matan@mellanox.com; shahafs@mellanox.com; > viacheslavo@mellanox.com; Honnappa Nagarahalli > ; drc@linux.vnet.ibm.com; nd > > Subject: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packe= t > RQ buffer refcnt >=20 > Use c11 atomics with explicit ordering instead of the rte_atomic ops > which enforce unnecessary barriers on aarch64. >=20 > Signed-off-by: Phil Yang > --- > v3: > Split from the patchset: > http://patchwork.dpdk.org/cover/68159/ >=20 > drivers/net/mlx5/mlx5_rxq.c | 2 +- > drivers/net/mlx5/mlx5_rxtx.c | 16 +++++++++------- > drivers/net/mlx5/mlx5_rxtx.h | 2 +- > 3 files changed, 11 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index dda0073..7f487f1 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1545,7 +1545,7 @@ mlx5_mprq_buf_init(struct rte_mempool *mp, > void *opaque_arg, >=20 > memset(_m, 0, sizeof(*buf)); > buf->mp =3D mp; > - rte_atomic16_set(&buf->refcnt, 1); > + __atomic_store_n(&buf->refcnt, 1, __ATOMIC_RELAXED); > for (j =3D 0; j !=3D strd_n; ++j) { > shinfo =3D &buf->shinfos[j]; > shinfo->free_cb =3D mlx5_mprq_buf_free_cb; > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index e4106bf..f0eda88 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1595,10 +1595,11 @@ mlx5_mprq_buf_free_cb(void *addr > __rte_unused, void *opaque) > { > struct mlx5_mprq_buf *buf =3D opaque; >=20 > - if (rte_atomic16_read(&buf->refcnt) =3D=3D 1) { > + if (__atomic_load_n(&buf->refcnt, __ATOMIC_RELAXED) =3D=3D 1) { > rte_mempool_put(buf->mp, buf); > - } else if (rte_atomic16_add_return(&buf->refcnt, -1) =3D=3D 0) { > - rte_atomic16_set(&buf->refcnt, 1); > + } else if (unlikely(__atomic_sub_fetch(&buf->refcnt, 1, > + __ATOMIC_RELAXED) =3D=3D 0)) { > + __atomic_store_n(&buf->refcnt, 1, __ATOMIC_RELAXED); > rte_mempool_put(buf->mp, buf); > } > } > @@ -1678,7 +1679,8 @@ mlx5_rx_burst_mprq(void *dpdk_rxq, struct > rte_mbuf **pkts, uint16_t pkts_n) >=20 > if (consumed_strd =3D=3D strd_n) { > /* Replace WQE only if the buffer is still in use. */ > - if (rte_atomic16_read(&buf->refcnt) > 1) { > + if (__atomic_load_n(&buf->refcnt, > + __ATOMIC_RELAXED) > 1) { > mprq_buf_replace(rxq, rq_ci & wq_mask, > strd_n); > /* Release the old buffer. */ > mlx5_mprq_buf_free(buf); > @@ -1790,9 +1792,9 @@ mlx5_rx_burst_mprq(void *dpdk_rxq, struct > rte_mbuf **pkts, uint16_t pkts_n) > void *buf_addr; >=20 > /* Increment the refcnt of the whole chunk. */ > - rte_atomic16_add_return(&buf->refcnt, 1); > - MLX5_ASSERT((uint16_t)rte_atomic16_read(&buf- > >refcnt) <=3D > - strd_n + 1); > + __atomic_add_fetch(&buf->refcnt, 1, > __ATOMIC_ACQUIRE); > + MLX5_ASSERT(__atomic_load_n(&buf->refcnt, > + __ATOMIC_RELAXED) <=3D strd_n + 1); > buf_addr =3D RTE_PTR_SUB(addr, > RTE_PKTMBUF_HEADROOM); > /* > * MLX5 device doesn't use iova but it is necessary in > a > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index 26621ff..0fc15f3 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -78,7 +78,7 @@ struct rxq_zip { > /* Multi-Packet RQ buffer header. */ > struct mlx5_mprq_buf { > struct rte_mempool *mp; > - rte_atomic16_t refcnt; /* Atomically accessed refcnt. */ > + uint16_t refcnt; /* Atomically accessed refcnt. */ > uint8_t pad[RTE_PKTMBUF_HEADROOM]; /* Headroom for the first > packet. */ > struct rte_mbuf_ext_shared_info shinfos[]; > /* > -- > 2.7.4