From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id 4DAEB2986 for ; Fri, 3 May 2019 05:57:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MOVEoXE0xV5zKPehgQ5IS1jkSp+iasP2m3T2KCmQck=; b=PpDG63XCCqNksk1fK5X9e0V6U9taMk5wSyaiHoaW9DLDBbX55Zfw3k/KCTsbntAv1aoNEAPn2xHtxViDuj+BzjRe9PNv753IGr9Y79veKj1lQmZ9+DCaJiLU2YN2coq+VlD5ac4kQIf31Wm2SaI0ZAQ2UaxGFxW663RnuFyYuTI= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4976.eurprd08.prod.outlook.com (10.255.158.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Fri, 3 May 2019 03:57:20 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f5e3:39bc:e7d9:dfea]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f5e3:39bc:e7d9:dfea%5]) with mapi id 15.20.1856.012; Fri, 3 May 2019 03:57:20 +0000 From: Honnappa Nagarahalli To: "yskoh@mellanox.com" CC: "jerinj@marvell.com" , Shahaf Shuler , "thomas@monjalon.net" , "dev@dpdk.org" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH 1/2] build: add option for armv8 crypto extension Thread-Index: AQHVAIqJi6+tD8kKt0qrWwX0uZr+wKZXNayggAAeHYCAAXMfIA== Date: Fri, 3 May 2019 03:57:20 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43c9d962-b2f1-4a6a-a91a-08d6cf7b715b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4976; x-ms-traffictypediagnostic: VE1PR08MB4976: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(39860400002)(136003)(376002)(189003)(199004)(6246003)(8936002)(9686003)(3846002)(6116002)(66946007)(53936002)(4326008)(52536014)(76116006)(2501003)(6916009)(66066001)(25786009)(5660300002)(316002)(66446008)(73956011)(64756008)(7736002)(6436002)(2351001)(66476007)(14444005)(33656002)(476003)(81156014)(1730700003)(8676002)(66556008)(76176011)(54906003)(99286004)(81166006)(446003)(5640700003)(55016002)(11346002)(229853002)(7696005)(26005)(71190400001)(71200400001)(186003)(102836004)(14454004)(486006)(6506007)(256004)(53546011)(68736007)(72206003)(305945005)(74316002)(2906002)(508600001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4976; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cRQhlJAe99AJC3dSc1aL5ptFaiyEhxs4Nh+p18GLsHvz0WIkCFifRYq836UeGzDuRS2Hb7MIhRSBWmZolSRWkjdz+Y7RAm/+Gq/wyo0VWT0PGVgB/KzOkL6J0B3qAlB83sjS9anA1jDLFuK36K2ghhQSIXflsxss/mcDpZA9BWYK9oC2SrbnJtwoMcNqUQv9uMLx4pCQIoKLX5vSialJ7ZdycPQBBaspQM4CBQdzjLFEeYCNyV76cQxgrtktHJ/W3qEvsuWWCc7EUva+zh+7OBhZRtkuJ3WBFJn9xey+eQWvt36j2aFBeiXHdT+jtOMRQW5vJptBvQQ8L+Keuiaz0/gLV1wK2HJ5DUXsQmJ9C3LGGDjS9Rr8iKO36LzLjkI+vh/jpwOM0veGcEHdh0/410IYAHtmIbakRGv9VLVP70c= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43c9d962-b2f1-4a6a-a91a-08d6cf7b715b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 03:57:20.8182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4976 Subject: Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 03:57:22 -0000 > > On May 1, 2019, at 9:13 PM, Honnappa Nagarahalli > wrote: > > > >> Per armv8 crypto extension support, make build always enable it by > >> default as long as compiler supports the feature while meson build > >> only enables it for 'default' machine of generic armv8 architecture. > >> For example, specifying '- mcpu=3Dcortex-a72' doesn't enable it but > >> '+crypto' is required in order to enable the feature. > >> > >> It is also known that not all the armv8 platforms have the crypto exte= nsion. > >> For example, Mellanox BlueField has a variant which doesn't have it. > >> If crypto enabled binary runs on such a platform, rte_eal_init() fails= . > >> > >> Therefore, an option to control this feature is necessary. It is > >> still enabled by default but can be selectively disabled by vendors. > > The distro/binary portable image needs to be built without crypto. Only= the > crypto drivers need to be built with crypto and at run time we need to ho= ok > up the correct function pointers. So, IMO, by default crypto should be > disabled and should be enabled in specific target machine configs. >=20 > I make it enabled by default simply because I don't want to change the > current behavior, no breakage. Good point. I don't know how to handle it either. But, the current distro p= ackage will not work on BlueField as it is built with crypto enabled. So, I= MO, we should consider it as bug. >=20 > I also want to hear from others. Jerin, Thomas? >=20 > >> > >> Signed-off-by: Yongseok Koh > >> --- > >> config/arm/meson.build | 16 +++++++++------- > >> config/common_armv8a_linux | 1 + > >> drivers/crypto/armv8/Makefile | 4 ++++ > >> meson_options.txt | 2 ++ > >> mk/machine/armv8a/rte.vars.mk | 4 ++++ > >> 5 files changed, 20 insertions(+), 7 deletions(-) > >> > >> diff --git a/config/arm/meson.build b/config/arm/meson.build index > >> 7fa6ed3105..3b53842d08 100644 > >> --- a/config/arm/meson.build > >> +++ b/config/arm/meson.build > >> @@ -8,6 +8,8 @@ march_opt =3D '-march=3D@0@'.format(machine) > >> arm_force_native_march =3D false arm_force_default_march =3D (machine= =3D=3D > >> 'default') > >> > >> +crypto_flag =3D get_option('enable_armv8_crypto') ? '+crypto' : '' > >> + > >> flags_common_default =3D [ > >> # Accelarate rte_memcpy. Be sure to run unit test > >> (memcpy_perf_autotest) > >> # to determine the best threshold in code. Refer to notes in source > >> file @@ -74,14 +76,14 @@ flags_octeontx2_extra =3D [ > >> ['RTE_USE_C11_MEM_MODEL', true]] > >> > >> machine_args_generic =3D [ > >> - ['default', ['-march=3Darmv8-a+crc+crypto']], > >> + ['default', ['-march=3Darmv8-a+crc' + crypto_flag]], > >> ['native', ['-march=3Dnative']], > >> - ['0xd03', ['-mcpu=3Dcortex-a53']], > >> - ['0xd04', ['-mcpu=3Dcortex-a35']], > >> - ['0xd07', ['-mcpu=3Dcortex-a57']], > >> - ['0xd08', ['-mcpu=3Dcortex-a72']], > >> - ['0xd09', ['-mcpu=3Dcortex-a73']], > >> - ['0xd0a', ['-mcpu=3Dcortex-a75']]] > >> + ['0xd03', ['-mcpu=3Dcortex-a53' + crypto_flag]], > >> + ['0xd04', ['-mcpu=3Dcortex-a35' + crypto_flag]], > >> + ['0xd07', ['-mcpu=3Dcortex-a57' + crypto_flag]], > >> + ['0xd08', ['-mcpu=3Dcortex-a72' + crypto_flag]], > >> + ['0xd09', ['-mcpu=3Dcortex-a73' + crypto_flag]], > >> + ['0xd0a', ['-mcpu=3Dcortex-a75' + crypto_flag]]] > >> > >> machine_args_cavium =3D [ > >> ['default', ['-march=3Darmv8-a+crc+crypto','-mcpu=3Dthunderx']], > >> diff --git a/config/common_armv8a_linux b/config/common_armv8a_linux > >> index 72091de1c7..0efa3e2eb2 100644 > >> --- a/config/common_armv8a_linux > >> +++ b/config/common_armv8a_linux > >> @@ -5,6 +5,7 @@ > >> #include "common_linux" > >> > >> CONFIG_RTE_MACHINE=3D"armv8a" > >> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=3Dy > >> > >> CONFIG_RTE_ARCH=3D"arm64" > >> CONFIG_RTE_ARCH_ARM64=3Dy > >> diff --git a/drivers/crypto/armv8/Makefile > >> b/drivers/crypto/armv8/Makefile index f71f6b14a4..867a5206cf 100644 > >> --- a/drivers/crypto/armv8/Makefile > >> +++ b/drivers/crypto/armv8/Makefile > >> @@ -4,6 +4,10 @@ > >> > >> include $(RTE_SDK)/mk/rte.vars.mk > >> > >> +ifneq ($(CONFIG_RTE_ENABLE_ARMV8_CRYPTO),y) > >> +$(error "Please enable CONFIG_RTE_ENABLE_ARMV8_CRYPTO") endif > >> + > >> ifneq ($(MAKECMDGOALS),clean) > >> ifneq ($(MAKECMDGOALS),config) > >> ifeq ($(ARMV8_CRYPTO_LIB_PATH),) > >> diff --git a/meson_options.txt b/meson_options.txt index > >> 16d9f92c65..4ca09771de 100644 > >> --- a/meson_options.txt > >> +++ b/meson_options.txt > >> @@ -4,6 +4,8 @@ option('allow_invalid_socket_id', type: 'boolean', val= ue: > >> false, > >> description: 'allow out-of-range NUMA socket id\'s for platforms > >> that don\'t report the value correctly') option('drivers_install_subd= ir', type: > >> 'string', value: 'dpdk/pmds-', > >> description: 'Subdirectory of libdir where to install PMDs. Defaults > >> to using a versioned subdirectory.') > >> +option('enable_armv8_crypto', type: 'boolean', value: true, > >> + description: 'enable armv8 crypto extension') > >> option('enable_docs', type: 'boolean', value: false, > >> description: 'build documentation') > >> option('enable_kmods', type: 'boolean', value: true, diff --git > >> a/mk/machine/armv8a/rte.vars.mk b/mk/machine/armv8a/rte.vars.mk > index > >> 8252efbb7b..4893d01a2d 100644 > >> --- a/mk/machine/armv8a/rte.vars.mk > >> +++ b/mk/machine/armv8a/rte.vars.mk > >> @@ -28,4 +28,8 @@ > >> # CPU_LDFLAGS =3D > >> # CPU_ASFLAGS =3D > >> > >> +ifeq ($(CONFIG_RTE_ENABLE_ARMV8_CRYPTO),y) > >> MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc+crypto > >> +else > >> +MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc endif > >> -- > >> 2.11.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DC8D6A0AC5 for ; Fri, 3 May 2019 05:57:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D41E02B89; Fri, 3 May 2019 05:57:23 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00084.outbound.protection.outlook.com [40.107.0.84]) by dpdk.org (Postfix) with ESMTP id 4DAEB2986 for ; Fri, 3 May 2019 05:57:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MOVEoXE0xV5zKPehgQ5IS1jkSp+iasP2m3T2KCmQck=; b=PpDG63XCCqNksk1fK5X9e0V6U9taMk5wSyaiHoaW9DLDBbX55Zfw3k/KCTsbntAv1aoNEAPn2xHtxViDuj+BzjRe9PNv753IGr9Y79veKj1lQmZ9+DCaJiLU2YN2coq+VlD5ac4kQIf31Wm2SaI0ZAQ2UaxGFxW663RnuFyYuTI= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4976.eurprd08.prod.outlook.com (10.255.158.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.11; Fri, 3 May 2019 03:57:20 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f5e3:39bc:e7d9:dfea]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::f5e3:39bc:e7d9:dfea%5]) with mapi id 15.20.1856.012; Fri, 3 May 2019 03:57:20 +0000 From: Honnappa Nagarahalli To: "yskoh@mellanox.com" CC: "jerinj@marvell.com" , Shahaf Shuler , "thomas@monjalon.net" , "dev@dpdk.org" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH 1/2] build: add option for armv8 crypto extension Thread-Index: AQHVAIqJi6+tD8kKt0qrWwX0uZr+wKZXNayggAAeHYCAAXMfIA== Date: Fri, 3 May 2019 03:57:20 +0000 Message-ID: References: <20190502015806.41497-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43c9d962-b2f1-4a6a-a91a-08d6cf7b715b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4976; x-ms-traffictypediagnostic: VE1PR08MB4976: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0026334A56 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(39860400002)(136003)(376002)(189003)(199004)(6246003)(8936002)(9686003)(3846002)(6116002)(66946007)(53936002)(4326008)(52536014)(76116006)(2501003)(6916009)(66066001)(25786009)(5660300002)(316002)(66446008)(73956011)(64756008)(7736002)(6436002)(2351001)(66476007)(14444005)(33656002)(476003)(81156014)(1730700003)(8676002)(66556008)(76176011)(54906003)(99286004)(81166006)(446003)(5640700003)(55016002)(11346002)(229853002)(7696005)(26005)(71190400001)(71200400001)(186003)(102836004)(14454004)(486006)(6506007)(256004)(53546011)(68736007)(72206003)(305945005)(74316002)(2906002)(508600001)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4976; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cRQhlJAe99AJC3dSc1aL5ptFaiyEhxs4Nh+p18GLsHvz0WIkCFifRYq836UeGzDuRS2Hb7MIhRSBWmZolSRWkjdz+Y7RAm/+Gq/wyo0VWT0PGVgB/KzOkL6J0B3qAlB83sjS9anA1jDLFuK36K2ghhQSIXflsxss/mcDpZA9BWYK9oC2SrbnJtwoMcNqUQv9uMLx4pCQIoKLX5vSialJ7ZdycPQBBaspQM4CBQdzjLFEeYCNyV76cQxgrtktHJ/W3qEvsuWWCc7EUva+zh+7OBhZRtkuJ3WBFJn9xey+eQWvt36j2aFBeiXHdT+jtOMRQW5vJptBvQQ8L+Keuiaz0/gLV1wK2HJ5DUXsQmJ9C3LGGDjS9Rr8iKO36LzLjkI+vh/jpwOM0veGcEHdh0/410IYAHtmIbakRGv9VLVP70c= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43c9d962-b2f1-4a6a-a91a-08d6cf7b715b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2019 03:57:20.8182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4976 Subject: Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503035720.wo7NizNZAqkdqNh8XLVF7o4uYjCIwcWjt1d8dj4C5Lo@z> > > On May 1, 2019, at 9:13 PM, Honnappa Nagarahalli > wrote: > > > >> Per armv8 crypto extension support, make build always enable it by > >> default as long as compiler supports the feature while meson build > >> only enables it for 'default' machine of generic armv8 architecture. > >> For example, specifying '- mcpu=3Dcortex-a72' doesn't enable it but > >> '+crypto' is required in order to enable the feature. > >> > >> It is also known that not all the armv8 platforms have the crypto exte= nsion. > >> For example, Mellanox BlueField has a variant which doesn't have it. > >> If crypto enabled binary runs on such a platform, rte_eal_init() fails= . > >> > >> Therefore, an option to control this feature is necessary. It is > >> still enabled by default but can be selectively disabled by vendors. > > The distro/binary portable image needs to be built without crypto. Only= the > crypto drivers need to be built with crypto and at run time we need to ho= ok > up the correct function pointers. So, IMO, by default crypto should be > disabled and should be enabled in specific target machine configs. >=20 > I make it enabled by default simply because I don't want to change the > current behavior, no breakage. Good point. I don't know how to handle it either. But, the current distro p= ackage will not work on BlueField as it is built with crypto enabled. So, I= MO, we should consider it as bug. >=20 > I also want to hear from others. Jerin, Thomas? >=20 > >> > >> Signed-off-by: Yongseok Koh > >> --- > >> config/arm/meson.build | 16 +++++++++------- > >> config/common_armv8a_linux | 1 + > >> drivers/crypto/armv8/Makefile | 4 ++++ > >> meson_options.txt | 2 ++ > >> mk/machine/armv8a/rte.vars.mk | 4 ++++ > >> 5 files changed, 20 insertions(+), 7 deletions(-) > >> > >> diff --git a/config/arm/meson.build b/config/arm/meson.build index > >> 7fa6ed3105..3b53842d08 100644 > >> --- a/config/arm/meson.build > >> +++ b/config/arm/meson.build > >> @@ -8,6 +8,8 @@ march_opt =3D '-march=3D@0@'.format(machine) > >> arm_force_native_march =3D false arm_force_default_march =3D (machine= =3D=3D > >> 'default') > >> > >> +crypto_flag =3D get_option('enable_armv8_crypto') ? '+crypto' : '' > >> + > >> flags_common_default =3D [ > >> # Accelarate rte_memcpy. Be sure to run unit test > >> (memcpy_perf_autotest) > >> # to determine the best threshold in code. Refer to notes in source > >> file @@ -74,14 +76,14 @@ flags_octeontx2_extra =3D [ > >> ['RTE_USE_C11_MEM_MODEL', true]] > >> > >> machine_args_generic =3D [ > >> - ['default', ['-march=3Darmv8-a+crc+crypto']], > >> + ['default', ['-march=3Darmv8-a+crc' + crypto_flag]], > >> ['native', ['-march=3Dnative']], > >> - ['0xd03', ['-mcpu=3Dcortex-a53']], > >> - ['0xd04', ['-mcpu=3Dcortex-a35']], > >> - ['0xd07', ['-mcpu=3Dcortex-a57']], > >> - ['0xd08', ['-mcpu=3Dcortex-a72']], > >> - ['0xd09', ['-mcpu=3Dcortex-a73']], > >> - ['0xd0a', ['-mcpu=3Dcortex-a75']]] > >> + ['0xd03', ['-mcpu=3Dcortex-a53' + crypto_flag]], > >> + ['0xd04', ['-mcpu=3Dcortex-a35' + crypto_flag]], > >> + ['0xd07', ['-mcpu=3Dcortex-a57' + crypto_flag]], > >> + ['0xd08', ['-mcpu=3Dcortex-a72' + crypto_flag]], > >> + ['0xd09', ['-mcpu=3Dcortex-a73' + crypto_flag]], > >> + ['0xd0a', ['-mcpu=3Dcortex-a75' + crypto_flag]]] > >> > >> machine_args_cavium =3D [ > >> ['default', ['-march=3Darmv8-a+crc+crypto','-mcpu=3Dthunderx']], > >> diff --git a/config/common_armv8a_linux b/config/common_armv8a_linux > >> index 72091de1c7..0efa3e2eb2 100644 > >> --- a/config/common_armv8a_linux > >> +++ b/config/common_armv8a_linux > >> @@ -5,6 +5,7 @@ > >> #include "common_linux" > >> > >> CONFIG_RTE_MACHINE=3D"armv8a" > >> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=3Dy > >> > >> CONFIG_RTE_ARCH=3D"arm64" > >> CONFIG_RTE_ARCH_ARM64=3Dy > >> diff --git a/drivers/crypto/armv8/Makefile > >> b/drivers/crypto/armv8/Makefile index f71f6b14a4..867a5206cf 100644 > >> --- a/drivers/crypto/armv8/Makefile > >> +++ b/drivers/crypto/armv8/Makefile > >> @@ -4,6 +4,10 @@ > >> > >> include $(RTE_SDK)/mk/rte.vars.mk > >> > >> +ifneq ($(CONFIG_RTE_ENABLE_ARMV8_CRYPTO),y) > >> +$(error "Please enable CONFIG_RTE_ENABLE_ARMV8_CRYPTO") endif > >> + > >> ifneq ($(MAKECMDGOALS),clean) > >> ifneq ($(MAKECMDGOALS),config) > >> ifeq ($(ARMV8_CRYPTO_LIB_PATH),) > >> diff --git a/meson_options.txt b/meson_options.txt index > >> 16d9f92c65..4ca09771de 100644 > >> --- a/meson_options.txt > >> +++ b/meson_options.txt > >> @@ -4,6 +4,8 @@ option('allow_invalid_socket_id', type: 'boolean', val= ue: > >> false, > >> description: 'allow out-of-range NUMA socket id\'s for platforms > >> that don\'t report the value correctly') option('drivers_install_subd= ir', type: > >> 'string', value: 'dpdk/pmds-', > >> description: 'Subdirectory of libdir where to install PMDs. Defaults > >> to using a versioned subdirectory.') > >> +option('enable_armv8_crypto', type: 'boolean', value: true, > >> + description: 'enable armv8 crypto extension') > >> option('enable_docs', type: 'boolean', value: false, > >> description: 'build documentation') > >> option('enable_kmods', type: 'boolean', value: true, diff --git > >> a/mk/machine/armv8a/rte.vars.mk b/mk/machine/armv8a/rte.vars.mk > index > >> 8252efbb7b..4893d01a2d 100644 > >> --- a/mk/machine/armv8a/rte.vars.mk > >> +++ b/mk/machine/armv8a/rte.vars.mk > >> @@ -28,4 +28,8 @@ > >> # CPU_LDFLAGS =3D > >> # CPU_ASFLAGS =3D > >> > >> +ifeq ($(CONFIG_RTE_ENABLE_ARMV8_CRYPTO),y) > >> MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc+crypto > >> +else > >> +MACHINE_CFLAGS +=3D -march=3Darmv8-a+crc endif > >> -- > >> 2.11.0 > >