From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Gavin Hu <Gavin.Hu@arm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head
Date: Wed, 18 Dec 2019 17:42:07 +0000 [thread overview]
Message-ID: <VE1PR08MB514919D74E060AA23584C30898530@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CY4PR1801MB18636F8816B1334FA8A5F263DE650@CY4PR1801MB1863.namprd18.prod.outlook.com>
<snip>
> >> >>
> >> >> static __rte_always_inline void
> >> >> -otx2_ssogws_head_wait(struct otx2_ssogws *ws, const uint8_t
> >> >wait_flag)
> >> >> +otx2_ssogws_head_wait(struct otx2_ssogws *ws)
> >> >> {
> >> >> - while (wait_flag && !(otx2_read64(ws->tag_op) &
> >> >BIT_ULL(35)))
> >> >> +#ifdef RTE_ARCH_ARM64
> >> >> + uint64_t tag;
> >> >> +
> >> >> + asm volatile (
> >> >> + " ldr %[tag], [%[tag_op]] \n"
> >> >"ldxr" should be used, exclusive-load is required to "monitor" the
> >> >location, then a write to the location will cause clear of the
> >> >exclusive monitor, thus a wake up event is generated implicitly.
> >>
> >> As I have mentioned in the commit log:
> >> "SSO signals EVENTI to allow cores to exit from wfe when they are
> >> waiting for specific operations in which one of them is setting HEAD
> >> bit in GWS_TAG."
> >If you have other expected wake up sources, that is ok. Just curious is
> >this signal explicitly sent to quit WFE?
>
> AFAIK yes, explicitly sent to quit WFE.
Pavan, is the wake up event sent to the particular core that is waiting on this head or is it sent to all the cores?
prev parent reply other threads:[~2019-12-18 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:12 pbhagavatula
2019-10-24 15:53 ` Gavin Hu (Arm Technology China)
2019-10-25 4:26 ` Pavan Nikhilesh Bhagavatula
2019-10-25 16:34 ` Gavin Hu (Arm Technology China)
2019-10-25 17:06 ` Pavan Nikhilesh Bhagavatula
2019-10-27 9:12 ` Gavin Hu (Arm Technology China)
2019-10-30 13:33 ` Jerin Jacob
2019-12-18 17:42 ` Honnappa Nagarahalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB514919D74E060AA23584C30898530@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).