From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1098AA046B for ; Tue, 23 Jul 2019 21:10:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE6541C0C5; Tue, 23 Jul 2019 21:10:15 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63]) by dpdk.org (Postfix) with ESMTP id E4CA91C0B9 for ; Tue, 23 Jul 2019 21:10:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZVL1RBeyX/IuUXpNmRAdHoVPTCH9ASkugGAG1xO0bbc=; b=YGWODXkZ7YgVBUY3cGVJ1foNH6boabSDFd2HmXF5V6QAuKCbEIob1vfNk8JZFZfUyssxAdrjlTsWpKvnAnSDuqcmEVbkxpWvubfFSpO6ns+RfCporlcXyTI8N1UFn1VThy2h+Vwst1Ut2Dmjzq/dkc0D4xXmkpLmwNlvLEn8OMc= Received: from VI1PR08CA0167.eurprd08.prod.outlook.com (2603:10a6:800:d1::21) by VI1PR0802MB2607.eurprd08.prod.outlook.com (2603:10a6:800:b9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 19:10:12 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by VI1PR08CA0167.outlook.office365.com (2603:10a6:800:d1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12 via Frontend Transport; Tue, 23 Jul 2019 19:10:12 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18 via Frontend Transport; Tue, 23 Jul 2019 19:10:10 +0000 Received: ("Tessian outbound 9f6cbbf0b897:v24"); Tue, 23 Jul 2019 19:10:08 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8063b7fad83a.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.5.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA03AB0F-EA99-443B-8E6E-4918B8F51DC3.1; Tue, 23 Jul 2019 19:10:03 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8063b7fad83a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Tue, 23 Jul 2019 19:10:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hikk0DB2iarYNyriakWnhU+YUZ4IwLpgZLNIlP0amudFsVXjqBrAeHYZeqiCBtX2HbxUn3HGmpNjrR0I2Fp1wNxOCFNxvQ3H4GDSiUysujkimJSsscoqnrIVr08leO0JyZ5wdj1xT+I0nQQK/KEIQphMfw5X0PTeD8tWW2JZICSTUEd+8vkuNvqEsg1RyWSxuYirmoCno6mGscyNF/759VBtdXgJVXZW5bjjPlK9rc8i+tZodjIbXhF8Vv/ohfKF7ghtcMlMRhRcKiW+/ND0NE8xsTxhdcMFOu4PmylMbLSQ4eUV0iFsbX61n2c/N46fUg+M1OFhmC3lNrXoKG0raQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZVL1RBeyX/IuUXpNmRAdHoVPTCH9ASkugGAG1xO0bbc=; b=jZ+KLkNF96doQnBxnfl9E4EoASU9Msw6ZfkP4sd/+OWm9H0efXWuI1cf+6/m1c0UJXU7cOzG8PN+H4rZW+esIzYTqC02exjNW7fAMVbqrET7uY+q1aklm8U1rSxB75Kwbzk4P5ykFuMDxcwZpm5G1Sd9JHJVWGt/oKM84WPuOnA/kk1OK9whTJdXCrD0vlMuw7ZjUxPONHdN89qfVO0ZCW2HFVMqQlZnxnOPbWBUdY3T0YvheCHStJ1SlIz4treqBGPJBfa24TesXtUSubbjq5l9k3l/BVlPx2vGyY+ylxAMslLIPDb0YpjqLmwRWhnA5TUxzGBxTOc0aNRWtPOkAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZVL1RBeyX/IuUXpNmRAdHoVPTCH9ASkugGAG1xO0bbc=; b=YGWODXkZ7YgVBUY3cGVJ1foNH6boabSDFd2HmXF5V6QAuKCbEIob1vfNk8JZFZfUyssxAdrjlTsWpKvnAnSDuqcmEVbkxpWvubfFSpO6ns+RfCporlcXyTI8N1UFn1VThy2h+Vwst1Ut2Dmjzq/dkc0D4xXmkpLmwNlvLEn8OMc= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4880.eurprd08.prod.outlook.com (10.255.113.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 19:10:01 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128%3]) with mapi id 15.20.2115.005; Tue, 23 Jul 2019 19:10:01 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger , "Gavin Hu (Arm Technology China)" CC: "dev@dpdk.org" , nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v3 5/5] config: add WFE config entry for aarch64 Thread-Index: AQHVQW14GCW8VZ5pjUmJIImgaUZoeabYf3gAgAAMXDA= Date: Tue, 23 Jul 2019 19:10:01 +0000 Message-ID: References: <1563896626-44862-1-git-send-email-gavin.hu@arm.com> <1563896626-44862-6-git-send-email-gavin.hu@arm.com> <20190723110508.1b68c1a9@hermes.lan> In-Reply-To: <20190723110508.1b68c1a9@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 219623b7-4fcb-4fdf-a954-0681642cdbdb.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 63f8dda5-6215-4663-bf61-08d70fa1625d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4880; X-MS-TrafficTypeDiagnostic: VE1PR08MB4880:|VI1PR0802MB2607: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 0107098B6C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(979002)(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(199004)(189003)(2906002)(66946007)(66476007)(64756008)(76116006)(6246003)(66446008)(53936002)(52536014)(66066001)(71190400001)(66556008)(71200400001)(229853002)(6436002)(86362001)(99286004)(81166006)(9686003)(6506007)(6636002)(8936002)(7736002)(76176011)(8676002)(486006)(305945005)(102836004)(25786009)(74316002)(81156014)(14454004)(3846002)(186003)(33656002)(55016002)(316002)(5660300002)(68736007)(4326008)(54906003)(256004)(11346002)(110136005)(14444005)(6116002)(26005)(446003)(7696005)(476003)(478600001)(21314003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4880; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: Ev/Eh2EH4tS7+Bq+SjR+e0h281zMeCdwuZ0VEBHcCjYD65cChnnnVTDnfEqKRRRdN+dokTO8jVgz+qGlp37lLyc5ZaJzAAQ3HLQT3FRdKfwOttNsLK5tsMEEMHQEuo4tn5WW8ziSuvmytjPaovHW586Rasga52S7F+2MvOwKP2odGawYZkh7OqjRyvAqmnsMkj/O+8wj+a3OwH5HI6gkdNqFi0CMuRqoAgZSaSOK3tOYkyKRBpi1yXJNCuBFIkWZTij3PIgcD+kY2VCPtrJfPrzAkF08agNIinr9FVqP4J8lISxAZ/IpKIMEo69m7dyOVeSDwu2HvZwqENPUIEFpJFgNmoDhXFbddsmesNMd3dpCjLLNZHDOknI6DEsQik7Qrz7jPDr5P5x40U0OcVSssWKq3oWn6kNLSkY/ZkivKtw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4880 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(4636009)(396003)(376002)(346002)(39860400002)(136003)(2980300002)(199004)(189003)(70586007)(97756001)(76176011)(70206006)(7696005)(102836004)(52536014)(356004)(33656002)(76130400001)(8746002)(26005)(4326008)(6506007)(50466002)(6636002)(5660300002)(6246003)(2906002)(81166006)(54906003)(81156014)(229853002)(63350400001)(63370400001)(26826003)(9686003)(14444005)(110136005)(55016002)(316002)(478600001)(8676002)(23726003)(74316002)(446003)(305945005)(3846002)(25786009)(14454004)(486006)(99286004)(336012)(47776003)(66066001)(36906005)(86362001)(11346002)(8936002)(22756006)(476003)(7736002)(6116002)(126002)(186003)(46406003)(21314003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0802MB2607; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 66584733-d6e9-4edf-1e7e-08d70fa15c76 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(710020)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR0802MB2607; NoDisclaimer: True X-Forefront-PRVS: 0107098B6C X-Microsoft-Antispam-Message-Info: xAWfCajhYFueCL7xaiMgpz0bS7MyTH3GwrT+Upvtxlapn+XupmHSBTCdk015LsWIA7kJ+GDC/XJs81O8lZufxPBwa9K/wQdEmCbdbwA6isT4ZRO7Zze5yfb0zxN8qIXkncTds9KUmCCI95BLCmJqb06Sb9m1UP7U2Pb5R5oUMTxauDhIQ/K96dI9xKga5JPNr5r2g59jmy3YfMIq5+6qW9EDHsszA5tXOdiH1382Oh2Lo1INt8nMWsL+yrmk6WcrbLc2YHuJu9eE1NJtC5nQUAUgWOXuxMpzCZ/Sn/S8UGJkZE5XzJXUf/I9wN+J6mO4XAtuekZq7V7Jk5UcLM9FmtS0J2S8HzmD6vyDhP3MndZh/GMN2LRVZoDkLv6wur21TrYlVIGjxhx4YClxGcLhr97D1tORvvGxysP2L06ZCm4= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2019 19:10:10.9926 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63f8dda5-6215-4663-bf61-08d70fa1625d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2607 Subject: Re: [dpdk-dev] [PATCH v3 5/5] config: add WFE config entry for aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > On Tue, 23 Jul 2019 23:43:46 +0800 > Gavin Hu wrote: >=20 > > Add the RTE_USE_WFE configuration entry for aarch64, disabled by defaul= t. > > It can be enabled selectively based on the performance benchmarking. > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Ruifeng Wang > > Reviewed-by: Steve Capper > > Reviewed-by: Honnappa Nagarahalli > > Acked-by: Pavan Nikhilesh > > --- > > config/arm/meson.build | 1 + > > config/common_armv8a_linux | 6 ++++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > > 979018e..496813a 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -116,6 +116,7 @@ impl_dpaa =3D ['NXP DPAA', flags_dpaa, > > machine_args_generic] > > impl_dpaa2 =3D ['NXP DPAA2', flags_dpaa2, machine_args_generic] > > > > dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > > +dpdk_conf.set('RTE_USE_WFE', 0) > > > > if not dpdk_conf.get('RTE_ARCH_64') > > dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64) diff --git > > a/config/common_armv8a_linux b/config/common_armv8a_linux index > > 481712e..48c7ab5 100644 > > --- a/config/common_armv8a_linux > > +++ b/config/common_armv8a_linux > > @@ -12,6 +12,12 @@ CONFIG_RTE_ARCH_64=3Dy > > > > CONFIG_RTE_FORCE_INTRINSICS=3Dy > > > > +# Use WFE instructions to implement the rte_wait_for_equal_xxx APIs, > > +# calling these APIs put the cores enter low power state while > > +waiting # for the memory address to be become equal to the expected va= lue. > > +# This is supported only by aarch64. > > +CONFIG_RTE_USE_WFE=3Dn > > + > > # Maximum available cache line size in arm64 implementations. > > # Setting to maximum available cache line size in generic config # > > to address minimum DMA alignment across all arm64 implementations. >=20 > Introducing config options is a maintenance nightmare. > How are distributions supposed to ship a package? > Does full regression test get done on both options? >=20 > The user should not be able to change this. Agree with these concerns here. In our tests, we are finding that this patc= h does not result in performance improvements on all micro-architectures. M= ay be these micro-architectures will evolve in the future knowing that WFE = is being used in DPDK. But at this point, it does not make sense to enable = this by default. This means additional testing/regression with the flag ena= bled. We could add this to Travis build (Travis yml file). Currently, this patch will address use cases where the target hardware/envi= ronment is known during compilation.