From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1221AA2E8D for ; Thu, 5 Sep 2019 17:46:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2911A1EDB8; Thu, 5 Sep 2019 17:46:06 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20059.outbound.protection.outlook.com [40.107.2.59]) by dpdk.org (Postfix) with ESMTP id B8E6D1EDB2; Thu, 5 Sep 2019 17:46:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyVHX3M64s57UaM52ueMYsnX/MKlvHt8fUjaVFCfDvk=; b=PnVUqzGnz1zoE1URR33wtBb5shPPT3DGiKWoFm9xuYjWccmOLpWyq1Jn1zOpmkfb7L/W8eSQh3rQnD2IfckuF2xy70w1sSudKA1LLL6RUh/N/iMdAXy2p/PNuj/70X5XZobxpIn/A5gg4pCLmVLX5y5EKVG0ob9Ivwbfv3h7Qro= Received: from VI1PR08CA0182.eurprd08.prod.outlook.com (2603:10a6:800:d2::12) by DB8PR08MB4105.eurprd08.prod.outlook.com (2603:10a6:10:b0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.18; Thu, 5 Sep 2019 15:46:02 +0000 Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::203) by VI1PR08CA0182.outlook.office365.com (2603:10a6:800:d2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.13 via Frontend Transport; Thu, 5 Sep 2019 15:46:02 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Thu, 5 Sep 2019 15:46:00 +0000 Received: ("Tessian outbound 108f768cde3d:v27"); Thu, 05 Sep 2019 15:46:00 +0000 X-CR-MTA-TID: 64aa7808 Received: from c317c0904e44.1 (cr-mta-lb-1.cr-mta-net [104.47.9.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 40F7B361-659B-4626-9EAA-033AC5CE7A70.1; Thu, 05 Sep 2019 15:45:55 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c317c0904e44.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Thu, 05 Sep 2019 15:45:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfjDUrdX8CVEm4JHwL/orqZkJumT3cjrTD2MD2Y4xtGUBljRql/us9Qzhi8S+nHSpEhXraoH5DQTHupDeh+Nc3+wcR1nplPJUTmBUHeqz0jnJfrWSwS/eaGcUZmMKqWiUgiCHkcjjPr3zUsVAb3R7CD+CGfFRO6vC0krRwA4LCeuBuC4ex7YNPovgzPd4UgyACC2NDefPLS7OoHxtjsB2/iPBYkryq7IT6r9Io4H57H/Kf0+EKyziv9GNmSt9sJ1Y6JtIUw5OaFbrWW2yShtGlhhoXwo2OZbBwfyDmbm0qKEArLalQ/ts31KvoQ2wmkMkWOWAleVI/ScAxEplVBqPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyVHX3M64s57UaM52ueMYsnX/MKlvHt8fUjaVFCfDvk=; b=WfG4d6wWSnChJxLPDjpYjy8dhOMAh8EB/GEMTDtVTTq6Up1xHM6MlXhhxt2nxX1wyQB6dFnczR0e46+dc6YX4/SzWAiSddfM/Un1FaPUXvcItInFePRzCUrJ7QYiz4PUFSEHGW3rZFb+cEYNEOETahZTLWqvQf7zlcRo9ZvYdnIKZh0cD2IuXYPQJOQK1Kxmn0vJnhHsvj6n20U0yR4xif1FvhDdhaRP3hgjkN8ajeL8WWOfHwifRWZa/JVBXGr0Dz/o+YGvvfxnSqAtZk7bRF8iT9G2zxhQEHSClBdQa4B0G5tDHJjaXF7l39ClO+TeTpDPqycCaKnPKwGjKHK3pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tyVHX3M64s57UaM52ueMYsnX/MKlvHt8fUjaVFCfDvk=; b=PnVUqzGnz1zoE1URR33wtBb5shPPT3DGiKWoFm9xuYjWccmOLpWyq1Jn1zOpmkfb7L/W8eSQh3rQnD2IfckuF2xy70w1sSudKA1LLL6RUh/N/iMdAXy2p/PNuj/70X5XZobxpIn/A5gg4pCLmVLX5y5EKVG0ob9Ivwbfv3h7Qro= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4925.eurprd08.prod.outlook.com (10.255.114.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.20; Thu, 5 Sep 2019 15:45:53 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128%3]) with mapi id 15.20.2178.023; Thu, 5 Sep 2019 15:45:53 +0000 From: Honnappa Nagarahalli To: Ferruh Yigit , David Hunt , Byron Marohn , Pablo de Lara Guarch , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Reshma Pattan CC: "dev@dpdk.org" , "stable@dpdk.org" , nd , nd Thread-Topic: [PATCH 10/10] test: fix global variable multiple definitions Thread-Index: AQHVY/m0VVTQoVJvFkC1C4y8cd0X5KcdOZAQ Date: Thu, 5 Sep 2019 15:45:53 +0000 Message-ID: References: <20190905145315.19395-1-ferruh.yigit@intel.com> <20190905145315.19395-11-ferruh.yigit@intel.com> In-Reply-To: <20190905145315.19395-11-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 084c2876-cb0c-4704-b5ac-533c5b3baf47.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5ac5f5df-6942-4c3a-6f2e-08d73218271b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4925; X-MS-TrafficTypeDiagnostic: VE1PR08MB4925:|DB8PR08MB4105: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1728;OLM:1728; x-forefront-prvs: 015114592F X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(366004)(396003)(346002)(376002)(199004)(189003)(66066001)(6116002)(3846002)(476003)(11346002)(446003)(229853002)(110136005)(9686003)(33656002)(53936002)(55016002)(76176011)(478600001)(6436002)(14454004)(6506007)(26005)(102836004)(2906002)(186003)(86362001)(7696005)(486006)(305945005)(81156014)(81166006)(7736002)(99286004)(7416002)(74316002)(8676002)(5660300002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(316002)(25786009)(6246003)(54906003)(4326008)(256004)(8936002)(71190400001)(52536014)(14444005)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4925; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: DYefD9Myt0+LdxAaDCQ6CP987w61FN6lEuMe5y4jUCweUwiMAnV/q6Wlwi9RimwLmkanS9dyrob1pbGYeZMFlDWyHel6TFDKN9iv6pavsnJWrzDr8jNC5aQEhg7Q868AAjBos+OQffVE6sy6/MVXp20exm0C+OiYDc40Sile3UrxhysaOGuXaqCBrovo+ZrrD+swOqsCUXYh8t4Vlr4dEzpQSUaPxq9pcJ2SBT4YMMT6wdak/LxABLqtrDMTGkIFG0cqzSGMVq014C8Nf/3mqLbTiZdEfBAhxJW/ecTNMnGa7xFThCIYZfvWbf92egc/pE4VldS6Bl88pJi3A1j1jId6em36x3f/iqQpBu+F/8n93L0oamPkdI4SA8YpioZ9lqDA/OfsCJLMKwM6QiLXOgkWXYM5sv4oVJizrmdJy70= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4925 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39860400002)(376002)(346002)(2980300002)(189003)(199004)(7736002)(478600001)(8746002)(8676002)(25786009)(33656002)(3846002)(23726003)(14454004)(6116002)(5660300002)(2906002)(8936002)(81166006)(81156014)(86362001)(36906005)(99286004)(7696005)(47776003)(316002)(305945005)(74316002)(66066001)(450100002)(110136005)(14444005)(446003)(6246003)(229853002)(6506007)(52536014)(76130400001)(63370400001)(97756001)(76176011)(70206006)(55016002)(70586007)(126002)(476003)(486006)(11346002)(102836004)(9686003)(186003)(336012)(50466002)(356004)(46406003)(63350400001)(26005)(54906003)(26826003)(4326008)(22756006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR08MB4105; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: da9d00f9-dc25-47ed-93be-08d732182281 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB8PR08MB4105; NoDisclaimer: True X-Forefront-PRVS: 015114592F X-Microsoft-Antispam-Message-Info: La2hEV+HBNZlP9D/yT8xeMlJNem87vW+0GtvRj+cTq4RLPrtVEAdkYSP7J+PCr8DUKxBz4MZ7OcuXTJ5FAXv1dzzmqp8bBlqnBVxoVx7+YUvs35la/wZDRiI5dtNXWJTW8PX2eMvWLEVQBqoYlsUmonPHpJUqcBQ3sFDRej27k6T8FYQobl7DPEK+uH/5+ZWTCdrdcI6ajgOGRo7UaVjiFGpc//lWYA04IOJAdUKLXJVR/GfOhKb/thfbQFNFupdjToMK5ZDxNxAPNQdcyob9LUKIRkeYy5TbhcmsIm3OMca7pFh4OErfgP9noWt2/TmB33TvAQMultE8sUq2kKkB2y7qcNBrFLqsQsKRyPJgr6QyTMyhostprQuP8Xso38ibFn6xXlqXaZ6u6cSq1dZVTl9M7TU9jHZXESXTnJzPc8= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2019 15:46:00.6912 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ac5f5df-6942-4c3a-6f2e-08d73218271b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4105 Subject: Re: [dpdk-dev] [PATCH 10/10] test: fix global variable multiple definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Multiple global variable are defined in multiple unit test files with sam= e > name, but all unit test files are linked into single executable, which me= ans > those variables share same storage which is not the intention, fixed by > making global variables 'static'. >=20 > Issue has been detected by '-fno-common' gcc flag. >=20 > Fixes: fdeb30fa7102 ("test/bitrate: add unit tests for bitrate library") > Fixes: c3eabff124e6 ("distributor: add unit tests") > Fixes: 0e925aef2779 ("app/test: add EFD functional and perf tests") > Fixes: 359e17bf081f ("app/test: improve hash unit tests") > Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") > Fixes: 1e3676a06e4c ("test/latency: add unit tests for latencystats libra= ry") > Fixes: 0cc67a96e486 ("test/member: add functional and perf tests") > Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count"= ) > Fixes: 104dbec2081a ("test/rcu: increase size of core numbers") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > app/test/test_bitratestats.c | 6 +++--- > app/test/test_distributor_perf.c | 2 +- > app/test/test_efd.c | 2 +- > app/test/test_efd_perf.c | 6 +++--- > app/test/test_hash_perf.c | 12 ++++++------ > app/test/test_hash_readwrite_lf.c | 8 ++++---- > app/test/test_latencystats.c | 6 +++--- > app/test/test_member_perf.c | 16 ++++++++-------- > app/test/test_rcu_qsbr.c | 10 +++++----- > 9 files changed, 34 insertions(+), 34 deletions(-) >=20 > diff --git a/app/test/test_bitratestats.c b/app/test/test_bitratestats.c = index > 32b1b0fc0..3a7d9c037 100644 > --- a/app/test/test_bitratestats.c > +++ b/app/test/test_bitratestats.c > @@ -18,9 +18,9 @@ > #define BIT_NUM_PACKETS 10 > #define QUEUE_ID 0 >=20 > -uint16_t portid; > -struct rte_stats_bitrates *bitrate_data; -struct rte_ring *ring; > +static uint16_t portid; > +static struct rte_stats_bitrates *bitrate_data; static struct rte_ring > +*ring; >=20 > /* To test whether rte_stats_bitrate_create is successful */ static int= diff -- > git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c > index 664530ff9..f153bcf9b 100644 > --- a/app/test/test_distributor_perf.c > +++ b/app/test/test_distributor_perf.c > @@ -25,7 +25,7 @@ static volatile unsigned worker_idx; struct > worker_stats { > volatile unsigned handled_packets; > } __rte_cache_aligned; > -struct worker_stats worker_stats[RTE_MAX_LCORE]; > +static struct worker_stats worker_stats[RTE_MAX_LCORE]; >=20 > /* > * worker thread used for testing the time to do a round-trip of a cache= diff - > -git a/app/test/test_efd.c b/app/test/test_efd.c index 73b304431..a779a71= f2 > 100644 > --- a/app/test/test_efd.c > +++ b/app/test/test_efd.c > @@ -94,7 +94,7 @@ static struct flow_key keys[5] =3D { > } > }; > /* Array to store the data */ > -efd_value_t data[5]; > +static efd_value_t data[5]; >=20 > static inline uint8_t efd_get_all_sockets_bitmask(void) { diff --git > a/app/test/test_efd_perf.c b/app/test/test_efd_perf.c index > 1dcb992c6..d47622d5c 100644 > --- a/app/test/test_efd_perf.c > +++ b/app/test/test_efd_perf.c > @@ -71,13 +71,13 @@ static uint32_t hashtest_key_lens[] =3D { }; >=20 > /* Array to store number of cycles per operation */ -uint64_t > cycles[NUM_KEYSIZES][NUM_OPERATIONS]; > +static uint64_t cycles[NUM_KEYSIZES][NUM_OPERATIONS]; >=20 > /* Array to store the data */ > -efd_value_t data[KEYS_TO_ADD]; > +static efd_value_t data[KEYS_TO_ADD]; >=20 > /* Array to store all input keys */ > -uint8_t keys[KEYS_TO_ADD][MAX_KEYSIZE]; > +static uint8_t keys[KEYS_TO_ADD][MAX_KEYSIZE]; >=20 > /* Shuffle the keys that have been added, so lookups will be totally ran= dom > */ static void diff --git a/app/test/test_hash_perf.c > b/app/test/test_hash_perf.c index 5648fce02..a438eae6c 100644 > --- a/app/test/test_hash_perf.c > +++ b/app/test/test_hash_perf.c > @@ -53,22 +53,22 @@ static uint32_t hashtest_key_lens[] =3D { struct > rte_hash *h[NUM_KEYSIZES]; >=20 > /* Array that stores if a slot is full */ -uint8_t slot_taken[MAX_ENTRIE= S]; > +static uint8_t slot_taken[MAX_ENTRIES]; >=20 > /* Array to store number of cycles per operation */ -uint64_t > cycles[NUM_KEYSIZES][NUM_OPERATIONS][2][2]; > +static uint64_t cycles[NUM_KEYSIZES][NUM_OPERATIONS][2][2]; >=20 > /* Array to store all input keys */ > -uint8_t keys[KEYS_TO_ADD][MAX_KEYSIZE]; > +static uint8_t keys[KEYS_TO_ADD][MAX_KEYSIZE]; >=20 > /* Array to store the precomputed hash for 'keys' */ -hash_sig_t > signatures[KEYS_TO_ADD]; > +static hash_sig_t signatures[KEYS_TO_ADD]; >=20 > /* Array to store how many busy entries have each bucket */ -uint8_t > buckets[NUM_BUCKETS]; > +static uint8_t buckets[NUM_BUCKETS]; >=20 > /* Array to store the positions where keys are added */ -int32_t > positions[KEYS_TO_ADD]; > +static int32_t positions[KEYS_TO_ADD]; >=20 > /* Parameters used for hash table in unit test functions. */ static str= uct > rte_hash_parameters ut_params =3D { diff --git > a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c > index 1f2fba41f..97c304054 100644 > --- a/app/test/test_hash_readwrite_lf.c > +++ b/app/test/test_hash_readwrite_lf.c > @@ -48,7 +48,7 @@ > #define WRITE_EXT_BKT 2 >=20 > #define NUM_TEST 3 > -unsigned int rwc_core_cnt[NUM_TEST] =3D {1, 2, 4}; > +static unsigned int rwc_core_cnt[NUM_TEST] =3D {1, 2, 4}; >=20 > struct rwc_perf { > uint32_t w_no_ks_r_hit[2][NUM_TEST]; > @@ -62,7 +62,7 @@ struct rwc_perf { >=20 > static struct rwc_perf rwc_lf_results, rwc_non_lf_results; >=20 > -struct { > +static struct { > uint32_t *keys; > uint32_t *keys_no_ks; > uint32_t *keys_ks; > @@ -87,9 +87,9 @@ static rte_atomic64_t greads; >=20 > static volatile uint8_t writer_done; >=20 > -uint16_t enabled_core_ids[RTE_MAX_LCORE]; > +static uint16_t enabled_core_ids[RTE_MAX_LCORE]; >=20 > -uint8_t *scanned_bkts; > +static uint8_t *scanned_bkts; >=20 > static inline uint16_t > get_short_sig(const hash_sig_t hash) > diff --git a/app/test/test_latencystats.c b/app/test/test_latencystats.c = index > 8dd794be4..968e0bc47 100644 > --- a/app/test/test_latencystats.c > +++ b/app/test/test_latencystats.c > @@ -17,10 +17,10 @@ > #define LATENCY_NUM_PACKETS 10 > #define QUEUE_ID 0 >=20 > -uint16_t portid; > -struct rte_ring *ring; > +static uint16_t portid; > +static struct rte_ring *ring; >=20 > -struct rte_metric_name lat_stats_strings[] =3D { > +static struct rte_metric_name lat_stats_strings[] =3D { > {"min_latency_ns"}, > {"avg_latency_ns"}, > {"max_latency_ns"}, > diff --git a/app/test/test_member_perf.c b/app/test/test_member_perf.c > index 564a2b3c1..e2840f12d 100644 > --- a/app/test/test_member_perf.c > +++ b/app/test/test_member_perf.c > @@ -65,18 +65,18 @@ static uint32_t hashtest_key_lens[] =3D { }; >=20 > /* Array to store number of cycles per operation */ -uint64_t > cycles[NUM_TYPE][NUM_KEYSIZES][NUM_OPERATIONS]; > -uint64_t false_data[NUM_TYPE][NUM_KEYSIZES]; > -uint64_t false_data_bulk[NUM_TYPE][NUM_KEYSIZES]; > -uint64_t false_data_multi[NUM_TYPE][NUM_KEYSIZES]; > -uint64_t false_data_multi_bulk[NUM_TYPE][NUM_KEYSIZES]; > +static uint64_t cycles[NUM_TYPE][NUM_KEYSIZES][NUM_OPERATIONS]; > +static uint64_t false_data[NUM_TYPE][NUM_KEYSIZES]; > +static uint64_t false_data_bulk[NUM_TYPE][NUM_KEYSIZES]; > +static uint64_t false_data_multi[NUM_TYPE][NUM_KEYSIZES]; > +static uint64_t false_data_multi_bulk[NUM_TYPE][NUM_KEYSIZES]; >=20 > -uint64_t false_hit[NUM_TYPE][NUM_KEYSIZES]; > +static uint64_t false_hit[NUM_TYPE][NUM_KEYSIZES]; >=20 > -member_set_t data[NUM_TYPE][/* Array to store the data */KEYS_TO_ADD]; > +static member_set_t data[NUM_TYPE][/* Array to store the data > +*/KEYS_TO_ADD]; >=20 > /* Array to store all input keys */ > -uint8_t keys[KEYS_TO_ADD][MAX_KEYSIZE]; > +static uint8_t keys[KEYS_TO_ADD][MAX_KEYSIZE]; >=20 > /* Shuffle the keys that have been added, so lookups will be totally ran= dom > */ static void diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu= _qsbr.c > index d1b9e46a2..53c46ccc1 100644 > --- a/app/test/test_rcu_qsbr.c > +++ b/app/test/test_rcu_qsbr.c > @@ -25,8 +25,8 @@ > /* Make sure that this has the same value as __RTE_QSBR_CNT_INIT */ > #define TEST_RCU_QSBR_CNT_INIT 1 >=20 > -uint16_t enabled_core_ids[RTE_MAX_LCORE]; -unsigned int num_cores; > +static uint16_t enabled_core_ids[RTE_MAX_LCORE]; static unsigned int > +num_cores; >=20 > static uint32_t *keys; > #define TOTAL_ENTRY (1024 * 8) > @@ -35,8 +35,8 @@ static uint32_t > *hash_data[RTE_MAX_LCORE][TOTAL_ENTRY]; > static uint8_t writer_done; >=20 > static struct rte_rcu_qsbr *t[RTE_MAX_LCORE]; -struct rte_hash > *h[RTE_MAX_LCORE]; -char hash_name[RTE_MAX_LCORE][8]; > +static struct rte_hash *h[RTE_MAX_LCORE]; static char > +hash_name[RTE_MAX_LCORE][8]; >=20 > struct test_rcu_thread_info { > /* Index in RCU array */ > @@ -46,7 +46,7 @@ struct test_rcu_thread_info { > /* lcore IDs registered on the RCU variable */ > uint16_t r_core_ids[2]; > }; > -struct test_rcu_thread_info thread_info[RTE_MAX_LCORE/4]; > +static struct test_rcu_thread_info thread_info[RTE_MAX_LCORE/4]; >=20 > static int > alloc_rcu(void) RCU changes look fine. > -- > 2.21.0