From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: David Marchand <david.marchand@redhat.com>,
Olivier Matz <olivier.matz@6wind.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
Gavin Hu <Gavin.Hu@arm.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH] ring: fix namespace prefix of inline functions
Date: Thu, 23 Jan 2020 15:56:31 +0000 [thread overview]
Message-ID: <VE1PR08MB51494132C4A9A211B71BB91E980F0@VE1PR08MB5149.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200123083022.3791956-1-thomas@monjalon.net>
<snip>
>
> When adding custom element size feature, some internal inline functions were
> added in a public header without rte_ prefix.
> It is fixed by adding __rte_ring_.
>
> Fixes: cc4b218790f6 ("ring: support configurable element size")
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Looks good.
Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
> lib/librte_ring/rte_ring_elem.h | 42 +++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_elem.h
> index 15d79bf2ac..7fdfe01e0b 100644
> --- a/lib/librte_ring/rte_ring_elem.h
> +++ b/lib/librte_ring/rte_ring_elem.h
> @@ -110,8 +110,8 @@ struct rte_ring *rte_ring_create_elem(const char
> *name, unsigned int esize,
> unsigned int count, int socket_id, unsigned int flags);
>
> static __rte_always_inline void
> -enqueue_elems_32(struct rte_ring *r, const uint32_t size, uint32_t idx,
> - const void *obj_table, uint32_t n)
> +__rte_ring_enqueue_elems_32(struct rte_ring *r, const uint32_t size,
> + uint32_t idx, const void *obj_table, uint32_t n)
> {
> unsigned int i;
> uint32_t *ring = (uint32_t *)&r[1];
> @@ -153,7 +153,7 @@ enqueue_elems_32(struct rte_ring *r, const uint32_t
> size, uint32_t idx, }
>
> static __rte_always_inline void
> -enqueue_elems_64(struct rte_ring *r, uint32_t prod_head,
> +__rte_ring_enqueue_elems_64(struct rte_ring *r, uint32_t prod_head,
> const void *obj_table, uint32_t n)
> {
> unsigned int i;
> @@ -186,7 +186,7 @@ enqueue_elems_64(struct rte_ring *r, uint32_t
> prod_head, }
>
> static __rte_always_inline void
> -enqueue_elems_128(struct rte_ring *r, uint32_t prod_head,
> +__rte_ring_enqueue_elems_128(struct rte_ring *r, uint32_t prod_head,
> const void *obj_table, uint32_t n)
> {
> unsigned int i;
> @@ -219,16 +219,16 @@ enqueue_elems_128(struct rte_ring *r, uint32_t
> prod_head,
> * single and multi producer enqueue functions.
> */
> static __rte_always_inline void
> -enqueue_elems(struct rte_ring *r, uint32_t prod_head, const void *obj_table,
> - uint32_t esize, uint32_t num)
> +__rte_ring_enqueue_elems(struct rte_ring *r, uint32_t prod_head,
> + const void *obj_table, uint32_t esize, uint32_t num)
> {
> /* 8B and 16B copies implemented individually to retain
> * the current performance.
> */
> if (esize == 8)
> - enqueue_elems_64(r, prod_head, obj_table, num);
> + __rte_ring_enqueue_elems_64(r, prod_head, obj_table, num);
> else if (esize == 16)
> - enqueue_elems_128(r, prod_head, obj_table, num);
> + __rte_ring_enqueue_elems_128(r, prod_head, obj_table,
> num);
> else {
> uint32_t idx, scale, nr_idx, nr_num, nr_size;
>
> @@ -238,13 +238,14 @@ enqueue_elems(struct rte_ring *r, uint32_t
> prod_head, const void *obj_table,
> idx = prod_head & r->mask;
> nr_idx = idx * scale;
> nr_size = r->size * scale;
> - enqueue_elems_32(r, nr_size, nr_idx, obj_table, nr_num);
> + __rte_ring_enqueue_elems_32(r, nr_size, nr_idx,
> + obj_table, nr_num);
> }
> }
>
> static __rte_always_inline void
> -dequeue_elems_32(struct rte_ring *r, const uint32_t size, uint32_t idx,
> - void *obj_table, uint32_t n)
> +__rte_ring_dequeue_elems_32(struct rte_ring *r, const uint32_t size,
> + uint32_t idx, void *obj_table, uint32_t n)
> {
> unsigned int i;
> uint32_t *ring = (uint32_t *)&r[1];
> @@ -286,7 +287,7 @@ dequeue_elems_32(struct rte_ring *r, const uint32_t
> size, uint32_t idx, }
>
> static __rte_always_inline void
> -dequeue_elems_64(struct rte_ring *r, uint32_t prod_head,
> +__rte_ring_dequeue_elems_64(struct rte_ring *r, uint32_t prod_head,
> void *obj_table, uint32_t n)
> {
> unsigned int i;
> @@ -319,7 +320,7 @@ dequeue_elems_64(struct rte_ring *r, uint32_t
> prod_head, }
>
> static __rte_always_inline void
> -dequeue_elems_128(struct rte_ring *r, uint32_t prod_head,
> +__rte_ring_dequeue_elems_128(struct rte_ring *r, uint32_t prod_head,
> void *obj_table, uint32_t n)
> {
> unsigned int i;
> @@ -348,16 +349,16 @@ dequeue_elems_128(struct rte_ring *r, uint32_t
> prod_head,
> * single and multi producer enqueue functions.
> */
> static __rte_always_inline void
> -dequeue_elems(struct rte_ring *r, uint32_t cons_head, void *obj_table,
> - uint32_t esize, uint32_t num)
> +__rte_ring_dequeue_elems(struct rte_ring *r, uint32_t cons_head,
> + void *obj_table, uint32_t esize, uint32_t num)
> {
> /* 8B and 16B copies implemented individually to retain
> * the current performance.
> */
> if (esize == 8)
> - dequeue_elems_64(r, cons_head, obj_table, num);
> + __rte_ring_dequeue_elems_64(r, cons_head, obj_table, num);
> else if (esize == 16)
> - dequeue_elems_128(r, cons_head, obj_table, num);
> + __rte_ring_dequeue_elems_128(r, cons_head, obj_table,
> num);
> else {
> uint32_t idx, scale, nr_idx, nr_num, nr_size;
>
> @@ -367,7 +368,8 @@ dequeue_elems(struct rte_ring *r, uint32_t
> cons_head, void *obj_table,
> idx = cons_head & r->mask;
> nr_idx = idx * scale;
> nr_size = r->size * scale;
> - dequeue_elems_32(r, nr_size, nr_idx, obj_table, nr_num);
> + __rte_ring_dequeue_elems_32(r, nr_size, nr_idx,
> + obj_table, nr_num);
> }
> }
>
> @@ -424,7 +426,7 @@ __rte_ring_do_enqueue_elem(struct rte_ring *r,
> const void *obj_table,
> if (n == 0)
> goto end;
>
> - enqueue_elems(r, prod_head, obj_table, esize, n);
> + __rte_ring_enqueue_elems(r, prod_head, obj_table, esize, n);
>
> update_tail(&r->prod, prod_head, prod_next, is_sp, 1);
> end:
> @@ -471,7 +473,7 @@ __rte_ring_do_dequeue_elem(struct rte_ring *r, void
> *obj_table,
> if (n == 0)
> goto end;
>
> - dequeue_elems(r, cons_head, obj_table, esize, n);
> + __rte_ring_dequeue_elems(r, cons_head, obj_table, esize, n);
>
> update_tail(&r->cons, cons_head, cons_next, is_sc, 0);
>
> --
> 2.24.1
next prev parent reply other threads:[~2020-01-23 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 8:30 Thomas Monjalon
2020-01-23 15:56 ` Honnappa Nagarahalli [this message]
2020-01-29 14:38 ` Olivier Matz
2020-02-06 12:39 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB51494132C4A9A211B71BB91E980F0@VE1PR08MB5149.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).