From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23110A04C1; Wed, 20 Nov 2019 05:41:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBD252C6D; Wed, 20 Nov 2019 05:41:42 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30059.outbound.protection.outlook.com [40.107.3.59]) by dpdk.org (Postfix) with ESMTP id 953A5271 for ; Wed, 20 Nov 2019 05:41:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zxl0Q/bDBMWf3F5Wu1ztScH1Ullm2Uevr6rjsY2CyI=; b=69tkgZHSmYOSRQU3SuO4NS0VCYorSQGh34iGHtcb5T0o3FBNL4iJ4+eP1FWqJ2bOVOe8CbmjFPjFQB5+Aj2M6Lov4dUlU3L4Er7dQSmvW3IBNMAZ7mCoWYGzJv0ZMZzxrsc0Yzb/UBqt/3b/LQeGngUymlsKLScx3RGZF2XR29Q= Received: from HE1PR0802CA0019.eurprd08.prod.outlook.com (2603:10a6:3:bd::29) by AM5PR0801MB1810.eurprd08.prod.outlook.com (2603:10a6:203:3b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.22; Wed, 20 Nov 2019 04:41:40 +0000 Received: from VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::202) by HE1PR0802CA0019.outlook.office365.com (2603:10a6:3:bd::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17 via Frontend Transport; Wed, 20 Nov 2019 04:41:40 +0000 Authentication-Results: spf=fail (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: Fail (protection.outlook.com: domain of arm.com does not designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT029.mail.protection.outlook.com (10.152.18.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17 via Frontend Transport; Wed, 20 Nov 2019 04:41:39 +0000 Received: ("Tessian outbound fee635499979:v33"); Wed, 20 Nov 2019 04:41:36 +0000 X-CR-MTA-TID: 64aa7808 Received: from 74f7e65315d8.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.10.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6C9D3DA8-C454-4C48-94AC-388A8F46EE16.1; Wed, 20 Nov 2019 04:41:31 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74f7e65315d8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Nov 2019 04:41:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WytnanGYpt1LMqlQ061wVs4bgBGQhc6OEiTAHSIMglJ1UDoH/QmKZyX1q7ErPWHnYsctlfq7V6FB/DBeVnqS9kv4/4VnvZhAXipseig7TQOLFqn5LQNYLKy1H9tv4r5XONtiAOuBR+6NlIj6AULVjhSzq9oI1BdRy5geI89Oh2RopW5LmmkzGCyXsDLZe555Ri1HLodSIY90CLRfpR4T/jR0621mmXyr6bEZDLSeqs2IKYXNQpMb7XQlkF3aghhN0g78xS7xBdKIEPJvzBn4SK4tf9SFbM1hbQCi9DnVYcPe/R3CotUe+AQCYG973fWD1tO425YUs4xt/4z16Yq1kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zxl0Q/bDBMWf3F5Wu1ztScH1Ullm2Uevr6rjsY2CyI=; b=hgGZo5zyGwl34W++b0DkwSarZCEVbWEbQ0M1Qy54qeDKvzDa5aIm7zv57/DfteRnr2dEe0xbKYfAUXpv9YCL9pD+ZkpYW5hZxpx4cEJ+eggt4adEmqcd3ObGRnvKjEX4BWgx3U/xxplxyHzBNntEQsGgHT1KGP8rW9WG5g+URLBmUQuZibSiDPyqog3QOvT6XLJAN93URpANcyRnDNtyVXUZmOlDLMGAAcLR77fCHxI24v7XwWRVB6tFuy1aJvXj0lrRLtEJtXABDqcHvsYbF9ZOm0d2AkKzuDQw/qUW/jz7pF0vzOyR8lRXEFMeljVz0DJXY4cDC1JFEMbXG5sftw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zxl0Q/bDBMWf3F5Wu1ztScH1Ullm2Uevr6rjsY2CyI=; b=69tkgZHSmYOSRQU3SuO4NS0VCYorSQGh34iGHtcb5T0o3FBNL4iJ4+eP1FWqJ2bOVOe8CbmjFPjFQB5+Aj2M6Lov4dUlU3L4Er7dQSmvW3IBNMAZ7mCoWYGzJv0ZMZzxrsc0Yzb/UBqt/3b/LQeGngUymlsKLScx3RGZF2XR29Q= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.27) by VE1PR08MB5103.eurprd08.prod.outlook.com (20.179.30.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.17; Wed, 20 Nov 2019 04:41:28 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::85ed:1642:c:78a1]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::85ed:1642:c:78a1%2]) with mapi id 15.20.2451.031; Wed, 20 Nov 2019 04:41:28 +0000 From: Honnappa Nagarahalli To: "Akhil.goyal@nxp.com" , Dharmik Thakkar , "jerinj@marvell.com" , Bruce Richardson CC: "dev@dpdk.org" , "thomas@monjalon.net" , "Ruifeng Wang (Arm Technology China)" , "Gavin Hu (Arm Technology China)" , nd , nd Thread-Topic: [dpdk-dev] [PATCH] crypto/armv8: enable meson build Thread-Index: AQHVej38Ic3H9g351kyCpTrDdoUz36eQ1NIAgALulgA= Date: Wed, 20 Nov 2019 04:41:28 +0000 Message-ID: References: <20191003225732.13463-1-dharmik.thakkar@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 408fcb75-241c-40cb-9f35-2fbf10a5ffe9.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1df8a572-8222-4c93-6207-08d76d73ef3e X-MS-TrafficTypeDiagnostic: VE1PR08MB5103:|VE1PR08MB5103:|AM5PR0801MB1810: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 02272225C5 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(189003)(199004)(5660300002)(25786009)(33656002)(52536014)(256004)(71200400001)(71190400001)(14444005)(76116006)(66946007)(66556008)(66476007)(64756008)(66446008)(6116002)(3846002)(14454004)(86362001)(305945005)(74316002)(2906002)(7696005)(478600001)(7736002)(76176011)(2501003)(102836004)(26005)(6246003)(486006)(99286004)(229853002)(476003)(316002)(54906003)(110136005)(66066001)(186003)(11346002)(446003)(8676002)(81156014)(81166006)(8936002)(6506007)(4326008)(6436002)(55016002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5103; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Y7OcSUOYk2nYJmj5Bu7a8yd94t353pzh0v4G+9gAkdLqOKegMjrWUUQrntUpCe4zS204n8DezVHQk1zY4QA0IeGvX5bymVodOCcBIKPcJmLL7B7sg68N1FCVxqKhapXPNEMQ07qehufUMT3G608I2WM2i4stcxmepIdIGypZ/YuRPnclyJN/MeHJ/w+Cs0J4SIgFWndU1lyA4BhMX5E1zMQRAGz2lT9c1fOf5t4HswYS86nW6dTS95g7bQwjCOIiom6G1NfJp0Y8R16i+JWLrHYC2qyPqbohwKwQT7AJkl/m0JUPdw5qV/wzwPR5+MUZIGXwzuYNULRIdfVobomTDYVA/a/1WJWeUiOsuVOE4kUoEv0evHv96oj4R7prvD/52LzpIItf3p4InQmg8OWP1D8QbjyonzMIbyPPRCuL3qVf2ArZj2eSALIQgfmDFivF Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5103 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT029.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(39860400002)(346002)(136003)(1110001)(339900001)(189003)(199004)(229853002)(110136005)(81156014)(8676002)(102836004)(6506007)(81166006)(52536014)(54906003)(26826003)(478600001)(11346002)(66066001)(476003)(55016002)(8936002)(99286004)(126002)(8746002)(25786009)(14454004)(2906002)(46406003)(446003)(7736002)(74316002)(76130400001)(486006)(186003)(2501003)(26005)(70206006)(14444005)(50466002)(70586007)(316002)(97756001)(3846002)(5660300002)(6116002)(47776003)(22756006)(105606002)(305945005)(86362001)(76176011)(36906005)(356004)(7696005)(23726003)(336012)(6246003)(4326008)(33656002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1810; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:Fail; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d6b11c3-834a-432a-5486-08d76d73e893 NoDisclaimer: True X-Forefront-PRVS: 02272225C5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yD1XLpkhRznYS1xcDXlSbRRVURiFG/DY8sgGLjpBO+rB/Nmrvuhgr5xOEfyrroVO6nY2C6jLsuQ5YYJeC0lOi6956j6p/8Qz/i7upUanUcbFdSMBQJXuW7ARiqJovYr5Ans6ItgZmCLr+i0y6ffmsu5IMZiFs2lgF8buW8AiDw1R2ZRROkMROYZeoHTPksUOFSZJi+fmJtKv4e3roTfnjYl5+rC6aI3AJkL6MhGOnx9OAkAsgFu8078wqi0SQQqLObBbI8683y/HxI6YNnUaJilgRW7EDNlwb0n29n+vV6G/4pBobnRE1XlE46vXCTf6DuMYu8p+Cx4DV6GDQ078fJTDna1GrWFY3ehZUtAw8hG5B/RpMYImX/b3KOLOWBRVO0zFZ8jH/Ak6dOy3NVe3itmi8LGKgi16ObpjJdq/7mZyfE8yWHO65I1TTT1ywx7R X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2019 04:41:39.7342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1df8a572-8222-4c93-6207-08d76d73ef3e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1810 Subject: Re: [dpdk-dev] [PATCH] crypto/armv8: enable meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Dharmik, >=20 > As per the recent communication with Honnappa on a separate mail chain, > ARM has agreed to Host the armv8_crypto library. If it is happening in 19= .11 To the wider audience, yes Arm will host a crypto library which is an exist= ing repo on Arm github. We will pull the Marvell's code into this repo. How= ever, Marvell's code needs changes to be integrated into the existing libra= ry. It also needs to go through a security review. We will not be able to c= omplete this work for 19.11. We are targeting 20.02 as of now. > timeframe, we should rebase this patch And add documentation for changed > location of the repo and if it is not in 19.11 timeframe we should have a > patch to disable the PMD. The PMD is already disabled by default. IMO, we just need the changes to release notes indicating that the support = of the Marvel's crypto library is no longer available. >=20 > Could you please send patches as are applicable? >=20 > Regards, > Akhil >=20 > > Add new meson.build file for crypto/armv8 > > > > Signed-off-by: Dharmik Thakkar > > --- > > drivers/crypto/armv8/meson.build | 25 +++++++++++++++++++++++++ > > drivers/crypto/meson.build | 6 +++--- > > meson_options.txt | 2 ++ > > 3 files changed, 30 insertions(+), 3 deletions(-) create mode 100644 > > drivers/crypto/armv8/meson.build > > > > diff --git a/drivers/crypto/armv8/meson.build > > b/drivers/crypto/armv8/meson.build > > new file mode 100644 > > index 000000000000..1ef78fa5d8c7 > > --- /dev/null > > +++ b/drivers/crypto/armv8/meson.build > > @@ -0,0 +1,25 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Arm > > +Limited > > + > > +path =3D get_option('armv8_crypto_dir') if path =3D=3D '' > > + build =3D false > > + reason =3D 'missing dependency, "armv8_crypto"' > > + subdir_done() > > +endif > > + > > +inc_dir =3D path + '/asm/include' > > + > > +lib =3D cc.find_library('libarmv8_crypto', dirs: [path], required: > > +false) if not lib.found() > > + build =3D false > > + reason =3D 'missing dependency, "armv8_crypto"' > > + subdir_done() > > +else > > + ext_deps +=3D lib > > + includes +=3D include_directories(inc_dir) endif > > + > > +deps +=3D ['bus_vdev'] > > +sources =3D files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c') > > +allow_experimental_apis =3D true > > diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build > > index 83e78860ebee..605dcdd5f4d6 100644 > > --- a/drivers/crypto/meson.build > > +++ b/drivers/crypto/meson.build > > @@ -1,9 +1,9 @@ > > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel > > Corporation > > > > -drivers =3D ['aesni_gcm', 'aesni_mb', 'caam_jr', 'ccp', 'dpaa_sec', 'd= paa2_sec', > > - 'kasumi', 'mvsam', 'null', 'octeontx', 'openssl', 'qat', 'scheduler', > > - 'snow3g', 'virtio', 'zuc'] > > +drivers =3D ['aesni_gcm', 'aesni_mb', 'armv8', 'caam_jr', 'ccp', 'dpaa= _sec', > > + 'dpaa2_sec', 'kasumi', 'mvsam', 'null', 'octeontx', 'openssl', 'qat', > > + 'scheduler', 'snow3g', 'virtio', 'zuc'] > > > > std_deps =3D ['cryptodev'] # cryptodev pulls in all other needed deps > > config_flag_fmt =3D 'RTE_LIBRTE_@0@_PMD' > > diff --git a/meson_options.txt b/meson_options.txt index > > 448f3e63dcf2..4c0413918a34 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -2,6 +2,8 @@ > > > > option('allow_invalid_socket_id', type: 'boolean', value: false, > > description: 'allow out-of-range NUMA socket id\'s for platforms > > that don\'t report the value correctly') > > +option('armv8_crypto_dir', type: 'string', value: '', > > + description: 'path to the armv8_crypto library installation > > +directory') > > option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-', > > description: 'Subdirectory of libdir where to install PMDs. Defaults > > to using a versioned subdirectory.') option('enable_docs', type: > > 'boolean', value: false, > > -- > > 2.17.1