From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30065.outbound.protection.outlook.com [40.107.3.65]) by dpdk.org (Postfix) with ESMTP id D604E1B2B3 for ; Sat, 13 Apr 2019 00:24:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4flQjUlax9RUiXAQK3iGzQJDvU0frto/ZxOS4iUTFEU=; b=FFEeNH8sFqBIrIMqs6lDFOHl5xBNqJpqYjCv2tSP4Qvhx9o0txsltPCdEG3uUh6LcRQESvKNIiztUInL4+U50tLaalIafrfPICtfSLDzvqdmkchmWyIQWACQASwBoGHb1flEDxYTmeDTD5qIzl9q7OgLKqZTSBo6Tc1Z+2gdayQ= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5104.eurprd08.prod.outlook.com (20.179.30.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.14; Fri, 12 Apr 2019 22:24:45 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177%2]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 22:24:45 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger CC: "konstantin.ananyev@intel.com" , "paulmck@linux.ibm.com" , "marko.kovacevic@intel.com" , "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , Malvika Gupta , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism Thread-Index: AQHU8XwL9ZW9vcwT20K3DuZSwCCMIqY5FWOA Date: Fri, 12 Apr 2019 22:24:45 +0000 Message-ID: References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-2-honnappa.nagarahalli@arm.com> <20190412150650.3709358e@shemminger-XPS-13-9360> In-Reply-To: <20190412150650.3709358e@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 560dbb26-7a9f-4429-e430-08d6bf95aaf8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5104; x-ms-traffictypediagnostic: VE1PR08MB5104: nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(376002)(396003)(346002)(189003)(199004)(3846002)(26005)(6246003)(14454004)(105586002)(106356001)(76176011)(93886005)(256004)(97736004)(9686003)(2906002)(25786009)(14444005)(66066001)(5660300002)(4326008)(53936002)(55016002)(6116002)(6436002)(229853002)(68736007)(8936002)(81156014)(99286004)(316002)(74316002)(8676002)(305945005)(81166006)(52536014)(7736002)(6916009)(478600001)(186003)(54906003)(446003)(7696005)(486006)(6506007)(71200400001)(71190400001)(72206003)(11346002)(476003)(102836004)(86362001)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5104; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JLepC7eHQYrXClfR3JDyEDVrWqIG3alsjBmTZfOhaDdgvheSXz7D/l6N4HU2piDSo++xB9X9h4lPJZCFhiiYFo7IZnRsSFDt5QXj5uU8+2/3Wmd0igXuMfzxpLzxoPmh7IvdtV9XQ60dUvYYE8I+qKhIqaYgNof2oLKYYJ9v1UNiZXGdZbucto3DguUJrxZSbxhylVru02uFZ27mWWUj+Oh/+w/6aqM/4R4Hn4lqdLfIntb7gHCvleo24WFrfvjxJh+M8o460YWCIyHT6VWwSW1f/C6OmmD/4vRgB4rlzU84wzBUNRLbubz1BiB/AaVM4P0b2npUJUP0j+XLeL5HBGuAbBaPGGE0txFzti4tAEdumA1TF49Ez8mxUL12kyMTzGlZMnApiCjQFnnrujsEOxd/OJxpLH6IW+6l/1Zi4Pw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 560dbb26-7a9f-4429-e430-08d6bf95aaf8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 22:24:45.7032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5104 Subject: Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 22:24:48 -0000 >=20 > On Fri, 12 Apr 2019 15:20:37 -0500 > Honnappa Nagarahalli wrote: >=20 > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock less > > data structures. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > Reviewed-by: Ola Liljedahl > > Acked-by: Konstantin Ananyev >=20 > After evaluating long term API/ABI issues, I think you need to get rid of= almost > all use of inline and visible structures. Yes it might be marginally slow= er, but > you thank me the first time you have to fix something. >=20 Agree, I was planning on another version to address this (I am yet to take = a look at your patch addressing the ABI). The structure visibility definitely needs to be addressed. For the inline functions, is the plan to convert all the inline functions i= n DPDK? If yes, I think we need to consider the performance difference. May= be consider L3-fwd application, change all the inline functions in its pat= h and run a test? > Even the log macro should be private. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F40E8A0096 for ; Sat, 13 Apr 2019 00:24:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C40ED1B3A8; Sat, 13 Apr 2019 00:24:49 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30065.outbound.protection.outlook.com [40.107.3.65]) by dpdk.org (Postfix) with ESMTP id D604E1B2B3 for ; Sat, 13 Apr 2019 00:24:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4flQjUlax9RUiXAQK3iGzQJDvU0frto/ZxOS4iUTFEU=; b=FFEeNH8sFqBIrIMqs6lDFOHl5xBNqJpqYjCv2tSP4Qvhx9o0txsltPCdEG3uUh6LcRQESvKNIiztUInL4+U50tLaalIafrfPICtfSLDzvqdmkchmWyIQWACQASwBoGHb1flEDxYTmeDTD5qIzl9q7OgLKqZTSBo6Tc1Z+2gdayQ= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5104.eurprd08.prod.outlook.com (20.179.30.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.14; Fri, 12 Apr 2019 22:24:45 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::e0ae:ecad:ec5:8177%2]) with mapi id 15.20.1792.016; Fri, 12 Apr 2019 22:24:45 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger CC: "konstantin.ananyev@intel.com" , "paulmck@linux.ibm.com" , "marko.kovacevic@intel.com" , "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , Dharmik Thakkar , Malvika Gupta , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism Thread-Index: AQHU8XwL9ZW9vcwT20K3DuZSwCCMIqY5FWOA Date: Fri, 12 Apr 2019 22:24:45 +0000 Message-ID: References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-2-honnappa.nagarahalli@arm.com> <20190412150650.3709358e@shemminger-XPS-13-9360> In-Reply-To: <20190412150650.3709358e@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 560dbb26-7a9f-4429-e430-08d6bf95aaf8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5104; x-ms-traffictypediagnostic: VE1PR08MB5104: nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0005B05917 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(39860400002)(376002)(396003)(346002)(189003)(199004)(3846002)(26005)(6246003)(14454004)(105586002)(106356001)(76176011)(93886005)(256004)(97736004)(9686003)(2906002)(25786009)(14444005)(66066001)(5660300002)(4326008)(53936002)(55016002)(6116002)(6436002)(229853002)(68736007)(8936002)(81156014)(99286004)(316002)(74316002)(8676002)(305945005)(81166006)(52536014)(7736002)(6916009)(478600001)(186003)(54906003)(446003)(7696005)(486006)(6506007)(71200400001)(71190400001)(72206003)(11346002)(476003)(102836004)(86362001)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5104; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JLepC7eHQYrXClfR3JDyEDVrWqIG3alsjBmTZfOhaDdgvheSXz7D/l6N4HU2piDSo++xB9X9h4lPJZCFhiiYFo7IZnRsSFDt5QXj5uU8+2/3Wmd0igXuMfzxpLzxoPmh7IvdtV9XQ60dUvYYE8I+qKhIqaYgNof2oLKYYJ9v1UNiZXGdZbucto3DguUJrxZSbxhylVru02uFZ27mWWUj+Oh/+w/6aqM/4R4Hn4lqdLfIntb7gHCvleo24WFrfvjxJh+M8o460YWCIyHT6VWwSW1f/C6OmmD/4vRgB4rlzU84wzBUNRLbubz1BiB/AaVM4P0b2npUJUP0j+XLeL5HBGuAbBaPGGE0txFzti4tAEdumA1TF49Ez8mxUL12kyMTzGlZMnApiCjQFnnrujsEOxd/OJxpLH6IW+6l/1Zi4Pw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 560dbb26-7a9f-4429-e430-08d6bf95aaf8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2019 22:24:45.7032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5104 Subject: Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412222445.G_XJSKFbXVxlqjIzxthGq4jIAjZJpN2jB77UF-0w6JU@z> >=20 > On Fri, 12 Apr 2019 15:20:37 -0500 > Honnappa Nagarahalli wrote: >=20 > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock less > > data structures. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Gavin Hu > > Reviewed-by: Ola Liljedahl > > Acked-by: Konstantin Ananyev >=20 > After evaluating long term API/ABI issues, I think you need to get rid of= almost > all use of inline and visible structures. Yes it might be marginally slow= er, but > you thank me the first time you have to fix something. >=20 Agree, I was planning on another version to address this (I am yet to take = a look at your patch addressing the ABI). The structure visibility definitely needs to be addressed. For the inline functions, is the plan to convert all the inline functions i= n DPDK? If yes, I think we need to consider the performance difference. May= be consider L3-fwd application, change all the inline functions in its pat= h and run a test? > Even the log macro should be private.