From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47E06A046B for ; Tue, 23 Jul 2019 21:15:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E0821C0C5; Tue, 23 Jul 2019 21:15:53 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70074.outbound.protection.outlook.com [40.107.7.74]) by dpdk.org (Postfix) with ESMTP id A1D001BCB8 for ; Tue, 23 Jul 2019 21:15:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fp0Kf+jjfaPyYTKYbNe+2lljAtXbOWi2vxTyiYzDTO0=; b=eDNgB8uTqN+NAJ4mOqS+m0zbr+0/o8WBOj/lOQWpjV0o8TtcmqyMvsHPveIQa4rfApgHvddq2EBF2rc+g2X79FT/Qyk1WS7ShPWpFkyhVTMMgdPIWNY8XGYLiN5DQFG0QOaZgmMM0UFX6GatGEJPMnN9hZHikmn8oeHKyIYu2O4= Received: from DB6PR0802CA0040.eurprd08.prod.outlook.com (2603:10a6:4:a3::26) by VI1PR0801MB1853.eurprd08.prod.outlook.com (2603:10a6:800:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.10; Tue, 23 Jul 2019 19:15:49 +0000 Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::200) by DB6PR0802CA0040.outlook.office365.com (2603:10a6:4:a3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2094.16 via Frontend Transport; Tue, 23 Jul 2019 19:15:49 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Tue, 23 Jul 2019 19:15:48 +0000 Received: ("Tessian outbound 70770b88fee7:v24"); Tue, 23 Jul 2019 19:15:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from 30824f9db91c.3 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.13.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id A43F1382-DB10-4B21-B904-A89CADFF1D7E.1; Tue, 23 Jul 2019 19:15:43 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 30824f9db91c.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Tue, 23 Jul 2019 19:15:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MI6BsxbGVCRq3u29Fi30/N+JB+Qrb3ua4/tObIEI0IDbKXCR5kagn5hnOlEiXXI/Zlf5/Eg00s6ErEASnfWMRQT6/zrdd6bus9Wl0Plc2CCw4TJ4k6YFUFjciPaKhKR0rCj58WcUcE3AS1tk4eyvPgLBU525irpcDdZnu4kAnnwVoqVehDD8BwKQcnhoApeV3lTASrP1q+k67b+OC2Lb286BY8WcctU80wMFcLWhgYL9y/PHgkCBvAIke0wsLNYew8w+0gagRdBs73QxseAtF/Yn80ZbeW7NyFUChoBDxtZ51x0d1g7P7YKEpdfaR2AeShxpFfk3wrh4USsB1kxZ0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fp0Kf+jjfaPyYTKYbNe+2lljAtXbOWi2vxTyiYzDTO0=; b=TeZWh5PhKDBVKHWrSB4ic0mJmGofWSg5rfx+MbFlFsjffDIIRvpV4Ux7U6GcT61hJ9JbYFxyRnLv/yJ/z71/KMqS8DWS+KLfzzLDCLF9nr2yNl/b/nGvzRrwABSiVhpPdi8bdgRZDC5pC8BAnF1khUKbJpcrxAH8WhDGfYZMjsIzVn8yOtiYN1MG0ilPnTMfKcYCb7/HBa3DD6QqBEsd4HgbVSyCXnKtXkyff4mGcJ93dVzApaDIh6I6csXNqIRNJ3y8Xx2S58k6fncppDHHxDi02bLZE0hvMLUB27krLqcu5l1at3LTPDEb6w3FCS8unKs8Lnl+XyDLbLB8tf5LJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fp0Kf+jjfaPyYTKYbNe+2lljAtXbOWi2vxTyiYzDTO0=; b=eDNgB8uTqN+NAJ4mOqS+m0zbr+0/o8WBOj/lOQWpjV0o8TtcmqyMvsHPveIQa4rfApgHvddq2EBF2rc+g2X79FT/Qyk1WS7ShPWpFkyhVTMMgdPIWNY8XGYLiN5DQFG0QOaZgmMM0UFX6GatGEJPMnN9hZHikmn8oeHKyIYu2O4= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB5181.eurprd08.prod.outlook.com (20.179.31.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Tue, 23 Jul 2019 19:15:40 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128%3]) with mapi id 15.20.2115.005; Tue, 23 Jul 2019 19:15:40 +0000 From: Honnappa Nagarahalli To: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "stephen@networkplumber.org" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v3 0/5] use WFE for locks and ring on aarch64 Thread-Index: AQHVQW1z4Z7UK1va2kOWQuaqqhxc7qbYke+g Date: Tue, 23 Jul 2019 19:15:40 +0000 Message-ID: References: <1561911676-37718-1-git-send-email-gavin.hu@arm.com> <1563896626-44862-1-git-send-email-gavin.hu@arm.com> In-Reply-To: <1563896626-44862-1-git-send-email-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: fd6d1203-eb46-4255-8176-fcb03110f9bc.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 4f4b6518-e50f-47dd-7b9c-08d70fa22ba3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB5181; X-MS-TrafficTypeDiagnostic: VE1PR08MB5181:|VI1PR0801MB1853: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 0107098B6C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(396003)(366004)(136003)(346002)(376002)(199004)(189003)(13464003)(476003)(86362001)(6436002)(2906002)(11346002)(8936002)(66066001)(14454004)(52536014)(66446008)(64756008)(54906003)(66476007)(76116006)(66946007)(110136005)(14444005)(68736007)(66556008)(256004)(486006)(81156014)(81166006)(5660300002)(3846002)(316002)(99286004)(71200400001)(33656002)(26005)(2501003)(74316002)(71190400001)(478600001)(7696005)(102836004)(305945005)(6506007)(53546011)(6116002)(25786009)(7736002)(186003)(76176011)(55016002)(229853002)(446003)(4326008)(8676002)(6246003)(53936002)(9686003)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5181; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: nKns2SABTLksqTQuT6IFGEOkPonEI9uKiMbLiILaFVioJbEHZ+yRSHUrRDWT8UQah9naOsvICJKOq0noaEnxLzmaBMLFsJops1rnKrKnaCIspyk4WuxwBco1L/KokGgzLm8NfDcIPeFeRW10KSArqwz/pXVQykuk4G6+mWTAZnl7qQwhMVQoHPFVluTNs+61t81H39khkNEnLm+Oncu3q67SH0dGJY8RXnrSAup6QqyOlAgNhclKw1P5vWC61SgalqRCZuFlmPfy/bgvHCIU3xG3jgWCkCZp6+fSU9MIz+7ZaRmYaJ7yjSygtQfz8z5zcEjcwkeXyFZOZfybtXi4TNKsZ5jvrx+/fw0iY5VvJYiabN37CFX44QREIxSpPqxdwKo+Cz6P7lZQpEEshtIvhFi/1GjdFcTUnD+kUQtGz5I= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5181 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(136003)(396003)(346002)(2980300002)(13464003)(189003)(199004)(8676002)(8936002)(81166006)(186003)(8746002)(81156014)(486006)(5660300002)(476003)(126002)(25786009)(14444005)(52536014)(2906002)(4326008)(446003)(63350400001)(47776003)(23726003)(6116002)(11346002)(76176011)(7696005)(63370400001)(6246003)(50466002)(99286004)(22756006)(9686003)(3846002)(478600001)(229853002)(33656002)(336012)(6506007)(53546011)(316002)(66066001)(54906003)(102836004)(55016002)(110136005)(74316002)(356004)(26826003)(14454004)(305945005)(70586007)(2501003)(76130400001)(86362001)(70206006)(97756001)(7736002)(26005)(46406003)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1853; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 8ed6ff63-e13c-43eb-d43f-08d70fa226eb X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:VI1PR0801MB1853; NoDisclaimer: True X-Forefront-PRVS: 0107098B6C X-Microsoft-Antispam-Message-Info: jWXGDoq0LiUrJsvKCUonVGL9aQRgvPauKx2XIqR6y0fdDZF/RbBth4x0sjU5hmkhrzftHxtr+gsnuFUZSA3G0HFT1DUFEVX/l3ovXW75/aMcdjiTh4LwjS5pSJ3cPYuIQtvwNbNDVW4Ajly2B10vxZyCgkHQiCy7rMwv2gzKZhm9CEYbFqkLn1F3APUaLoaABklctR6bXEKiZsHyU3GMFPMwdAjw50q9Dc1gILvrh2LM1SotxU0DDwNKOpwCuUzSivuiLG4DRmzEB18kZiPBg6+eQWmCSxSpm4m5MIAvVtsJ5ftxUpz4CvTLS+Xnu/dqTStUI3P7YYTZEgpmtMALOGqZCUYShtF4eVh7VLMDxqZGIxujwERI0/SKNT1EPztibBhQZlFeKI6+KbhzTNtJdzXDJxHDrUAm2SJqZnZq4XY= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2019 19:15:48.6166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f4b6518-e50f-47dd-7b9c-08d70fa22ba3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1853 Subject: Re: [dpdk-dev] [PATCH v3 0/5] use WFE for locks and ring on aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Gavin, I think this should have been V1 (I mean, no versioning, just 'PATCH'), si= nce it is converted to patch. I think we should be able to resend it as V1 = and mark this V3 as 'superseded'. Hi Thomas, Please let us know if it is worth/helps fixing the version. Thanks, Honnappa > -----Original Message----- > From: Gavin Hu > Sent: Tuesday, July 23, 2019 10:44 AM > To: dev@dpdk.org > Cc: nd ; thomas@monjalon.net; > stephen@networkplumber.org; jerinj@marvell.com; > pbhagavatula@marvell.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > > Subject: [PATCH v3 0/5] use WFE for locks and ring on aarch64 >=20 > DPDK has multiple use cases where the core repeatedly polls a location in > memory. This polling results in many cache and memory transactions. >=20 > Arm architecture provides WFE (Wait For Event) instruction, which allows = the > cpu core to enter a low power state until woken up by the update to the > memory location being polled. Thus reducing the cache and memory > transactions. >=20 > x86 has the PAUSE hint instruction to reduce such overhead. >=20 > The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling = for a > memory location to become equal to a given value'. >=20 > For non-Arm platforms, these APIs are just wrappers around do-while loop > with rte_pause, so there are no performance differences. >=20 > For Arm platforms, use of WFE can be configured using > CONFIG_RTE_USE_WFE option. It is disabled by default. >=20 > Currently, use of WFE is supported only for aarch64 platforms. armv7 > platforms do support the WFE instruction, but they require explicit wake = up > events(sev) and are less performannt. >=20 > Testing shows that, performance varies across different platforms, with s= ome > showing degradation. >=20 > CONFIG_RTE_USE_WFE should be enabled depending on the performance on > the target platforms. >=20 > V3: > * Convert RFCs to patches > V2: > * Use inline functions instead of marcos > * Add load and compare in the beginning of the APIs > * Fix some style errors in asm inline > V1: > * Add the new APIs and use it for ring and locks >=20 > Gavin Hu (5): > eal: add the APIs to wait until equal > ticketlock: use new API to reduce contention on aarch64 > ring: use wfe to wait for ring tail update on aarch64 > spinlock: use wfe to reduce contention on aarch64 > config: add WFE config entry for aarch64 >=20 > config/arm/meson.build | 1 + > config/common_armv8a_linux | 6 ++ > .../common/include/arch/arm/rte_atomic_64.h | 4 + > .../common/include/arch/arm/rte_pause_64.h | 106 > +++++++++++++++++++++ > .../common/include/arch/arm/rte_spinlock.h | 25 +++++ > lib/librte_eal/common/include/generic/rte_pause.h | 39 +++++++- > .../common/include/generic/rte_spinlock.h | 2 +- > .../common/include/generic/rte_ticketlock.h | 3 +- > lib/librte_ring/rte_ring_c11_mem.h | 4 +- > lib/librte_ring/rte_ring_generic.h | 3 +- > 10 files changed, 185 insertions(+), 8 deletions(-) >=20 > -- > 2.7.4